danielmarjamaki added a comment.

> Do you mind writing some tests with multidimensional arrays to check what do 
> we lose if we remove that code?

I have spent a few hours trying to write a test case that shows there is false 
negatives caused by this change. And fail.

I see lots of false negatives for multidimensional arrays with or without this 
code.

For instance:

  void f(int x) {
    int buf[2][3];
    if (x < 4 || x>10)
      return;
    buf[1][x] = 0;
  }


Repository:
  rL LLVM

https://reviews.llvm.org/D39049



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to