george.burgess.iv added a comment.
I like the idea of fixing those things, too; I'll start poking them soon. :)
Even if we do end up fixing all of that, I still think it would be good to try
to diagnose this in the frontend. So, if anyone has comments on this while I'm
staring at the aarch64 ba
malaperle added inline comments.
Comment at: clangd/Protocol.h:458
+///
+/// A parameter can have a label and a doc-comment.
+struct ParameterInformation {
rwols wrote:
> @malaperle I copied the sentences from the protocol markdown file over
> [here](https://git
On Mon, Oct 2, 2017 at 7:02 PM, Richard Smith wrote:
> On 2 October 2017 at 17:10, Peter Collingbourne via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Looks like this caused PR34811, which caused a link error on a Chromium
>> bot:
>> https://build.chromium.org/p/chromium.fyi/builders/
hfinkel added a comment.
In https://reviews.llvm.org/D37624#885438, @choikwa wrote:
> > Can you get more information on what GCC actually implemented and why? It's
> > not clear to me that ignoring the namespaces is the most-useful way to do
> > this. I don't want to emulate GCC bugs, but maybe
Author: ericwf
Date: Mon Oct 2 19:25:05 2017
New Revision: 314755
URL: http://llvm.org/viewvc/llvm-project?rev=314755&view=rev
Log:
Fix test suite misconfiguration on OS X
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Modified: libcxx/trunk/utils/libcxx/test/config.py
URL:
http://llvm
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
This looks fine to me too, assuming the other parts get approved.
Once this is all working, please don't forget:
- user documentation
- release notes
https://reviews.llvm.org/D32199
_
On 2 October 2017 at 17:10, Peter Collingbourne via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Looks like this caused PR34811, which caused a link error on a Chromium
> bot:
> https://build.chromium.org/p/chromium.fyi/builders/CFI%
> 20Linux%20ToT/builds/7081
>
> The link error might be ca
Author: rsmith
Date: Mon Oct 2 18:58:15 2017
New Revision: 314754
URL: http://llvm.org/viewvc/llvm-project?rev=314754&view=rev
Log:
R34811: Allow visibilities other than 'default' for VisibleNoLinkage entities.
Modified:
cfe/trunk/lib/AST/Decl.cpp
cfe/trunk/test/CodeGenCXX/visibility-inl
efriedma added a comment.
As far as I can see, there are three significant issues with the current
-mgeneral-regs-only:
1. We don't correctly ignore inline asm clobbers for registers which aren't
allocatable (https://bugs.llvm.org/show_bug.cgi?id=30792)
2. We don't diagnose calls which need vec
Author: faisalv
Date: Mon Oct 2 18:33:36 2017
New Revision: 314753
URL: http://llvm.org/viewvc/llvm-project?rev=314753&view=rev
Log:
Add parens around the boolean condition of one of the added asserts in r314747
...
... in the hopes of teaching the bots the gift of silence ;)
For quick refere
Author: vedantk
Date: Mon Oct 2 18:27:26 2017
New Revision: 314752
URL: http://llvm.org/viewvc/llvm-project?rev=314752&view=rev
Log:
[ubsan] Skip alignment checks which are folded away
Don't emit alignment checks which the IR constant folder throws away.
I've tested this out on X86FastISel.cpp.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314752: [ubsan] Skip alignment checks which are folded away
(authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D37544?vs=116374&id=117461#toc
Repository:
rL LLVM
https://review
Author: vedantk
Date: Mon Oct 2 18:27:26 2017
New Revision: 314751
URL: http://llvm.org/viewvc/llvm-project?rev=314751&view=rev
Log:
[ubsan] Save the result of getLLVMContext. NFC.
Modified:
cfe/trunk/lib/CodeGen/CGExpr.cpp
Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp
URL:
http://llvm.org/vi
Author: vedantk
Date: Mon Oct 2 18:27:25 2017
New Revision: 314750
URL: http://llvm.org/viewvc/llvm-project?rev=314750&view=rev
Log:
[ubsan] Add helpers to decide when null/vptr checks are required. NFC.
Modified:
cfe/trunk/lib/CodeGen/CGExpr.cpp
cfe/trunk/lib/CodeGen/CodeGenFunction.h
Author: vedantk
Date: Mon Oct 2 18:27:24 2017
New Revision: 314749
URL: http://llvm.org/viewvc/llvm-project?rev=314749&view=rev
Log:
[ubsan] Save a ptrtoint when emitting alignment checks
The alignment check emits a ptrtoint instruction which can be reused in
the call to the diagnostic handler.
Author: faisalv
Date: Mon Oct 2 18:20:40 2017
New Revision: 314748
URL: http://llvm.org/viewvc/llvm-project?rev=314748&view=rev
Log:
Remove an assertion I added from the refactoring of pasteTokens
(https://reviews.llvm.org/rL314747).
- it made the bots v angry!
I'm not exactly sure why the as
On 10/02/2017 07:38 PM, Alexey Bataev wrote:
No, there is no such page. We parse everything from 4.5, but have very
limited support in codegen for target-specific directives, especially
combined one. Moreover, some of them are not implemented at all and we
may produce incorrect code. I can try
Author: faisalv
Date: Mon Oct 2 17:52:14 2017
New Revision: 314747
URL: http://llvm.org/viewvc/llvm-project?rev=314747&view=rev
Log:
[NFC] Refactor PasteTokens so that it can be passed the Token Stream and Index
to start concatenating at.
In passing:
- change the name of the function to pa
No, there is no such page. We parse everything from 4.5, but have very limited
support in codegen for target-specific directives, especially combined one.
Moreover, some of them are not implemented at all and we may produce incorrect
code. I can try to revisit these "badly" supported constructs
On 10/02/2017 07:08 PM, Alexey Bataev wrote:
Hi Hal,
As soon as we get the support for 4.5, including offloading. Otherwise
there always are going to be some people blaming the compiler for not
supporting 4.5 in full. Will try to support it ASAP.
Meanwhile, you can use -fopenmp-version=45 opt
Author: rnk
Date: Mon Oct 2 17:14:03 2017
New Revision: 314743
URL: http://llvm.org/viewvc/llvm-project?rev=314743&view=rev
Log:
[clang-cl] Claim ignored /O[12xd] arguments
Fixes PR34809
Modified:
cfe/trunk/lib/Driver/ToolChains/MSVC.cpp
cfe/trunk/test/Driver/cl-options.c
Modified: cfe
Looks like this caused PR34811, which caused a link error on a Chromium bot:
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20ToT/builds/7081
The link error might be caused by an unrelated LTO bug, but this bug does
seem real. Please take a look.
Peter
On Thu, Sep 21, 2017 at 9:3
Hi Hal,
As soon as we get the support for 4.5, including offloading. Otherwise there
always are going to be some people blaming the compiler for not supporting 4.5
in full. Will try to support it ASAP.
Meanwhile, you can use -fopenmp-version=45 option to force to 4.5
Best regards,
Alexey Bataev
rsmith added inline comments.
Comment at: lib/AST/ExprConstant.cpp:576
+typedef std::pair EvaluatingObject;
+
Please add a comment explaining what the two fields mean.
Comment at: lib/AST/ExprConstant.cpp:588
+ : EI(EI), Object(O
Hi, Alexey,
At what point can we switch, by default, to reporting a version for
_OPENMP corresponding to 4.x? We're missing out on some OpenMP simd
directives because the source code guards them with '#if _OPENMP >=
201307' or similar.
Thanks again,
Hal
On 05/26/2016 11:13 PM, Alexey Bataev
Yes, actually, I will have a meeting with ARM team on this.
Xinmin
-Original Message-
From: Hal Finkel via Phabricator [mailto:revi...@reviews.llvm.org]
Sent: Monday, October 2, 2017 4:19 PM
To: graham.hun...@arm.com; kkw...@gmail.com; Tian, Xinmin
; a.bat...@hotmail.com
Cc: hfin...@a
erik.pilkington created this revision.
Previously, clang rejected the following (copied from PR19741):
struct A {
int a = 0;
constexpr A() { a = 1; }
};
constexpr bool f() {
constexpr A a;
static_assert(a.a == 1, "");
return a.a == 1;
}
static_assert(f(), "");
Clang
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hfinkel added a comment.
Is this still being worked on?
https://reviews.llvm.org/D31417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Mon Oct 2 15:52:51 2017
New Revision: 314735
URL: http://llvm.org/viewvc/llvm-project?rev=314735&view=rev
Log:
Improve test runner output for broken configurations.
Previously LIT would often fail while attempting to set up/configure
the test compiler; normally when attempti
bsdjhb marked 14 inline comments as done.
bsdjhb added a comment.
I have only tested this (test programs as mentioned earlier) with clang 5.0.0
(with a few patches) on o32 and n64. I am in the process of performing the
same tests with GCC 6.3.0. I will also spend some time figuring out how to
bsdjhb updated this revision to Diff 117438.
bsdjhb added a comment.
- Fixes from review feedback.
https://reviews.llvm.org/D38110
Files:
include/__libunwind_config.h
include/libunwind.h
src/Registers.hpp
src/UnwindCursor.hpp
src/UnwindRegistersRestore.S
src/UnwindRegistersSave.S
Author: rsmith
Date: Mon Oct 2 15:43:36 2017
New Revision: 314733
URL: http://llvm.org/viewvc/llvm-project?rev=314733&view=rev
Log:
PR33839: Fix -Wunused handling for structured binding declarations.
We warn about a structured binding declaration being unused only if none of its
bindings are use
rwols updated this revision to Diff 117427.
rwols added a comment.
- Update `invokeCodeComplete` function to also take a `CodeCompleteOptions`, we
assign it to the `CompilerInstance`'s `FrontendOpts.CodeCompleteOpts`.
- Remove unused variable in `SignatureHelpCollector::ProcessOverloadCandidate`.
george.burgess.iv created this revision.
Herald added a subscriber: javed.absar.
(Copy/pasting the reviewer list from https://reviews.llvm.org/D26856.)
Addresses https://bugs.llvm.org/show_bug.cgi?id=30792 .
In GCC, -mgeneral-regs-only emits errors upon trying to emit floating-point or
vector op
hintonda added a comment.
LGTM...
https://reviews.llvm.org/D36806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
W dniu pon, 02.10.2017 o godzinie 13∶33 -0700, użytkownik George
Karpenkov napisał:
> > On Oct 2, 2017, at 12:57 PM, Michał Górny via Phabricator
> > wrote:
> >
> > mgorny added a comment.
> >
> > In https://reviews.llvm.org/D38444#886138, @george.karpenkov wrote:
> >
> > > > breaking stand-al
Author: george.karpenkov
Date: Mon Oct 2 14:01:46 2017
New Revision: 314722
URL: http://llvm.org/viewvc/llvm-project?rev=314722&view=rev
Log:
[Analyzer] Avoid copy and modifying passed reference in
BodyFarm::create_call_once
Differential Revision: https://reviews.llvm.org/D38475
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314716: Add CMake support for building for MinGW (authored
by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D38380?vs=117046&id=117417#toc
Repository:
rL LLVM
https://reviews.llvm.org
Author: mstorsjo
Date: Mon Oct 2 13:46:37 2017
New Revision: 314716
URL: http://llvm.org/viewvc/llvm-project?rev=314716&view=rev
Log:
Add CMake support for building for MinGW
This section is similar to what already exists in libcxx and libcxxabi.
Differential Revision: https://reviews.llvm.org/
> On Oct 2, 2017, at 12:57 PM, Michał Górny via Phabricator
> wrote:
>
> mgorny added a comment.
>
> In https://reviews.llvm.org/D38444#886138, @george.karpenkov wrote:
>
>>> breaking stand-alone builds as a result
>>
>> That's a strong statement. Could you clarify? We have a lot of buildbo
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D38290#885503, @ruiu wrote:
> This patch virtually sets `ld64` the linker command name for macOS. I'd be a
> bit reluctant doing that, because `ld64` sounds like a too ge
mgorny added a comment.
In https://reviews.llvm.org/D38444#886138, @george.karpenkov wrote:
> > breaking stand-alone builds as a result
>
> That's a strong statement. Could you clarify? We have a lot of buildbots
> performing standalone builds, and they are still green.
I didn't know anyone ac
I forgot to include the Phabricator URL for the patch in question. It is here:
https://reviews.llvm.org/D38473
Thanks,
-michael
On Mon, Oct 2, 2017 at 3:19 PM, Michael Ferguson wrote:
> This change adds a new function, CodeGen::getFieldNumber, that
> enables a user of clang's code generation t
This change adds a new function, CodeGen::getFieldNumber, that
enables a user of clang's code generation to get the field number
in a generated LLVM IR struct that corresponds to a particular field
in a C struct.
It is important to expose this information in Clang's code generation
interface becau
Author: arphaman
Date: Mon Oct 2 12:02:42 2017
New Revision: 314708
URL: http://llvm.org/viewvc/llvm-project?rev=314708&view=rev
Log:
Add std::move in RefactoringActionRulesTest.cpp
Should fix http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental
Modified:
cfe/trunk/unittest
rsmith added a comment.
In https://reviews.llvm.org/D35216#856415, @NoQ wrote:
> We already have the object's fields in the AST, with its AST record layout,
> however field names and layouts are implementation-dependent, and it is
> unsafe to try to understand how the specific standard library
Author: waltl
Date: Mon Oct 2 11:50:57 2017
New Revision: 314706
URL: http://llvm.org/viewvc/llvm-project?rev=314706&view=rev
Log:
Add support for Myriad ma2x8x series of CPUs
Summary:
Also:
- Add support for some older Myriad CPUs that were missing.
- Fix some incorrect compiler defines for exi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314704: [refactor] Simplify the refactoring interface
(authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D37681?vs=115211&id=117403#toc
Repository:
rL LLVM
https://reviews.llv
Author: arphaman
Date: Mon Oct 2 11:42:43 2017
New Revision: 314704
URL: http://llvm.org/viewvc/llvm-project?rev=314704&view=rev
Log:
[refactor] Simplify the refactoring interface
This commit simplifies the interface for the refactoring action rules and the
refactoring requirements. It merges th
Author: jvesely
Date: Mon Oct 2 11:39:00 2017
New Revision: 314702
URL: http://llvm.org/viewvc/llvm-project?rev=314702&view=rev
Log:
integer/add_sat: Use clang builtin instead of llvm asm
reviewer: Tom Stellard
Signed-off-by: Jan Vesely
Removed:
libclc/trunk/generic/lib/integer/add_sat_if
srhines added a comment.
Ping again. This is really trivial.
https://reviews.llvm.org/D36806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jvesely
Date: Mon Oct 2 11:38:57 2017
New Revision: 314701
URL: http://llvm.org/viewvc/llvm-project?rev=314701&view=rev
Log:
integer/clz: Use clang builtin instead of llvm asm
The generated llvm IR mostly identical. char/uchar case is a bit worse.
reviewer: Tom Stellard
Signed-off-by:
Author: jvesely
Date: Mon Oct 2 11:39:03 2017
New Revision: 314703
URL: http://llvm.org/viewvc/llvm-project?rev=314703&view=rev
Log:
integer/sub_sat: Use clang builtin instead of llvm asm
reviewer: Tom Stellard
Signed-off-by: Jan Vesely
Removed:
libclc/trunk/generic/lib/integer/sub_sat_if
arphaman added a comment.
I will commit this today. @klimek, let me know if there any issues in
post-commit review.
Repository:
rL LLVM
https://reviews.llvm.org/D37681
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
Author: adrian
Date: Mon Oct 2 11:31:52 2017
New Revision: 314700
URL: http://llvm.org/viewvc/llvm-project?rev=314700&view=rev
Log:
Add a testcase to check that debug info is upgraded when compiling LLVM IR
through clang.
Added:
cfe/trunk/test/CodeGen/verify-debuginfo.ll
Added: cfe/trunk/te
Author: dgregor
Date: Mon Oct 2 11:22:19 2017
New Revision: 314697
URL: http://llvm.org/viewvc/llvm-project?rev=314697&view=rev
Log:
Revert "Add /System/Library/PrivateFrameworks as a header search path."
This reverts commit f7a95215a435aa8d5f64f43a8bb23ba077270755.
Modified:
cfe/trunk/lib/
aprantl abandoned this revision.
aprantl added a comment.
Abandoning in favor of https://reviews.llvm.org/D38184
https://reviews.llvm.org/D38042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
predator5047 updated this revision to Diff 117398.
predator5047 marked 5 inline comments as done.
predator5047 added a comment.
Address review comments:
- Use llvm::SmallVector instead of std::vector
- Some formatting changes.
https://reviews.llvm.org/D38284
Files:
clang-tidy/readabilit
Author: mstorsjo
Date: Mon Oct 2 11:14:06 2017
New Revision: 314695
URL: http://llvm.org/viewvc/llvm-project?rev=314695&view=rev
Log:
Fix building on macOS after SVN r314492
That commit incorrectly expanded the assumption that defined(__APPLE__)
implies SjLj exception handling, which only is tru
JonasToth added a comment.
ping. is there something obviously wrong with this check?
https://reviews.llvm.org/D37808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.karpenkov added a comment.
> breaking stand-alone builds as a result
That's a strong statement. Could you clarify? We have a lot of buildbots
performing standalone builds, and they are still green.
> and the likeliness of people mistakenly adding more unconditional dependencies
That's a
Author: malaperle
Date: Mon Oct 2 11:00:37 2017
New Revision: 314693
URL: http://llvm.org/viewvc/llvm-project?rev=314693&view=rev
Log:
[clangd] Handle workspace/didChangeWatchedFiles
Summary:
The client can send notifications when it detects watched files have
changed. This patch adds the protoc
Author: george.karpenkov
Date: Mon Oct 2 10:59:12 2017
New Revision: 314692
URL: http://llvm.org/viewvc/llvm-project?rev=314692&view=rev
Log:
[Analyzer] Make testing scripts flake8 compliant
Differential Review: https://reviews.llvm.org/D38213
Modified:
cfe/trunk/utils/analyzer/CmpRuns.py
GorNishanov added a comment.
ping
https://reviews.llvm.org/D37115
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
martell added a comment.
`CODE_OWNERS.TXT` does not have a list of `driver` owners.
It does have rsmith as an owner for all things not covered by someone else so I
added him.
Reid usually reviews driver patches I submit to clang and is on the owner list
so I added him here initially.
I think eit
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314691: [CUDA] Fix name of __activemask() (authored by
Hahnfeld).
Changed prior to commit:
https://reviews.llvm.org/D38468?vs=117384&id=117392#toc
Repository:
rL LLVM
https://reviews.llvm.org/D38468
Author: hahnfeld
Date: Mon Oct 2 10:50:11 2017
New Revision: 314691
URL: http://llvm.org/viewvc/llvm-project?rev=314691&view=rev
Log:
[CUDA] Fix name of __activemask()
The name has two underscores in the official CUDA documentation:
http://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
Thank you for the fix!
https://reviews.llvm.org/D38468
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
This is https://bugs.llvm.org/show_bug.cgi?id=34805
On Mon, Oct 2, 2017 at 10:16 AM, Reid Kleckner via cfe-commits
wrote:
> Author: rnk
> Date: Mon Oct 2 10:16:14 2017
> New Revision: 314689
>
> URL: http://llvm.org/viewvc/llvm-project?rev=314689&view=rev
> Log:
> Revert "[Sema] Warn on attribut
Hahnfeld created this revision.
The name has two underscores in the official CUDA documentation:
http://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#warp-vote-functions
https://reviews.llvm.org/D38468
Files:
lib/Headers/__clang_cuda_intrinsics.h
Index: lib/Headers/__clang_cuda_i
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Looks great to me.
I do wonder if long-term we should consider removing the auto-deduction when
loading from the store. On the one hand it is really nice to avoid having to
specify that
Author: rnk
Date: Mon Oct 2 10:16:14 2017
New Revision: 314689
URL: http://llvm.org/viewvc/llvm-project?rev=314689&view=rev
Log:
Revert "[Sema] Warn on attribute nothrow conflicting with language specifiers"
This reverts r314461.
It is warning on user code that uses END_COM_MAP(), which expands
sepavloff added a comment.
Here is a list of design solutions used in this implementation of config files.
**How config file is specified**
There are two ways to specify config file:
- To encode it into executable file name, such as `foo-clang`,
- To pass config file in command line arguments.
dcoughlin accepted this revision.
dcoughlin added inline comments.
This revision is now accepted and ready to land.
Comment at: test/Analysis/objc-boxing.m:66
+ BoxableStruct bs;
+ bs.str = strdup("dynamic string"); // The duped string shall be owned by val.
+ NSValue *val = @
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM, but is there a reason this isn't just part of that patch?
Repository:
rL LLVM
https://reviews.llvm.org/D38460
___
cfe-commits mailin
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D38456
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
Author: erichkeane
Date: Mon Oct 2 09:49:32 2017
New Revision: 314687
URL: http://llvm.org/viewvc/llvm-project?rev=314687&view=rev
Log:
Update IUnknown lit test to pass on Win32
Modified:
cfe/trunk/test/SemaCXX/ms-iunknown-template-function.cpp
Modified: cfe/trunk/test/SemaCXX/ms-iunknown-t
sammccall updated this revision to Diff 117374.
sammccall added a comment.
- clang-format
https://reviews.llvm.org/D38464
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/JSONRPCDispatcher.cpp
clangd/JSONRPCDispatcher.h
clangd/Protocol.cpp
clangd/Protocol.h
clangd
sammccall created this revision.
Make the ProtocolHandlers glue between JSONRPCDispatcher and
ClangdLSPServer generic.
Eliminate small differences between methods, de-emphasize the unimportant
distinction between notifications and methods.
ClangdLSPServer is no longer responsible for producing a
Author: abataev
Date: Mon Oct 2 09:32:39 2017
New Revision: 314686
URL: http://llvm.org/viewvc/llvm-project?rev=314686&view=rev
Log:
[OPENMP] Capture argument of `device` clause for target-based
directives.
The argument of the `device` clause in target-based executable
directives must be capture
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D38458
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
rnk added inline comments.
Comment at: test/CodeGen/ms-inline-asm.cpp:37-38
- int lvar = 10;
- __asm mov eax, offset Foo::ptr
- __asm mov eax, offset Foo::Bar::ptr
-// CHECK-LABEL: define void @_Z2t2v()
coby wrote:
> rnk wrote:
> > These don't seem tested anyw
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/NamespaceCommentCheck.cpp:59
+static std::string getNamespaceComment(const std::string &s,
+ bool InsertLineBreak) {
`s` should be renamed to `S` or so
MontyKutyi updated this revision to Diff 117367.
MontyKutyi added a comment.
Updated to the latest trunk version.
https://reviews.llvm.org/D34030
Files:
include/clang/AST/RecursiveASTVisitor.h
unittests/AST/PostOrderASTVisitor.cpp
Index: unittests/AST/PostOrderASTVisitor.cpp
=
stringham added a comment.
@djasper should I move forward with extending the BracketAlignmentStyle option?
I'm happy to do it, but I'd like to get the idea signed off on before I spend
more time working on it. We've been using a version of clang-format with these
changes since May, and we've be
erichkeane added a comment.
@chapuni Thanks for the fix! That 'novtable' line is there simply because that
is supposed to be a minimized replica of what happens in the UnknwnBase.h
header.
I'll likely just remove the attribute and your fix, since the warning itself
isn't important to the test
NoQ updated this revision to Diff 117360.
NoQ added a comment.
Yeah, nice catch. So we need to either always tell the checkers to specify
their `CharTy` when they are dealing with void pointers, or to do our
substitution consistently, not only for `SymbolicRegion` but also for
`AllocaRegion` (d
yaxunl created this revision.
Currently clang allows the following code
int a;
int b = (const int) a;
However it does not the following code
int4 a;
int4 b = (const int4) a;
This is because Clang compares the qualified types instead of unqualified types
for vector type casting, which
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314683: [clang-format] Fix regression about short functions
after #else (authored by krasimir).
Repository:
rL LLVM
https://reviews.llvm.org/D37973
Files:
cfe/trunk/lib/Format/UnwrappedLineFormatter
Author: krasimir
Date: Mon Oct 2 08:53:37 2017
New Revision: 314683
URL: http://llvm.org/viewvc/llvm-project?rev=314683&view=rev
Log:
[clang-format] Fix regression about short functions after #else
Summary:
This patch fixes a regression introduced in r312904, where the formatter
confuses
the `e
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
This test looks like it was intended to catch some case, maybe we're now
mishandling some case like
if (foo)
{
}
else
{
// this can now be merged
}
But there's no testca
ilya-biryukov added a comment.
Did a minor rename and added a few `std::move`s before submitting. Was not
worth another round of code review.
Repository:
rL LLVM
https://reviews.llvm.org/D37150
___
cfe-commits mailing list
cfe-commits@lists.llvm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314678: [clangd] Command line arg to specify
compile_commands.json path (authored by ibiryukov).
Changed prior to commit:
https://reviews.llvm.org/D37150?vs=117340&id=117354#toc
Repository:
rL LLVM
Author: ibiryukov
Date: Mon Oct 2 08:13:20 2017
New Revision: 314678
URL: http://llvm.org/viewvc/llvm-project?rev=314678&view=rev
Log:
[clangd] Command line arg to specify compile_commands.json path
Summary: Adds compileCommands command line argument to specify an absolute path
directly to the
Author: ibiryukov
Date: Mon Oct 2 08:10:41 2017
New Revision: 314677
URL: http://llvm.org/viewvc/llvm-project?rev=314677&view=rev
Log:
[clangd] Run clang-format on the source code. NFC.
Modified:
clang-tools-extra/trunk/clangd/ProtocolHandlers.h
Modified: clang-tools-extra/trunk/clangd/Prot
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:1127
+// only consist of ObjC objects, and escapes of ObjC objects
+// aren't so important (eg., retain count checker ignores them).
+if (isa(Ex) ||
dcoughlin wr
Nebiroth updated this revision to Diff 117351.
Nebiroth marked 3 inline comments as done.
Nebiroth added a comment.
Addressed initial comments.
Formatted ClangdUnit.h
https://reviews.llvm.org/D38425
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/C
kosarev created this revision.
kosarev added a project: clang.
This patch fixes clang to propagate complete TBAA information for atomic
accesses and not just the final access types. Prepared against
https://reviews.llvm.org/D38456 and requires it to be committed first.
This is part of https://r
Author: abataev
Date: Mon Oct 2 07:35:31 2017
New Revision: 314673
URL: http://llvm.org/viewvc/llvm-project?rev=314673&view=rev
Log:
[OPENMP] Fix test, NFC.
Modified:
cfe/trunk/test/OpenMP/target_codegen.cpp
Modified: cfe/trunk/test/OpenMP/target_codegen.cpp
URL:
http://llvm.org/viewvc/llv
1 - 100 of 123 matches
Mail list logo
