Author: ahatanak
Date: Tue Sep 19 23:55:43 2017
New Revision: 313725
URL: http://llvm.org/viewvc/llvm-project?rev=313725&view=rev
Log:
Revert "Add support for attribute 'noescape'."
This reverts commit r313722.
It looks like compiler-rt/lib/tsan/rtl/tsan_libdispatch_mac.cc cannot be
compiled bec
ahatanak updated this revision to Diff 115966.
ahatanak added a comment.
Upload the rebased patch again.
https://reviews.llvm.org/D32520
Files:
include/clang/Sema/Sema.h
lib/CodeGen/CGExprScalar.cpp
lib/Sema/SemaExpr.cpp
test/CodeGen/fp16vec-ops.c
test/Sema/fp16vec-sema.c
Index: test
ahatanak reopened this revision.
ahatanak added a comment.
Reopening this review. I accidentally closed this review when I committed
r313717 (the patch that adds support for 'noescape').
Repository:
rL LLVM
https://reviews.llvm.org/D32520
___
cf
ahatanak accepted this revision.
ahatanak added a comment.
This revision is now accepted and ready to land.
This one can be closed.
Repository:
rL LLVM
https://reviews.llvm.org/D32210
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
ahatanak reopened this revision.
ahatanak added a comment.
Reopening this review. I accidentally closed this review when I committed
r313717 (the patch that adds support for 'noescape').
Repository:
rL LLVM
https://reviews.llvm.org/D32210
___
cf
Author: ahatanak
Date: Tue Sep 19 23:32:45 2017
New Revision: 313722
URL: http://llvm.org/viewvc/llvm-project?rev=313722&view=rev
Log:
Add support for attribute 'noescape'.
The attribute informs the compiler that the annotated pointer parameter
of a function cannot escape and enables IRGen to att
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313722: Add support for attribute 'noescape'. (authored by
ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D32210?vs=115432&id=115965#toc
Repository:
rL LLVM
https://reviews.llvm.org/D3
Author: ahatanak
Date: Tue Sep 19 23:27:39 2017
New Revision: 313721
URL: http://llvm.org/viewvc/llvm-project?rev=313721&view=rev
Log:
Revert "Add support for attribute 'noescape'."
This reverts r313717.
I closed the wrong phabricator review.
Removed:
cfe/trunk/test/CodeGenCXX/noescape.cpp
Author: ahatanak
Date: Tue Sep 19 23:22:51 2017
New Revision: 313720
URL: http://llvm.org/viewvc/llvm-project?rev=313720&view=rev
Log:
Add support for attribute 'noescape'.
The attribute informs the compiler that the annotated pointer parameter
of a function cannot escape and enables IRGen to att
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313720: Add support for attribute 'noescape'. (authored by
ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D32520?vs=115304&id=115964#toc
Repository:
rL LLVM
https://reviews.llvm.org/D3
Author: ahatanak
Date: Tue Sep 19 22:39:18 2017
New Revision: 313717
URL: http://llvm.org/viewvc/llvm-project?rev=313717&view=rev
Log:
[Sema][ObjC] Warn about mismatches in attributes between overriding and
overridden methods when compiling for non-ARC.
Previously, clang would error out when comp
gtbercea updated this revision to Diff 115948.
Repository:
rL LLVM
https://reviews.llvm.org/D37914
Files:
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Driver/openmp-offload-gpu.c
===
--- test/D
chandlerc requested changes to this revision.
chandlerc added a comment.
This revision now requires changes to proceed.
Marking as needing changes to clear dashboard.
https://reviews.llvm.org/D38042
___
cfe-commits mailing list
cfe-commits@lists.llv
Lekensteyn updated this revision to Diff 115946.
Lekensteyn retitled this revision from "Expand absolute system header paths
when using -MD depfiles" to "Try to shorten system header paths when using -MD
depfiles".
Lekensteyn edited the summary of this revision.
Lekensteyn added a comment.
Thank
gtbercea updated this revision to Diff 115947.
Repository:
rL LLVM
https://reviews.llvm.org/D38040
Files:
test/OpenMP/target_map_codegen.cpp
Index: test/OpenMP/target_map_codegen.cpp
===
--- test/OpenMP/target_map_codegen.cpp
wmi updated this revision to Diff 115945.
wmi added a comment.
Address Eli's comment.
Repository:
rL LLVM
https://reviews.llvm.org/D38046
Files:
include/clang/Basic/TargetInfo.h
lib/Basic/Targets.cpp
lib/Basic/Targets/X86.h
test/OpenMP/atomic_capture_codegen.cpp
test/OpenMP/atomic_
gtbercea updated this revision to Diff 115943.
gtbercea added a comment.
Don't take into account unknown CUDA archs not even for testing purposes.
Repository:
rL LLVM
https://reviews.llvm.org/D37913
Files:
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Driv
gtbercea updated this revision to Diff 115941.
gtbercea added a comment.
Address comment.
Repository:
rL LLVM
https://reviews.llvm.org/D37912
Files:
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Driver/openmp-offload-gpu.c
=
eugenis added a comment.
A test, please.
Comment at: clang/lib/CodeGen/CGClass.cpp:1592
+ llvm::CallInst *I = CGF.EmitNounwindRuntimeCall(Fn, Args);
+ I->setMetadata("nosanitize", llvm::MDNode::get(CGF.getLLVMContext(),
+ llv
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D38060
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
hfinkel added inline comments.
Comment at: test/Driver/openmp-offload-gpu.c:140
+
+/// Check that error is not thrown by toolchain when no cuda lib device is
found when using -c -S.
+/// Check that the flag is passed when -fopenmp-relocatable-target is used.
Do
morehouse created this revision.
Herald added a subscriber: hiraditya.
Eliminate unnecessary instrumentation at __sanitizer_dtor_callback
call sites. Fixes https://github.com/google/sanitizers/issues/861.
https://reviews.llvm.org/D38063
Files:
clang/lib/CodeGen/CGClass.cpp
llvm/lib/Transfo
andrew.w.kaylor created this revision.
This patch amends the changes that were committed from
https://reviews.llvm.org/D37042 to remove the offset size check in the idiom
identification routine.
That check was behaving inconsistently (from target to target) because the
offset was implicitly pr
aprantl added a comment.
In https://reviews.llvm.org/D38042#875734, @chandlerc wrote:
> In https://reviews.llvm.org/D38042#875441, @aprantl wrote:
>
> > In https://reviews.llvm.org/D38042#875418, @chandlerc wrote:
> >
> > > Absolutely. I think the verifier should never, under any circumstances,
vsapsai added a comment.
Thanks for review.
In https://reviews.llvm.org/D37881#875574, @rsmith wrote:
> I think we need to clearly identify what state we're saving here and why.
> It's the state that is pending from a class that we're currently in the
> middle of parsing, so how about somethin
ioeric added a comment.
Sorry for the delay (most of us are OOO this week).
Comment at: include/clang/Tooling/Refactoring/RefactoringActionRule.h:48
+
+ virtual void visitRefactoringOptions(RefactoringOptionConsumer &Consumer) =
0;
};
Please document the beh
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313694: [libc++] Replace __sync_* functions with
__libcpp_atomic_* functions (authored by weimingz).
Changed prior to commit:
https://reviews.llvm.org/D35235?vs=115918&id=115922#toc
Repository:
rL LL
Author: weimingz
Date: Tue Sep 19 16:18:03 2017
New Revision: 313694
URL: http://llvm.org/viewvc/llvm-project?rev=313694&view=rev
Log:
[libc++] Replace __sync_* functions with __libcpp_atomic_* functions
Summary:
This patch replaces __sync_* with __libcpp_atomic_* and adds a wrapper
function for
dlj created this revision.
Herald added a subscriber: sanjoy.
Even though the base typedef is private, it still participates in lookup. For
example:
void base() {}
struct X : private std::list {
X() { base(); }
};
https://reviews.llvm.org/D38059
Files:
include/list
Index: include
weimingz updated this revision to Diff 115918.
weimingz added a comment.
minor change
https://reviews.llvm.org/D35235
Files:
src/exception.cpp
src/include/atomic_support.h
src/include/refstring.h
src/locale.cpp
src/new.cpp
src/support/runtime/exception_fallback.ipp
src/support/run
chandlerc added a comment.
In https://reviews.llvm.org/D38042#875441, @aprantl wrote:
> In https://reviews.llvm.org/D38042#875418, @chandlerc wrote:
>
> > Absolutely. I think the verifier should never, under any circumstances,
> > mutate the IR. Think about it, with the current design if a pass
bruno added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:1042
+}
+
+assert(SrcElementTy->isFloatingPointTy() &&
What happens if the SrcElementTy is float and DstElementTy isn't? Seems like it
will hit the assertion below.
Author: anemet
Date: Tue Sep 19 16:00:59 2017
New Revision: 313693
URL: http://llvm.org/viewvc/llvm-project?rev=313693&view=rev
Log:
Add override for ClangDiagnosticHandler::isAnyRemarkEnabled()
This is used by the new closure-based variant of
OptimizationRemarkEmitter::emit().
Modified:
cfe
thakis added a comment.
I think for depfile generation, we generally try to be gcc-compatible (I can
link to prior changes in this spirit), so I think this seems like a good thing
to do to me. gcc only does this for system headers, yes?
Does gcc support the non-negated spelling of this flag
(-
efriedma added a comment.
I would rather not make ARM baremetal do something different from every other
target...
On Linux, for most targets, we don't add the uwtable attribute by default;
without the uwtable attribute, non-ARM backends (e.g. aarch64) only emit tables
for functions which might
EricWF accepted this revision.
EricWF added inline comments.
Comment at: src/include/atomic_support.h:153
+_ValueType old;
+old = *__target;
+*__target = __value;
Initialize `old` on the same line it's declared on.
https://reviews.llvm.org/D35235
efriedma added a comment.
I agree, it doesn't add much value.
Either way, though, please make sure you address the buildbot failures quickly.
Repository:
rL LLVM
https://reviews.llvm.org/D37042
___
cfe-commits mailing list
cfe-commits@lists.llvm
lebedev.ri reopened this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.
Reverted due to buildbot failures.
Need to investigate.
Repository:
rL LLVM
https://reviews.llvm.org/D37629
___
cfe-commits mailing li
Author: akaylor
Date: Tue Sep 19 14:43:01 2017
New Revision: 313684
URL: http://llvm.org/viewvc/llvm-project?rev=313684&view=rev
Log:
Fix 32-bit buildbots by removing tests that are dependent on pointer-size
comparisons.
The recently behavior in the code that these tests were meant to be checkin
Author: lebedevri
Date: Tue Sep 19 14:40:41 2017
New Revision: 313683
URL: http://llvm.org/viewvc/llvm-project?rev=313683&view=rev
Log:
Revert "[Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare"
This reverts commit r313677.
Buildbots fail with assertion failure
Failing Tests
Nebiroth added a comment.
In https://reviews.llvm.org/D36150#867971, @ilya-biryukov wrote:
> Overall looks good, but still needs at least a few tests.
I have a test for this commit that uses included source and header files, would
that be okay to do or should I generate files dynamically? If s
andrew.w.kaylor added a comment.
This is breaking buildbots for 32-bit targets because the offset in 'nullptr +
int8_t_N' is being implicitly cast to an int. That makes the sizeof(offset) ==
sizeof(ptr) check turn out differently than my tests were assuming.
I can get the buildbots green quick
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313677: [Sema] Move some stuff into
-Wtautological-unsigned-enum-zero-compare (authored by lebedevri).
Changed prior to commit:
https://reviews.llvm.org/D37629?vs=115890&id=115903#toc
Repository:
rL
On Fri, Sep 8, 2017 at 7:10 PM, Roman Lebedev wrote:
> On Fri, Sep 8, 2017 at 3:26 PM, Roman Lebedev wrote:
>> On Fri, Sep 8, 2017 at 2:48 PM, Sam McCall wrote:
>> Hi.
>>
>>> Nice fix!
>> Thank you!
>>
>>> It catches a lot of new cases on our codebase, all technically
>>> correct so far.
>>>
>>>
Author: lebedevri
Date: Tue Sep 19 14:11:35 2017
New Revision: 313677
URL: http://llvm.org/viewvc/llvm-project?rev=313677&view=rev
Log:
[Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare
Summary:
As requested by Sam McCall:
> Enums (not new I guess). Typical case: if (enum < 0
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313675: [OpenMP] fix seg-faults printing diagnostics with
invalid ordered(n) values (authored by rcraik).
Changed prior to commit:
https://reviews.llvm.org/D38049?vs=115876&id=115901#toc
Repository:
Author: rcraik
Date: Tue Sep 19 14:04:23 2017
New Revision: 313675
URL: http://llvm.org/viewvc/llvm-project?rev=313675&view=rev
Log:
[OpenMP] fix seg-faults printing diagnostics with invalid ordered(n) values
When the value specified for n in ordered(n) is larger than the number of loops
a segme
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D37629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D37881#871556, @vsapsai wrote:
> I don't like name `SavePendingDelayedStateRAII` as too vague. Hope you'll be
> able to suggest something better or I'll have better
weimingz updated this revision to Diff 115891.
weimingz added a comment.
Moved the inclusion from stdexcept.cpp into refstring.h
For exception.cpp and new.cpp, I think it's better to keep the inclusion there.
Those files include new_handler_fallback.ipp, exception_fallback.ipp, which
need the
lebedev.ri updated this revision to Diff 115890.
lebedev.ri added a comment.
Simplify `CheckTautologicalComparisonWithZero()` as per review notes.
Less LOC.
Repository:
rL LLVM
https://reviews.llvm.org/D37629
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313666: Teach clang to tolerate the 'p = nullptr + n' idiom
used by glibc (authored by akaylor).
Changed prior to commit:
https://reviews.llvm.org/D37042?vs=115262&id=115889#toc
Repository:
rL LLVM
Author: akaylor
Date: Tue Sep 19 13:26:40 2017
New Revision: 313666
URL: http://llvm.org/viewvc/llvm-project?rev=313666&view=rev
Log:
Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc
Differential Revision: https://reviews.llvm.org/D37042
Added:
cfe/trunk/test/CodeGen/nullpt
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D38049
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:8605
- return Match;
+ const char *Cmp; // Simplified, pretty-printed comparison string
+ // Similar to E->getOpcodeStr(), but with extra 0 on either LHS or RHS
I'd drop this comment
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
All the tests pass now (on Mac OS) Thanks!
https://reviews.llvm.org/D37955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
Rakete updated this revision to Diff 115881.
Rakete added a project: clang.
Rakete added a comment.
Used better diagnostic id.
https://reviews.llvm.org/D36357
Files:
include/clang/Basic/DiagnosticParseKinds.td
lib/Parse/ParseExprCXX.cpp
test/Parser/cxx0x-lambda-expressions.cpp
rcraik created this revision.
When the value specified for //n// in ordered(//n//) is larger than the number
of loops a segmentation fault can occur in one of two ways when attempting to
print out a diagnostic for an associated depend(sink : //vec//):
1. The iteration vector //vec// contains le
vsk updated this revision to Diff 115879.
vsk added a comment.
- Use a better test case. This one was lifted from an actual example in
X86CallingConv.h:86.
https://reviews.llvm.org/D37544
Files:
lib/CodeGen/CGExpr.cpp
test/CodeGenCXX/ubsan-suppress-checks.cpp
Index: test/CodeGenCXX/ubsan
aprantl added a comment.
In https://reviews.llvm.org/D38042#875418, @chandlerc wrote:
> In https://reviews.llvm.org/D38042#875412, @aprantl wrote:
>
> > In https://reviews.llvm.org/D38042#875334, @chandlerc wrote:
> >
> > > In https://reviews.llvm.org/D38042#875328, @aprantl wrote:
> > >
> > > >
rnk added inline comments.
Comment at: test/CodeGen/ms-inline-asm.cpp:37-38
- int lvar = 10;
- __asm mov eax, offset Foo::ptr
- __asm mov eax, offset Foo::Bar::ptr
-// CHECK-LABEL: define void @_Z2t2v()
These don't seem tested anywhere now
Repository:
rL L
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D37413
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
lebedev.ri updated this revision to Diff 115877.
lebedev.ri added a comment.
1. Correctly added `TautologicalUnsignedEnumZeroCompare` to
`TautologicalCompare` group (sigh)
2. Hopefully fixed spelling of the comments and added a bit better comments
3. Fixed variable names to comply with the coding
werbitt updated this revision to Diff 115875.
werbitt edited the summary of this revision.
werbitt added a comment.
Rename assume-file to assume-file-name and update documentation
https://reviews.llvm.org/D37903
Files:
tools/clang-format/clang-format.el
Index: tools/clang-format/clang-forma
aprantl added a comment.
In https://reviews.llvm.org/D38042#875412, @aprantl wrote:
> In https://reviews.llvm.org/D38042#875334, @chandlerc wrote:
>
> > In https://reviews.llvm.org/D38042#875328, @aprantl wrote:
> >
> > > In https://reviews.llvm.org/D38042#875303, @chandlerc wrote:
> > >
> > > >
rwols created this revision.
Makes clangd respond to a client's "textDocument/signatureHelp" request by
presenting function/method overloads.
Still need to add tests.
Also, there is duplicate code in clangd::codeComplete and clangd::signatureHelp
now, maybe refactor this to a common function?
ht
chandlerc added a comment.
In https://reviews.llvm.org/D38042#875412, @aprantl wrote:
> In https://reviews.llvm.org/D38042#875334, @chandlerc wrote:
>
> > In https://reviews.llvm.org/D38042#875328, @aprantl wrote:
> >
> > > In https://reviews.llvm.org/D38042#875303, @chandlerc wrote:
> > >
> > >
aprantl added a comment.
In https://reviews.llvm.org/D38042#875334, @chandlerc wrote:
> In https://reviews.llvm.org/D38042#875328, @aprantl wrote:
>
> > In https://reviews.llvm.org/D38042#875303, @chandlerc wrote:
> >
> > > But, the verifier itself will just "crash". It won't print a stack trace,
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:8593
- bool Match = true;
+ // is this a tautological comparison? if yes, than contains the always-result
+ llvm::Optional Result;
Comments should be complete sentences with capitaliz
NoQ added a comment.
The overall idea makes sense to me. I'd like you to join the effort with Peter
who during his work on loop widening came up with a matcher-based procedure for
finding out if a variable is changed anywhere; it currently lives in
`LoopUnrolling.cpp` and we need only once impl
Author: anemet
Date: Tue Sep 19 10:59:40 2017
New Revision: 313653
URL: http://llvm.org/viewvc/llvm-project?rev=313653&view=rev
Log:
Fix ClangDiagnosticHandler::is*RemarkEnabled members
Apparently these weren't really working. I added test coverage and fixed the
typo in the name and the parameter
chandlerc added a comment.
In https://reviews.llvm.org/D38042#875328, @aprantl wrote:
> In https://reviews.llvm.org/D38042#875303, @chandlerc wrote:
>
> > But, the verifier itself will just "crash". It won't print a stack trace,
> > but I don't see why that's much better? And this flag is suppos
aprantl added a comment.
In https://reviews.llvm.org/D38042#875303, @chandlerc wrote:
> But, the verifier itself will just "crash". It won't print a stack trace, but
> I don't see why that's much better? And this flag is supposed to be a
> developer option and not a user facing one, so I'm some
tra added a comment.
LGTM in general.
Comment at: test/OpenMP/target_map_codegen.cpp:4845
+///==///
+// RUN: %clang_cc1 -DCK30 -std=c++11 -fopenmp -S -emit-llvm -fopenmp
-fopenmp-targets=nvptx64-nvidia-cud
lebedev.ri added a comment.
Ping, would be really nice to get this going :)
Would unblock me for working on the second half of the fix for
https://bugs.llvm.org/show_bug.cgi?id=34147
Repository:
rL LLVM
https://reviews.llvm.org/D37629
___
cfe-co
chandlerc added a comment.
But, the verifier itself will just "crash". It won't print a stack trace, but I
don't see why that's much better? And this flag is supposed to be a developer
option and not a user facing one, so I'm somewhat confused at what the intent
is here...
https://reviews.llv
tra added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:441
-SmallString<256> Name = llvm::sys::path::filename(II.getFilename());
+SmallString<256> Name = StringRef(II.getFilename());
llvm::sys::path::replace_extension(Name, "cubin");
ahatanak added a comment.
ping
https://reviews.llvm.org/D36915
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: zturner
Date: Tue Sep 19 10:19:10 2017
New Revision: 313643
URL: http://llvm.org/viewvc/llvm-project?rev=313643&view=rev
Log:
Resubmit "Fix llvm-lit script generation in libcxx."
After speaking with the libcxx owners, they agreed that this is
a bug in the bot that needs to be fixed by the
tra added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:255-257
CudaArch gpu_arch = StringToCudaArch(GPUArchName);
- assert(gpu_arch != CudaArch::UNKNOWN &&
+ assert((gpu_arch != CudaArch::UNKNOWN ||
+ Args.hasArg(options::OPT_nocudalib)) &&
--
aprantl created this revision.
This patch fixes a regression introduced by r290392
(https://reviews.llvm.org/D28047 — Make '-disable-llvm-optzns' an alias for
'-disable-llvm-passes'.)
After r290392, CodeGenOpts.DisableLLVMOpts implicitly disables
CodeGenOpts.VerifyModule, because the Verifier
timshen updated this revision to Diff 115851.
timshen added a comment.
Fixed.
Those tests were XFAILing on linux-gnu. I also created
https://reviews.llvm.org/D38041 to XFAIL only on the failing ones.
https://reviews.llvm.org/D37955
Files:
libcxx/include/regex
libcxx/test/std/re/re.alg/re.
timshen created this revision.
Herald added a subscriber: sanjoy.
Herald added a reviewer: EricWF.
The tests don't pass on linux-gnu. Move them out, so that the others
don't have to be XFAIL.
https://reviews.llvm.org/D38041
Files:
libcxx/test/std/re/re.alg/re.alg.match/basic.pass.cpp
libcxx
vlad.tsyrklevich marked an inline comment as done.
vlad.tsyrklevich added inline comments.
Comment at: docs/SanitizerSpecialCaseList.rst:57
+
+Sections are regular expressions written in square brackets that denote which
+sanitizer the following entries apply to. For example, ``[
Anastasia added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:957
-return Builder.CreateBitCast(Addr, ConvertType(E->getType()));
+return Builder.CreatePointerBitCastOrAddrSpaceCast(
+Addr, ConvertType(E->getType()));
Anastasia
vlad.tsyrklevich updated this revision to Diff 115849.
vlad.tsyrklevich added a comment.
- Refactor to make compile() not virtual again
- Refactor a confusing use of ASanMask into individual uses of
SanitizerKind::{Address,KernelAddress}
- 'Sections' -> 'Section names'
https://reviews.llvm.org/
Rakete updated this revision to Diff 115846.
Rakete added a comment.
Used the correct return type, even if it doesn't really matter to the compiler.
https://reviews.llvm.org/D36101
Files:
lib/Parse/ParseExpr.cpp
test/Parser/cxx1z-fold-expressions.cpp
Index: test/Parser/cxx1z-fold-
gtbercea created this revision.
Test for checking if the mapping is performed correctly. This is a test
initially included in Patch https://reviews.llvm.org/D29905
Repository:
rL LLVM
https://reviews.llvm.org/D38040
Files:
test/OpenMP/target_map_codegen.cpp
Index: test/OpenMP/target_map
klimek added a comment.
Ok, we still need to fix structured bindings in the UnwrappedLineParser.
Unfortunately isCppStructuredBinding requires a "previous token" function,
which we don't really have in the UnwrappedLineParser. /me goes thinking more
about that part of the problem. That should b
Rakete updated this revision to Diff 115842.
Rakete added a project: clang.
Rakete added a comment.
Added the tests to the existing test file for fold operators that I didn't
notice before :)
https://reviews.llvm.org/D36101
Files:
lib/Parse/ParseExpr.cpp
test/Parser/cxx1z-fold-
curdeius added a comment.
I confirm what I observed before: when invoking tests in
`unittests/Format/NamespaceEndCommentsFixerTest.cpp`, the `const AnnotatedLine
*line` parameter in `getNamespaceToken` gets one big line that includes both
`namespace` and `{` (something like `namespace\n{\n...`,
Alexander-Shukaev added a comment.
Mark, just wanted to check if the review is still somewhere on your radar.
Repository:
rL LLVM
https://reviews.llvm.org/D15465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
mibintc added a comment.
Hey @jyknight I heard from @erichkeane that you may want a couple more changes
to this patch. Please let me know if you have some changes to recommend.
@joerg thought this was OK for submission. Thanks --Melanie
https://reviews.llvm.org/D34158
_
zibi added a comment.
Please be aware that I don't have the commit permission yet since this is my
first patch. I will rely on somebody to push it to the trunk.
https://reviews.llvm.org/D37861
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
zibi updated this revision to Diff 115838.
zibi added a comment.
original + review changes
https://reviews.llvm.org/D37861
Files:
include/clang/Lex/PPCallbacks.h
lib/Frontend/PrintPreprocessedOutput.cpp
lib/Lex/Pragma.cpp
test/Preprocessor/pragma_assume_nonnull.c
Index: test/Preprocess
curdeius abandoned this revision.
curdeius added a comment.
Ok. Nice patch. You can close https://bugs.llvm.org/show_bug.cgi?id=19986 now.
https://reviews.llvm.org/D37980
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
mclow.lists requested changes to this revision.
mclow.lists added a comment.
This revision now requires changes to proceed.
When I applied this patch locally, some of the other tests started failing.
Specifically:
Assertion failed: (!std::regex_match(s, m, std::regex("^[a-f]$",
std::regex_cons
phst accepted this revision.
phst added a comment.
This revision is now accepted and ready to land.
Your use case sounds good to me. Please be sure to document the new parameter,
though.
Comment at: tools/clang-format/clang-format.el:154
+ `("-outpu
klimek added a comment.
I find the current semantics of the functions a bit surprising, specifically:
... reflowProtrudingToken(..., bool Reflow)
is really confusing me :)
I'd have expected something like this where we currently call
breakProtrudingToken():
if (CanBreak) {
ReflowPenalty =
phst added inline comments.
Comment at: tools/clang-format/clang-format.el:125
If called interactively uses the region or the current statement if there
is no active region. If no style is given uses `clang-format-style'."
(interactive
Please document the A
1 - 100 of 126 matches
Mail list logo
