rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D37881#871556, @vsapsai wrote:

> I don't like name `SavePendingDelayedStateRAII` as too vague. Hope you'll be 
> able to suggest something better or I'll have better ideas later.


I like everything about this patch other than the name of the class :)

I think we need to clearly identify what state we're saving here and why. It's 
the state that is pending from a class that we're currently in the middle of 
parsing, so how about something like `SavePendingParsedClassStateRAII`?


https://reviews.llvm.org/D37881



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D37881: [... Volodymyr Sapsai via Phabricator via cfe-commits
    • [PATCH] D378... Volodymyr Sapsai via Phabricator via cfe-commits
    • [PATCH] D378... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D378... Volodymyr Sapsai via Phabricator via cfe-commits
    • [PATCH] D378... Volodymyr Sapsai via Phabricator via cfe-commits
    • [PATCH] D378... Volodymyr Sapsai via Phabricator via cfe-commits

Reply via email to