timshen added inline comments.
Comment at:
libcxx/test/std/re/re.traits/lookup_classname_user_defined.pass.cpp:46
+// matches all characters (they are classified as alnum)
+std::wstring re1 = L"([[:alnum:]]+)";
+std::regex_search(in, m, std::wregex(re1));
---
timshen updated this revision to Diff 115597.
timshen added a comment.
Propagate __icase_ correctly into lookup_classname.
https://reviews.llvm.org/D37958
Files:
libcxx/include/regex
libcxx/test/std/re/re.traits/lookup_classname_user_defined.pass.cpp
libcxx/utils/libcxx/test/target_info.p
Author: chapuni
Date: Sun Sep 17 22:52:57 2017
New Revision: 313513
URL: http://llvm.org/viewvc/llvm-project?rev=313513&view=rev
Log:
Revert rL313511, "Fix a warning discovered by rL313487.
[-Wunused-lambda-capture]"
It was incompatible to msc.
Modified:
cfe/trunk/lib/Lex/PPLexerChange.cpp
Author: chapuni
Date: Sun Sep 17 21:55:33 2017
New Revision: 313511
URL: http://llvm.org/viewvc/llvm-project?rev=313511&view=rev
Log:
Fix a warning discovered by rL313487. [-Wunused-lambda-capture]
Modified:
cfe/trunk/lib/Lex/PPLexerChange.cpp
Modified: cfe/trunk/lib/Lex/PPLexerChange.cpp
UR
Author: chapuni
Date: Sun Sep 17 21:55:31 2017
New Revision: 313510
URL: http://llvm.org/viewvc/llvm-project?rev=313510&view=rev
Log:
Reformat.
Modified:
cfe/trunk/lib/Lex/PPLexerChange.cpp
Modified: cfe/trunk/lib/Lex/PPLexerChange.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/
Thanks!
On Mon, Sep 18, 2017 at 5:58 AM Eric Fiselier wrote:
> Fixed in r313499.
>
> /Eric
>
> On Sun, Sep 17, 2017 at 2:04 PM, Eric Fiselier wrote:
>
>> I'll correct them.
>>
>> /Eric
>>
>> On Sat, Sep 16, 2017 at 6:28 PM, Richard Smith
>> wrote:
>>
>>> This is a bug in the libc++ tests. It's
joerg added a comment.
ninja is not the only consumer of this. For human inspection, it can be quite
surprising to see symlinks resolved, i.e. /usr/include/machine on NetBSD. Build
systems have different ideas on whether they want absolute resolved paths or
not, so it seems like ninja should be
Lekensteyn added a comment.
In https://reviews.llvm.org/D37954#873373, @joerg wrote:
> Resolving the path doesn't necessary shorten the string at all, in many cases
> it will be longer.
The description was based on the GCC manual page (" When preprocessing, do not
shorten system header paths
Author: ericwf
Date: Sun Sep 17 14:50:59 2017
New Revision: 313502
URL: http://llvm.org/viewvc/llvm-project?rev=313502&view=rev
Log:
Fix two failing -verify tests to tolerate old and new clang versions
Modified:
libcxx/trunk/test/std/utilities/any/any.nonmembers/any.cast/const_correctness.fa
joerg added a comment.
The comments at the very least are misleading. Resolving the path doesn't
necessary shorten the string at all, in many cases it will be longer. I'm
really not sure if clang should resolve symlinks like this as it can be quite
surprising.
https://reviews.llvm.org/D37954
Thank you!
Sent from my iPhone
> On Sep 17, 2017, at 1:58 PM, Eric Fiselier wrote:
>
> Fixed in r313499.
>
> /Eric
>
>> On Sun, Sep 17, 2017 at 2:04 PM, Eric Fiselier wrote:
>> I'll correct them.
>>
>> /Eric
>>
>>> On Sat, Sep 16, 2017 at 6:28 PM, Richard Smith
>>> wrote:
>>
>>> This is
Author: ericwf
Date: Sun Sep 17 14:00:27 2017
New Revision: 313501
URL: http://llvm.org/viewvc/llvm-project?rev=313501&view=rev
Log:
Update changelog revision
Modified:
libcxx/trunk/lib/abi/CHANGELOG.TXT
Modified: libcxx/trunk/lib/abi/CHANGELOG.TXT
URL:
http://llvm.org/viewvc/llvm-project/l
Author: ericwf
Date: Sun Sep 17 13:59:43 2017
New Revision: 313500
URL: http://llvm.org/viewvc/llvm-project?rev=313500&view=rev
Log:
ABI: Fix for undefined "___cxa_deleted_virtual" symbol in MacOSX
Patch from Eddie Elizondo. Reviewed as D37830 (https://reviews.llvm.org/D37830).
On MacOSX the fol
Fixed in r313499.
/Eric
On Sun, Sep 17, 2017 at 2:04 PM, Eric Fiselier wrote:
> I'll correct them.
>
> /Eric
>
> On Sat, Sep 16, 2017 at 6:28 PM, Richard Smith
> wrote:
>
>> This is a bug in the libc++ tests. It's OK for them to check that the
>> static_assert message is produced, but not that
Author: ericwf
Date: Sun Sep 17 13:57:05 2017
New Revision: 313499
URL: http://llvm.org/viewvc/llvm-project?rev=313499&view=rev
Log:
Fix failing -verify tests due to change in Clangs static_assert message.
Clang recently changed the way it outputs static assert diagnostics.
This patch fixes libc+
NoQ created this revision.
Standard boilerplate: stop tracking mutex state when the mutex dies as a region.
Clean up the destroyed symbol cleanup code a tiny bit. Note that this code is
unaffected by the zombie symbol bug because whenever we need to take action,
constraint manager is bound to m
I'll correct them.
/Eric
On Sat, Sep 16, 2017 at 6:28 PM, Richard Smith
wrote:
> This is a bug in the libc++ tests. It's OK for them to check that the
> static_assert message is produced, but not that they're prefixed with the
> exact string "static_assert failed:".
>
> On 16 September 2017 at
NoQ updated this revision to Diff 115586.
NoQ added a comment.
Remove the changes in tests for now. I guess they'd need more cleanup anyway.
https://reviews.llvm.org/D37809
Files:
lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp
Index: lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp
===
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:271
}
-assert(lockFail && lockSucc);
-C.addTransition(lockFail);
-
+// We might want to handle the case when the mutex lock function was
inlined
+// and returned an Unk
Author: ctopper
Date: Sun Sep 17 12:05:46 2017
New Revision: 313497
URL: http://llvm.org/viewvc/llvm-project?rev=313497&view=rev
Log:
[X86] Move even more of our CPU to feature mapping switch to use fallthroughs
This arranges more of the Intel and AMD CPUs into fallthrough positions based
on the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313497: [X86] Move even more of our CPU to feature mapping
switch to use fallthroughs (authored by ctopper).
Changed prior to commit:
https://reviews.llvm.org/D37941?vs=115517&id=115585#toc
Repository:
Hi,
I would present patch: The small extension of clang-format.
I added two additional format options:
- Space before square bracket.
- Space before angle bracket.
I know that it's very strange formatting, but unfortunately, it's
formatting style in the company I work in it.
I'm not really sure w
Quuxplusone added inline comments.
Comment at:
libcxx/test/std/re/re.traits/lookup_classname_user_defined.pass.cpp:46
+// matches all characters (they are classified as alnum)
+std::wstring re1 = L"([[:alnum:]]+)";
+std::regex_search(in, m, std::wregex(re1));
---
Hi Nico,
On Sun, Sep 17, 2017 at 10:47:24AM -0400, Nico Weber wrote:
> Have you checked how much the additional stat()ing added in this patch
> slows down builds?
Additional cost: zero :-)
The information is already collected by FileManager::getFile(), calling
tryGetRealPathName just reads infor
Author: faisalv
Date: Sun Sep 17 08:37:51 2017
New Revision: 313487
URL: http://llvm.org/viewvc/llvm-project?rev=313487&view=rev
Log:
Fix the second half of PR34266: Don't implicitly capture '*this' if the
members are found in a class unrelated to the enclosing class.
https://bugs.llvm.org/show
Have you checked how much the additional stat()ing added in this patch
slows down builds?
On Sep 16, 2017 11:49 PM, "Peter Wu via Phabricator via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Lekensteyn added a comment.
>
> I tried to contact Simon (the author of the GCC) patch with a quest
lebedev.ri added a comment.
In https://reviews.llvm.org/D36836#873246, @JonasToth wrote:
> For my part the current state is ok.
@JonasToth thank you for the review!
> but @alexfh and @aaron.ballman should do their review before committing.
+1 :)
Now what one full review is done, it may be eas
JonasToth added inline comments.
Comment at: clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:102-114
+const std::array CognitiveComplexity::Msgs = {{
+// B1 + B2 + B3
+"+%0, including nesting penalty of %1, nesting level increased to %2",
+
+// B1 + B2
+
lebedev.ri added inline comments.
Comment at: clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:102-114
+const std::array CognitiveComplexity::Msgs = {{
+// B1 + B2 + B3
+"+%0, including nesting penalty of %1, nesting level increased to %2",
+
+// B1 + B2
+
JonasToth added a comment.
For my part the current state is ok. @alexfh and @aaron.ballman but should do
their review before committing.
I would be interested in a exampleoutput for any real project.
Comment at: clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:102-1
coby updated this revision to Diff 115564.
coby added a comment.
addressed @rnk 's suggestions:
cuteness out
c++ mischief in
Repository:
rL LLVM
https://reviews.llvm.org/D37413
Files:
include/clang/Parse/Parser.h
include/clang/Sema/Sema.h
lib/Parse/ParseStmtAsm.cpp
lib/Sema/SemaStmtA
coby added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D37466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
timshen updated this revision to Diff 115560.
timshen added a comment.
Stylize template decl to "template https://reviews.llvm.org/D37958
Files:
libcxx/include/regex
libcxx/test/std/re/re.traits/lookup_classname_user_defined.pass.cpp
libcxx/utils/libcxx/test/target_info.py
Index: libcxx/ut
timshen updated this revision to Diff 115559.
timshen added a comment.
Update description.
https://reviews.llvm.org/D37958
Files:
libcxx/include/regex
libcxx/test/std/re/re.traits/lookup_classname_user_defined.pass.cpp
libcxx/utils/libcxx/test/target_info.py
Index: libcxx/utils/libcxx/te
timshen added a comment.
I'm not sure if we need to change the CI server to suport ja_JP.UTF-8.
https://reviews.llvm.org/D37958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
timshen created this revision.
Herald added a subscriber: sanjoy.
Herald added a reviewer: EricWF.
Always lookup the class name, even when the traits type is regex_traits<>.
The lookup happens at regex compile time, so it shouldn't affect the
performance.
I also added ja_JP.UTF-8 as a common loc
36 matches
Mail list logo
