This revision was automatically updated to reflect the committed changes.
Closed by commit rL313122: Use CMAKE_AR instead of the system default 'ar' for
merging static libraries (authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D37134?vs=114908&id=114981#toc
Repository:
Author: mstorsjo
Date: Tue Sep 12 23:55:44 2017
New Revision: 313122
URL: http://llvm.org/viewvc/llvm-project?rev=313122&view=rev
Log:
Use CMAKE_AR instead of the system default 'ar' for merging static libraries
Using the system default 'ar' might not be the right choice when
cross compiling.
Do
coby added inline comments.
Comment at: lib/Sema/SemaStmtAsm.cpp:617
+return;
+ } else if (Res->isRValue()) {
+bool Enum = isa(T) && Res->EvaluateAsRValue(Eval,
Context);
rnk wrote:
> RKSimon wrote:
> > (style) Split these instead of an if-elseif chain
jina.nahias updated this revision to Diff 114978.
https://reviews.llvm.org/D37668
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Basic/BuiltinsX86_64.def
lib/Headers/avx512bwintrin.h
lib/Headers/avx512fintrin.h
lib/Headers/avx512vlbwintrin.h
lib/Headers/avx512vlintrin.h
te
compnerd added a comment.
I'm happy to pick this up again. LMK what needs to be addressed. AFAIK, no
constructors will be invoked as the class is just a wrapper over static data so
we don't need the constructors. I would rather do the undecorating stuff in a
follow-up.
https://reviews.llvm
compnerd closed this revision.
compnerd added a comment.
SVN r313111
https://reviews.llvm.org/D37577
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pcc created this revision.
Also add some missing driver tests for the regular clang driver.
https://reviews.llvm.org/D37787
Files:
clang/include/clang/Driver/Options.td
clang/test/Driver/whole-program-vtables.c
Index: clang/test/Driver/whole-program-vtables.c
=
smeenai added a comment.
Rebased and tested on Windows again.
I'd like to see this patch get through to reduce the dependencies on the
`vcruntime` headers, since those end up pulling in lots of cruft and can cause
some nasty conflicts. (Similarly, I'll be trying to remove dependencies on
`Wind
smeenai updated this revision to Diff 114957.
smeenai added a comment.
Rebase
https://reviews.llvm.org/D28212
Files:
include/typeinfo
src/support/runtime/exception_msvc.ipp
src/typeinfo.cpp
Index: src/typeinfo.cpp
===
--- sr
Just to follow up,
The test case here was added by yaron in https://reviews.llvm.org/rL253066
As a follow up to the original detection which I originally wrote and reid
reviewed https://reviews.llvm.org/rL242121
Given that no other target does special checks except msvc for lld-link
removing this t
Author: compnerd
Date: Tue Sep 12 19:15:09 2017
New Revision: 313111
URL: http://llvm.org/viewvc/llvm-project?rev=313111&view=rev
Log:
libclang: expose `clang_getCursorTLSKind`
Introduce the 'TLS Kind' property of variable declarations through
libclang. Additionally, provide a Python accessor for
mcgrathr created this revision.
Herald added a subscriber: mgorny.
This is a "Does your linker support it?" option, and all ours do.
Repository:
rL LLVM
https://reviews.llvm.org/D37785
Files:
cmake/caches/Fuchsia-stage2.cmake
Index: cmake/caches/Fuchsia-stage2.cmake
=
Hey Reid, Rui,
I had to revert this twice. I'm not sure where the configurations for the
build bots are but there are 2 issues as I mentioned in the commit message
Looking through the clang test directory I only se -fuse-ld=lld tested in 4
locations
test/Driver/windows-cross.c does some really o
EricWF added inline comments.
Comment at: include/memory:1349
is_same<
-decltype(__has_construct_test(declval<_Alloc>(),
- declval<_Pointer>(),
- declval<_Args>()...)),
+
Author: awatry
Date: Tue Sep 12 18:40:25 2017
New Revision: 313107
URL: http://llvm.org/viewvc/llvm-project?rev=313107&view=rev
Log:
Add native_recip(x) as ((1)/(x))
Signed-off-by: Aaron Watry
Acked-by: Jan Vesely
Added:
libclc/trunk/generic/include/clc/math/native_recip.h
Modified:
li
vsapsai added a comment.
Does your fix work for deeper nesting too (e.g. template in template in
template)? Looks like it should, just want to confirm.
Are there other places where you need to avoid calling
`DeduceTemplateArguments` due to templates depth mismatch?
`CheckDependentFunctionTempl
Author: martell
Date: Tue Sep 12 17:57:50 2017
New Revision: 313104
URL: http://llvm.org/viewvc/llvm-project?rev=313104&view=rev
Log:
Revert "[Driver] MinGW: Remove custom linker detection"
This reverts rL313102 because it still fails some build bot tests.
On many linux bots it fails with the fo
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
Why the additional inclusion of the support in the files which are not modified
to use functions? (e.g. `src/stdexcept.cpp`). LG otherwise.
Comment at: src/include/ato
Quuxplusone added inline comments.
Comment at: include/memory:1349
is_same<
-decltype(__has_construct_test(declval<_Alloc>(),
- declval<_Pointer>(),
- declval<_Args>()...)),
+
Author: martell
Date: Tue Sep 12 17:46:54 2017
New Revision: 313102
URL: http://llvm.org/viewvc/llvm-project?rev=313102&view=rev
Log:
[Driver] MinGW: Remove custom linker detection
In rL289668 the ability to specify the default linker at compile time
was added but because the MinGW driver used cu
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D36719#841499, @smeenai wrote:
> There should probably be some documentation for this, but I couldn't think of
> the right place; the Using libc++ documentation onl
EricWF added inline comments.
Comment at: include/__split_buffer:279
while (__begin_ != __new_begin)
-__alloc_traits::destroy(__alloc(), __to_raw_pointer(__begin_++));
+__alloc_traits::destroy(__alloc(),
_VSTD::__to_raw_pointer(__begin_++));
}
-
anemet added a comment.
In https://reviews.llvm.org/D37196#868320, @vivekvpandya wrote:
> > Why? That was inside BackendConsumer.
>
> I was getting incomplete type error.
You may have to move the class declaration of ClangDiagnosticHandler before the
BackendConsumer and move the definition of
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313096: [ubsan] Function Sanitizer: Don't require writable
text segments (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D37597?vs=114932&id=114943#toc
Repository:
rL LLVM
h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313097: [ubsan] Enable -fsanitize=function test on Darwin
(authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D37598?vs=114268&id=114944#toc
Repository:
rL LLVM
https://reviews.
vsk marked 4 inline comments as done.
vsk added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:461
+ ? EncodedAddr
+ : Builder.CreateSExt(EncodedAddr, IntPtrTy);
+ auto *FuncAsInt = Builder.CreatePtrToInt(F, IntPtrTy,
Author: vedantk
Date: Tue Sep 12 17:04:36 2017
New Revision: 313099
URL: http://llvm.org/viewvc/llvm-project?rev=313099&view=rev
Log:
[ubsan] Enable -fsanitize=function on Darwin
https://reviews.llvm.org/D37598
Modified:
cfe/trunk/docs/UndefinedBehaviorSanitizer.rst
cfe/trunk/lib/Driver/
Author: vedantk
Date: Tue Sep 12 17:04:36 2017
New Revision: 313098
URL: http://llvm.org/viewvc/llvm-project?rev=313098&view=rev
Log:
Tighten up a test case. NFC.
Modified:
cfe/trunk/test/CodeGenCXX/catch-undef-behavior.cpp
Modified: cfe/trunk/test/CodeGenCXX/catch-undef-behavior.cpp
URL:
h
Author: vedantk
Date: Tue Sep 12 17:04:35 2017
New Revision: 313096
URL: http://llvm.org/viewvc/llvm-project?rev=313096&view=rev
Log:
[ubsan] Function Sanitizer: Don't require writable text segments
This change will make it possible to use -fsanitize=function on Darwin and
possibly on other platf
ahatanak added a comment.
I was thinking about correcting the typo in Sema::ActOnMemberAccessExpr before
checking whether Base is dependent. Doing so would cause
BuildMemberReferenceExpr to be called instead of ActOnDependentMemberExpr.
I thought that would be a simpler approach, but I'm actual
erichkeane added a comment.
Also, Craig mentioned to me that naming rules require static fucntions to start
with a lower case letter (not uppercase). Additionally, Variables (like
'result') need to start with a capital letter.
Comment at: lib/Sema/SemaDeclCXX.cpp:2388
+
+ re
Author: marshall
Date: Tue Sep 12 16:33:34 2017
New Revision: 313092
URL: http://llvm.org/viewvc/llvm-project?rev=313092&view=rev
Log:
Mark the new tests as unsupported when there are no exceptions
Modified:
libcxx/trunk/test/std/re/re.alg/re.alg.match/exponential.pass.cpp
libcxx/trunk/te
zahiraam updated this revision to Diff 114935.
zahiraam added a comment.
Erich, Aaron,
Please review at your convenience.
Thanks.
https://reviews.llvm.org/D37308
Files:
lib/Sema/SemaDeclCXX.cpp
test/SemaCXX/ms-uuid.cpp
Index: test/SemaCXX/ms-uuid.cpp
=
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Comment at: lib/CodeGen/CodeGenFunction.cpp:461
+ ? EncodedAddr
+ : Builder.CreateSExt(EncodedAddr, IntPtrTy);
+ auto
It is reverted because it broke buildbots:
http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/42380/testReport/junit/Clang/Driver/mingw_useld_c/
On Tue, Sep 12, 2017 at 4:05 PM, Rui Ueyama wrote:
> I wonder why you reverted this change.
>
> On Tue, Sep 12, 2017 at 4:04 PM, Mar
Just incase anyone comes here wondering why.
The thread for the original patch `r313082 - [Driver] MinGW: Remove custom
linker detection` here on cfe-commits explains why.
On Wed, Sep 13, 2017 at 12:05 AM, Rui Ueyama wrote:
> I wonder why you reverted this change.
>
> On Tue, Sep 12, 2017 at 4:
I'm perhaps not the only person who is wondering, so I'll update the
original thread instead of replying to this thread.
On Tue, Sep 12, 2017 at 4:07 PM, Martell Malone
wrote:
> cc @rui this is why I reverted it.
>
> On Wed, Sep 13, 2017 at 12:00 AM, Martell Malone
> wrote:
>
>> Hi Mike,
>>
>>
cc @rui this is why I reverted it.
On Wed, Sep 13, 2017 at 12:00 AM, Martell Malone
wrote:
> Hi Mike,
>
> I reverted this for now, I assume it has to do with the argument ordering.
> Will try a change and re apply.
>
> Many Thanks,
> Martell
>
> On Tue, Sep 12, 2017 at 11:57 PM, Martell Malone
vsapsai added a comment.
Ping. If you don't have time to review the change in depth, please say if the
approach is wrong on high level.
https://reviews.llvm.org/D37089
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
I wonder why you reverted this change.
On Tue, Sep 12, 2017 at 4:04 PM, Martell Malone
wrote:
> Will do in future, thanks Rui.
>
> On Wed, Sep 13, 2017 at 12:03 AM, Rui Ueyama wrote:
>
>> When you revert a commit, please explain why you are reverting it in the
>> commit message.
>>
>> On Tue, S
Will do in future, thanks Rui.
On Wed, Sep 13, 2017 at 12:03 AM, Rui Ueyama wrote:
> When you revert a commit, please explain why you are reverting it in the
> commit message.
>
> On Tue, Sep 12, 2017 at 3:58 PM, Martell Malone via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author:
When you revert a commit, please explain why you are reverting it in the
commit message.
On Tue, Sep 12, 2017 at 3:58 PM, Martell Malone via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: martell
> Date: Tue Sep 12 15:58:12 2017
> New Revision: 313088
>
> URL: http://llvm.org/viewvc/l
vsk added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:445
+ auto *GV = new llvm::GlobalVariable(CGM.getModule(), Addr->getType(),
+ /*isConstant=*/false,
+ llvm::GlobalValue::PrivateLinkag
vsk updated this revision to Diff 114932.
vsk marked 8 inline comments as done.
vsk added a comment.
Address review feedback.
https://reviews.llvm.org/D37597
Files:
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.cpp
lib/CodeGen/CodeGenFunction.h
lib/CodeGen/TargetInfo.cpp
test/Cod
Hi Mike,
I reverted this for now, I assume it has to do with the argument ordering.
Will try a change and re apply.
Many Thanks,
Martell
On Tue, Sep 12, 2017 at 11:57 PM, Martell Malone
wrote:
> Hi Mike,
>
> I actually posted this in the phab thread a few minutes ago.
>
> ```
> Tests for this
Author: martell
Date: Tue Sep 12 15:58:12 2017
New Revision: 313088
URL: http://llvm.org/viewvc/llvm-project?rev=313088&view=rev
Log:
Revert "[Driver] MinGW: Remove custom linker detection"
This reverts rL313082
Modified:
cfe/trunk/lib/Driver/ToolChains/MinGW.cpp
cfe/trunk/test/Driver/mi
Hi Mike,
I actually posted this in the phab thread a few minutes ago.
```
Tests for this pass locally but the build bots are complaining with
// CHECK_LLD_32: "{{[^"]*}}ld.lld{{(.exe)?}}"
^
:1:1: note: scanning from here
clang version 6.0.0 (trunk 313082)
^
:5:51: note: possible
Hi,
Would you please have a look at:
http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/42380/
it appears this commit is causing some tests to fail on our bots. Any
assistance you may provide in getting the bots back green would be greatly
appreciated.
Respectfully,
Mike Edwar
Author: vedantk
Date: Tue Sep 12 15:51:53 2017
New Revision: 313087
URL: http://llvm.org/viewvc/llvm-project?rev=313087&view=rev
Log:
[Driver] Disable uwtable by default in -ffreestanding mode
We make the same decision when compiling the kernel or kexts -- we
should do this in -ffreestanding mode
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313087: [Driver] Disable uwtable by default in
-ffreestanding mode (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D3?vs=114927&id=114929#toc
Repository:
rL LLVM
https:/
ahatanak accepted this revision.
ahatanak added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D3
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
I agree with the general consensus that we should only make this change if it's
significantly faster, and only after we have a test that demonstrates this.
Unfortunately I don't reca
vsk created this revision.
Herald added subscribers: kristof.beyls, aemerson.
We make the same decision when compiling the kernel or kexts -- we
should do this in -ffreestanding mode as well to avoid size regressions
in a potentially large set of firmware projects.
It's still possible to get uwta
vsapsai added a comment.
In https://reviews.llvm.org/D37322#859065, @ahatanak wrote:
> Is it possible to avoid creating CXXDependentScopeMemberExpr in the first
> place? It seems to me that we shouldn't be creating a
> CXXDependentScopeMemberExpr for an ObjC property access.
>
> Or perhaps ther
Author: martell
Date: Tue Sep 12 15:32:02 2017
New Revision: 313084
URL: http://llvm.org/viewvc/llvm-project?rev=313084&view=rev
Log:
libcxx: fix merge_archives error variable name
Differential Revision: https://reviews.llvm.org/D37728
Modified:
libcxx/trunk/utils/merge_archives.py
Modified
EricWF accepted this revision.
EricWF added a comment.
LGTM, minus inline comments.
Comment at: utils/merge_archives.py:97
parser.add_argument(
+'-a', '--ar', dest='ar_exe', required=False,
+help='The ar executable to use, finds \'ar\' in the path if not gi
EricWF accepted this revision.
EricWF added inline comments.
This revision is now accepted and ready to land.
Comment at: CMakeLists.txt:633
+ if (EXISTS "${site_config_path}")
+file(REMOVE "${site_config_path}")
+ endif()
Maybe print a warning or a message
martell closed this revision.
martell added a comment.
Landed in https://reviews.llvm.org/rL313082
Repository:
rL LLVM
https://reviews.llvm.org/D37727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
Author: martell
Date: Tue Sep 12 15:14:18 2017
New Revision: 313082
URL: http://llvm.org/viewvc/llvm-project?rev=313082&view=rev
Log:
[Driver] MinGW: Remove custom linker detection
In rL289668 the ability to specify the default linker at compile time
was added but because the MinGW driver used cu
martell added a comment.
In https://reviews.llvm.org/D37727#868284, @rnk wrote:
> Nice! IIUC, now that the gnu ld driver works on Windows we can remove this
> logic. Thanks!
We could have removed it before the addition of the gnu ld driver, I think the
author just missed this target and possi
efriedma added a comment.
Ping.
https://reviews.llvm.org/D35235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: pcc
Date: Tue Sep 12 14:50:41 2017
New Revision: 313078
URL: http://llvm.org/viewvc/llvm-project?rev=313078&view=rev
Log:
IR: Represent -ggnu-pubnames with a flag on the DICompileUnit.
This allows the flag to be persisted through to LTO.
Differential Revision: https://reviews.llvm.org/D3
mstorsjo updated this revision to Diff 114908.
mstorsjo added a comment.
The previous patch actually lacked the 's' option that the summary talked about
https://reviews.llvm.org/D37134
Files:
lib/CMakeLists.txt
utils/merge_archives.py
Index: utils/merge_archives.py
===
mstorsjo updated this revision to Diff 114907.
mstorsjo retitled this revision from "[libc++] Rerun ranlib manually after
merging the static libraries" to "[libc++] Use CMAKE_AR for merging static
libraries".
mstorsjo edited the summary of this revision.
https://reviews.llvm.org/D37134
Files:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313072: Handle object files named *.obj in merge_archives.py
(authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D37133?vs=114893&id=114906#toc
Repository:
rL LLVM
https://revi
Author: mstorsjo
Date: Tue Sep 12 13:54:15 2017
New Revision: 313072
URL: http://llvm.org/viewvc/llvm-project?rev=313072&view=rev
Log:
Handle object files named *.obj in merge_archives.py
Differential Revision: https://reviews.llvm.org/D37133
Modified:
libcxx/trunk/utils/merge_archives.py
M
vsk added a comment.
In https://reviews.llvm.org/D32842#868505, @vlad.tsyrklevich wrote:
> @vsk Why don't I take a look at implementing the blacklist selection methods
> @eugenis mentioned on top of this change now so that we can skip ahead and
> merge something everyone is satisfied with?
Fe
vlad.tsyrklevich added a comment.
@vsk Why don't I take a look at implementing the blacklist selection methods
@eugenis mentioned on top of this change now so that we can skip ahead and
merge something everyone is satisfied with?
https://reviews.llvm.org/D32842
_
mstorsjo added a comment.
In https://reviews.llvm.org/D37134#868497, @EricWF wrote:
> Ironically I think parts of this change should be moved into
> `merge_archives.py`.
>
> > the ar used in merge_archives.py might not be the right one for the target
>
> OK, then we should modify `merge_archives
EricWF requested changes to this revision.
EricWF added a comment.
Ironically I think parts of this change should be moved into
`merge_archives.py`.
> the ar used in merge_archives.py might not be the right one for the target
OK, then we should modify `merge_archives.py` to support optionally s
mstorsjo updated this revision to Diff 114893.
mstorsjo added a comment.
Using `*.o*` instead of checking `*.obj` separately.
https://reviews.llvm.org/D37133
Files:
utils/merge_archives.py
Index: utils/merge_archives.py
===
---
On Tue, Sep 12, 2017 at 08:12:26PM +, Blower, Melanie via cfe-commits wrote:
> How is platform opt-in accomplished, is it part of the configure step?
It is part of the Linux toolchain, other platforms interested in this or
equivalent functionality would have to duplicate the hook.
Joerg
_
mstorsjo added inline comments.
Comment at: utils/merge_archives.py:121
files = glob.glob(os.path.join(temp_directory_root, '*.o'))
if not files:
EricWF wrote:
> How about simply using `*.o*`?
Sure, that would probably work as well.
https://reviews.
EricWF added inline comments.
Comment at: utils/merge_archives.py:121
files = glob.glob(os.path.join(temp_directory_root, '*.o'))
if not files:
How about simply using `*.o*`?
https://reviews.llvm.org/D37133
___
EricWF added a comment.
In https://reviews.llvm.org/D37133#860549, @compnerd wrote:
> I think we should avoid this logic entirely and use CMake to do this.
It's not that easy to do in CMake, and a CMake solution would be limited to only
merging in-tree builds together. This script allows mergin
> -Original Message-
> From: Joerg Sonnenberger via Phabricator [mailto:revi...@reviews.llvm.org]
> Sent: Tuesday, September 12, 2017 3:24 PM
> To: Blower, Melanie ; olivier...@gmail.com;
> kalinichev.s...@gmail.com; kf...@kde.org; m...@milianw.de; Keane, Erich
> ; mgo...@gentoo.org; fedo
mibintc updated this revision to Diff 114887.
mibintc added a comment.
Updating to latest version. No change other than that.
https://reviews.llvm.org/D34624
Files:
test/clang-tidy/llvm-include-order.cpp
test/pp-trace/pp-trace-conditional.cpp
test/pp-trace/pp-trace-ident.cpp
test/pp-tra
pcc added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:445
+ auto *GV = new llvm::GlobalVariable(CGM.getModule(), Addr->getType(),
+ /*isConstant=*/false,
+ llvm::GlobalValue::PrivateLinkag
JonasToth added a comment.
Recommited with fix in https://reviews.llvm.org/rL313067
https://reviews.llvm.org/D36354
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jonastoth
Date: Tue Sep 12 13:00:42 2017
New Revision: 313067
URL: http://llvm.org/viewvc/llvm-project?rev=313067&view=rev
Log:
[clang-tidy] Implement type-based check for `gsl::owner`
This check implements the typebased semantic of `gsl::owner`.
Meaning, that
- only `gsl::owner` is allo
vsk added a comment.
@eugenis I gave the idea of annotating blacklist entries with a list of
sanitizers they apply to some thought. It would be a nice follow-up to this
change, but would depend on it. As an initial step, I think we should move
forward with this patch, since it makes it possible
vsk updated this revision to Diff 114882.
vsk added a comment.
- Rebase to ToT.
https://reviews.llvm.org/D32842
Files:
include/clang/AST/ASTContext.h
include/clang/Basic/LangOptions.h
include/clang/Basic/SanitizerBlacklist.h
include/clang/Driver/SanitizerArgs.h
lib/AST/ASTContext.cpp
JonasToth updated this revision to Diff 114881.
JonasToth added a comment.
- make matcher for ctor initialization more readable
https://reviews.llvm.org/D36354
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/cppcor
joerg added a comment.
This version is fine with me. The only contentious part is whether it should be
opt-in or opt-out for platforms, so getting this version in and revisiting the
issue again later is OK from my perspective.
https://reviews.llvm.org/D34158
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313065: [Driver] Darwin: Link in the profile runtime archive
first (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D35385?vs=106538&id=114877#toc
Repository:
rL LLVM
https:/
Author: vedantk
Date: Tue Sep 12 12:15:31 2017
New Revision: 313065
URL: http://llvm.org/viewvc/llvm-project?rev=313065&view=rev
Log:
[Driver] Darwin: Link in the profile runtime archive first
While building a project with code coverage enabled, we can link in
dependencies which export a weak def
vsk added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:463
+ auto *PCRelAsInt =
+ Builder.CreatePtrToInt(EncodedAddr, IntPtrTy, "encoded_addr.int");
+ auto *FuncAsInt = Builder.CreatePtrToInt(F, IntPtrTy, "func_addr.int");
vsk wrote:
> pcc
Author: marshall
Date: Tue Sep 12 12:01:32 2017
New Revision: 313064
URL: http://llvm.org/viewvc/llvm-project?rev=313064&view=rev
Log:
XFAIL a couple of new tests for C++03
Modified:
libcxx/trunk/test/std/re/re.alg/re.alg.match/exponential.pass.cpp
libcxx/trunk/test/std/re/re.alg/re.alg.
Author: vedantk
Date: Tue Sep 12 11:58:00 2017
New Revision: 313062
URL: http://llvm.org/viewvc/llvm-project?rev=313062&view=rev
Log:
[ubsan] Extend default blacklist support to integer/nullability groups
The default blacklist should also apply when the integer or nullability
checks are enabled.
Author: hans
Date: Tue Sep 12 11:38:34 2017
New Revision: 313060
URL: http://llvm.org/viewvc/llvm-project?rev=313060&view=rev
Log:
clang-format-vs: Update the VSIX ID.
We're moving the extension to a new account on the VS Marketplace, and
apparently it's not possible to re-upload an extension wit
Author: jonastoth
Date: Tue Sep 12 11:35:54 2017
New Revision: 313059
URL: http://llvm.org/viewvc/llvm-project?rev=313059&view=rev
Log:
[clang-tidy] Revert Implement type-based check for gsl::owner
This should unbreak the buildbot for visual studio 2015 for now.
Removed:
clang-tools-extra/tr
aaron.ballman added a comment.
In https://reviews.llvm.org/D37436#868295, @hfinkel wrote:
> In https://reviews.llvm.org/D37436#867965, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D37436#867287, @rsmith wrote:
> >
> > > If this is just supposed to be an experiment to get feedback on th
vivekvpandya updated this revision to Diff 114869.
vivekvpandya marked 3 inline comments as done.
vivekvpandya added a comment.
Update.
https://reviews.llvm.org/D33514
Files:
include/llvm/Analysis/OptimizationDiagnosticInfo.h
include/llvm/CodeGen/MachineOptimizationRemarkEmitter.h
include
vivekvpandya added a comment.
Why? That was inside BackendConsumer.
I was getting incomplete type error.
You can just save the old DiagHandler object instead.
I don't think now we need to do that as per my understanding CodeGen i.e
emitting LLVM IR is last phase in clang which will pass control
JonasToth reopened this revision.
JonasToth added a comment.
This revision is now accepted and ready to land.
This Patch broke the buildbot for vs-2015.
I will revert, when i figured out how to do this in svn :/
It does not emit a warning for line 311:
here the log
> C:\b\slave\clang-x86-windows
Hello Yael,
It looks like this commit broke one of our builders:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/17121
. . .
Failing Tests (1):
Clang :: Modules/builtins.m
Please have a look?
Thanks
Galina
On Tue, Sep 12, 2017 at 12:46 AM, Yael Tsafrir
hfinkel added a comment.
In https://reviews.llvm.org/D37436#867965, @aaron.ballman wrote:
> In https://reviews.llvm.org/D37436#867287, @rsmith wrote:
>
> > If this is just supposed to be an experiment to get feedback on the
> > feature, then I don't think we should be treating it as a different
lebedev.ri added a comment.
In https://reviews.llvm.org/D33826#868185, @aaron.ballman wrote:
> Ah, I think I'm catching on to the point you're raising (thank you for
> the patience). If the return type is void *, we don't have enough
> information to sensibly diagnose (not without data flow ana
rnk added inline comments.
Comment at: lib/Sema/SemaStmtAsm.cpp:617
+return;
+ } else if (Res->isRValue()) {
+bool Enum = isa(T) && Res->EvaluateAsRValue(Eval,
Context);
RKSimon wrote:
> (style) Split these instead of an if-elseif chain
LLVM suggests ea
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Applied as revision 313056 (with minor editing)
https://reviews.llvm.org/D28224
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
1 - 100 of 189 matches
Mail list logo
