Author: gbiv
Date: Tue Aug 8 23:07:08 2017
New Revision: 310445
URL: http://llvm.org/viewvc/llvm-project?rev=310445&view=rev
Log:
Attempt #2 to appease buildbots
"error: unable to create target: 'No available targets are compatible
with this triple.'"
Modified:
cfe/trunk/test/CodeGenCXX/pr2
Author: gbiv
Date: Tue Aug 8 22:20:05 2017
New Revision: 310444
URL: http://llvm.org/viewvc/llvm-project?rev=310444&view=rev
Log:
Attempt to appease msc buildbot
It was timing out on this test, but for reasons unrelated to the
specific bug it was testing for. Randomly breaking in gdb with `clang
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D36491
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
vitalybuka added inline comments.
Comment at: clang/cmake/modules/ProtobufMutator.cmake:6
+
+ExternalProject_Add(${PBM_PREFIX}
+ PREFIX ${PBM_PREFIX}
Just noticed, for cmake projects shorter syntax can be used.
Example:
https://github.com/google/libprotobuf-mut
Author: vitalybuka
Date: Tue Aug 8 21:45:00 2017
New Revision: 310441
URL: http://llvm.org/viewvc/llvm-project?rev=310441&view=rev
Log:
[clang-fuzzer] Resolve proto dependencies
Modified:
cfe/trunk/tools/clang-fuzzer/proto-to-cxx/CMakeLists.txt
Modified: cfe/trunk/tools/clang-fuzzer/proto-t
rjmccall added a comment.
Yeah, I think having an internal C++ ABI version makes a lot more sense than
having a million different flags. Is there a reason to expose this as a knob
to users at all?
Repository:
rL LLVM
https://reviews.llvm.org/D36501
__
Author: gbiv
Date: Tue Aug 8 21:12:17 2017
New Revision: 310437
URL: http://llvm.org/viewvc/llvm-project?rev=310437&view=rev
Log:
[AST] Cache intermediate visibility/linkage results
This is a follow-up to r310436 with actual functional changes. Please
see that commit message for a description of
STL_MSFT created this revision.
[libcxx] [test] Update for C++17 feature removals.
test/std/containers/Emplaceable.h
test/std/containers/NotConstructible.h
test/support/counting_predicates.hpp
Replace unary_function/binary_function inheritance with typedefs.
test/std/depr/depr.function.objects/d
Author: gbiv
Date: Tue Aug 8 21:02:49 2017
New Revision: 310436
URL: http://llvm.org/viewvc/llvm-project?rev=310436&view=rev
Log:
[AST] Move visibility computations into a class; NFC
This is patch 1 in a 2 patch series that aims to fix PR29160. Its goal
is to cache decl visibility/linkage for th
dcoughlin added a comment.
Nice work! This looks good, with some nits and testing comments inline. Have
you run this on real code? What kind of false positives do you see?
Comment at: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp:1853
+
+void deriveParamLocation(Check
rsmith created this revision.
Herald added a subscriber: sanjoy.
This patch adds a flag `-fpass-indirect-ignore-move` that can be used to undo
the ABI change in r310401, reverting Clang to its prior C++ ABI for pass/return
by value of class types affected by that change.
This flag is enabled by
Author: rtrieu
Date: Tue Aug 8 19:03:59 2017
New Revision: 310435
URL: http://llvm.org/viewvc/llvm-project?rev=310435&view=rev
Log:
Allow operator delete to be an invalid Decl.
Do not discard invalid Decl when searching for the operator delete function.
The lookup for this function always expect
bcraig added a comment.
I like this change in general. Dinkumware has been using introsort for 10+
years, so I'm a bit surprised that libc++ wasn't already.
Comment at: include/algorithm:4208
+
+ // Threshold(or depth limit) for introsort is taken to be 2*log2(size)
+ typed
bcraig added a comment.
Those are interesting (and useful) results... but they don't look like they
came from the same algorithms.bench.cpp that I'm looking at...
https://github.com/llvm-mirror/libcxx/blob/master/benchmarks/algorithms.bench.cpp
That being said, the benchmark there only does 1k e
gtbercea added a comment.
I have just pushed a fix, revision 310433.
https://reviews.llvm.org/D29654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
phosek updated this revision to Diff 110311.
Repository:
rL LLVM
https://reviews.llvm.org/D36349
Files:
cmake/caches/Fuchsia-stage2.cmake
Index: cmake/caches/Fuchsia-stage2.cmake
===
--- cmake/caches/Fuchsia-stage2.cmake
+++ c
arsenm added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:7571
+
+ // XXX: Should this be i64 instead, and should the limit increase?
+ llvm::Type *I32Ty = llvm::Type::getInt32Ty(getVMContext());
b-sumner wrote:
> arsenm wrote:
> > b-sumner w
saugustine added a comment.
In https://reviews.llvm.org/D36431#835165, @nemanjai wrote:
> This patch appears to be perfectly fine. However, it triggers a large number
> of warnings. Namely, there's a large number of `warning: ISO C forbids an
> empty translation unit [-Wpedantic]` warnings prod
Author: tnorthover
Date: Tue Aug 8 16:17:51 2017
New Revision: 310426
URL: http://llvm.org/viewvc/llvm-project?rev=310426&view=rev
Log:
Revert "Lexer: always allow imaginary constants in GNU mode."
This reverts r310423. It was committed by mistake, I intended to commit the
improved diagnostics f
Author: tnorthover
Date: Tue Aug 8 16:18:05 2017
New Revision: 310427
URL: http://llvm.org/viewvc/llvm-project?rev=310427&view=rev
Log:
Sema: disable implicit conversion from _Complex to real types in C++.
Converting a _Complex type to a real one simply discards the imaginary part.
This can easi
fedor.sergeev added a comment.
In https://reviews.llvm.org/D34158#836026, @jyknight wrote:
> In https://reviews.llvm.org/D34158#827178, @joerg wrote:
>
> > I had a long discussion with James about this on IRC without reaching a
> > clear consensus. I consider forcing this behavior on all targets
jyknight added a comment.
In https://reviews.llvm.org/D34158#827178, @joerg wrote:
> I had a long discussion with James about this on IRC without reaching a clear
> consensus. I consider forcing this behavior on all targets to be a major bug.
> It should be opt-in and opt-in only:
>
> (1) The h
modocache created this revision.
`gcc -ftime-report` provides a breakdown of how much time GCC spends
doing preprocessing, parsing, template instantiation, and more:
g++ -ftime-report foo.cpp
Execution times (seconds)
phase setup : 0.00 ( 0%) usr 0.00 ( 0%) sys 0.00 ( 0%)
mprobst created this revision.
Herald added a subscriber: klimek.
A closing parenthesis followed by a declaration or statement should always
terminate the current statement.
https://reviews.llvm.org/D36491
Files:
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTestJS.cpp
Index:
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/Sema/SemaStmtAsm.cpp:702-705
+ // MS InlineAsm often uses struct pointer aliases as a base
+ const QualType QT = TD->getUnderlyingType();
+ RT =
euhlmann added a comment.
In https://reviews.llvm.org/D35955#835439, @klimek wrote:
> I think if we need this info, we can just make it count down to -1 again (or,
> but that's isomorphic, let it run from 0 and make sure we never index into
> the data structures at 0 :)
Should I do one of the
Author: tnorthover
Date: Tue Aug 8 15:03:54 2017
New Revision: 310423
URL: http://llvm.org/viewvc/llvm-project?rev=310423&view=rev
Log:
Lexer: always allow imaginary constants in GNU mode.
Added:
cfe/trunk/test/Lexer/imaginary-constants.cpp
Modified:
cfe/trunk/lib/Lex/LiteralSupport.cpp
b-sumner added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:7571
+
+ // XXX: Should this be i64 instead, and should the limit increase?
+ llvm::Type *I32Ty = llvm::Type::getInt32Ty(getVMContext());
arsenm wrote:
> b-sumner wrote:
> > What we
erik.pilkington added inline comments.
Comment at: src/cxa_demangle.cpp:1575-1577
-sub_type names;
-template_param_type subs;
-Vector template_param;
dexonsmith wrote:
> - Why not rename `names` as well?
> - Please rename these in a separate prep comm
erik.pilkington updated this revision to Diff 110281.
erik.pilkington marked 14 inline comments as done.
erik.pilkington added a comment.
Address review comments.
Thanks!
Erik
https://reviews.llvm.org/D36427
Files:
src/cxa_demangle.cpp
test/unittest_demangle.pass.cpp
Index: test/unittest_d
eandrews added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:2434
+// Emit section information for extern variables.
+if (D->hasExternalStorage() && !D->isThisDeclarationADefinition()) {
+ if (const SectionAttr *SA = D->getAttr())
efried
arsenm added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:7386
+ bool isHomogeneousAggregateBaseType(QualType Ty) const override;
+ bool isHomogeneousAggregateSmallEnough(const Type *Base,
+ uint64_t Members) const override;
--
efriedma added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:2434
+// Emit section information for extern variables.
+if (D->hasExternalStorage() && !D->isThisDeclarationADefinition()) {
+ if (const SectionAttr *SA = D->getAttr())
Why do
atanasyan added a comment.
Thanks for review.
Repository:
rL LLVM
https://reviews.llvm.org/D36208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310418: [mips] Enable `long_call/short_call` attributes on
MIPS64 (authored by atanasyan).
Changed prior to commit:
https://reviews.llvm.org/D36208?vs=110252&id=110275#toc
Repository:
rL LLVM
https:
Author: atanasyan
Date: Tue Aug 8 14:17:33 2017
New Revision: 310418
URL: http://llvm.org/viewvc/llvm-project?rev=310418&view=rev
Log:
[mips] Enable `long_call/short_call` attributes on MIPS64
This change enables `long_call/short_call/far/near` attributes on
MIPS64 targets.
Differential revisio
efriedma added a comment.
Please propose a patch for LangRef clarifying what exactly it means to have a
section attribute on a declaration.
Comment at: test/CodeGenCXX/extern-section-attribute.cpp:1
+// RUN: %clang_cc1 -emit-llvm %s -o - -ffreestanding -triple=i386-pc-linux-gn
eandrews created this revision.
Currently, if _attribute_((section())) is used for extern variables, section
information is not emitted in generated IR when the variables are used. This is
expected since sections are not generated for external linkage objects. However
NiosII requires this info
b-sumner added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:7571
+
+ // XXX: Should this be i64 instead, and should the limit increase?
+ llvm::Type *I32Ty = llvm::Type::getInt32Ty(getVMContext());
What we do here depends on NumRegsLeft when
Author: rnk
Date: Tue Aug 8 13:30:14 2017
New Revision: 310410
URL: http://llvm.org/viewvc/llvm-project?rev=310410&view=rev
Log:
[codeview] Emit nested enums and typedefs from classes
Previously we limited ourselves to only emitting nested classes, but we
need other kinds of types as well.
This
arsenm updated this revision to Diff 110272.
arsenm added a comment.
Fix assert when estimating array registers
https://reviews.llvm.org/D36171
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGenOpenCL/addr-space-struct-arg.cl
test/CodeGenOpenCL/amdgpu-abi-struct-coerce.cl
test/CodeGenOpenCL
fjricci added a comment.
Please add a test for this.
Repository:
rL LLVM
https://reviews.llvm.org/D36482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: kcc
Date: Tue Aug 8 13:20:40 2017
New Revision: 310409
URL: http://llvm.org/viewvc/llvm-project?rev=310409&view=rev
Log:
[sanitizer-coverage] -fsanitize-coverage=bb,inline-8bit-counters
Modified:
cfe/trunk/lib/Driver/SanitizerArgs.cpp
cfe/trunk/test/Driver/fsanitize-coverage.c
M
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310408: Integrate Kostya's clang-proto-fuzzer with LLVM.
(authored by morehouse).
Changed prior to commit:
https://reviews.llvm.org/D36324?vs=110265&id=110269#toc
Repository:
rL LLVM
https://reviews
Author: morehouse
Date: Tue Aug 8 13:15:04 2017
New Revision: 310408
URL: http://llvm.org/viewvc/llvm-project?rev=310408&view=rev
Log:
Integrate Kostya's clang-proto-fuzzer with LLVM.
Summary:
The clang-proto-fuzzer models a subset of C++ as a protobuf and
uses libprotobuf-mutator to generate in
alekseyshl added a comment.
Driver/openmp-offload.c still fails on
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7038,
please fix.
https://reviews.llvm.org/D29654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310406: [coverage] Special-case calls to noreturn functions.
(authored by efriedma).
Changed prior to commit:
https://reviews.llvm.org/D36250?vs=110249&id=110267#toc
Repository:
rL LLVM
https://revi
Author: efriedma
Date: Tue Aug 8 13:10:14 2017
New Revision: 310406
URL: http://llvm.org/viewvc/llvm-project?rev=310406&view=rev
Log:
[coverage] Special-case calls to noreturn functions.
The code after a noreturn call doesn't execute.
The pattern in the testcase is pretty common in LLVM (a swit
morehouse updated this revision to Diff 110265.
morehouse added a comment.
- README tweaks.
https://reviews.llvm.org/D36324
Files:
clang/CMakeLists.txt
clang/cmake/modules/ProtobufMutator.cmake
clang/tools/clang-fuzzer/CMakeLists.txt
clang/tools/clang-fuzzer/ClangFuzzer.cpp
clang/tool
morehouse updated this revision to Diff 110264.
morehouse added a comment.
- Add run instructions to README.
https://reviews.llvm.org/D36324
Files:
clang/CMakeLists.txt
clang/cmake/modules/ProtobufMutator.cmake
clang/tools/clang-fuzzer/CMakeLists.txt
clang/tools/clang-fuzzer/ClangFuzzer
kcc accepted this revision.
kcc added a comment.
LGTM with a couple if nits in the README
Thanks!
Comment at: clang/tools/clang-fuzzer/README.txt:11
+class, producing valid C++ programs in the process. As a result,
+clang-proto-fuzzer is better at stressing deeper layers of C
morehouse updated this revision to Diff 110262.
morehouse added a comment.
- Add README.txt.
https://reviews.llvm.org/D36324
Files:
clang/CMakeLists.txt
clang/cmake/modules/ProtobufMutator.cmake
clang/tools/clang-fuzzer/CMakeLists.txt
clang/tools/clang-fuzzer/ClangFuzzer.cpp
clang/too
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D36208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
jmgao added a comment.
Thanks for the review!
Repository:
rL LLVM
https://reviews.llvm.org/D36237
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310402: Reland "Thread Safety Analysis: fix
assert_capability." (authored by jmgao).
Changed prior to commit:
https://reviews.llvm.org/D36237?vs=110054&id=110260#toc
Repository:
rL LLVM
https://revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310403: Thread Safety Analysis: warn on nonsensical
attributes. (authored by jmgao).
Changed prior to commit:
https://reviews.llvm.org/D36237?vs=110054&id=110259#toc
Repository:
rL LLVM
https://revi
Author: jmgao
Date: Tue Aug 8 12:44:35 2017
New Revision: 310403
URL: http://llvm.org/viewvc/llvm-project?rev=310403&view=rev
Log:
Thread Safety Analysis: warn on nonsensical attributes.
Add warnings in cases where an implicit `this` argument is expected to
attributes because either `this` doesn
Author: jmgao
Date: Tue Aug 8 12:44:34 2017
New Revision: 310402
URL: http://llvm.org/viewvc/llvm-project?rev=310402&view=rev
Log:
Reland "Thread Safety Analysis: fix assert_capability."
Delete the test that was broken by rL309725, and add it back in a
follow up commit. Also, improve the tests a
yaxunl added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:7386
+ bool isHomogeneousAggregateBaseType(QualType Ty) const override;
+ bool isHomogeneousAggregateSmallEnough(const Type *Base,
+ uint64_t Members) const override;
--
krytarowski created this revision.
krytarowski added a project: Sanitizers.
vptr is required for ubsan, which is reported to work on NetBSD.
Sponsored by
Repository:
rL LLVM
https://reviews.llvm.org/D36482
Files:
lib/Driver/ToolChains/NetBSD.cpp
Index: lib/Driver/ToolChains/NetBSD.cpp
arsenm added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:7386
+ bool isHomogeneousAggregateBaseType(QualType Ty) const override;
+ bool isHomogeneousAggregateSmallEnough(const Type *Base,
+ uint64_t Members) const override;
--
atanasyan updated this revision to Diff 110252.
atanasyan added a comment.
- Renamed `TargetMips` to `TargetMips32`
Repository:
rL LLVM
https://reviews.llvm.org/D36208
Files:
include/clang/Basic/Attr.td
test/CodeGen/long-call-attr.c
test/Sema/attr-long-call.c
Index: test/Sema/attr-lo
yaxunl added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:7386
+ bool isHomogeneousAggregateBaseType(QualType Ty) const override;
+ bool isHomogeneousAggregateSmallEnough(const Type *Base,
+ uint64_t Members) const override;
--
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D35817#835740, @t.p.northover wrote:
> > What's going on with the OpenMP test changes?
>
> Compound assignment operators like "real /= complex" become illegal unde
vsk accepted this revision.
vsk added a comment.
Thanks, lgtm.
Repository:
rL LLVM
https://reviews.llvm.org/D36250
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
I forgot to say:
Based on a patch by Vassil Vassilev, which was based on a patch by Bernd
Schmidt, which was based on a patch by Reid Kleckner.
On 8 August 2017 at 12:12, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Tue Aug 8 12:12:28 2017
> New Re
rsmith closed this revision.
rsmith added a comment.
Committed as r310401.
Repository:
rL LLVM
https://reviews.llvm.org/D35056
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
t.p.northover added a comment.
> What's going on with the OpenMP test changes?
Compound assignment operators like "real /= complex" become illegal under the
new rules (in C++) because somewhere there has to be an implicit conversion. I
was pretty relieved to discover GCC also rejects the syntax
Author: rsmith
Date: Tue Aug 8 12:12:28 2017
New Revision: 310401
URL: http://llvm.org/viewvc/llvm-project?rev=310401&view=rev
Log:
PR19668, PR23034: Fix handling of move constructors and deleted copy
constructors when deciding whether classes should be passed indirectly.
This fixes ABI differen
efriedma updated this revision to Diff 110249.
efriedma added a comment.
Update to call VisitStmt(E)
Repository:
rL LLVM
https://reviews.llvm.org/D36250
Files:
lib/CodeGen/CoverageMappingGen.cpp
test/CoverageMapping/md.cpp
test/CoverageMapping/switch.cpp
Index: test/CoverageMapping/s
hfinkel added a comment.
What's going on with the OpenMP test changes?
https://reviews.llvm.org/D35817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bader added a comment.
@rsmith do you have an opinion on what would be the right place for the kind of
proposed optimization?
It looks like it can be implemented as target independent optimization, acting
only for target with specified properties - in this case target must provide
required buil
Sorry for the slow reply; I missed this somehow.
Merged in r310395.
Thanks,
Hans
On Tue, Aug 8, 2017 at 5:20 AM, Alex L wrote:
> Ping?
>
> On 21 July 2017 at 10:44, Alex L wrote:
>>
>> Hans, can you please merge this to the LLVM 5.0 branch?
>>
>> AFAIK It's a recent regression that should get
Merged to 5.0 in r310393.
On Thu, Jul 27, 2017 at 3:43 AM, Peter Smith via cfe-commits
wrote:
> Author: psmith
> Date: Thu Jul 27 03:43:53 2017
> New Revision: 309263
>
> URL: http://llvm.org/viewvc/llvm-project?rev=309263&view=rev
> Log:
> [CodeGen][ARM] ARM runtime helper functions are not alwa
t.p.northover added a comment.
Pingy.
https://reviews.llvm.org/D35817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl added a comment.
In https://reviews.llvm.org/D36327#835634, @Anastasia wrote:
> In https://reviews.llvm.org/D36327#835153, @b-sumner wrote:
>
> > In https://reviews.llvm.org/D36327#834032, @Anastasia wrote:
> >
> > > In https://reviews.llvm.org/D36327#833891, @yaxunl wrote:
> > >
> > > > I
kcc added a comment.
Looks good!
Now, please add a clang/tools/clang-fuzzer/README.txt describing how to build
the fuzzers (both the old one and the new one) and how to run them.
For the new one explain how to install the deps
https://reviews.llvm.org/D36324
_
Merged to 5.0 in r310390 as suggested in the review.
Thanks,
Hans
On Tue, Aug 8, 2017 at 7:13 AM, Nikolai Bozhenov via cfe-commits
wrote:
> Author: n.bozhenov
> Date: Tue Aug 8 07:13:50 2017
> New Revision: 310359
>
> URL: http://llvm.org/viewvc/llvm-project?rev=310359&view=rev
> Log:
> [libcla
hans added a comment.
In https://reviews.llvm.org/D36453#834949, @n.bozhenov wrote:
> If the patch is accepted, it should also be merged into 5.0, I believe.
Sounds like a good idea.
r310390
https://reviews.llvm.org/D36453
___
cfe-commits mailing
rnk added inline comments.
Comment at: test/CodeGenCXX/uncopyable-args.cpp:101
+
+// In MSVC 2013, the copy ctor is not deleted by a move assignment. In MSVC
2015, it is.
+// WIN64-18-LABEL: declare void @"\01?foo@implicitly_deleted@@YAXUA@1@@Z"(i64
rsmith wrote
twoh updated this revision to Diff 110237.
twoh added a comment.
Addressing dblaikie's comments. Thanks!
https://reviews.llvm.org/D36474
Files:
lib/CodeGen/CGDebugInfo.cpp
test/CodeGen/debug-info-preprocessed-file.i
Index: test/CodeGen/debug-info-preprocessed-file.i
==
rsmith added inline comments.
Comment at: include/clang/AST/DeclCXX.h:420
+/// \brief True if this class has at least one non-deleted copy or move
+/// constructor. That would allow passing it by registers.
rnk wrote:
> Isn't this "... at least one *tri
aaron.ballman closed this revision.
aaron.ballman added a comment.
I've commit in r310388
https://reviews.llvm.org/D36411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Tue Aug 8 11:07:17 2017
New Revision: 310388
URL: http://llvm.org/viewvc/llvm-project?rev=310388&view=rev
Log:
Restore previous structure ABI behavior for bit-fields with the packed
attribute for PS4 targets.
An ABI change was introduced in r254596 that modified struc
Author: abataev
Date: Tue Aug 8 11:04:06 2017
New Revision: 310387
URL: http://llvm.org/viewvc/llvm-project?rev=310387&view=rev
Log:
[OPENMP][DEBUG] Set proper address space info if required by target.
Arguments, passed to the outlined function, must have correct address
space info for proper De
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from a minor naming nit, LGTM!
Comment at: lib/Sema/SemaStmt.cpp:605-608
+static QualType GetTypeBeforeIntegralPromotion(const Expr *&expr) {
+ if (const
Anastasia added a comment.
In https://reviews.llvm.org/D36327#835153, @b-sumner wrote:
> In https://reviews.llvm.org/D36327#834032, @Anastasia wrote:
>
> > In https://reviews.llvm.org/D36327#833891, @yaxunl wrote:
> >
> > > In https://reviews.llvm.org/D36327#833653, @bader wrote:
> > >
> > > > Hi
dexonsmith added a comment.
In https://reviews.llvm.org/D34331#831686, @arphaman wrote:
> Don't you need `// UNSUPPORTED: c++98, c++03` since `std::function` is
> supported in C++11 only?
The tests in libcxx/test/std/utilities/function.objects/ don't have UNSUPPORTED
lines, and I don't see a
Author: ctopper
Date: Tue Aug 8 10:43:44 2017
New Revision: 310386
URL: http://llvm.org/viewvc/llvm-project?rev=310386&view=rev
Log:
[X86] Support 'avx5124vnniw' and 'avx5124fmaps' for __builtin_cpu_supports.
They still need to be implemented in the intrinsics, the command line, and the
backend
dblaikie added a comment.
Looks plausible (not sure how nice it is to use the llvm::Module itself to
communicate the file name to this bit of logic - I'll leave that to Richard
Smith to judge, I think)
Comment at: test/CodeGen/debug-info-preprocessed-file.i:10
+// RUN: %clang
twoh updated this revision to Diff 110230.
twoh added a comment.
Relocate.
https://reviews.llvm.org/D36474
Files:
lib/CodeGen/CGDebugInfo.cpp
test/CodeGen/debug-info-preprocessed-file.i
Index: test/CodeGen/debug-info-preprocessed-file.i
gtbercea added a comment.
In https://reviews.llvm.org/D29654#835548, @hfinkel wrote:
> In https://reviews.llvm.org/D29654#835392, @gtbercea wrote:
>
> > In https://reviews.llvm.org/D29654#835371, @arphaman wrote:
> >
> > > The last RUN line in the new commit triggers the same assertion failure:
>
haowei created this revision.
Herald added a subscriber: xazax.hun.
This patch adds "mx_create_sink" annotation support to MagentaHandleChecker to
address the false positives found in Magenta unit tests. After this patch, when
a call to a function contains this annotation, MagentaHandleChecker w
twoh created this revision.
Herald added a subscriber: aprantl.
Even in the case of the input file is a preprocessed source, clang uses the
file name of the preprocesses source for debug info (DW_AT_name attribute for
DW_TAG_compile_unit). However, gcc uses the file name specified in the first
hfinkel added a comment.
In https://reviews.llvm.org/D29654#835392, @gtbercea wrote:
> In https://reviews.llvm.org/D29654#835371, @arphaman wrote:
>
> > The last RUN line in the new commit triggers the same assertion failure:
>
...
> Hi Alex, I'm not sure why it's failing as I can't reproduce
ormris added a comment.
Great. Thanks for the review! I don't have commit access currently.
https://reviews.llvm.org/D36411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added a comment.
No, entry 1 has a different pointer (0x000111c01320 vs 0x000111c017d0).
Why is there a `DependentBoundArch` if it's always empty?
https://reviews.llvm.org/D29654
___
cfe-commits mailing list
cfe-commits@lists.llvm.
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D35056#834705, @rnk wrote:
> In https://reviews.llvm.org/D35056#834689, @rsmith wrote:
>
> > I also removed some incorrect assumptions from the Win64 ABI code; this
> > c
rnk accepted this revision.
rnk added a comment.
Thanks, most of these looks like potential races between tests waiting to
happen.
Repository:
rL LLVM
https://reviews.llvm.org/D36437
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310382: [Availability] Don't make an availability attribute
imply default visibility on… (authored by epilk).
Changed prior to commit:
https://reviews.llvm.org/D36191?vs=109218&id=110223#toc
Repository
1 - 100 of 193 matches
Mail list logo
