efriedma added inline comments.

================
Comment at: lib/CodeGen/CodeGenModule.cpp:2434
+    // Emit section information for extern variables.
+    if (D->hasExternalStorage() && !D->isThisDeclarationADefinition()) {
+      if (const SectionAttr *SA = D->getAttr<SectionAttr>())
----------------
Why do you specifically check "D->hasExternalStorage() && 
!D->isThisDeclarationADefinition()", instead of just setting the section 
unconditionally?


https://reviews.llvm.org/D36487



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to