MontyKutyi updated this revision to Diff 108013.
MontyKutyi added a comment.
Updated the comment.
https://reviews.llvm.org/D34030
Files:
include/clang/AST/RecursiveASTVisitor.h
Index: include/clang/AST/RecursiveASTVisitor.h
===
xazax.hun added a reviewer: aaron.ballman.
xazax.hun added a comment.
Aaron, could you comment on the applicability of this check to C? Thanks in
advance.
https://reviews.llvm.org/D33672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308954: [clang-tidy] Handle incomplete types in
bugprone-undefined-memory-manipulation (authored by xazax).
Changed prior to commit:
https://reviews.llvm.org/D35790?vs=107863&id=108012#toc
Repository:
Author: xazax
Date: Mon Jul 24 23:52:08 2017
New Revision: 308954
URL: http://llvm.org/viewvc/llvm-project?rev=308954&view=rev
Log:
[clang-tidy] Handle incomplete types in bugprone-undefined-memory-manipulation
check
Patch by: Reka Nikolett Kovacs
Differential Revision: https://reviews.llvm.org/
djasper added a comment.
Yes, your example would work, too. The specific use case I have is where we are
shadowing global variables.
https://reviews.llvm.org/D35783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
kimgr added a comment.
Any chance you could try my example too? It seems like this approach might
catch it.
But does the new approach really do anything different for your original
example?
https://reviews.llvm.org/D35783
___
cfe-commits mailing
rsmith added a comment.
I would prefer to handle `std::byte` explicitly in the places where it matters,
rather than adding an attribute to it and otherwise treating it like any other
enumeration. We're going to want to be able to identify `std::byte` for warning
emission and probably other code
Author: faisalv
Date: Mon Jul 24 20:15:36 2017
New Revision: 308948
URL: http://llvm.org/viewvc/llvm-project?rev=308948&view=rev
Log:
[NFC] Use RAII to un-poison and then re-poison __VA_ARGS__
- This will also be used for the forthcoming __VA_OPT__ feature approved for
C++2a.
- recommended by
On Mon, 2017-07-24 at 09:32 +0200, Ulrich Weigand wrote:
> > Andrew Jeffery wrote on 24.07.2017 03:54:05:
>
> > > > > + bool shouldPassIndirectlyForSwift(CharUnits totalSize,
> > > > > +ArrayRef scalars,
> > > > > +bool asRe
rsmith added a comment.
I think we need more consideration of what the end result of `__VA_OPT__`
should be, and particularly how it should affect the `SourceLocation` data. It
seems there are two models:
1. Model `__VA_OPT__` following the specification in the standard: form an
imaginary macr
majnemer created this revision.
std::byte, when defined as an enum, needs to be given special treatment
with regards to its aliasing properties. An array of std::byte is
allowed to be used as storage for other types.
This fixes PR33916.
https://reviews.llvm.org/D35824
Files:
lib/Sema/SemaDec
Author: adrian
Date: Mon Jul 24 16:48:51 2017
New Revision: 308938
URL: http://llvm.org/viewvc/llvm-project?rev=308938&view=rev
Log:
Debug Info: Avoid completing class types when a definition is in a module.
This patch adds an early exit to CGDebugInfo::completeClassData() when
compiling with -gm
thomasanderson added a comment.
Hm.. is there anyone else who might be able to review?
https://reviews.llvm.org/D35388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak updated this revision to Diff 107993.
ahatanak marked an inline comment as done.
ahatanak added a comment.
Herald added a subscriber: javed.absar.
Address review comments.
https://reviews.llvm.org/D32210
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/c
ahatanak marked an inline comment as done.
ahatanak added a comment.
In https://reviews.llvm.org/D32210#810508, @rjmccall wrote:
> In https://reviews.llvm.org/D32210#810292, @ahatanak wrote:
>
> > Address review comments.
> >
> > - Allow attaching "noescape" to pointers other than block pointers.
mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
LGTM. Perhaps there should be a test.
Repository:
rL LLVM
https://reviews.llvm.org/D35820
___
cfe-commits mailing list
cfe-commits@lists.
phosek created this revision.
Herald added a subscriber: dberris.
This makes it possible to print the name of compiler-rt libraries
by using simply clang -print-file-name=libclang_rt.${runtime}-${arch}.so
same as other libraries, without having to know the details of the
resource directory organiz
szepet updated this revision to Diff 107976.
szepet added a subscriber: cfe-commits.
szepet added a comment.
Accidentally left typo removed.
OK so I am not sure but am I allowed to commit it again? I mean I made some
notable changes. Not on the functionality of the feature but the stored data.
So
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308932: Remove addtional parameters in function std::next()
and std::prev() (authored by rcraik).
Changed prior to commit:
https://reviews.llvm.org/D34649?vs=104030&id=107977#toc
Repository:
rL LLVM
Author: rcraik
Date: Mon Jul 24 15:17:05 2017
New Revision: 308932
URL: http://llvm.org/viewvc/llvm-project?rev=308932&view=rev
Log:
Remove addtional parameters in function std::next() and std::prev()
Creating a function pointer with proper parameters pointing to std::next() or
std::prev() shoul
t.p.northover updated this revision to Diff 107970.
t.p.northover added a comment.
Sorry, uploaded version with slightly wrong tests.
https://reviews.llvm.org/D35817
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/lib/Sema/SemaChecking.cpp
clang/lib/Sema/SemaExpr.cpp
clang
t.p.northover created this revision.
Herald added a subscriber: mcrosier.
As part of preparing Clang for a C++14 default we noticed that code like this
was accepted and did horrible things in C++11 or earlier modes (i.e. where
1.0if is a `_Complex float` rather than a UDL):
std::complex var =
rsmith added inline comments.
Comment at: lib/AST/DeclCXX.cpp:1476
+
+ data().HasNonDeletedCopyOrMoveConstructor = !CopyOrMoveDeleted;
}
This is wrong. "Has a non-deleted copy or move constructor" is not the same
thing as "does not have a deleted copy or move
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D35426
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
marsupial added a comment.
Ping.
https://reviews.llvm.org/D35103
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rnk
Date: Mon Jul 24 13:48:15 2017
New Revision: 308926
URL: http://llvm.org/viewvc/llvm-project?rev=308926&view=rev
Log:
Revert "[X86][InlineAsm][Ms Compatibility]Prefer variable name over a register
when the two collides"
This reverts r308867 and r308866.
It broke the sanitizer-window
aoli updated this revision to Diff 107954.
aoli added a comment.
Remove test code. Sorry for the noise.
https://reviews.llvm.org/D33561
Files:
cmake/caches/Android-stage2.cmake
cmake/caches/Android.cmake
Index: cmake/caches/Android.cmake
aoli updated this revision to Diff 107953.
aoli added a comment.
Remove test code.
https://reviews.llvm.org/D33561
Files:
cmake/caches/Android-stage2.cmake
cmake/caches/Android.cmake
Index: cmake/caches/Android.cmake
===
--- /
aoli updated this revision to Diff 107951.
aoli added a comment.
Add `STAGE2_` prefix to pass stage2 variables. Add
`ANDROID_RUNTIMES_BUILD_TYPE`, `ANDROID_RUNTIMES_ENABLE_ASSERTIONS`, and
`ANDROID_BUILTINS_BUILD_TYPE`.
https://reviews.llvm.org/D33561
Files:
cmake/caches/Android-stage2.cmak
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Looks good! Thanks!
Please rebase with master before committing since we've been touching the same
lines in `UnwrappedLineParser.cpp`.
https://reviews.llvm.org/D35483
_
mgrang added a comment.
Ping 2 for reviews please!
https://reviews.llvm.org/D35426
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: krasimir
Date: Mon Jul 24 12:52:49 2017
New Revision: 308918
URL: http://llvm.org/viewvc/llvm-project?rev=308918&view=rev
Log:
[clang-format] Reorder assignments, NFC
Modified:
cfe/trunk/lib/Format/UnwrappedLineParser.cpp
Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp
URL:
h
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Serialization/ASTWriterStmt.cpp:320-321
+
+static void serializeSuspendExpr(ASTStmtWriter &Writer, ASTRecordWriter
&Record,
+
mehdi_amini added a comment.
Weekly ping! (@rsmith)
https://reviews.llvm.org/D34992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ accepted this revision.
NoQ added a comment.
These comments of mine are mostly random ideas for follow-up patches, i agree
with Gabor this patch is good to land.
https://reviews.llvm.org/D33672
___
cfe-commits mailing list
cfe-commits@lists.llv
thakis added a comment.
In https://reviews.llvm.org/D33900#819234, @dim wrote:
> In https://reviews.llvm.org/D33900#818957, @thakis wrote:
>
> > Sorry, I just noticed this weeks later. Why are we adding this to
> > `--version` instead of adding some new flag for printing this? When I pass
> > `
bruno added a comment.
Hi Peter,
Please add a testcase for this change, it also seems that you should update the
comment.
https://reviews.llvm.org/D34030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Hi Ilya,
Your change seems to be causing the test 'clangd/definitions.test' to fail on
the PS4 Windows bot. Can you take a look?
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/11222
FAIL: Clang Tools :: clangd/definitions.test (11935 of 34225)
dim added a comment.
Also note that it is only added to the `--version` output, not the `-v` output
(the former is really a "verbose" version of the latter):
$ clang -v
clang version 5.0.0 (trunk 308421)
Target: x86_64-unknown-freebsd12.0
Thread model: posix
InstalledDir: /share/dim/ll
dim added a comment.
In https://reviews.llvm.org/D33900#818957, @thakis wrote:
> Sorry, I just noticed this weeks later. Why are we adding this to `--version`
> instead of adding some new flag for printing this? When I pass `--version`,
> I'm usually interested in clang's version and don't need
bruno added a comment.
Hi Strahinja,
Does GCC already has a similar option? If so, does this share the same name?
https://reviews.llvm.org/D34878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
AntonBikineev added a comment.
ping..
https://reviews.llvm.org/D35661
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ added a comment.
Did the checker flag any intentionally underpopulated enums, eg.
enum {
Unset = -1
} NumberOfChickens = 15;
(such code is bad, but it is not necessarily buggy - as far as i understand
from the CERT rule, we're talking about "unspecified behavior" which some
impleme
NoQ added a comment.
Yeah, this looks good. How does this compare to `alpha.core.BoolConversion`,
should we maybe merge them?
Comment at: lib/StaticAnalyzer/Checkers/EnumCastOutOfRangeChecker.cpp:84
+void EnumCastOutOfRangeChecker::reportWarning(CheckerContext &C) const {
+ i
GorNishanov added a comment.
@rsmith, ping. Would be good to get this in for clang 5.0
https://reviews.llvm.org/D35383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gamesh411 updated this revision to Diff 107923.
https://reviews.llvm.org/D27918
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/OStreamFormatChecker.cpp
test/Analysis/Inputs/system-header-simulator-cxx-iostrea
Author: smeenai
Date: Mon Jul 24 10:16:27 2017
New Revision: 308899
URL: http://llvm.org/viewvc/llvm-project?rev=308899&view=rev
Log:
[CodeGen] Propagate dllexport to thunks
Under Windows Itanium, we need to export virtual and non-virtual thunks
if the functions being thunked are exported. These
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308899: [CodeGen] Propagate dllexport to thunks (authored by
smeenai).
Repository:
rL LLVM
https://reviews.llvm.org/D34972
Files:
cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp
cfe/trunk/test/CodeGenCXX/
gamesh411 updated this revision to Diff 107921.
https://reviews.llvm.org/D27918
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/OStreamFormatChecker.cpp
test/Analysis/Inputs/system-header-simulator-cxx-iostrea
Author: tnorthover
Date: Mon Jul 24 10:06:23 2017
New Revision: 308898
URL: http://llvm.org/viewvc/llvm-project?rev=308898&view=rev
Log:
AArch64 & ARM: move TargetInfo functions from .h to .cpp file. NFC.
Most of them are virtual anyway, and the few remaining ones can move to the
.cpp for consist
@jyknight I've removed the check on nostdinc. AFAIK, I've addressed all the
feedback which I've received on the patch, is it OK to commit? --Melanie
-Original Message-
From: James Y Knight via Phabricator [mailto:revi...@reviews.llvm.org]
Sent: Monday, July 10, 2017 11:57 AM
To: Blower
gamesh411 added a comment.
Hello,
After experimentation the following AST difference between the mock and the
standard library implementation still stands (which necessitates the special
handling of the complex manipulators). Example:
// The different behaviour of the AST is illustrated on t
We probably want this in 5.0.
On Mon, Jul 24, 2017 at 12:54 PM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: nico
> Date: Mon Jul 24 09:54:11 2017
> New Revision: 308897
>
> URL: http://llvm.org/viewvc/llvm-project?rev=308897&view=rev
> Log:
> Work around an MSVC2017
thakis closed this revision.
thakis added a comment.
r308897.
https://reviews.llvm.org/D35757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Mon Jul 24 09:54:11 2017
New Revision: 308897
URL: http://llvm.org/viewvc/llvm-project?rev=308897&view=rev
Log:
Work around an MSVC2017 update 3 codegen bug.
C2017 update 3 produces a clang that crashes when compiling clang. Disabling
optimizations for StmtProfiler::VisitCXXOpe
yawanng added a comment.
Ping
https://reviews.llvm.org/D35372
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D35757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erik.pilkington accepted this revision.
erik.pilkington added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for working on this!
Comment at: lib/Sema/SemaDeclAttr.cpp:7230
+return;
+ for (const auto &M : S.getPreprocessor().macros()) {
+
alexfh added a comment.
In https://reviews.llvm.org/D35787#819007, @alexfh wrote:
> Should we look at whether the size is statically known?
(and small enough)
https://reviews.llvm.org/D35787
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
alexfh added a comment.
Should we look at whether the size is statically known?
https://reviews.llvm.org/D35787
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
A few more nits.
Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.h:68
bool IgnoreArrays;
+ // Whether fix-its for initializers of fundamental ty
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D34972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
mehdi_amini added a comment.
Here is the current output:
clang version 5.0.0
Target: x86_64-apple-darwin16.6.0
Thread model: posix
InstalledDir: /Users/mamini/projects/llvm/./clangDebug/bin
Registered Targets:
aarch64- AArch64 (little endian)
aarch64_be - AArch64 (
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thank you for the fix!
https://reviews.llvm.org/D35790
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
thakis added a comment.
Sorry, I just noticed this weeks later. Why are we adding this to `--version`
instead of adding some new flag for printing this? When I pass `--version`, I'm
usually interested in clang's version and don't need a screenful of other
information below it (which makes the o
mcrosier added a comment.
In https://reviews.llvm.org/D35577#818936, @kparzysz wrote:
> In https://reviews.llvm.org/D35577#817944, @echristo wrote:
>
> > "Should this just be part of the tuning for the hexagon backend and not
> > options at all"
>
>
>
>
> I don't think we need separate options
sgundapa added a comment.
If it is okay for the reviewers, I have no problem using -fno-jump-tables to
this effect.
I need to update https://reviews.llvm.org/D35578 and
https://reviews.llvm.org/D35579
https://reviews.llvm.org/D35577
___
cfe-commit
I am thinking about reducing the patch further to leave only the ability to
include config file when clang is called as `target-clang-drivermode`. It
is still useful for cross compilation tasks because:
- It is a convenient way to switch between supported targets,
- SDK producer can ship compiler w
kparzysz added a comment.
In https://reviews.llvm.org/D35577#817944, @echristo wrote:
> "Should this just be part of the tuning for the hexagon backend and not
> options at all"
The ultimate decision as to what kind of code to generate out of a switch
statement belongs to the customer. The r
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308882: [clang-format] Fix comment levels between '} else {'
and PPDirective. (authored by krasimir).
Repository:
rL LLVM
https://reviews.llvm.org/D35794
Files:
cfe/trunk/lib/Format/TokenAnnotator.c
Author: abataev
Date: Mon Jul 24 07:52:13 2017
New Revision: 308883
URL: http://llvm.org/viewvc/llvm-project?rev=308883&view=rev
Log:
[OPENMP] Fix the restrictions for in_reduction clause.
This patch allows to use in_reduction clause even if the innermost
directive is not taskgroup.
Modified:
Author: krasimir
Date: Mon Jul 24 07:51:59 2017
New Revision: 308882
URL: http://llvm.org/viewvc/llvm-project?rev=308882&view=rev
Log:
[clang-format] Fix comment levels between '} else {' and PPDirective.
Summary:
This fixes a regression exposed by r307795 and rL308725 in which the level of a
com
krasimir updated this revision to Diff 107904.
krasimir added a comment.
- Address review comments
https://reviews.llvm.org/D35794
Files:
lib/Format/TokenAnnotator.cpp
lib/Format/UnwrappedLineParser.cpp
lib/Format/UnwrappedLineParser.h
unittests/Format/FormatTestComments.cpp
Index: uni
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
Comment at: lib/Format/UnwrappedLineParser.h:126
bool eof() const;
- void nextToken();
+ // LevelDifference is the difference of levels after and before this token.
+
arphaman marked 3 inline comments as done.
arphaman added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:7230
+return;
+ for (const auto &M : S.getPreprocessor().macros()) {
+if (M.first->getName() != "API_AVAILABLE")
erik.pilkington
MontyKutyi added a comment.
Ping.
https://reviews.llvm.org/D34030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman updated this revision to Diff 107903.
arphaman marked 2 inline comments as done.
arphaman added a comment.
Addressed Erik's comments
Repository:
rL LLVM
https://reviews.llvm.org/D35726
Files:
lib/Sema/SemaDeclAttr.cpp
test/FixIt/fixit-availability.c
test/FixIt/fixit-availabili
krasimir updated this revision to Diff 107901.
krasimir added a comment.
- Remove unused import
https://reviews.llvm.org/D35794
Files:
lib/Format/TokenAnnotator.cpp
lib/Format/UnwrappedLineParser.cpp
lib/Format/UnwrappedLineParser.h
unittests/Format/FormatTestComments.cpp
Index: unitte
krasimir updated this revision to Diff 107900.
krasimir added a comment.
- Switch to relative levels
https://reviews.llvm.org/D35794
Files:
lib/Format/TokenAnnotator.cpp
lib/Format/UnwrappedLineParser.cpp
lib/Format/UnwrappedLineParser.h
unittests/Format/FormatTestComments.cpp
Index: u
sgundapa added a comment.
> "Should this just be part of the tuning for the hexagon backend and not
> options at all"
This will be useful to all the backends/archs that support a tightly coupled
memory.
AFAIK, hexagon is not the only target that has a TCM.
https://reviews.llvm.org/D35577
_
Author: marshall
Date: Mon Jul 24 07:05:10 2017
New Revision: 308880
URL: http://llvm.org/viewvc/llvm-project?rev=308880&view=rev
Log:
make sure that we don't call basic_streambuf::gbump with a value bigger than
INT_MAX, since it only takes an int. Related to, but not quite the same as
PR33725
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308879: [mips] Add support for -m(no-)extern-data. (authored
by sdardis).
Changed prior to commit:
https://reviews.llvm.org/D35550?vs=107073&id=107897#toc
Repository:
rL LLVM
https://reviews.llvm.or
Author: sdardis
Date: Mon Jul 24 07:02:09 2017
New Revision: 308879
URL: http://llvm.org/viewvc/llvm-project?rev=308879&view=rev
Log:
[mips] Add support for -m(no-)extern-data.
Add support for -m(no-)extern-data when using -mgpopt in the driver. It is
enabled by default in the backend.
Reviewers
krasimir updated this revision to Diff 107896.
krasimir added a comment.
- Make the closing brace use the same thing
https://reviews.llvm.org/D35794
Files:
lib/Format/TokenAnnotator.cpp
lib/Format/UnwrappedLineParser.cpp
lib/Format/UnwrappedLineParser.h
unittests/Format/FormatTestCommen
arphaman added a comment.
You might also want to mention the fact that `-fsanitizer=vptr` requires `null`
in the release notes.
https://reviews.llvm.org/D35735
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D35736
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
m.ostapenko updated this revision to Diff 107894.
m.ostapenko added a comment.
Rebased and removed a bunch of stale changes. Also added a check for goto's: if
we see GotoStmt and have cfg-scopes == true, make badCFG = true and retry
without scopes enabled. This check will be removed once GotoStm
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: test/CodeGenCXX/ubsan-devirtualized-calls.cpp:67
static_cast(badp)->f1(); //< No devirt, test 'badp isa Base1'.
+ // We were able to skip the null c
rnkovacs created this revision.
Herald added subscribers: baloghadamsoftware, xazax.hun, whisperity, mgorny.
This check warns if a derived type object is deleted through a base pointer
with a non-virtual destructor in its base class. It also places a note at the
last point where the derived-to-b
Typz added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:464
+ for (const auto &i : PPStack) {
+hash_combine(h, i.Kind);
+hash_combine(h, i.Line);
krasimir wrote:
> When I patch this, I get an `UnwrappedLineParser.cpp:457:16 error: impl
xazax.hun accepted this revision.
xazax.hun added reviewers: dcoughlin, NoQ, a.sidorin.
xazax.hun added a comment.
This revision is now accepted and ready to land.
Looks good to me. Did you run it on a codebase to check the results?
https://reviews.llvm.org/D33672
gamesh411 marked 2 inline comments as done.
gamesh411 added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/EnumCastOutOfRangeChecker.cpp:104
+ // Check whether the cast type is an enum.
+ const auto ED = dyn_cast_or_null(T->getAsTagDecl());
+ // If it is not an enum,
Author: coby
Date: Mon Jul 24 00:06:37 2017
New Revision: 308867
URL: http://llvm.org/viewvc/llvm-project?rev=308867&view=rev
Log:
[X86][InlineAsm][Ms Compatibility]Prefer variable name over a register when the
two collides
On MS-style, the following snippet:
int eax;
__asm mov eax, ebx
should
spetrovic added a comment.
ping
https://reviews.llvm.org/D34878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gamesh411 updated this revision to Diff 107886.
gamesh411 added a comment.
Fixed the naming convention issues. Also applied the suggested modifications
inside the overridden checker method.
https://reviews.llvm.org/D33672
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticA
djasper added a comment.
Like this?
https://reviews.llvm.org/D35783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper updated this revision to Diff 107885.
djasper added a comment.
Updated to be a bit more strict (warn if declarations from the same context get
shadowed).
https://reviews.llvm.org/D35783
Files:
lib/Sema/SemaDecl.cpp
test/SemaCXX/warn-shadow.cpp
Index: test/SemaCXX/warn-shadow.cpp
=
klimek added a comment.
Could we perhaps only suppress the warning when we shadow a variable within the
same declcontext? Generally, with macros, shadowing local variables is more
surprising.
https://reviews.llvm.org/D35783
___
cfe-commits mailing
krasimir created this revision.
Herald added a subscriber: klimek.
This fixes a regression exposed by r307795 and
https://reviews.llvm.org/rL308725 in which the level of a
comment line between '} else {' and a preprocessor directive is incorrectly set
as the level of the '} else {' line. For exam
arphaman added a comment.
Some comments:
- I had to make a couple of post-commit fixes to appease the buildbots when I
committed your first patch, so it looks like this one doesn't apply cleanly
anymore. Can you please rebase it?
- Let's separate the addition of HTML output and the improvements
1 - 100 of 111 matches
Mail list logo
