Lg
On Tue, Jul 11, 2017, 8:07 PM Sterling Augustine via Phabricator <
revi...@reviews.llvm.org> wrote:
> saugustine added a comment.
>
> Manuel, What do you think?
>
>
> https://reviews.llvm.org/D35131
>
>
>
>
___
cfe-commits mailing list
cfe-commits@li
ogoffart added a comment.
Ping
https://reviews.llvm.org/D35190
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
That was what the diff was doing originally (see
https://reviews.llvm.org/D35174?id=105752), but Eric suggested switching to
static consts (presumably to work regardless of enum class availability).
From: cfe-commits on behalf of David
Majnemer via cfe-commits
Reply-To: David Majnemer
Date:
FWIW, I think you could just give the enum an explicit underlying type of
size_type.
On Tue, Jul 11, 2017 at 6:45 PM, Ben Craig via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: bcraig
> Date: Tue Jul 11 18:45:13 2017
> New Revision: 307751
>
> URL: http://llvm.org/viewvc/llvm-projec
djasper added a comment.
Generally upload diffs with full context to phabricator. That makes reviewing
much easier.
Comment at: test/Format/verbose.cpp:2
+// RUN: clang-format %s -verbose | FileCheck %s
+// CHECK: Formatting
+
This seems like a pretty minimal
djasper added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:2267
+ return true;
+if (Right.is(tok::l_paren) && Left.is(tok::kw_co_await) &&
+Left.Previous && Left.Previous->is(tok::kw_operator))
EricWF wrote:
> djasper wrote:
> > I k
hintonda added a comment.
It's just an effort to make the code a bit more accessible, especially for new
users (or ones not used to running find/grep).
Steve had suggested adding an option that took the entire message and matched
it when it was produced. However, that won't work very well sinc
rjmccall added a comment.
This is a cute hack, but... I'm not sure I accept the premise that it's a
noteworthy obstacle to Clang development to do two greps instead of one. And I
don't think I've ever had to debug a diagnostic where __FILE__ and __LINE__
information would've been helpful.
Als
EricWF marked an inline comment as done.
EricWF added a comment.
@alexfh Thanks for correcting the reviewers. I had no idea who to add so I used
something like `git-suggest-reviewers`.
Comment at: lib/Format/Format.cpp:1958
LangOpts.DeclSpecKeyword = 1; // To get __declspec
EricWF updated this revision to Diff 106135.
EricWF marked an inline comment as done.
EricWF added a comment.
- Address most review comments except those about `spaceBreakBetween` and
`spaceBreakBefore`.
https://reviews.llvm.org/D34225
Files:
lib/Format/Format.cpp
lib/Format/TokenAnnotator
Author: bcraig
Date: Tue Jul 11 18:45:13 2017
New Revision: 307751
URL: http://llvm.org/viewvc/llvm-project?rev=307751&view=rev
Log:
Fix unrepresentable enum for clang-cl unstable ABI
When using LIBCXX_ABI_UNSTABLE=YES, clang-cl gave the following warning:
P:\llvm_master\src\llvm\projects\libcxx
Author: ericwf
Date: Tue Jul 11 18:38:35 2017
New Revision: 307749
URL: http://llvm.org/viewvc/llvm-project?rev=307749&view=rev
Log:
Remove <__refstring> header; Move it into source directory.
The libc++ <__refstring> headers has no real reason why it should
be a public header that libc++ ships.
Author: ericwf
Date: Tue Jul 11 18:34:21 2017
New Revision: 307748
URL: http://llvm.org/viewvc/llvm-project?rev=307748&view=rev
Log:
Remove dependancy on __refstring header; use local copy instead.
This patch removes the dependancy on libc++'s __refstring header,
which was only a header in the fi
Author: ericwf
Date: Tue Jul 11 18:16:33 2017
New Revision: 307746
URL: http://llvm.org/viewvc/llvm-project?rev=307746&view=rev
Log:
Revert "[libc++] Refactoring __sync_* builtins; NFC (Reland)"
This reverts commit r307595. The commit had some issues that needed
to first be addressed in review.
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D35174
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Author: rtrieu
Date: Tue Jul 11 17:38:27 2017
New Revision: 307743
URL: http://llvm.org/viewvc/llvm-project?rev=307743&view=rev
Log:
[ODRHash] Revert r307720 to fix buildbot.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td
cfe/trunk/lib/AST/ODRHash.cpp
cfe/trun
dcoughlin added a comment.
Thanks for the patch. It is really great to see these documented!
Who is the target of this documentation? Is it developers of the analyzer or is
it end users of the analyzer? If it is end users, it is unfortunate that we've
been just grabbing examples from the regres
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chh added inline comments.
Comment at: lib/Frontend/TextDiagnostic.cpp:1109-1110
- } else {
-FixItInsertionLine.clear();
-break;
}
chh wrote:
> alexfh wrote:
> > Did you figure out why the old code used to give up here? Why does your
This revision was automatically updated to reflect the committed changes.
Closed by commit rL307723: Enhance synchscope representation (clang) (authored
by kzhuravl).
Changed prior to commit:
https://reviews.llvm.org/D33109?vs=105499&id=106106#toc
Repository:
rL LLVM
https://reviews.llvm.or
Author: kzhuravl
Date: Tue Jul 11 15:23:37 2017
New Revision: 307723
URL: http://llvm.org/viewvc/llvm-project?rev=307723&view=rev
Log:
Enhance synchscope representation (clang)
Relevant changes required for r307722.
Differential Revision: https://reviews.llvm.org/D33109
Modified:
cfe/trunk
Author: rtrieu
Date: Tue Jul 11 15:10:49 2017
New Revision: 307720
URL: http://llvm.org/viewvc/llvm-project?rev=307720&view=rev
Log:
[ODRHash] Support more method types.
Hash CXXConstructorDecl and CXXDestructorDecl. Extend the diagnostics from
CXXMethodDecl to include constructors and destructo
yunlian added a comment.
I've sent a reproduce test case to tejohnson.
https://reviews.llvm.org/D35081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: malaperle
Date: Tue Jul 11 14:26:18 2017
New Revision: 307715
URL: http://llvm.org/viewvc/llvm-project?rev=307715&view=rev
Log:
[clangd] Fix Go to Definition not working in VSCode extension
Summary:
The URI conversion logic was returning 'undefined' when going from server to
VSCode which
phosek updated this revision to Diff 106098.
Repository:
rL LLVM
https://reviews.llvm.org/D32817
Files:
cmake/caches/Fuchsia-stage2.cmake
cmake/caches/Fuchsia.cmake
Index: cmake/caches/Fuchsia.cmake
===
--- cmake/caches/Fuch
hintonda updated this revision to Diff 106094.
hintonda added a comment.
- Only maintain enum names in debug builds. Current cost of maintaining enum
names is 176k.
https://reviews.llvm.org/D35175
Files:
include/clang/Basic/DiagnosticIDs.h
include/clang/Basic/DiagnosticOptions.def
inclu
Author: rnk
Date: Tue Jul 11 13:22:17 2017
New Revision: 307701
URL: http://llvm.org/viewvc/llvm-project?rev=307701&view=rev
Log:
Fix clang-tidy diagnostic.cpp test on Windows
Modified:
clang-tools-extra/trunk/test/clang-tidy/diagnostic.cpp
Modified: clang-tools-extra/trunk/test/clang-tidy/d
ddcc updated this revision to Diff 106084.
ddcc added a comment.
Split plist-macros.cpp, and update analyzer_test.py to support tests that
require not z3
https://reviews.llvm.org/D28953
Files:
include/clang/StaticAnalyzer/Checkers/SValExplainer.h
lib/StaticAnalyzer/Core/SValBuilder.cpp
l
Author: abataev
Date: Tue Jul 11 12:43:28 2017
New Revision: 307697
URL: http://llvm.org/viewvc/llvm-project?rev=307697&view=rev
Log:
[OPENMP] Skip BuildMemberExpr() in BuildFieldReferenceExpr(), NFC, by Kai Noda
In the OpenMP mode, we don't need to call BuildMemberExpr() only to discard its
retu
tejohnson added a comment.
In https://reviews.llvm.org/D35081#805506, @yunlian wrote:
> This error happens when I try to triage a thinLTO failure on ARM.
>
> Initially I got some error like
> Instruction does not dominate all uses!
>
> %205 = bitcast i1 (%"class.blink::LayoutObject"*)** %194
george.burgess.iv abandoned this revision.
george.burgess.iv added a comment.
r306467 used `__has_extension(overloadable_unmarked)` instead.
Thanks again for the comments!
https://reviews.llvm.org/D33904
___
cfe-commits mailing list
cfe-commits@lis
Author: abataev
Date: Tue Jul 11 12:16:44 2017
New Revision: 307693
URL: http://llvm.org/viewvc/llvm-project?rev=307693&view=rev
Log:
[OPENMP] Add restriction for reduction clause in taskloop directives.
Added checks for the reduction clauses in the taskloop directives:
1. Only addressable items
jklaehn created this revision.
jklaehn added a project: clang.
In `ASTUnit::LoadFromASTFile`, the context object is set up using
default-constructed
`LangOptions` (which only later get populated). As the language options are
used in the constructor
of `PrintingPolicy`, this needs to be updated
saugustine added a comment.
Manuel, What do you think?
https://reviews.llvm.org/D35131
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yunlian added a comment.
This error happens when I try to triage a thinLTO failure on ARM.
Initially I got some error like
Instruction does not dominate all uses!
%205 = bitcast i1 (%"class.blink::LayoutObject"*)** %194 to i8*, !dbg !51180
%200 = getelementptr i8, i8* %205, i32 ptrtoint (i8
jklaehn added a comment.
I do not have commit access, it would be great if you could commit it. Thanks!
https://reviews.llvm.org/D35187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM. Do you have commit access or would you like me to commit it on your
behalf?
https://reviews.llvm.org/D35187
___
cfe-commits mailing li
I'm roughly where I was before, I think:
"In any case, it seems like it might make sense for you to upstream your
template naming change and put it under the PS4 debugger tuning option, and
put this change there too, once the motivation for it is in-tree. At that
point, while I'd be curious about
Not really. It will get confused by a setup in which you open 2 files
depending on each other with spaces in their names, for example: A A:
#include "B B", because clangd will not recognize that the local B%20B is
the same as B B.
On Tue, Jul 11, 2017 at 7:35 PM, Marc-Andre Laperle via Phabricator
jklaehn updated this revision to Diff 106066.
jklaehn added a project: clang.
https://reviews.llvm.org/D35187
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_cursor.py
include/clang-c/Index.h
test/Index/print-type-declaration.cpp
tools/c-index-test/c-index-test.
sylvestre.ledru added a comment.
is that ok @djasper ?
https://reviews.llvm.org/D34824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eandrews added a comment.
In https://reviews.llvm.org/D35259#805415, @erichkeane wrote:
> In https://reviews.llvm.org/D35259#805409, @rnk wrote:
>
> > In https://reviews.llvm.org/D35259#805284, @erichkeane wrote:
> >
> > > Oren discovered this miss to the original implementation. I'd reviewed
>
Praetonus added a comment.
I forgot to mention that I don't have commit access. If you or somebody else
could commit this it would be great.
https://reviews.llvm.org/D35180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
chh updated this revision to Diff 106064.
chh marked 2 inline comments as done.
https://reviews.llvm.org/D35225
Files:
test/clang-tidy/Inputs/performance-unnecessary-value-param/header-fixed.h
test/clang-tidy/Inputs/performance-unnecessary-value-param/header.h
test/clang-tidy/performance-un
malaperle added a comment.
In the other review: "The tool is fine with spaces encoded as %20 by the way."
If that's true, wouldn't that mean the other review is the way to go?
Repository:
rL LLVM
https://reviews.llvm.org/D35215
___
cfe-commits m
probinson updated this revision to Diff 106063.
probinson added a comment.
Refresh to current TOT, and ping. Funny what you can find in a year-old to-do
list
https://reviews.llvm.org/D14358
Files:
lib/CodeGen/CGDebugInfo.cpp
test/CodeGenCXX/debug-info-template-fwd-param.cpp
test/Mod
arphaman created this revision.
This patch changes the way ambiguous property synthesis (i.e. when synthesizing
a property that's declared in multiple protocols) is performed. Previously, we
synthesized the first property that was found. This lead to problems when the
property was synthesized i
rjmccall accepted this revision.
rjmccall added a comment.
Still looks good to me. Do you need help committing?
https://reviews.llvm.org/D35180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
erichkeane added a comment.
In https://reviews.llvm.org/D35259#805409, @rnk wrote:
> In https://reviews.llvm.org/D35259#805284, @erichkeane wrote:
>
> > Oren discovered this miss to the original implementation. I'd reviewed
> > this internally quite a bit.
> >
> > The reason for the Win32ABI te
rnk added a comment.
In https://reviews.llvm.org/D35259#805284, @erichkeane wrote:
> Oren discovered this miss to the original implementation. I'd reviewed this
> internally quite a bit.
>
> The reason for the Win32ABI test is that MSVC 'long double' is actually small
> enough for SSE register
yawanng updated this revision to Diff 106058.
yawanng marked 4 inline comments as done.
https://reviews.llvm.org/D34913
Files:
clang-tidy/android/AndroidTidyModule.cpp
clang-tidy/android/CMakeLists.txt
clang-tidy/android/CloexecOpenCheck.cpp
clang-tidy/android/CloexecSocketCheck.cpp
cla
On Mon, Jul 10, 2017 at 10:58 AM Dehao Chen wrote:
> This test was originally added in https://reviews.llvm.org/D34721 with
> clang change. It's kind of dup of the previous test
> (-check-prefix=SAMPLEPGO) in terms of testing the clang bits. But we
> want to make sure the new PM has the expected
chill updated this revision to Diff 106056.
chill added a comment.
Herald added a subscriber: eraman.
Set the compound statement flag on all compound statement scopes (previous
version used to set the flag on just enough scopes
as to be sufficient for the purpose of inserting C90 implicit functio
krasimir abandoned this revision.
krasimir added a comment.
https://reviews.llvm.org/D35215 is an even better solution to this problem!
https://reviews.llvm.org/D35238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Looks good! This is better than my https://reviews.llvm.org/D35238!
Repository:
rL LLVM
https://reviews.llvm.org/D35215
___
cfe-commits ma
chill added inline comments.
Comment at: lib/Parse/ParseStmt.cpp:843-845
+ return ParseCompoundStatement(isStmtExpr,
+Scope::DeclScope | Scope::CompoundStmtScope);
}
rsmith wrote:
> This seems to miss quite a lot of places that i
chh added inline comments.
Comment at: lib/Frontend/TextDiagnostic.cpp:1109-1110
- } else {
-FixItInsertionLine.clear();
-break;
}
alexfh wrote:
> Did you figure out why the old code used to give up here? Why does your code
> just con
Author: rnk
Date: Tue Jul 11 09:18:05 2017
New Revision: 307670
URL: http://llvm.org/viewvc/llvm-project?rev=307670&view=rev
Log:
Add missing dllimport member pointer template argument test from r307446
Added:
cfe/trunk/test/CodeGenCXX/dllimport-memptr-global.cpp
Added: cfe/trunk/test/CodeGe
boris added a comment.
Ping.
https://reviews.llvm.org/D35020
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
boris updated this revision to Diff 106041.
boris added a comment.
Rebase on latest HEAD.
https://reviews.llvm.org/D35020
Files:
docs/ClangCommandLineReference.rst
docs/Modules.rst
include/clang/Driver/Options.td
include/clang/Lex/HeaderSearch.h
include/clang/Lex/HeaderSearchOptions.h
erichkeane added a comment.
Oren discovered this miss to the original implementation. I'd reviewed this
internally quite a bit.
The reason for the Win32ABI test is that MSVC 'long double' is actually small
enough for SSE registers in this case. I DO now (looking again, sorry
Elizabeth) wonde
Author: joerg
Date: Tue Jul 11 08:50:48 2017
New Revision: 307665
URL: http://llvm.org/viewvc/llvm-project?rev=307665&view=rev
Log:
NetBSD uses soft-float by default, unless the environment is EABIHF or
GNUEABIHF.
Modified:
cfe/trunk/lib/Driver/ToolChains/Arch/ARM.cpp
cfe/trunk/test/Prepr
Author: joerg
Date: Tue Jul 11 08:49:45 2017
New Revision: 307664
URL: http://llvm.org/viewvc/llvm-project?rev=307664&view=rev
Log:
Run the preprocessor test as frontend test for NetBSD, since CC1 mode
doesn't get flags like the default target CPU. Update for test to
reflect the difference.
Modif
Author: courbet
Date: Tue Jul 11 08:45:22 2017
New Revision: 307663
URL: http://llvm.org/viewvc/llvm-project?rev=307663&view=rev
Log:
[ASTMatchers][NFC] integerLiteral(): Mention negative integers in
documentation.
Trying to match integerLiteral(-1) will silently fail, because an numeric
literal
hfinkel added a comment.
This is much closer to what I had in mind, thanks! Now I think we're in a
position to make this work for more than just the CUDA target. It looks like
the added code is now:
1. Remove -march from the translated arguments (because any existing -march
would apply only fo
eandrews created this revision.
This change is part of the RegCall calling convention support for LLVM.
Existing RegCall implementation was extended to include correct handling of
Complex Long Double type. Complex long double types should be returned/passed
in memory and not register stack. Thi
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/utils/ASTUtils.h:24
+
+/// Check whether a macro flag is present in the given argument. Only consider
+/// cases of single match or match
NoQ added a comment.
These are some great questions, i guess it'd be better to discuss them more
openly. As a quick dump of my current mood:
- To me it seems obvious that we need to aim for a checker API that is both
simple //and// powerful. This can probably by keeping the API as powerful as
Author: alexfh
Date: Tue Jul 11 08:23:05 2017
New Revision: 307661
URL: http://llvm.org/viewvc/llvm-project?rev=307661&view=rev
Log:
[clang-tidy] Extend diagnostics test.
* test that no diagnostics are redirected to stderr
* test that a file-based compilation database is not picked up when th
yaxunl updated this revision to Diff 106030.
yaxunl marked an inline comment as done.
yaxunl edited the summary of this revision.
yaxunl added a comment.
Always put indirect arg in alloca addr space.
https://reviews.llvm.org/D34367
Files:
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGDecl.cpp
test
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UnaryStaticAssertCheck.cpp:32
+
+ if (!AssertMessage || AssertMessage->getLength())
+return;
I think this should be `!AssertMessage->getLength()`
Comment at: test/clang-
yaxunl marked 3 inline comments as done.
yaxunl added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:1605
+ ? CGM.getDataLayout().getAllocaAddrSpace()
+ : getContext().getTargetAddressSpace(LangAS::Default));
break;
rjmccall
djasper added inline comments.
Comment at: lib/Format/Format.cpp:1958
LangOpts.DeclSpecKeyword = 1; // To get __declspec.
+ LangOpts.CoroutinesTS = 1;
return LangOpts;
Can we change this only if Style.isCpp()? We should probably do that for other
things,
barancsuk updated this revision to Diff 106026.
barancsuk added a comment.
- Missed some fixes last time
https://reviews.llvm.org/D35257
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UnaryStaticAssertCheck.cpp
clang-tidy/mod
barancsuk updated this revision to Diff 106025.
barancsuk marked 10 inline comments as done.
barancsuk added a comment.
- Address review comments
https://reviews.llvm.org/D35257
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/Un
krasimir added a comment.
Looks good to me too, but I actually don't know this code. Leaving to Daniel!
https://reviews.llvm.org/D34225
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
tejohnson added a comment.
In https://reviews.llvm.org/D35081#805127, @fhahn wrote:
> To reproduce the issue you could use
>
> +; Check that we only add a single summary entry for multiple definitions
> +; of a linkonce_odr function
> +
> +; RUN: opt -module-summary %s -o %t1.bc
> +; RU
alexfh added a comment.
Another thing is that at this point I'd already create a `bugprone` module (if
nobody has a better name) and place the check there (together with the other
memset-related check).
https://reviews.llvm.org/D35051
___
cfe-comm
alexfh added a comment.
As usual, please run the check at least on LLVM+Clang and include a brief
summary of results into the description of the patch.
https://reviews.llvm.org/D35051
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
fhahn added a comment.
To reproduce the issue you could use
+; Check that we only add a single summary entry for multiple definitions
+; of a linkonce_odr function
+
+; RUN: opt -module-summary %s -o %t1.bc
+; RUN: opt -module-summary %s -o %t2.bc
+; RUN: llvm-lto -thinlto-action=thin
alexfh added inline comments.
Comment at: docs/clang-tidy/checks/readability-redundant-keyword.rst:8
+
+`extern` is redundant in function declarations
+
xazax.hun wrote:
> alexfh wrote:
> > Could you explain, why you think `extern` is redundant in function
> > d
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UnaryStaticAssertCheck.cpp:28
+void UnaryStaticAssertCheck::check(const MatchFinder::MatchResult &Result) {
+
+ const auto *MatchedDecl =
Can remove the empty line.
Comment
barancsuk updated this revision to Diff 106021.
barancsuk added a comment.
- Do not rewrite macro expansions
https://reviews.llvm.org/D35257
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UnaryStaticAssertCheck.cpp
clang-tidy
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
Comment at: clang-tidy/modernize/UnaryStaticAssertCheck.cpp:28
+void UnaryStaticAssertCheck::check(const MatchFinder::MatchResult &Result) {
+
+ const auto *MatchedDecl
barancsuk created this revision.
barancsuk added a project: clang-tools-extra.
Herald added subscribers: xazax.hun, JDevlieghere, mgorny.
The check finds `static_assert` declarations with empty messages, and
replaces them with an unary `static_assert` declaration.
The check is only applicable fo
alexfh added a comment.
This looks good overall, btw. But please wait for Krasimir or Daniel, since
they actually know this code ;]
https://reviews.llvm.org/D34225
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
alexfh added a comment.
Leaving only the most likely reviewers for this code.
https://reviews.llvm.org/D34225
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D35254
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Thank you for the fix! A few comments below.
Comment at: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:291-299
const FileEntry *Entry = SM.getFi
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:1
-// RUN: %check_clang_tidy %s performance-unnecessary-value-param %t
+// RUN: cp %S/Inputs
alexfh added inline comments.
Comment at: lib/Frontend/TextDiagnostic.cpp:1109-1110
- } else {
-FixItInsertionLine.clear();
-break;
}
Did you figure out why the old code used to give up here? Why does your code
just continue?
https:
alexfh added a comment.
In https://reviews.llvm.org/D31326#803535, @mfherbst wrote:
> I do not have commit rights to the svn if that's what you're asking, but I
> could send the patch to llvm-commits if that makes it easier for you.
No need to send the patch to the list separately, Phabricator
spetrovic added a comment.
ping
https://reviews.llvm.org/D34878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdardis created this revision.
Herald added a subscriber: arichardson.
https://reviews.llvm.org/D35254
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/Arch/Mips.cpp
test/Driver/mips-features.c
Index: test/Driver/mips-features.c
arphaman added a comment.
> Currently looks like around 200k (4534 @ 33 byte avg length + ptr). If this
> is too much, we could make it conditional based on NDEBUG or some other macro
> at compile time.
I think this is mostly useful during development, so some conditional mechanism
would make
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM, thanks.
https://reviews.llvm.org/D35082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
xazax.hun added a comment.
At this point, I am a bit wondering about two questions.
- When should something belong to a checker and when should something belong to
the engine? Sometimes we model library aspects in the engine and model language
constructs in checkers.
- What is the checker progr
Author: arphaman
Date: Tue Jul 11 03:18:35 2017
New Revision: 307642
URL: http://llvm.org/viewvc/llvm-project?rev=307642&view=rev
Log:
[ObjC] Check that a subscript methods is declared for a qualified id type
Objective-C subscript expressions report errors when a subscript method is not
declared
kfunk added inline comments.
Comment at: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:296
+ << "' doesn't exist. Ignoring...\n";
+}
continue;
yawanng wrote:
> Maybe add some error message here if it's not an existenc
Author: arphaman
Date: Tue Jul 11 02:39:23 2017
New Revision: 307638
URL: http://llvm.org/viewvc/llvm-project?rev=307638&view=rev
Log:
RecursiveASTVisitor should visit the nested name qualifiers in
a template specialisation
rdar://33123354
Differential Revision: https://reviews.llvm.org/D34981
1 - 100 of 107 matches
Mail list logo
