Author: malaperle Date: Tue Jul 11 14:26:18 2017 New Revision: 307715 URL: http://llvm.org/viewvc/llvm-project?rev=307715&view=rev Log: [clangd] Fix Go to Definition not working in VSCode extension
Summary: The URI conversion logic was returning 'undefined' when going from server to VSCode which broke the Go to Definition functionality. Reviewers: krasimir Reviewed By: krasimir Subscribers: cfe-commits Tags: #clang-tools-extra Differential Revision: https://reviews.llvm.org/D35215 Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/src/extension.ts Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/src/extension.ts URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/clients/clangd-vscode/src/extension.ts?rev=307715&r1=307714&r2=307715&view=diff ============================================================================== --- clang-tools-extra/trunk/clangd/clients/clangd-vscode/src/extension.ts (original) +++ clang-tools-extra/trunk/clangd/clients/clangd-vscode/src/extension.ts Tue Jul 11 14:26:18 2017 @@ -29,7 +29,7 @@ export function activate(context: vscode // the "workaround" below disables temporarily the encoding until decoding // is implemented properly in clangd code2Protocol: (uri: vscode.Uri) : string => uri.toString(true), - protocol2Code: (uri: string) : vscode.Uri => undefined + protocol2Code: (uri: string) : vscode.Uri => vscode.Uri.parse(uri) } }; _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
