[PATCH] D34930: [Bash-autocompletion] Show flags which has HelpText or GroupID

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. For the record, one can get a (maybe incomplete) list of options that are without completion via: `curl "https://teemperor.de/pub/clang_flags.txt"; | grep -v HelpText | grep -v Group`. T

r306969 - fix trivial typos in comments; NFC

Author: inouehrs Date: Sat Jul 1 23:12:49 2017 New Revision: 306969 URL: http://llvm.org/viewvc/llvm-project?rev=306969&view=rev Log: fix trivial typos in comments; NFC Modified: cfe/trunk/lib/Parse/ParseDecl.cpp cfe/trunk/lib/Parse/ParseExpr.cpp cfe/trunk/test/Sema/warn-documentatio

[PATCH] D34930: [Bash-autocompletion] Show flags which has HelpText or GroupID

yamaguchi created this revision. Herald added a subscriber: hiraditya. Otherwise internal flags will be also completed. https://reviews.llvm.org/D34930 Files: llvm/lib/Option/OptTable.cpp Index: llvm/lib/Option/OptTable.cpp ===

[PATCH] D34926: Deprecation flag group + use for BB vectorizer options

This revision was automatically updated to reflect the committed changes. Closed by commit rL306965: Add an option group for deprecated warnings. Add the removed (authored by joerg). Changed prior to commit: https://reviews.llvm.org/D34926?vs=104998&id=105004#toc Repository: rL LLVM https:/

r306965 - Add an option group for deprecated warnings. Add the removed

Author: joerg Date: Sat Jul 1 14:36:21 2017 New Revision: 306965 URL: http://llvm.org/viewvc/llvm-project?rev=306965&view=rev Log: Add an option group for deprecated warnings. Add the removed -fslp-vectorize-aggressive and -fno-slp-vectorize-aggressive flags back under this group and test for the

[PATCH] D34510: Teach clang how to merge typedef over anonymous structs in C mode.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r306964. Repository: rL LLVM https://reviews.llvm.org/D34510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

r306964 - [modules] Teach clang how to merge typedef over anonymous structs in C mode.

Author: vvassilev Date: Sat Jul 1 13:44:49 2017 New Revision: 306964 URL: http://llvm.org/viewvc/llvm-project?rev=306964&view=rev Log: [modules] Teach clang how to merge typedef over anonymous structs in C mode. In C mode clang fails to merge the textually included definition with the one impor

[PATCH] D34926: Deprecation flag group + use for BB vectorizer options

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM Comment at: docs/ReleaseNotes.rst:69 + +- -fslp-vectorize-aggressive used to enable the BB vectorizing passes. They have been superseeded + by the normal SLP vectori

[PATCH] D34928: Add docs for -foptimization-record-file=

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D34928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D34928: Add docs for -foptimization-record-file=

modocache created this revision. The Clang option was previously not included in the User's Manual. https://reviews.llvm.org/D34928 Files: docs/UsersManual.rst Index: docs/UsersManual.rst === --- docs/UsersManual.rst +++ docs/U

[PATCH] D34927: [Bash-autocompletion] Fix a bug that -foo=bar doesn't handled properly

yamaguchi created this revision. Fixed a bug that -foo=bar wasn't handled properly on old version of bash. https://reviews.llvm.org/D34927 Files: clang/utils/bash-autocomplete.sh Index: clang/utils/bash-autocomplete.sh === ---

[PATCH] D34924: [Bash-autocompletion] Add support for older bash version.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306962: [Bash-autocompletion] Add support for older bash version. (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D34924?vs=104996&id=104999#toc Repository: rL LLVM https:

r306962 - [Bash-autocompletion] Add support for older bash version.

Author: yamaguchi Date: Sat Jul 1 11:32:55 2017 New Revision: 306962 URL: http://llvm.org/viewvc/llvm-project?rev=306962&view=rev Log: [Bash-autocompletion] Add support for older bash version. Summary: OS X seems to use older bash version which doesn't suport _init_completion and compopt, so add

[PATCH] D34924: [Bash-autocompletion] Add support for older bash version.

teemperor accepted this revision. teemperor added a comment. LGTM, everything still works in the latest bash on Linux. Also thanks for the reviews Rui! https://reviews.llvm.org/D34924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D34924: [Bash-autocompletion] Add support for older bash version.

ruiu accepted this revision. ruiu added a comment. LGTM. Confirmed that it works as expected on my Mac which doesn't have the bash-autocomplete package. Comment at: clang/utils/bash-autocomplete.sh:19 +COMPREPLY=() +cword=$COMP_CWORD +cur="${COMP_WORDS[$cword]}" --

[PATCH] D34926: Deprecation flag group + use for BB vectorizer options

joerg created this revision. Herald added a subscriber: rengolin. As discussed on IRC when https://reviews.llvm.org/D34846 came up, removing flags is problematic from a UX experience. This change introduces a new option group similar to the group GCC optimizer flags like -fexpensive-optimizatio

[PATCH] D34925: [Bash-completion] Fixed a bug that ~ doesn't expanded to $HOME

This revision was automatically updated to reflect the committed changes. Closed by commit rL306957: [Bash-completion] Fixed a bug that ~ doesn't expanded to $HOME (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D34925?vs=104991&id=104997#toc Repository: rL LLVM h

r306957 - [Bash-completion] Fixed a bug that ~ doesn't expanded to $HOME

Author: yamaguchi Date: Sat Jul 1 09:30:02 2017 New Revision: 306957 URL: http://llvm.org/viewvc/llvm-project?rev=306957&view=rev Log: [Bash-completion] Fixed a bug that ~ doesn't expanded to $HOME Summary: `~/build/bin/clang -f[tab]` was executed without ~ expanded to $HOME, so changed this by

[PATCH] D34924: [Bash-autocompletion] Add support for older bash version.

yamaguchi updated this revision to Diff 104996. yamaguchi added a comment. _get_comp_words_by_ref still depends on older bash-completion package, so delete this and set cword and cur manualy. https://reviews.llvm.org/D34924 Files: clang/utils/bash-autocomplete.sh Index: clang/utils/bash-au

[PATCH] D34924: [Bash-autocompletion] Add support for older bash version.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. It looks like this works with bash 3.2. I've tested this on mac and it works well. https://reviews.llvm.org/D34924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

[PATCH] D34925: [Bash-completion] Fixed a bug that ~ doesn't expanded to $HOME

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. That fixes my issue. LGTM. https://reviews.llvm.org/D34925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D34824: clang-format: add an option -verbose to list the files being processed

sylvestre.ledru updated this revision to Diff 104995. Herald added a subscriber: klimek. https://reviews.llvm.org/D34824 Files: docs/ClangFormat.rst docs/ReleaseNotes.rst test/Format/verbose.cpp tools/clang-format/ClangFormat.cpp Index: tools/clang-format/ClangFormat.cpp ===

[PATCH] D34924: [Bash-autocompletion] Add support for older bash version.

ruiu accepted this revision. ruiu added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D34924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D34924: [Bash-autocompletion] Add support for older bash version.

yamaguchi updated this revision to Diff 104994. yamaguchi marked an inline comment as done. yamaguchi added a comment. Update patch. https://reviews.llvm.org/D34924 Files: clang/utils/bash-autocomplete.sh Index: clang/utils/bash-autocomplete.sh ==

[PATCH] D34924: [Bash-autocompletion] Add support for older bash version.

ruiu added inline comments. Comment at: clang/utils/bash-autocomplete.sh:8-9 + # the latter doesn't. So we use compgen only when _filedir is not provided. + _filedir 2>/dev/null + [[ "$?" != 0 ]] && COMPREPLY=( $( compgen -f ) ) +} If this works, you can proba

[PATCH] D34924: [Bash-autocompletion] Add support for older bash version.

yamaguchi updated this revision to Diff 104993. yamaguchi added a comment. Update diff. https://reviews.llvm.org/D34924 Files: clang/utils/bash-autocomplete.sh Index: clang/utils/bash-autocomplete.sh === --- clang/utils/bash-au

[PATCH] D34924: [Bash-autocompletion] Add support for older bash version.

ruiu added inline comments. Comment at: clang/utils/bash-autocomplete.sh:3 + +_clang_filedir() +{ yamaguchi wrote: > ruiu wrote: > > Is the output of `compgen -f` the same as `_filedir`? If so, can you always > > use `compgen -f`? > _filedir is better than `comp

[PATCH] D34924: [Bash-autocompletion] Add support for older bash version.

yamaguchi updated this revision to Diff 104992. yamaguchi marked 2 inline comments as done. yamaguchi added a comment. Update diff. https://reviews.llvm.org/D34924 Files: clang/utils/bash-autocomplete.sh Index: clang/utils/bash-autocomplete.sh ===

[PATCH] D34924: [Bash-autocompletion] Add support for older bash version.

yamaguchi added inline comments. Comment at: clang/utils/bash-autocomplete.sh:3 + +_clang_filedir() +{ ruiu wrote: > Is the output of `compgen -f` the same as `_filedir`? If so, can you always > use `compgen -f`? _filedir is better than `compgen -f`, because it

[PATCH] D34925: [Bash-completion] Fixed a bug that ~ doesn't expanded to $HOME

yamaguchi created this revision. `~/build/bin/clang -f[tab]` was executed without ~ expanded to $HOME, so changed this by expanding ~ to path using eval. https://reviews.llvm.org/D34925 Files: clang/utils/bash-autocomplete.sh Index: clang/utils/bash-autocomplete.sh

[PATCH] D34924: [Bash-autocompletion] Add support for older bash version.

ruiu added inline comments. Comment at: clang/utils/bash-autocomplete.sh:3 + +_clang_filedir() +{ Is the output of `compgen -f` the same as `_filedir`? If so, can you always use `compgen -f`? Comment at: clang/utils/bash-autocomplete.sh:7 + i

[PATCH] D34924: [Bash-autocompletion] Check if bash-completion is installed or not

yamaguchi updated this revision to Diff 104988. yamaguchi added a comment. Update patch and diff. https://reviews.llvm.org/D34924 Files: clang/utils/bash-autocomplete.sh Index: clang/utils/bash-autocomplete.sh === --- clang/uti

[PATCH] D34888: [OpenMP] Fix mapping of scalars for combined directives

This revision was automatically updated to reflect the committed changes. Closed by commit rL306956: [OpenMP] Fix mapping of scalars for combined directives (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D34888?vs=104863&id=104986#toc Repository: rL LLVM https://r

r306956 - [OpenMP] Fix mapping of scalars for combined directives

Author: hahnfeld Date: Sat Jul 1 03:40:50 2017 New Revision: 306956 URL: http://llvm.org/viewvc/llvm-project?rev=306956&view=rev Log: [OpenMP] Fix mapping of scalars for combined directives Combined directives like 'target parallel' have two captured statements. Sema has to check the right one f

[PATCH] D34924: [Bash-autocompletion] Check if bash-completion is installed

yamaguchi created this revision. Bash-autocompletion for clang depends on bash-completion system and abort `bash: _init_completion: command not found` when it is not installed. Changed to return silently if bash-completion is not installed. https://reviews.llvm.org/D34924 Files: clang/utils/

[PATCH] D34770: [Bash-autocompletion] Auto complete cc1 options if -cc1 is specified

yamaguchi updated this revision to Diff 104983. yamaguchi added a comment. Update code comments. https://reviews.llvm.org/D34770 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/autocomplete.c clang/utils/bash-autocomplete.sh llvm/include/llvm/Option/OptTable.h llvm/lib/Option/Opt

[PATCH] D34770: [Bash-autocompletion] Auto complete cc1 options if -cc1 is specified

yamaguchi updated this revision to Diff 104982. yamaguchi added a comment. Update diff. Autocomplete cc1 flags when argv[1] is -cc1 or previous flag is -Xclang. https://reviews.llvm.org/D34770 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/autocomplete.c clang/utils/bash-autocomple

r306954 - fix trivial typos; NFC

Author: inouehrs Date: Sat Jul 1 01:46:43 2017 New Revision: 306954 URL: http://llvm.org/viewvc/llvm-project?rev=306954&view=rev Log: fix trivial typos; NFC Modified: cfe/trunk/lib/Basic/Targets.cpp cfe/trunk/lib/Driver/ToolChains/MipsLinux.cpp cfe/trunk/lib/Frontend/ModuleDependency

r306953 - Changed Opts.EABIVersion type string to llvm::EABI enum class

Author: yamaguchi Date: Sat Jul 1 00:57:23 2017 New Revision: 306953 URL: http://llvm.org/viewvc/llvm-project?rev=306953&view=rev Log: Changed Opts.EABIVersion type string to llvm::EABI enum class Summary: Changed EABIVersion type from string to llvm::EABI. It seems it was just a typo and this i

[PATCH] D34770: [Bash-autocompletion] Auto complete cc1 options if -cc1 is specified

teemperor added a comment. > I'm not sure what you refer to by ` I just saw we actually have the > completion code in the Driver`. We are already auto completing both cc1 > options and driver options, right? Woops, I misread the code there. Never mind! > What about completing cc1 options only