ruiu accepted this revision.
ruiu added a comment.

LGTM. Confirmed that it works as expected on my Mac which doesn't have the 
bash-autocomplete package.



================
Comment at: clang/utils/bash-autocomplete.sh:19
+    COMPREPLY=()
+    cword=$COMP_CWORD
+    cur="${COMP_WORDS[$cword]}"
----------------
I think you want to quote $COMP_WORD with "" so that it works even if 
$COMP_WORD contains space characters.
20      


https://reviews.llvm.org/D34924



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to