[PATCH] D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width

zaks.anna added a comment. These are great additions! Going back to my comment about adding these to CheckerContext, I think we should be adding helper functions as methods on CheckerContext as it is **the primary place where checker writers look for helpers**. Two of the three methods added t

[PATCH] D33820: [PowerPC] Pass CPU to assembler with -no-integrated-as

nemanjai updated this revision to Diff 101169. nemanjai added a comment. Initially, forgot to add a test case. Repository: rL LLVM https://reviews.llvm.org/D33820 Files: lib/Driver/ToolChains/Arch/PPC.cpp lib/Driver/ToolChains/Arch/PPC.h lib/Driver/ToolChains/Gnu.cpp test/Driver/linu

[PATCH] D33820: [PowerPC] Pass CPU to assembler with -no-integrated-as

nemanjai created this revision. This just adds the CPU to a list of commands passed to GAS when not using the integrated assembler. Repository: rL LLVM https://reviews.llvm.org/D33820 Files: lib/Driver/ToolChains/Arch/PPC.cpp lib/Driver/ToolChains/Arch/PPC.h lib/Driver/ToolChains/Gnu.

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 marked 12 inline comments as done. jyu2 added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6341 +: Warning<"%0 has a non-throwing exception specification but can still " + "throw, may result in unexpected program termination.">, + In

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 added a comment. In https://reviews.llvm.org/D3#770238, @aaron.ballman wrote: > In https://reviews.llvm.org/D3#768332, @jyu2 wrote: > > > Okay this CFG version of this change. In this change I am basic using same > > algorithm with -Winfinite-recursion. > > > > In addition to my or

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 marked 8 inline comments as done. jyu2 added inline comments. Comment at: lib/Sema/AnalysisBasedWarnings.cpp:334 + continue; +else + HasThrowOutFunc = true; aaron.ballman wrote: > You can drop the `else` here and just set `HasThrowOutFunc` to t

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 updated this revision to Diff 101167. jyu2 marked an inline comment as done. jyu2 added a comment. Update to address review comments. https://reviews.llvm.org/D3 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/AnalysisBasedWarnings.cpp test/CXX/except/except.spec/p11.c

r304519 - Minor fixes to for-loop warning.

Author: rtrieu Date: Thu Jun 1 23:24:46 2017 New Revision: 304519 URL: http://llvm.org/viewvc/llvm-project?rev=304519&view=rev Log: Minor fixes to for-loop warning. The warning for unchanged loop variables outputted a diagnostic that was dependent on iteration order from a pointer set, which is

[PATCH] D32269: [Driver] Add iSOFTLinux to GNU ToolChains X86Triple

compnerd added inline comments. Comment at: test/Driver/linux-ld.c:467-471 +// RUN: %clang %s -### -o %t.o 2>&1 --target=x86_64-everest-linux +// RUN: %clang %s -### -o %t.o 2>&1 --target=x86_64-pure64-linux +// RUN: %clang %s -### -o %t.o 2>&1 --target=i686-isoft-linux +// RUN:

[PATCH] D33703: Support lazy stat'ing of files referenced by module maps

This revision was automatically updated to reflect the committed changes. Closed by commit rL304515: Support lazy stat'ing of files referenced by module maps. (authored by rsmith). Changed prior to commit: https://reviews.llvm.org/D33703?vs=101157&id=101162#toc Repository: rL LLVM https://r

r304515 - Support lazy stat'ing of files referenced by module maps.

Author: rsmith Date: Thu Jun 1 20:55:39 2017 New Revision: 304515 URL: http://llvm.org/viewvc/llvm-project?rev=304515&view=rev Log: Support lazy stat'ing of files referenced by module maps. This patch adds support for a `header` declaration in a module map to specify certain `stat` information (

[PATCH] D33788: Return a canonical path from getClangResourcePath()

bruno added a reviewer: bruno. bruno added a comment. Hi Aaron, Nice catch! Any chance you can add a testcase to this? https://reviews.llvm.org/D33788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D33703: Support lazy stat'ing of files referenced by module maps

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D33703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D33703: Support lazy stat'ing of files referenced by module maps

rsmith updated this revision to Diff 101157. rsmith marked an inline comment as done. rsmith added a comment. Rebased and added requested test. https://reviews.llvm.org/D33703 Files: docs/Modules.rst include/clang/Basic/DiagnosticLexKinds.td include/clang/Basic/DiagnosticSerializationKind

[PATCH] D33719: Add _Float16 as a C/C++ source language type

bruno added a comment. Hi Sjoerd, Thanks for working on this. Can you add context to your patch? Comment at: test/CodeGenCXX/float16-declarations-error.cpp:1 +// RUN: not %clang -S -emit-llvm --target=aarch64 %s -o - 2>&1 | FileCheck %s --check-prefix=CHECK-ERROR + --

[PATCH] D33816: [Sema][ObjC] Don't allow -Wunguarded-availability to be silenced with redeclarations

erik.pilkington created this revision. This patch drops support for suppressing -Wunguarded-availability with redeclarations. This was behavior left over from the -Wpartial-availability days, where it was the only way of silencing the diagnostic. Now that we have @available and better support f

[PATCH] D33739: [Sema] Improve -Wstrict-prototypes diagnostic message for blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rL304507: [Sema] Improve -Wstrict-prototypes diagnostic message for blocks. (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D33739?vs=100916&id=101155#toc Repository: rL LLVM

r304507 - [Sema] Improve -Wstrict-prototypes diagnostic message for blocks.

Author: ahatanak Date: Thu Jun 1 20:07:08 2017 New Revision: 304507 URL: http://llvm.org/viewvc/llvm-project?rev=304507&view=rev Log: [Sema] Improve -Wstrict-prototypes diagnostic message for blocks. Print "this block declaration is not a prototype" for non-prototype declarations of blocks inste

r304506 - PR32848: There isn't necessarily a FileChanged or FileSkipped for every InclusionDirective callback.

Author: rsmith Date: Thu Jun 1 20:05:44 2017 New Revision: 304506 URL: http://llvm.org/viewvc/llvm-project?rev=304506&view=rev Log: PR32848: There isn't necessarily a FileChanged or FileSkipped for every InclusionDirective callback. In particular, you don't get one if the inclusion directive en

Re: r297702 - [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded

It crashes when there is an anonymous ivar of a bitfield type. @interface FormatScanner { int : 1; } @end @implementation FormatScanner @end I'm not sure if the code above is valid or not, but out of curiosity, why would you want an anonymous bitfield variable? > On Jun 1, 2017, at 11:33 AM,

[PATCH] D32520: Support __fp16 vectors

bruno added a comment. Hi Akira, This is nice, thanks for doing it! Comment at: include/clang/Sema/Sema.h:9270 + QualType RHSType, + bool CompAssign = false); Can you

Re: r304376 - PR33232: implement support for MSVC's __is_trivially_destructible trait.

On 31 May 2017 at 17:41, Eric Fiselier wrote: > I'm assuming libc++ should move to this trait instead? > Yes, that'd be a good idea. Though now that you mention it, I'm not sure we have a good feature detection story for these builtins. Looks like a bunch of the existing ones are (oddly) covered

[PATCH] D33706: CodeGen: Cast temporary variable to proper address space

rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:3805 +Address Addr = +CreateMemTemp(I->Ty, ArgInfo.getIndirectAlign(), "tmp", false); IRCallArgs[FirstIRArg] = Addr.getPointer(); How about "indirect-arg-temp" as the

r304501 - [ThinLTO] Add x86 requires to thin_link_bitcode. NFC.

Author: timshen Date: Thu Jun 1 19:08:58 2017 New Revision: 304501 URL: http://llvm.org/viewvc/llvm-project?rev=304501&view=rev Log: [ThinLTO] Add x86 requires to thin_link_bitcode. NFC. It already specifies the triples, so the intention was to test x86 for now (or then). Differential Revision:

[PATCH] D33703: Support lazy stat'ing of files referenced by module maps

rsmith added a comment. In https://reviews.llvm.org/D33703#770896, @bruno wrote: > - I've noticed in the patch that on the ASTWriter side we serialize the > introduced size / mtime, but there are no changes to the ASTReader, so I > assume in the reader side you still need the module map around

[PATCH] D33108: Generate extra .ll files before/after optimization when using -save-temps.

jgorbe added inline comments. Comment at: lib/Driver/Driver.cpp:2603-2614 + // lipo-able. + if (!MultiArchUniversalBuild) { +if (isSaveTempsEnabled() && Phase == phases::Compile) { + Actions.push_back( + C.MakeAction(Current, types::TY_LLVM

r304499 - [CodeGen] Surround assertion with parentheses.

Author: davide Date: Thu Jun 1 18:55:18 2017 New Revision: 304499 URL: http://llvm.org/viewvc/llvm-project?rev=304499&view=rev Log: [CodeGen] Surround assertion with parentheses. This should placate GCC's -Wparentheses. Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp Modified: cfe/trunk/l

[PATCH] D33703: Support lazy stat'ing of files referenced by module maps

bruno added a comment. Hi Richard, Thanks for improving this further! Questions / comments: - I've noticed in the patch that on the ASTWriter side we serialize the introduced size / mtime, but there are no changes to the ASTReader, so I assume in the reader side you still need the module map

[PATCH] D33692: [ThinLTO] Wire up ThinLTO and new PM

This revision was automatically updated to reflect the committed changes. Closed by commit rL304496: [ThinLTO] Wire up ThinLTO and new PM (authored by timshen). Changed prior to commit: https://reviews.llvm.org/D33692?vs=101106&id=101135#toc Repository: rL LLVM https://reviews.llvm.org/D336

r304496 - [ThinLTO] Wire up ThinLTO and new PM

Author: timshen Date: Thu Jun 1 18:27:51 2017 New Revision: 304496 URL: http://llvm.org/viewvc/llvm-project?rev=304496&view=rev Log: [ThinLTO] Wire up ThinLTO and new PM Summary: This patch teaches clang to use and propagate new PM in ThinLTO. Reviewers: davide, chandlerc, tejohnson Subscriber

[libcxx] r304487 - [test] Allow non-libc++ coroutine_handle::done to strengthen noexcept

Author: caseycarter Date: Thu Jun 1 17:40:16 2017 New Revision: 304487 URL: http://llvm.org/viewvc/llvm-project?rev=304487&view=rev Log: [test] Allow non-libc++ coroutine_handle::done to strengthen noexcept Modified: libcxx/trunk/test/std/experimental/language.support/support.coroutines/cor

Re: r304459 - [ubsan] Add a check for pointer overflow UB

I checked in r304486 to try and address the issue. thanks, vedant > On Jun 1, 2017, at 3:21 PM, Vedant Kumar via cfe-commits > wrote: > > Taking a look. > > vedant > >> On Jun 1, 2017, at 2:45 PM, Galina Kistanova > > wrote: >> >> Hello Vedant, >> >> This commi

r304486 - Relax test to try and appease builders. NFC.

Author: vedantk Date: Thu Jun 1 17:27:39 2017 New Revision: 304486 URL: http://llvm.org/viewvc/llvm-project?rev=304486&view=rev Log: Relax test to try and appease builders. NFC. I'm not sure why, but on some bots, the order of two instructions are swapped (as compared to the output on my machine

Re: r304459 - [ubsan] Add a check for pointer overflow UB

Taking a look. vedant > On Jun 1, 2017, at 2:45 PM, Galina Kistanova wrote: > > Hello Vedant, > > This commit broke tests on some of our builders: > > Failing Tests (1): > Clang :: CodeGen/ubsan-pointer-overflow.m > > http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-w

Re: r304459 - [ubsan] Add a check for pointer overflow UB

Hello Vedant, This commit broke tests on some of our builders: Failing Tests (1): Clang :: CodeGen/ubsan-pointer-overflow.m http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/2865/steps/test-check-all/logs/stdio http://lab.llvm.org:8011/builders/llvm-clang-lld-x8

Re: [PATCH] D33424: Lexer: allow imaginary constants in GNU mode (only).

On 1 June 2017 at 14:36, Tim Northover wrote: > On 26 May 2017 at 11:29, Richard Smith wrote: > > If we generally think that distinction is a good thing, then (because > this > > is a conforming extension) consistency weakly suggests that it should > not be > > controlled by GNU mode. But I don'

[PATCH] D33721: [ARM] Add support for target("arm") and target("thumb").

echristo added inline comments. Comment at: lib/Basic/Targets.cpp:5439-5442 +// [-|+]thumb-mode target features respectively. +std::vector UpdatedFeaturesVec(FeaturesVec); +for (auto &Feature : UpdatedFeaturesVec) { + if (Feature.compare("+arm") == 0) ---

[PATCH] D33692: [ThinLTO] Wire up ThinLTO and new PM

davide added a comment. LGTM once the other patch lands. https://reviews.llvm.org/D33692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D33424: Lexer: allow imaginary constants in GNU mode (only).

On 26 May 2017 at 11:29, Richard Smith wrote: > If we generally think that distinction is a good thing, then (because this > is a conforming extension) consistency weakly suggests that it should not be > controlled by GNU mode. But I don't find that argument decisive; the > important thing is that

[PATCH] D33692: [ThinLTO] Wire up ThinLTO and new PM

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. This patch LGTM whenever the underlying LLVM change lands, thanks https://reviews.llvm.org/D33692 ___ cfe-commits mailing list cfe-comm

r304481 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

Author: gkistanova Date: Thu Jun 1 16:29:45 2017 New Revision: 304481 URL: http://llvm.org/viewvc/llvm-project?rev=304481&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Parse/ParseTentative.cpp Modified: cfe/trunk/lib/P

r304479 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

Author: gkistanova Date: Thu Jun 1 16:28:26 2017 New Revision: 304479 URL: http://llvm.org/viewvc/llvm-project?rev=304479&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Parse/ParseStmt.cpp Modified: cfe/trunk/lib/Parse/

r304478 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

Author: gkistanova Date: Thu Jun 1 16:26:38 2017 New Revision: 304478 URL: http://llvm.org/viewvc/llvm-project?rev=304478&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Parse/ParseOpenMP.cpp Modified: cfe/trunk/lib/Pars

r304477 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

Author: gkistanova Date: Thu Jun 1 16:23:52 2017 New Revision: 304477 URL: http://llvm.org/viewvc/llvm-project?rev=304477&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Parse/ParseInit.cpp Modified: cfe/trunk/lib/Parse/

r304475 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

Author: gkistanova Date: Thu Jun 1 16:21:49 2017 New Revision: 304475 URL: http://llvm.org/viewvc/llvm-project?rev=304475&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Parse/ParseExpr.cpp Modified: cfe/trunk/lib/Parse/

r304473 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

Author: gkistanova Date: Thu Jun 1 16:19:06 2017 New Revision: 304473 URL: http://llvm.org/viewvc/llvm-project?rev=304473&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Parse/ParseDeclCXX.cpp Modified: cfe/trunk/lib/Par

r304472 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

Author: gkistanova Date: Thu Jun 1 16:15:34 2017 New Revision: 304472 URL: http://llvm.org/viewvc/llvm-project?rev=304472&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Parse/ParseDecl.cpp Modified: cfe/trunk/lib/Parse/

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

This revision was automatically updated to reflect the committed changes. Closed by commit rL304470: [CGDebugInfo] Finalize SubPrograms when we're done with them (authored by kfischer). Changed prior to commit: https://reviews.llvm.org/D33705?vs=101092&id=101107#toc Repository: rL LLVM http

r304470 - [CGDebugInfo] Finalize SubPrograms when we're done with them

Author: kfischer Date: Thu Jun 1 16:14:03 2017 New Revision: 304470 URL: http://llvm.org/viewvc/llvm-project?rev=304470&view=rev Log: [CGDebugInfo] Finalize SubPrograms when we're done with them `GenerateVarArgsThunk` in `CGVTables` clones a function before the frontend is done emitting the comp

[PATCH] D33692: [ThinLTO] Migrate ThinLTOBitcodeWriter to the new PM.

timshen updated this revision to Diff 101106. timshen added a comment. Rebase the patch onto https://reviews.llvm.org/D33799. https://reviews.llvm.org/D33692 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/thin_link_bitcode.c Index: clang/test/CodeGen/thin_link_bitcode.c =

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

loladiro added a comment. I don't think that change is entirely necessary. I don't have any strong objections to it, but I also don't see a good reason to require it. In any case, let me get this in to be able to re-land https://reviews.llvm.org/D33655 and we can revisit the more disruptive cha

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

aprantl added a comment. Looks good.. Are you also planning to change DIBuilder to not finalize subprograms automatically any more (and not insert them into AllSubprograms)? (That will be the more impactful change as it will force all non-clang frontends to make a similar change). https://rev

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

loladiro added a comment. There's already such a test case, but the cloning currently doesn't assert properly (but it can generate incorrect code). https://reviews.llvm.org/D33655 fixes that up, so I think the testing is covered once that LLVM commit goes in. I'll hold off a little while to giv

r304465 - Don't assume that a store source is a vector type just because the destination is (PR26099)

Author: rksimon Date: Thu Jun 1 15:13:34 2017 New Revision: 304465 URL: http://llvm.org/viewvc/llvm-project?rev=304465&view=rev Log: Don't assume that a store source is a vector type just because the destination is (PR26099) Added: cfe/trunk/test/CodeGen/pr26099.c Modified: cfe/trunk/li

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. I guess this would need a cross-project test case (ie: it'd have to run LLVM optimizations to fail/pass/demonstrate the fix). I think it'd be OK to add one if there's a neat/clean/obvious

Re: r304346 - [modules] When compiling a preprocessed module map, look for headers relative

On 1 June 2017 at 12:53, Richard Smith wrote: > On 1 June 2017 at 11:10, Galina Kistanova wrote: > >> Hello Richard, >> >> This commit broke tests on few of our builders: >> >> Failing Tests (2): >> Clang :: Modules/preprocess-module.cpp >> Clang :: Modules/preprocess-nested.cpp >> >> ht

r304464 - Escape filenames in module map line marker directives, to unbreak Windows build bots.

Author: rsmith Date: Thu Jun 1 15:10:35 2017 New Revision: 304464 URL: http://llvm.org/viewvc/llvm-project?rev=304464&view=rev Log: Escape filenames in module map line marker directives, to unbreak Windows build bots. Modified: cfe/trunk/lib/Frontend/FrontendActions.cpp cfe/trunk/lib/Fr

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

loladiro added a comment. @aprantl @dblaikie See if you like this better. https://reviews.llvm.org/D33705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

loladiro updated this revision to Diff 101092. loladiro added a comment. Finalize all subprograms when we're done emitting them. The one we're interested in is a side effect, but doing this uniformly might be cleaner and help avoid similar errors in the future. https://reviews.llvm.org/D33705 F

[PATCH] D33398: Mangle __unaligned in Itanium ABI

rsmith accepted this revision. rsmith added a comment. Looks great, thanks! Comment at: lib/AST/ItaniumMangle.cpp:2210 + if (Quals.hasUnaligned()) + mangleVendorQualifier("__unaligned"); + rogfer01 wrote: > rsmith wrote: > > Too much indentation here. Als

[PATCH] D33797: [coroutines] Fix rebuilding of dependent coroutine parameters

GorNishanov created this revision. We were not handling correctly rebuilding of parameter and were not creating copies for them. With this checking, we will be always rebuilding parameter moves in TreeTransform's TransformCoroutineBodyStmt. https://reviews.llvm.org/D33797 Files: lib/Sema/Co

[PATCH] D32724: [Modules] Handle sanitizer feature mismatches when importing modules

This revision was automatically updated to reflect the committed changes. Closed by commit rL304463: [Modules] Handle sanitizer feature mismatches when importing modules (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D32724?vs=98371&id=101088#toc Repository: rL LLVM

[libcxx] r304462 - Mark two coroutine tests as unsupported under ubsan

Author: vedantk Date: Thu Jun 1 15:00:40 2017 New Revision: 304462 URL: http://llvm.org/viewvc/llvm-project?rev=304462&view=rev Log: Mark two coroutine tests as unsupported under ubsan They appear to crash inside of SelectionDAG on some Linux bots, when ubsan is enabled. https://bugs.llvm.org/s

r304463 - [Modules] Handle sanitizer feature mismatches when importing modules

Author: vedantk Date: Thu Jun 1 15:01:01 2017 New Revision: 304463 URL: http://llvm.org/viewvc/llvm-project?rev=304463&view=rev Log: [Modules] Handle sanitizer feature mismatches when importing modules This patch makes it an error to have a mismatch between the enabled sanitizers in a CU, and in

Re: r304346 - [modules] When compiling a preprocessed module map, look for headers relative

On 1 June 2017 at 11:10, Galina Kistanova wrote: > Hello Richard, > > This commit broke tests on few of our builders: > > Failing Tests (2): > Clang :: Modules/preprocess-module.cpp > Clang :: Modules/preprocess-nested.cpp > > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64- > sce

[PATCH] D33305: [ubsan] Add a check for pointer overflow UB

This revision was automatically updated to reflect the committed changes. Closed by commit rL304459: [ubsan] Add a check for pointer overflow UB (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D33305?vs=100475&id=101078#toc Repository: rL LLVM https://reviews.llvm.o

r304459 - [ubsan] Add a check for pointer overflow UB

Author: vedantk Date: Thu Jun 1 14:22:18 2017 New Revision: 304459 URL: http://llvm.org/viewvc/llvm-project?rev=304459&view=rev Log: [ubsan] Add a check for pointer overflow UB Check pointer arithmetic for overflow. For some more background on this check, see: https://wdtz.org/catching-point

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

efriedma added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:569 + if (Triple.getEnvironment() == llvm::Triple::EABI) { +switch (Triple.getArch()) { chrib wrote: > efriedma wrote: > > Specifically checking for "llvm::Triple::EABI" is suspici

r304456 - Add compatibility alias for -Wno-#warnings

Author: dblaikie Date: Thu Jun 1 14:08:34 2017 New Revision: 304456 URL: http://llvm.org/viewvc/llvm-project?rev=304456&view=rev Log: Add compatibility alias for -Wno-#warnings GCC uses -Wno-cpp for this, so seems reasonable to add an alias to match. Modified: cfe/trunk/include/clang/Basic/

r304455 - Fixed broken test (strict-vtable-pointers)

Author: prazek Date: Thu Jun 1 14:08:05 2017 New Revision: 304455 URL: http://llvm.org/viewvc/llvm-project?rev=304455&view=rev Log: Fixed broken test (strict-vtable-pointers) Modified: cfe/trunk/test/CodeGenCXX/strict-vtable-pointers.cpp Modified: cfe/trunk/test/CodeGenCXX/strict-vtable-poi

[PATCH] D33706: CodeGen: Cast temporary variable to proper address space

yaxunl updated this revision to Diff 101070. yaxunl marked 2 inline comments as done. yaxunl retitled this revision from "[AMDGPU] Fix address space for global and temporary variables in C++" to "CodeGen: Cast temporary variable to proper address space". yaxunl edited the summary of this revision

r304451 - [SemaCXX] Add diagnostics to require_constant_initialization

Author: kfischer Date: Thu Jun 1 13:54:16 2017 New Revision: 304451 URL: http://llvm.org/viewvc/llvm-project?rev=304451&view=rev Log: [SemaCXX] Add diagnostics to require_constant_initialization Summary: This hooks up the detailed diagnostics of why constant initialization was not possible if re

[PATCH] D24371: Add diagnostics to require_constant_initialization

This revision was automatically updated to reflect the committed changes. Closed by commit rL304451: [SemaCXX] Add diagnostics to require_constant_initialization (authored by kfischer). Changed prior to commit: https://reviews.llvm.org/D24371?vs=100949&id=101066#toc Repository: rL LLVM http

[libcxx] r304450 - Remove ubsan XFAILS in two tests

Author: vedantk Date: Thu Jun 1 13:48:27 2017 New Revision: 304450 URL: http://llvm.org/viewvc/llvm-project?rev=304450&view=rev Log: Remove ubsan XFAILS in two tests These two tests are ubsan-clean now: http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/3553/ Modified: libcx

[PATCH] D33698: [CodeGen][ObjC] Fix assertion failure in CodeGenFunction::EmitARCStoreStrongCall

This revision was automatically updated to reflect the committed changes. Closed by commit rL304449: [CodeGen][ObjC] Fix assertion failure in EmitARCStoreStrongCall. (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D33698?vs=100787&id=101060#toc Repository: rL LLVM

r304449 - [CodeGen][ObjC] Fix assertion failure in EmitARCStoreStrongCall.

Author: ahatanak Date: Thu Jun 1 13:41:25 2017 New Revision: 304449 URL: http://llvm.org/viewvc/llvm-project?rev=304449&view=rev Log: [CodeGen][ObjC] Fix assertion failure in EmitARCStoreStrongCall. The assertion fails because EmitValueForIvarAtOffset doesn't get the correct type of the ivar whe

[PATCH] D31830: Emit invariant.group.barrier when using union field

This revision was automatically updated to reflect the committed changes. Closed by commit rL304448: Emit invariant.group.barrier when using union field (authored by Prazek). Changed prior to commit: https://reviews.llvm.org/D31830?vs=100977&id=101058#toc Repository: rL LLVM https://reviews

r304448 - Emit invariant.group.barrier when using union field

Author: prazek Date: Thu Jun 1 13:39:34 2017 New Revision: 304448 URL: http://llvm.org/viewvc/llvm-project?rev=304448&view=rev Log: Emit invariant.group.barrier when using union field Summary: We need to emit barrier if the union field is CXXRecordDecl because it might have vptrs. The testcode w

[PATCH] D33726: [driver][netbsd] Build and pass `-L` arguments to the linker

joerg added a comment. A small subset can be found by searching for LINKER_RPATH_FLAG in pkgsrc. A classic offender is Emacs. For more, I would have to systematically search. Repository: rL LLVM https://reviews.llvm.org/D33726 ___ cfe-commits ma

Re: r297702 - [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded

On Tue, Mar 14, 2017 at 04:00:53AM -, Akira Hatanaka via cfe-commits wrote: > Author: ahatanak > Date: Mon Mar 13 23:00:52 2017 > New Revision: 297702 > > URL: http://llvm.org/viewvc/llvm-project?rev=297702&view=rev > Log: > [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded >

r304445 - Strip trailing whitespace. NFCI.

Author: rksimon Date: Thu Jun 1 13:17:18 2017 New Revision: 304445 URL: http://llvm.org/viewvc/llvm-project?rev=304445&view=rev Log: Strip trailing whitespace. NFCI. Modified: cfe/trunk/lib/Sema/SemaOverload.cpp Modified: cfe/trunk/lib/Sema/SemaOverload.cpp URL: http://llvm.org/viewvc/llvm

r304444 - Remove late nullptr pointer test (PR32447)

Author: rksimon Date: Thu Jun 1 13:13:02 2017 New Revision: 30 URL: http://llvm.org/viewvc/llvm-project?rev=30&view=rev Log: Remove late nullptr pointer test (PR32447) IgnoreNarrowingConversion should never return nullptr, but I've added an assert just in case. Modified: cfe/trunk/

Re: r304346 - [modules] When compiling a preprocessed module map, look for headers relative

Hello Richard, This commit broke tests on few of our builders: Failing Tests (2): Clang :: Modules/preprocess-module.cpp Clang :: Modules/preprocess-nested.cpp http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/10199 and http://lab.llvm.org:8011/bui

[PATCH] D24371: Add diagnostics to require_constant_initialization

loladiro added a comment. Sure, I'll commit it. https://reviews.llvm.org/D24371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33765: Show correct column nr. when multi-byte utf8 chars are used.

efriedma added a comment. Correctly counting columns is a bit more complicated that that... for example, consider what happens if you replace `ideëen` with `idez̈en`. See https://stackoverflow.com/questions/3634627/how-to-know-the-preferred-display-width-in-columns-of-unicode-characters . ht

[PATCH] D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer.

ABataev added a comment. In https://reviews.llvm.org/D33735#770333, @rjmccall wrote: > In https://reviews.llvm.org/D33735#770318, @aaron.ballman wrote: > > > In https://reviews.llvm.org/D33735#770296, @ABataev wrote: > > > > > In https://reviews.llvm.org/D33735#770288, @aaron.ballman wrote: > > >

[PATCH] D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer.

rjmccall added a comment. In https://reviews.llvm.org/D33735#770318, @aaron.ballman wrote: > In https://reviews.llvm.org/D33735#770296, @ABataev wrote: > > > In https://reviews.llvm.org/D33735#770288, @aaron.ballman wrote: > > > > > Can you help me to understand what problem is being solved with

[PATCH] D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer.

aaron.ballman added a comment. In https://reviews.llvm.org/D33735#770296, @ABataev wrote: > In https://reviews.llvm.org/D33735#770288, @aaron.ballman wrote: > > > Can you help me to understand what problem is being solved with this new > > attribute? Under what circumstances would the first argu

[PATCH] D33774: [CodeGen] Make __attribute__(const) calls speculatable

efriedma added a comment. Consider something like this: define i32 @div(i32 %x, i32 %y) { entry: %div = sdiv i32 %x, %y ret i32 %div } We can mark this function readnone, but not speculatable: it doesn't read or write memory, but could exhibit undefined behavior. Consider another

[PATCH] D33788: Return a canonical path from getClangResourcePath()

aaron.ballman created this revision. on POSIX systems, CIndexer::getClangResourcesPath() uses dladdr() to get the path of the shared object. It seems that on some systems (in our case, OS X 10.6.8), dladdr() does not return a canonicalized path. We're getting a path like PATH/TO/CLANG/build/bin

[PATCH] D33588: Fix two sources of UB in __next_hash_pow2 (from __hash_table)

vsk added inline comments. Comment at: include/__hash_table:139 { -return size_t(1) << (std::numeric_limits::digits - __clz(__n-1)); +return (__n > 1) ? (size_t(1) << (std::numeric_limits::digits - __clz(__n-1))) : __n; } EricWF wrote: > Shouldn't this

[PATCH] D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer.

ABataev added a comment. In https://reviews.llvm.org/D33735#770288, @aaron.ballman wrote: > Can you help me to understand what problem is being solved with this new > attribute? Under what circumstances would the first argument be an > `ImplicitParamDecl` but not an implicit this or self? For

[PATCH] D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer.

aaron.ballman added a comment. Can you help me to understand what problem is being solved with this new attribute? Under what circumstances would the first argument be an `ImplicitParamDecl` but not an implicit this or self? https://reviews.llvm.org/D33735 __

[PATCH] D31830: Emit invariant.group.barrier when using union field

rjmccall accepted this revision. rjmccall added a comment. Thanks, LGTM. https://reviews.llvm.org/D31830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33537: [clang-tidy] Exception Escape Checker

aaron.ballman added a comment. In https://reviews.llvm.org/D33537#765445, @baloghadamsoftware wrote: > In https://reviews.llvm.org/D33537#764834, @Prazek wrote: > > > How is that compared to https://reviews.llvm.org/D19201 and the clang patch > > mentioned in this patch? > > > Actually, this che

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

aaron.ballman added a comment. In https://reviews.llvm.org/D3#768332, @jyu2 wrote: > Okay this CFG version of this change. In this change I am basic using same > algorithm with -Winfinite-recursion. > > In addition to my original implementation, I add handler type checking which > basic u

[PATCH] D33739: [Sema] Improve -Wstrict-prototypes diagnostic message for blocks

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D33739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D33108: Generate extra .ll files before/after optimization when using -save-temps.

tra added inline comments. Comment at: lib/Driver/Driver.cpp:2603-2614 + // lipo-able. + if (!MultiArchUniversalBuild) { +if (isSaveTempsEnabled() && Phase == phases::Compile) { + Actions.push_back( + C.MakeAction(Current, types::TY_LLVM_IR

[libunwind] r304432 - Creating release candidate rc2 from release_401 branch

Author: tstellar Date: Thu Jun 1 11:30:02 2017 New Revision: 304432 URL: http://llvm.org/viewvc/llvm-project?rev=304432&view=rev Log: Creating release candidate rc2 from release_401 branch Added: libunwind/tags/RELEASE_401/rc2/ (props changed) - copied from r304431, libunwind/branche

[libcxxabi] r304426 - Creating release candidate rc2 from release_401 branch

Author: tstellar Date: Thu Jun 1 11:29:45 2017 New Revision: 304426 URL: http://llvm.org/viewvc/llvm-project?rev=304426&view=rev Log: Creating release candidate rc2 from release_401 branch Added: libcxxabi/tags/RELEASE_401/rc2/ (props changed) - copied from r304425, libcxxabi/branche

  1   2   >