yamaguchi updated this revision to Diff 96273.
yamaguchi added a comment.
Add testcase.
https://reviews.llvm.org/D32341
Files:
lib/Driver/ToolChains/Clang.cpp
test/Driver/m_and_mm.c
Index: test/Driver/m_and_mm.c
===
--- test/
efriedma added inline comments.
Comment at: clang/test/Headers/stdint-typeof-MINMAX.cpp:1
+// RUN: %clang_cc1 %s -ffreestanding -std=c++1z -fsyntax-only
-triple=aarch64-none-none
+// RUN: %clang_cc1 %s -ffreestanding -std=c++1z -fsyntax-only
-triple=arm-none-none
--
STL_MSFT created this revision.
[libcxx] [test] Avoid P0138R2, direct-list-init of fixed enums from integers.
This C++17 Core Language feature isn't necessary when testing std::byte.
It's a minor convenience, but it limits test coverage to very new compilers.
(I encountered this because C1XX cur
dexonsmith added inline comments.
Comment at: clang/test/Headers/stdint-typeof-MINMAX.cpp:1
+// RUN: %clang_cc1 %s -ffreestanding -std=c++1z -fsyntax-only
-triple=aarch64-none-none
+// RUN: %clang_cc1 %s -ffreestanding -std=c++1z -fsyntax-only
-triple=arm-none-none
dexonsmith updated this revision to Diff 96269.
dexonsmith added a comment.
Thanks Eli and Richard.
Given that, I've thrown in fixes for `INTMAX_MIN`, `INTMAX_MAX`, `UINTMAX_MAX`,
`INTMAX_C()`, and `UINTMAX_C()`, as well as fixing the typedefs for `intptr_t`,
`uintptr_t`, `intmax_t`, and `uintm
Author: rsmith
Date: Fri Apr 21 19:47:53 2017
New Revision: 301066
URL: http://llvm.org/viewvc/llvm-project?rev=301066&view=rev
Log:
Rearrange some Modules TS testcases into test/CXX/modules-ts.
Added:
cfe/trunk/test/CXX/modules-ts/
cfe/trunk/test/CXX/modules-ts/basic/
cfe/trunk/test/
hfinkel updated this revision to Diff 96264.
hfinkel added a comment.
Output metadata to provide the types of globals (similar to how Clang marks
globals for asan).
https://reviews.llvm.org/D32199
Files:
include/clang/Basic/Sanitizers.def
include/clang/Driver/SanitizerArgs.h
lib/CodeGen/
joshz added a comment.
Are there any further changes I should make, or is this good to submit now?
Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D31542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Author: dblaikie
Date: Fri Apr 21 18:35:36 2017
New Revision: 301063
URL: http://llvm.org/viewvc/llvm-project?rev=301063&view=rev
Log:
Move Split DWARF handling to an MC option/command line argument rather than
using metadata
Since Split DWARF needs to name the actual .dwo file that is generated
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D32064
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
eugenis added a comment.
PTAL
Repository:
rL LLVM
https://reviews.llvm.org/D32064
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis updated this revision to Diff 96263.
Repository:
rL LLVM
https://reviews.llvm.org/D32064
Files:
lib/CodeGen/BackendUtil.cpp
test/CodeGen/asan-globals-gc.cpp
Index: test/CodeGen/asan-globals-gc.cpp
===
--- /dev/null
+
dexonsmith closed this revision.
dexonsmith added a comment.
Committed in r301060.
https://reviews.llvm.org/D31561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dexonsmith
Date: Fri Apr 21 18:14:55 2017
New Revision: 301060
URL: http://llvm.org/viewvc/llvm-project?rev=301060&view=rev
Log:
cmath: Skip Libc for integral types in isinf, etc.
For std::isinf, the standard requires effectively calling isinf as
double from Libc for integral types. But i
dexonsmith added a comment.
Since I haven't heard from Marshall and Hal's fine with the less-future-proof
std::is_floating_point, I'll commit that and we can iterate in tree. Just
running tests.
https://reviews.llvm.org/D31561
___
cfe-commits mai
CaseyCarter created this revision.
.. by injecting base classes that differentiate between trivial/non-trivial
implementation of each copy/move constructor/assignment. This actually goes a
bit beyond the PR by also making the copy/move assignment operators trivial
when the base type has corresp
Author: rsmith
Date: Fri Apr 21 17:39:18 2017
New Revision: 301056
URL: http://llvm.org/viewvc/llvm-project?rev=301056&view=rev
Log:
P0629R0: Switch to latest proposal for distinguishing module interface from
implementation.
This switches from the prototype syntax in P0273R0 ('module' and 'modul
Author: caseycarter
Date: Fri Apr 21 17:38:59 2017
New Revision: 301055
URL: http://llvm.org/viewvc/llvm-project?rev=301055&view=rev
Log:
Expand test coverage for LWG2857
* Cover optional's emplace-from-initializer_list overload
* Verify that any::emplace and optional::emplace return a reference
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301055: Expand test coverage for LWG2857 (authored by
CaseyCarter).
Changed prior to commit:
https://reviews.llvm.org/D32106?vs=95368&id=96260#toc
Repository:
rL LLVM
https://reviews.llvm.org/D32106
Prazek updated this revision to Diff 96255.
Prazek added a comment.
- format
https://reviews.llvm.org/D31830
Files:
lib/CodeGen/CGExpr.cpp
test/CodeGenCXX/strict-vtable-pointers.cpp
Index: test/CodeGenCXX/strict-vtable-pointers.cpp
==
Prazek marked 6 inline comments as done.
Prazek added a comment.
For now I will check if it has any vptrs. It will be probably soon stored in
the CXXRecordDecl because it will be used much more frequently when generating
barriers for pointer casts.
https://reviews.llvm.org/D31830
__
Prazek updated this revision to Diff 96254.
Prazek added a comment.
- Checking for vptrs
https://reviews.llvm.org/D31830
Files:
lib/CodeGen/CGExpr.cpp
test/CodeGenCXX/strict-vtable-pointers.cpp
Index: test/CodeGenCXX/strict-vtable-pointers.cpp
==
rsmith added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:3066-3067
+} else { // Unsigned integers and pointers.
+ if (CGF.CGM.getCodeGenOpts().StrictVTablePointers &&
+ CGF.CGM.getCodeGenOpts().OptimizationLevel > 0) {
+// Based on comparis
Author: akirtzidis
Date: Fri Apr 21 17:27:06 2017
New Revision: 301051
URL: http://llvm.org/viewvc/llvm-project?rev=301051&view=rev
Log:
[index] Take into account the category's external_symbol attr for namespacing
its methods
Modified:
cfe/trunk/include/clang/Index/USRGeneration.h
cfe/t
Prazek created this revision.
This code was wrongly devirtualized before:
A* a = new A;
a->foo();
A* b = new(a) B;
if (a == b)
b->foo();
Now we insert barrier before comparing dynamic pointers.
https://reviews.llvm.org/D32378
Files:
lib/CodeGen/CGExprScalar.cpp
test/CodeGen
pcc added a comment.
I think the only functional change here is for COFF, so you can add a CodeGen
test that checks that metadata globals are created only if `-fdata-sections` is
passed.
Repository:
rL LLVM
https://reviews.llvm.org/D32064
___
c
rsmith added a comment.
In https://reviews.llvm.org/D31856#733845, @efriedma wrote:
> We normally use stdint.h from the host C library, rather than our own
> version; this file is only relevant in -ffreestanding mode. So it should be
> safe to change.
Agreed; r89237 (and nearby changes: r892
eugenis added a comment.
what kind of test?
Repository:
rL LLVM
https://reviews.llvm.org/D32064
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Johnniesnato added a comment.
0day Scene Albums House, Club, Dance, Minimal, Psy-Trance, Dubstep
http://0daymusic.org
https://reviews.llvm.org/D32371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
rsmith added inline comments.
Comment at: test/std/numerics/numeric.ops/numeric.ops.gcd/gcd.pass.cpp:46
+std::gcd(static_cast(0), static_cast(0)))>::value, "");
+const bool result = static_cast>(out) ==
+std::gcd(static_cast(in1), static_cast(in2));
--
pcc added a comment.
Please add a test case.
Repository:
rL LLVM
https://reviews.llvm.org/D32064
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added a comment.
This needs testcases (the one from your summary plus the ones in my comments
above would be good).
Comment at: lib/AST/ExprConstant.cpp:2622
// Next subobject is an array element.
- const ConstantArrayType *CAT = Info.Ctx.getAsConstantArrayT
BillyONeal updated this revision to Diff 96231.
BillyONeal added a comment.
Stephan had some code review comments :)
https://reviews.llvm.org/D32309
Files:
test/std/numerics/numeric.ops/numeric.ops.gcd/gcd.pass.cpp
test/std/numerics/numeric.ops/numeric.ops.lcm/lcm.pass.cpp
Index: test/std/
thakis closed this revision.
thakis marked an inline comment as done.
thakis added a comment.
r301039, thanks.
https://reviews.llvm.org/D32371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: nico
Date: Fri Apr 21 15:55:00 2017
New Revision: 301039
URL: http://llvm.org/viewvc/llvm-project?rev=301039&view=rev
Log:
Add comments to the diagnostic kinds in Diagnostic.td.
https://reviews.llvm.org/D32371
Modified:
cfe/trunk/include/clang/Basic/Diagnostic.td
Modified: cfe/trunk
malaperle-ericsson added a comment.
Thanks a lot!
Repository:
rL LLVM
https://reviews.llvm.org/D32234
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
Highly useful I'd say!
lgtm
Comment at: include/clang/Basic/Diagnostic.td:113
+// Extensions are warnings about accepted language extensions that are
+// default-off but enabled
eugenis updated this revision to Diff 96227.
eugenis added a comment.
Reverted back to using pass constructor argument.
Repository:
rL LLVM
https://reviews.llvm.org/D32064
Files:
lib/CodeGen/BackendUtil.cpp
Index: lib/CodeGen/BackendUtil.cpp
==
Arcoth created this revision.
Arrays of unknown bound are subject to some bugs in constant expressions.
const extern int arr[];
constexpr int f(int i) {return arr[i];}
constexpr int arr[] {1, 2, 3};
int main() {constexpr int x = f(2);}
This is spuriously rejected. On the other hand,
extern cons
thakis added a comment.
Not sure if this is useful, but this is where I always check first.
https://reviews.llvm.org/D32371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis created this revision.
https://reviews.llvm.org/D32371
Files:
include/clang/Basic/Diagnostic.td
Index: include/clang/Basic/Diagnostic.td
===
--- include/clang/Basic/Diagnostic.td
+++ include/clang/Basic/Diagnostic.td
@@ -1
vsk added a comment.
In https://reviews.llvm.org/D32043#728427, @pcc wrote:
> This seems reasonable to me, although it's unfortunate that the design of the
> sanitizer blacklist feature does not (at present) allow different blacklists
> for different sanitizers.
IMO this might be a real probl
thakis closed this revision.
thakis added a comment.
r301032, thanks.
https://reviews.llvm.org/D32369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Fri Apr 21 15:12:26 2017
New Revision: 301032
URL: http://llvm.org/viewvc/llvm-project?rev=301032&view=rev
Log:
[ms] Give -Wmicrosoft-enum-forward-reference a chance to fire in clang-cl,
PR32736
clang-cl sets MicrosoftCompat. In that mode, we always give enums a fixed
underlyi
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D32369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
thakis created this revision.
clang-cl sets MicrosoftCompat. In that mode, we always give enums a fixed
underlying type, and for enums with fixed underlying type we never enter the
block that tries to emit ext_ms_forward_ref_enum. Fix this by requiring an
explicit underlying type when we're sk
v.g.vassilev added a comment.
Could you add a test case?
https://reviews.llvm.org/D32341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mehdi_amini added a comment.
@mclow.lists you mentioned on IRC you may have some suggestions to make this
less noisy? Do you still plan to review?
https://reviews.llvm.org/D31739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
dexonsmith added a comment.
s/Eli/Eric/
https://reviews.llvm.org/D32263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dexonsmith updated this revision to Diff 96201.
dexonsmith added a comment.
Thanks for the review, Eli.
I've changed `IsModule` to be a required `bool*` parameter. Setting the
default to `nullptr` looked confusing at call sites.
https://reviews.llvm.org/D32263
Files:
clang/include/clang/Le
kzhuravl abandoned this revision.
kzhuravl added a comment.
Abandoned in favor of https://reviews.llvm.org/D32363.
https://reviews.llvm.org/D32084
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Eugene.Zelenko added a comment.
It may be good idea to add check for arguments which taken from C++ containers
like std::string, std::string_view, etc.
Repository:
rL LLVM
https://reviews.llvm.org/D32346
___
cfe-commits mailing list
cfe-commits@
eric_niebler added inline comments.
Comment at: clang/include/clang/Lex/HeaderSearch.h:401
+ }
+
/// \brief Look up a subframework for the specified \#include file.
Why not just add a `, bool *IsMapped = nullptr` parameter to the existing
`LookupFile`?
htt
mehdi_amini added a comment.
@mclow.lists you mentioned on IRC you may have some suggestions to make this
less noisy? Do you still plan to review?
https://reviews.llvm.org/D31739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
arsenm added inline comments.
Comment at: lib/Basic/Targets.cpp:2208-2210
+ TargetOpts.Features.push_back(
+ (Twine(hasFullSpeedFMAF32(TargetOpts.CPU) &&
+ !CGOpts.FlushDenorm ? '+' : '-') + Twine("fast-fmaf")).str());
We glue fast-fmaf to
efriedma added a comment.
We normally use stdint.h from the host C library, rather than our own version;
this file is only relevant in -ffreestanding mode. So it should be safe to
change.
https://reviews.llvm.org/D31856
___
cfe-commits mailing li
jtbandes updated this revision to Diff 96181.
jtbandes added a comment.
Cleanup
https://reviews.llvm.org/D32333
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
test/clang-tidy/readability-identifier-naming.cpp
Index: test/clang-tidy/readability-identifier-naming.cpp
==
jtbandes updated this revision to Diff 96180.
jtbandes edited the summary of this revision.
jtbandes added a comment.
Remove unnecessary checks for empty prefix/suffix
https://reviews.llvm.org/D32333
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
test/clang-tidy/readability-identif
emilio added inline comments.
Comment at: clang/test/Index/print-type.cpp:118
// CHECK: TemplateRef=Foo:4:8 [type=] [typekind=Invalid] [isPOD=0]
-// CHECK: FieldDecl=qux:29:38 (Definition) [type=Qux,
outer::inner::Bar::FooType>] [typekind=Unexposed] [templateargs/4= [type=int]
Anastasia added a comment.
Sure! LGTM!
https://reviews.llvm.org/D30805
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hiraditya added inline comments.
Comment at: libcxx/include/locale:891
+#ifndef _LIBCPP_ABI_OPTIMIZED_LOCALE
// signed
EricWF wrote:
> Would it be possible to reduce the amount of duplicate code between the two
> implementations? Currently it seems like there
hiraditya updated this revision to Diff 96159.
hiraditya added a comment.
Minimized the diff by putting #ifdefs inside the function.
https://reviews.llvm.org/D30268
Files:
libcxx/include/__config
libcxx/include/locale
Index: libcxx/include/locale
===
arphaman added inline comments.
Comment at: clang/test/Index/print-type.cpp:118
// CHECK: TemplateRef=Foo:4:8 [type=] [typekind=Invalid] [isPOD=0]
-// CHECK: FieldDecl=qux:29:38 (Definition) [type=Qux,
outer::inner::Bar::FooType>] [typekind=Unexposed] [templateargs/4= [type=int
This revision was automatically updated to reflect the committed changes.
Closed by commit rL300991: [Clangd] Failed to decode params using
1.x-compatible request message (authored by d0k).
Changed prior to commit:
https://reviews.llvm.org/D32238?vs=95811&id=96153#toc
Repository:
rL LLVM
ht
Author: d0k
Date: Fri Apr 21 10:51:23 2017
New Revision: 300991
URL: http://llvm.org/viewvc/llvm-project?rev=300991&view=rev
Log:
[Clangd] Failed to decode params using 1.x-compatible request message
textDocument/completion sends a TextDocumentPositionParams message in the 2.x
and 3.x. But in 1.x
This revision was automatically updated to reflect the committed changes.
Closed by commit rL300990: [Clangd] Support Authority-less URIs (authored by
d0k).
Changed prior to commit:
https://reviews.llvm.org/D32234?vs=95809&id=96152#toc
Repository:
rL LLVM
https://reviews.llvm.org/D32234
Fi
Author: d0k
Date: Fri Apr 21 10:51:18 2017
New Revision: 300990
URL: http://llvm.org/viewvc/llvm-project?rev=300990&view=rev
Log:
[Clangd] Support Authority-less URIs
Clangd strips URIs by removing the file:// part but some clients can send file:
which is also valid according to RFC 3896. For exa
bkramer added a comment.
Still looking good. Will commit this soon.
https://reviews.llvm.org/D32234
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malaperle-ericsson added a comment.
Benjamin, I added a test, do you still think it's OK? Thanks!
https://reviews.llvm.org/D32234
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malaperle-ericsson added a comment.
Could you commit it? I don't have commit access :) Thanks!
https://reviews.llvm.org/D32238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bkramer added a comment.
lg from my side. It would be good to wait until Manuel is back though, I think
he had plans for extending this interface at some point.
https://reviews.llvm.org/D32351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: stulova
Date: Fri Apr 21 10:13:24 2017
New Revision: 300988
URL: http://llvm.org/viewvc/llvm-project?rev=300988&view=rev
Log:
[OpenCL] Fix semantic check of ndrange_t for device_side_enqueue.
Check unqualified type for ndrange argument in device_side_enqueue so
device_side_enqueue accept
xazax.hun marked 6 inline comments as done and an inline comment as not done.
xazax.hun added a comment.
In https://reviews.llvm.org/D30691#731617, @zaks.anna wrote:
> I agree that scan-build or scan-build-py integration is an important issue to
> resolve here. What I envision is that users will
jroelofs added inline comments.
Comment at: utils/libcxx/test/config.py:387
+self.config.available_features.add(
+'with_system_cxx_lib=%s' % component)
mehdi_amini wrote:
> jroelofs wrote:
> > Is it worth filtering out `none`
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
https://reviews.llvm.org/D29659
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
gtbercea updated this revision to Diff 96144.
gtbercea added a comment.
Refactor if condition.
Repository:
rL LLVM
https://reviews.llvm.org/D29659
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-offload.c
==
This revision was automatically updated to reflect the committed changes.
Closed by commit rL300985: [clang-format] Replace IncompleteFormat by a struct
with Line (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D32298?vs=96131&id=96141#toc
Repository:
rL LLVM
https
Author: krasimir
Date: Fri Apr 21 09:35:20 2017
New Revision: 300985
URL: http://llvm.org/viewvc/llvm-project?rev=300985&view=rev
Log:
[clang-format] Replace IncompleteFormat by a struct with Line
Summary: This patch replaces the boolean IncompleteFormat that is used to
notify the client if an u
Author: krasimir
Date: Fri Apr 21 09:30:01 2017
New Revision: 300983
URL: http://llvm.org/viewvc/llvm-project?rev=300983&view=rev
Log:
[clang-format] Clang-tidy cleanup of NamespaceEndCommentFixerTest.cpp, NFC
Modified:
cfe/trunk/unittests/Format/NamespaceEndCommentsFixerTest.cpp
Modified: c
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
Comment at: docs/clang-tidy/checks/readability-strlen-argument.rst:6
+
+This checker will detect addition in strlen() argument. Example code:
+
JonasToth
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Sounds good.
https://reviews.llvm.org/D32298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Author: krasimir
Date: Fri Apr 21 09:21:21 2017
New Revision: 300982
URL: http://llvm.org/viewvc/llvm-project?rev=300982&view=rev
Log:
[clang-format] Clang-tidy cleanup of CleanupTest.cpp, NFC
Modified:
cfe/trunk/unittests/Format/CleanupTest.cpp
Modified: cfe/trunk/unittests/Format/CleanupTe
krasimir added inline comments.
Comment at: include/clang/Format/Format.h:1524
+ /// best-effort analysis, and could be imprecise.
+ unsigned Line = 0;
+};
krasimir wrote:
> djasper wrote:
> > Hm. Something we might need to be thinking about here is whether thi
Author: arphaman
Date: Fri Apr 21 09:17:49 2017
New Revision: 300981
URL: http://llvm.org/viewvc/llvm-project?rev=300981&view=rev
Log:
[PR32667] -Wdocumentation should allow @param/@returns for fields/variables
that have a function/block pointer type
This commit improves the -Wdocumentation warni
krasimir created this revision.
Herald added a subscriber: klimek.
This field is never assigned to and it's only ever read from libclang.
This patch removes it and adapts libclang to return constants.
https://reviews.llvm.org/D32351
Files:
include/clang/Tooling/CompilationDatabase.h
tools/l
hfinkel updated this revision to Diff 96135.
hfinkel retitled this revision from "[TBAASan] A TBAA Sanitizer (Clang)" to
"[TySan] A Type Sanitizer (Clang)".
hfinkel edited the summary of this revision.
hfinkel added a comment.
Rename TBAASanitizer -> TypeSanitizer
https://reviews.llvm.org/D3219
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D32238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
baloghadamsoftware created this revision.
Herald added a subscriber: mgorny.
This is an old checker used only internally until now. The original author is
Bence Babati, I added him as a subscriber.
The checker checks whather exceptions escape the main() function, destructors.
functions with exc
Hi,
Fragmentation of the bots is not ideal. While I totally understand Eric's
reasoning for doing so, and am delighted to see another Windows bot
helping to ensure quality code, I think this is a bit of a slippery slope.
We already have the main Buildbots, Green Dragon, Chapuni's Bots, a myriad
o
krasimir added inline comments.
Comment at: include/clang/Format/Format.h:1524
+ /// best-effort analysis, and could be imprecise.
+ unsigned Line = 0;
+};
djasper wrote:
> Hm. Something we might need to be thinking about here is whether this should
> be the l
krasimir updated this revision to Diff 96131.
krasimir added a comment.
- Refactor tests
https://reviews.llvm.org/D32298
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/UnwrappedLineFormatter.cpp
lib/Format/UnwrappedLineFormatter.h
test/Format/incomplete.cpp
to
emilio updated this revision to Diff 96130.
emilio added a comment.
Full diff, thanks @arphaman :)
https://reviews.llvm.org/D32348
Files:
clang/test/Index/print-type.cpp
clang/tools/libclang/CXType.cpp
Index: clang/tools/libclang/CXType.cpp
krasimir updated this revision to Diff 96129.
krasimir marked 5 inline comments as done.
krasimir added a comment.
- Changed IncompleteFormat to FormatComplete
https://reviews.llvm.org/D32298
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/UnwrappedLineFormatter.cpp
yamaguchi updated this revision to Diff 96128.
yamaguchi added a comment.
Modified README.txt.
I thought its good to specify where the html is.
https://reviews.llvm.org/D32342
Files:
docs/CMakeLists.txt
docs/README.txt
docs/doxygen.cfg.in
Index: docs/doxygen.cfg.in
==
arphaman added a comment.
Please post the diff with full context (git diff -U).
Repository:
rL LLVM
https://reviews.llvm.org/D32348
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
emilio created this revision.
emilio added a project: clang-c.
This allows us to see the default template parameters too.
This is a regression in clang 4.0, so uplifting to a dot release would be neat
(but not required, I guess).
The regression was caused by https://reviews.llvm.org/D26663.
Fi
yamaguchi updated this revision to Diff 96124.
yamaguchi retitled this revision from "Fixed llvm/CMakeLists.txt which doesn't
generate proper MakeFiles and added relative path to llvm doxygen" to "Changed
llvm/CMakeLists.txt and added relative path to llvm doxygen".
yamaguchi added a comment.
Ed
On Fri, Apr 21, 2017 at 01:49:24PM +0100, Alex L wrote:
> Hi,
>
> On 21 April 2017 at 12:55, Emilio Cobos Álvarez via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> > This allows us to get the default template parameters too.
> >
> > This patch was submitted also as https://reviews.llvm.o
sanwou01 added a comment.
Thanks for your comments Reid. Please find my responses inline. I'll spin a new
patch addressing your comments soonish.
Comment at: include/clang/Basic/SourceLocation.h:336
+ bool hasManager() const { return SrcMgr != nullptr; }
/// \pre This Fu
Hi,
On 21 April 2017 at 12:55, Emilio Cobos Álvarez via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> This allows us to get the default template parameters too.
>
> This patch was submitted also as https://reviews.llvm.org/D31732, but I
> see no
> reference to it in cfe-commits or llvm-commi
1 - 100 of 125 matches
Mail list logo
