jroelofs added inline comments.
================ Comment at: utils/libcxx/test/config.py:387 + self.config.available_features.add( + 'with_system_cxx_lib=%s' % component) ---------------- mehdi_amini wrote: > jroelofs wrote: > > Is it worth filtering out `none` and `unknown`, as they're often repeated, > > and you can't tell which part of the triple they came from? > > > > Consider: `arm-none-linux-gnueabi` vs `arm-none-none-eabi`. > > > > Or would it be better to include some marker in the features to say which > > part of the triple it came from, eg: > > > > ``` > > - with_system_cxx_lib=arch:arm > > - with_system_cxx_lib=vendor:none > > - with_system_cxx_lib=os:linux > > - with_system_cxx_lib=sys:gnueabi > > ``` > I like this idea! > It seems like orthogonal to the availability introduced here, so it'd belong > to a separate patch I think. sounds fine to me! https://reviews.llvm.org/D31739 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
