xiangzhai updated this revision to Diff 95273.
xiangzhai added a comment.
Hi All,
I have updated my patch as your suggestion, please review it, thanks a lot!
Regards,
Leslie Zhai
Repository:
rL LLVM
https://reviews.llvm.org/D31868
Files:
lib/StaticAnalyzer/Checkers/CStringChecker.cpp
t
chenwj added a comment.
Ping? :-)
https://reviews.llvm.org/D32014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added a comment.
Those test changes are smaller than I thought they might be; great.
https://reviews.llvm.org/D32029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kubamracek updated this revision to Diff 95271.
kubamracek added a comment.
Trying a different approach: Keeping the loop variable alive for the whole
loop by extending ForScope and registering the cleanup function inside
EmitAutoVarAlloca.
https://reviews.llvm.org/D32029
Files:
lib/CodeGe
kzhuravl added inline comments.
Comment at: lib/Basic/Targets.cpp:2114
+ static bool hasFullSpeedFMA(StringRef GPUName) {
+return parseAMDGCNName(GPUName) >= GK_GFX9;
arsenm wrote:
> arsenm wrote:
> > FMAF32?
> Actually this also needs to specify full spee
This revision was automatically updated to reflect the committed changes.
kzhuravl marked 2 inline comments as done.
Closed by commit rL300306: [AMDGPU][GFX9] Set +fp32-denormals for >=gfx900
unless -cl-denorms-are-zero is… (authored by kzhuravl).
Changed prior to commit:
https://reviews.llvm.o
Author: kzhuravl
Date: Fri Apr 14 00:33:57 2017
New Revision: 300306
URL: http://llvm.org/viewvc/llvm-project?rev=300306&view=rev
Log:
[AMDGPU][GFX9] Set +fp32-denormals for >=gfx900 unless -cl-denorms-are-zero is
set
Differential Revision: https://reviews.llvm.org/D31482
Added:
cfe/trunk/t
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for the cleanup ;)
Repository:
rL LLVM
https://reviews.llvm.org/D32063
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
hokein added inline comments.
Comment at: clang-tidy/performance/InefficientVectorOperationCheck.cpp:109-111
+ auto AllVectorVarRefs = utils::decl_ref_expr::allDeclRefExprs(
+ *VectorVarDecl, *LoopParent, *Result.Context);
+ for (const auto *Ref : AllVectorVarRefs) {
-
hokein updated this revision to Diff 95269.
hokein marked an inline comment as done.
hokein added a comment.
Explicit the type.
https://reviews.llvm.org/D31757
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientVectorOperationCheck.cpp
clang-tidy/performance/In
kubamracek reopened this revision.
kubamracek added a comment.
This revision is now accepted and ready to land.
Reverted because this fails for-in.m by crashing the compiler when compiling:
void t2(NSArray *array) {
for (NSArray *array in array) { // expected-warning {{collection expression
Author: davidxl
Date: Thu Apr 13 23:14:29 2017
New Revision: 300304
URL: http://llvm.org/viewvc/llvm-project?rev=300304&view=rev
Log:
Fix use after free error
Modified:
cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp
Modified: cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp
URL:
http://llvm.org/v
Could you confirm if it is right fix?
On Fri, Apr 14, 2017 at 12:29 PM NAKAMURA Takumi via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: chapuni
> Date: Thu Apr 13 22:16:48 2017
> New Revision: 300303
>
> URL: http://llvm.org/viewvc/llvm-project?rev=300303&view=rev
> Log:
> clang/tes
Author: chapuni
Date: Thu Apr 13 22:16:48 2017
New Revision: 300303
URL: http://llvm.org/viewvc/llvm-project?rev=300303&view=rev
Log:
clang/test/CoverageMapping/unused_names.c: Relax an expression for targeting
PECOFF.
Modified:
cfe/trunk/test/CoverageMapping/unused_names.c
Modified: cfe/tr
Author: davidxl
Date: Thu Apr 13 22:01:25 2017
New Revision: 300301
URL: http://llvm.org/viewvc/llvm-project?rev=300301&view=rev
Log:
Remove unused function /nfc
Modified:
cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp
Modified: cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp
URL:
http://llvm.or
Does anyone know what it would take to get the slow unwinder to work on Darwin?
thanks,
vedant
> On Apr 13, 2017, at 6:59 PM, Vedant Kumar via cfe-commits
> wrote:
>
> Author: vedantk
> Date: Thu Apr 13 20:59:44 2017
> New Revision: 300295
>
> URL: http://llvm.org/viewvc/llvm-project?rev=3002
Author: rsmith
Date: Thu Apr 13 21:04:44 2017
New Revision: 300296
URL: http://llvm.org/viewvc/llvm-project?rev=300296&view=rev
Log:
Remove empty test directory for nonexistent standard clause.
Removed:
cfe/trunk/test/CXX/garbage.collection/
___
cf
Author: vedantk
Date: Thu Apr 13 20:59:44 2017
New Revision: 300295
URL: http://llvm.org/viewvc/llvm-project?rev=300295&view=rev
Log:
[docs] UBSan: Mention that print_stacktrace=1 is unsupported on Darwin
Printing out stack traces along with UBSan diagnostics is unsupported on
Darwin. That's beca
dexonsmith added reviewers: hfinkel, rsmith.
dexonsmith added a comment.
+Hal and Richard, a couple of possible reviewers.
https://reviews.llvm.org/D31856
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
eugenis updated this revision to Diff 95254.
eugenis retitled this revision from "[asan] Disable ASan global-GC depending on
the target and CGOpts" to "[asan] Disable ASan global-GC depending on the
target and compiler flags".
Repository:
rL LLVM
https://reviews.llvm.org/D32064
Files:
lib/
Author: kuba.brecka
Date: Thu Apr 13 20:00:03 2017
New Revision: 300290
URL: http://llvm.org/viewvc/llvm-project?rev=300290&view=rev
Log:
Revert r300287.
Modified:
cfe/trunk/lib/CodeGen/CGObjC.cpp
cfe/trunk/test/CodeGenObjC/arc-foreach.m
cfe/trunk/test/CodeGenObjC/arc-ternary-op.m
M
This revision was automatically updated to reflect the committed changes.
Closed by commit rL300287: [ObjC] Fix lifetime markers of loop variable in
EmitObjCForCollectionStmt (authored by kuba.brecka).
Changed prior to commit:
https://reviews.llvm.org/D32029?vs=95157&id=95251#toc
Repository:
Author: kuba.brecka
Date: Thu Apr 13 19:32:43 2017
New Revision: 300287
URL: http://llvm.org/viewvc/llvm-project?rev=300287&view=rev
Log:
[ObjC] Fix lifetime markers of loop variable in EmitObjCForCollectionStmt
CodeGenFunction::EmitObjCForCollectionStmt currently emits lifetime markers for
the
yamaguchi added a comment.
I don't have a commit access. Can you commit?
https://reviews.llvm.org/D31591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pcc added a comment.
I think it would be better to move this logic to the driver and have it pass in
an `-mllvm` flag. The sanitizer passes should really be taking no arguments in
the constructor like the other passes, so I don't want us to add another
argument here.
Repository:
rL LLVM
ht
Author: gbiv
Date: Thu Apr 13 18:47:08 2017
New Revision: 300283
URL: http://llvm.org/viewvc/llvm-project?rev=300283&view=rev
Log:
Fix PR31934: forming refs to functions with enable_if attrs.
Modified:
cfe/trunk/lib/Sema/SemaInit.cpp
cfe/trunk/test/SemaCXX/enable_if.cpp
Modified: cfe/tru
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Yes, looks good to me.
Repository:
rL LLVM
https://reviews.llvm.org/D32029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
Author: davidxl
Date: Thu Apr 13 18:37:21 2017
New Revision: 300279
URL: http://llvm.org/viewvc/llvm-project?rev=300279&view=rev
Log:
[Profile] PE binary coverage bug fix
PR/32584
Differential Revision: https://reviews.llvm.org/D32023
Modified:
cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp
eugenis added a comment.
From a quick look at the code, it seems like -fno-data-sections on COFF would
suppress GC of globals the same as on ELF. Is that true?
Repository:
rL LLVM
https://reviews.llvm.org/D32064
___
cfe-commits mailing list
cfe-
kubamracek added a comment.
Note that C++ foreach loops also generate lifetime.start and lifetime.end
inside of the loop body.
Repository:
rL LLVM
https://reviews.llvm.org/D32029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
eugenis created this revision.
The linux part is a bit ahead of time - the instrumentation code where this
matters have not landed yet. But when it does, this would be the right
condition, and for now ELF instrumentation simply ignores this setting.
Repository:
rL LLVM
https://reviews.llvm.
alexshap created this revision.
alexshap created this object with visibility "All Users".
This diff removes unnecessary using of unique_ptr with ClangMoveActionFactory
(pico cleanup).
NFC
Repository:
rL LLVM
https://reviews.llvm.org/D32063
Files:
tool/ClangMoveMain.cpp
Index: tool/Clang
Author: rnk
Date: Thu Apr 13 18:12:13 2017
New Revision: 300272
URL: http://llvm.org/viewvc/llvm-project?rev=300272&view=rev
Log:
[IR] Make getParamAttributes take argument numbers, not ArgNo+1
Add hasParamAttribute() and use it instead of hasAttribute(ArgNo+1,
Kind) everywhere.
The fact that th
Author: rsmith
Date: Thu Apr 13 17:44:22 2017
New Revision: 300271
URL: http://llvm.org/viewvc/llvm-project?rev=300271&view=rev
Log:
[docs] Regenerate diagnostics reference.
Modified:
cfe/trunk/docs/DiagnosticsReference.rst
Modified: cfe/trunk/docs/DiagnosticsReference.rst
URL:
http://llvm.
Author: rsmith
Date: Thu Apr 13 17:39:49 2017
New Revision: 300270
URL: http://llvm.org/viewvc/llvm-project?rev=300270&view=rev
Log:
[docs] Fix a couple of typos in command line flag help text and regenerate
documentation.
Modified:
cfe/trunk/docs/ClangCommandLineReference.rst
cfe/trunk/
rsmith added a comment.
The change to test/SemaCXX/anonymous-struct.cpp appeared to be unrelated to the
rest of the patch, so I committed it separately as r300266.
Thank you!
Repository:
rL LLVM
https://reviews.llvm.org/D27263
___
cfe-commits m
Author: rsmith
Date: Thu Apr 13 16:51:04 2017
New Revision: 300266
URL: http://llvm.org/viewvc/llvm-project?rev=300266&view=rev
Log:
Add test for anonymous struct containing an implicitly private data member.
Patch by Jacob Young!
Modified:
cfe/trunk/test/SemaCXX/anonymous-struct.cpp
Modifi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL300264: Diagnose attempt to take address of bitfield members
in anonymous structs. (authored by rsmith).
Changed prior to commit:
https://reviews.llvm.org/D27263?vs=79759&id=95222#toc
Repository:
rL
Author: rsmith
Date: Thu Apr 13 16:49:46 2017
New Revision: 300264
URL: http://llvm.org/viewvc/llvm-project?rev=300264&view=rev
Log:
Diagnose attempt to take address of bitfield members in anonymous structs.
Patch by Jacob Young!
Differential Revision: https://reviews.llvm.org/D27263
Modified:
chenwj added a comment.
I don't have commit access, need someone's help. :-)
https://reviews.llvm.org/D32014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Thu Apr 13 16:37:24 2017
New Revision: 300262
URL: http://llvm.org/viewvc/llvm-project?rev=300262&view=rev
Log:
PR32185: Revert r291512 and add a testcase for PR32185.
This reverts an attempt to check that types match when matching a
dependently-typed non-type template parame
kparzysz updated this revision to Diff 95217.
kparzysz edited the summary of this revision.
kparzysz added a reviewer: hfinkel.
kparzysz added a comment.
Fixed the testcases (forgot to use FileCheck).
Repository:
rL LLVM
https://reviews.llvm.org/D31885
Files:
lib/CodeGen/CGExpr.cpp
lib/C
Author: phosek
Date: Thu Apr 13 16:29:21 2017
New Revision: 300261
URL: http://llvm.org/viewvc/llvm-project?rev=300261&view=rev
Log:
[libcxx] Direct support for Fuchsia
Fuchsia's libc was forked from musl, but has evolved sufficiently
since then so it no longer makes sense to pretend it's musl. T
Author: phosek
Date: Thu Apr 13 16:09:42 2017
New Revision: 300257
URL: http://llvm.org/viewvc/llvm-project?rev=300257&view=rev
Log:
[CMake] Support building Fuchsia toolchain on Darwin
This is already supported on Linux but on Darwin it requires some
extra flags.
Differential Revision: https://
v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
LGTM.
https://reviews.llvm.org/D31591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erik.pilkington added inline comments.
Comment at: include/memory:3606
+template <>
+class _LIBCPP_TEMPLATE_VIS allocator<__shared_ptr_dummy_rebind_allocator_type>
+{
EricWF wrote:
> I would prefer using an entirely different allocator type, not a
> specializati
erik.pilkington updated this revision to Diff 95210.
erik.pilkington added a comment.
This new patch includes @EricWF's static_assert & test.
Thanks,
Erik
https://reviews.llvm.org/D30837
Files:
include/memory
test/libcxx/utilities/memory/util.smartptr/util.smartptr.shared/function_type_def
vsk created this revision.
Clang should look for a default UBSan blacklist in its resource dir.
Depends on https://reviews.llvm.org/D32043.
https://reviews.llvm.org/D32047
Files:
lib/Driver/SanitizerArgs.cpp
test/Driver/Inputs/resource_dir/ubsan_blacklist.txt
test/Driver/fsanitize-blackl
aaron.ballman added inline comments.
Comment at: clang-tidy/performance/InefficientVectorOperationCheck.cpp:95-96
+const MatchFinder::MatchResult &Result) {
+ if (Result.Context->getDiagnostics().hasUncompilableErrorOccurred())
+return;
+
hokein wrote:
>
vsk created this revision.
This patch removes a limitation which causes us to load at most one
default sanitizer blacklist when multiple sanitizers are enabled. E.g if
asan + cfi are enabled, and default blacklists for both sanitizers are
present, we would only load one of the blacklists.
The new
gtbercea updated this revision to Diff 95198.
gtbercea added a comment.
Re-use an already existing flag rather than creating a new one.
Repository:
rL LLVM
https://reviews.llvm.org/D32035
Files:
lib/Frontend/CompilerInvocation.cpp
test/OpenMP/target_messages.cpp
Index: test/OpenMP/targ
erichkeane abandoned this revision.
erichkeane added a comment.
I don't really see a good solution for this, and haven't tried in a while, so
I'll see if I can prep another version of this in the future.
https://reviews.llvm.org/D29401
___
cfe-comm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL300246: [libc++] Add _LIBCPP_DISABLE_EXTERN_TEMPLATE config
option (authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D31725?vs=95189&id=95190#toc
Repository:
rL LLVM
https://r
Author: smeenai
Date: Thu Apr 13 15:13:32 2017
New Revision: 300246
URL: http://llvm.org/viewvc/llvm-project?rev=300246&view=rev
Log:
[libc++] Add _LIBCPP_DISABLE_EXTERN_TEMPLATE config option
When the libc++ extern template macros were added, the intent was for it
to be possible for consumers of
smeenai updated this revision to Diff 95189.
smeenai added a comment.
Add documentation
https://reviews.llvm.org/D31725
Files:
docs/UsingLibcxx.rst
include/__config
Index: include/__config
===
--- include/__config
+++ include
Author: hans
Date: Thu Apr 13 15:09:18 2017
New Revision: 300245
URL: http://llvm.org/viewvc/llvm-project?rev=300245&view=rev
Log:
clang-format-vs licence.txt: drop svn:executable
Not sure how it ended up with that property in the first place.
Modified:
cfe/trunk/tools/clang-format-vs/ClangF
rsmith added inline comments.
Comment at: lib/Serialization/ASTReader.cpp:8487
+std::sort(Comments.begin(), Comments.end(),
+ BeforeThanCompare(SourceMgr));
Context.Comments.addDeserializedComments(Comments);
Does this cause us to deserializ
bruno added a comment.
@rsmith ping!
https://reviews.llvm.org/D31778
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno closed this revision.
bruno added a comment.
Done in r290134
https://reviews.llvm.org/D27546
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno closed this revision.
bruno added a comment.
r291466 & r291517
https://reviews.llvm.org/D27429
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno closed this revision.
bruno added a comment.
Done way back in r248932
Repository:
rL LLVM
https://reviews.llvm.org/D13117
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> On Apr 13, 2017, at 9:50 AM, Reid Kleckner wrote:
>
> Fixed in r300209. Was the -Wslash-u-filename warning not explanatory enough
> to suggest the solution? Maybe we could add a note like "escape source paths
> starting with /U by passing them at the end of the command line after —".
Ah, I
joerg added a comment.
In https://reviews.llvm.org/D31992#725963, @klimek wrote:
> If I understand correctly, that's " and \ for JSON and ", \ and all
> non-printable characters (which unfortunately requires understanding of
> unicode to solve this fully correctly) in YAML.
I'd modify that sl
bruno closed this revision.
bruno added a comment.
Updating: already done in r298175
https://reviews.llvm.org/D29001
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists closed this revision.
mclow.lists added a comment.
committed as revision 300232
https://reviews.llvm.org/D31769
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Thu Apr 13 13:25:32 2017
New Revision: 300232
URL: http://llvm.org/viewvc/llvm-project?rev=300232&view=rev
Log:
Remove the binders from C++17. Reviewed as https://reviews.llvm.org/D31769
Added:
libcxx/trunk/test/libcxx/depr/depr.function.objects/
libcxx/trunk/test/l
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: test/CodeGenOpenCL/lifetime.cl:14
+// AMDGIZ: @llvm.lifetime.start.p5i
+ helper_no_markers();
+}
Check line for the end as well?
https://
Author: hans
Date: Thu Apr 13 13:15:00 2017
New Revision: 300231
URL: http://llvm.org/viewvc/llvm-project?rev=300231&view=rev
Log:
Follow-up to r300225: update ClangFormat.csproj too
Modified:
cfe/trunk/tools/clang-format-vs/ClangFormat/ClangFormat.csproj
Modified: cfe/trunk/tools/clang-form
gtbercea marked 4 inline comments as done.
gtbercea added inline comments.
Comment at: test/Driver/openmp-offload.c:594
+/// Check cubin file generation and usage by nvlink
+// RUN: %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda
-save-temps -no-canonical-pref
bruno abandoned this revision.
bruno added a comment.
This isn't needed anymore.
https://reviews.llvm.org/D25383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gtbercea updated this revision to Diff 95175.
gtbercea added a comment.
Use the rename() utility function of LLVM for renaming the PTXAS output before
invoking NVLINK.
Repository:
rL LLVM
https://reviews.llvm.org/D29654
Files:
lib/Driver/Driver.cpp
lib/Driver/ToolChains/CommonArgs.cpp
hokein added a comment.
Thanks for the comments.
Comment at: clang-tidy/performance/InefficientVectorOperationCheck.cpp:81
+ hasLoopInit(LoopVarInit),
+ hasCondition(binaryOperator(hasOperatorName("<"),
+ hasLHS(RefersToLoo
hokein updated this revision to Diff 95174.
hokein marked 11 inline comments as done.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D31757
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientVectorOperationCheck.cpp
clang-tidy/perform
gtbercea created this revision.
Herald added a subscriber: rengolin.
Throw an error when offloading is unsupported for a particular target
architecture.
Repository:
rL LLVM
https://reviews.llvm.org/D32035
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Frontend/CompilerInvocatio
gtbercea updated this revision to Diff 95171.
gtbercea added a comment.
Remove tests which belong into a different patch.
Repository:
rL LLVM
https://reviews.llvm.org/D29658
Files:
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
Author: hans
Date: Thu Apr 13 12:47:47 2017
New Revision: 300226
URL: http://llvm.org/viewvc/llvm-project?rev=300226&view=rev
Log:
Follow-up to r300225: update ClangFormat.sln to VS2017
This got lost in the previous patch somehow.
Modified:
cfe/trunk/tools/clang-format-vs/ClangFormat.sln
Mo
Author: hans
Date: Thu Apr 13 12:42:45 2017
New Revision: 300225
URL: http://llvm.org/viewvc/llvm-project?rev=300225&view=rev
Log:
Warning-free clang-format plugin install for VS 15.0
With the new release of VS, it's required that all plugins migrate to
the new VSIX manifest format. The new forma
Author: hans
Date: Thu Apr 13 12:37:17 2017
New Revision: 300223
URL: http://llvm.org/viewvc/llvm-project?rev=300223&view=rev
Log:
clang-format-vs: Use a separate license.txt copy
The regular file used to display very poorly in the VSIX installer due
to long lines, wrapping etc.
Added:
cfe/t
jacobly added a comment.
Ping.
https://reviews.llvm.org/D27263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kubamracek created this revision.
kubamracek added a project: Sanitizers.
CodeGenFunction::EmitObjCForCollectionStmt currently emits lifetime markers for
the loop variable in an inconsistent way: `lifetime.start` is emitted before
the loop is entered, but `lifetime.end` is emitted inside the lo
Author: marshall
Date: Thu Apr 13 11:57:42 2017
New Revision: 300218
URL: http://llvm.org/viewvc/llvm-project?rev=300218&view=rev
Log:
Implement LWG#2855 - made easy by previous refactoring
Modified:
libcxx/trunk/include/exception
libcxx/trunk/test/std/language.support/support.exception/
zaks.anna added a comment.
Thanks!!!
Comment at: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:965
+
+// Performing operator `&' on an lvalue expression is essentially a no-op.
+// Then, if we are taking addresses of fields or elements, these are also
Fixed in r300209. Was the -Wslash-u-filename warning not explanatory enough
to suggest the solution? Maybe we could add a note like "escape source
paths starting with /U by passing them at the end of the command line after
--".
/Users/buildslave/jenkins/sharedspace/phase1@2/llvm/tools/clang/test/D
Author: rnk
Date: Thu Apr 13 11:36:28 2017
New Revision: 300214
URL: http://llvm.org/viewvc/llvm-project?rev=300214&view=rev
Log:
Use the clang-cl recognized spelling of --target=
This fixes a warning. The test was passing without this change.
Modified:
cfe/trunk/test/Driver/fsanitize.c
Mod
Author: rnk
Date: Thu Apr 13 11:32:26 2017
New Revision: 300209
URL: http://llvm.org/viewvc/llvm-project?rev=300209&view=rev
Log:
Re-land "[clang-cl] Make all sanitizer flags available in clang-cl"
Adding RUN lines with %clang_cl was causing these tests to fail on Mac
because absolute paths there
Author: smeenai
Date: Thu Apr 13 11:27:38 2017
New Revision: 300206
URL: http://llvm.org/viewvc/llvm-project?rev=300206&view=rev
Log:
[libc++] Explicitly set output directory for DLL
DLLs on Windows are treated as runtime targets. Explicitly set the
output directory for them, to be consistent wit
mgorny abandoned this revision.
mgorny added a comment.
https://reviews.llvm.org/D31864 covered all that was needed for Gentoo, and I
lack the knowledge to push the full split properly forward.
https://reviews.llvm.org/D25157
___
cfe-commits mailin
alexfh added inline comments.
Comment at: docs/clang-tidy/checks/misc-unused-parameters.rst:15
+
+ void a(int /*i*/) {}
+
sylvestre.ledru wrote:
> alexfh wrote:
> > nit: two spaces before the comment.
> I believe it is the case ?
> I stole this from the unit t
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Yay! This is going to fix some really confusing false positives.LGTM with
Gabor's comments addressed.
One note. I am not a big fan of using clang_analyzer_explain() in tests for
functio
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Looks good
https://reviews.llvm.org/D32014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
arphaman created this revision.
This is useful for "go to definition" feature for an IDE like Xcode. Consider
the following example:
template
struct Traits {
using EncodedAs = void; // 1
};
template<>
struct Traits {
using EncodedAs = int; // 2
};
This change will allow
Hahnfeld added a comment.
Is there a way to actually test the changed code? The current test changes seem
unrelated...
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:165-166
"The target '%0' is not a supported OpenMP host target.">;
+def err_drv_omp_device_target_
gtbercea updated this revision to Diff 95126.
gtbercea added a comment.
Fix.
Repository:
rL LLVM
https://reviews.llvm.org/D29660
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-offload.c
Author: marshall
Date: Thu Apr 13 09:41:45 2017
New Revision: 300197
URL: http://llvm.org/viewvc/llvm-project?rev=300197&view=rev
Log:
Refactor throw_with_nested. NFC.
Modified:
libcxx/trunk/include/exception
Modified: libcxx/trunk/include/exception
URL:
http://llvm.org/viewvc/llvm-project/
yaxunl added a comment.
In https://reviews.llvm.org/D31167#725705, @mehdi_amini wrote:
> I believe considering the goal of moving to using per-instruction FMF and
> kills the global backend option, this leads to a bitcode upgrade issue:
> OpenCL (or other) bitcode that were generated bitcode do
chenwj created this revision.
Herald added subscribers: rengolin, aemerson.
The Result variable is unused both in Sema::CheckARMBuiltinFunctionCall and
Sema::CheckAArch64BuiltinFunctionCall, remove it.
https://reviews.llvm.org/D32014
Files:
lib/Sema/SemaChecking.cpp
Index: lib/Sema/SemaChe
klimek added a comment.
In https://reviews.llvm.org/D31992#725912, @malaperle-ericsson wrote:
> In https://reviews.llvm.org/D31992#725866, @krasimir wrote:
>
> > Seems that we're starting to hit some YAML/JSON mismatches, or is it that
> > your YAML string support is lacking?
>
>
> I don't think
aaron.ballman added inline comments.
Comment at: clang-tidy/performance/InefficientVectorOperationCheck.cpp:81
+ hasLoopInit(LoopVarInit),
+ hasCondition(binaryOperator(hasOperatorName("<"),
+ hasLHS(RefersToLoopVar),
---
klimek added inline comments.
Comment at: clangd/Protocol.cpp:26-50
+ for (llvm::StringRef::iterator i = Input.begin(), e = Input.end(); i != e;
++i) {
+if (*i == '\\')
+ EscapedInput += "";
+else if (*i == '"')
+ EscapedInput += "\\\"";
+// bell
+
malaperle-ericsson added a comment.
In https://reviews.llvm.org/D31992#725913, @joerg wrote:
> I'm strongly against this patch. Can you give an actual test case for the
> problematic behavior?
Sure I can add a test. If you meant more real work scenario, you can juste type
"é" in VS Code and i
1 - 100 of 125 matches
Mail list logo
