Author: rsmith Date: Thu Apr 13 16:49:46 2017 New Revision: 300264 URL: http://llvm.org/viewvc/llvm-project?rev=300264&view=rev Log: Diagnose attempt to take address of bitfield members in anonymous structs.
Patch by Jacob Young! Differential Revision: https://reviews.llvm.org/D27263 Modified: cfe/trunk/lib/Sema/SemaExpr.cpp cfe/trunk/test/Sema/expr-address-of.c cfe/trunk/test/SemaCXX/ptrtomember.cpp Modified: cfe/trunk/lib/Sema/SemaExpr.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=300264&r1=300263&r2=300264&view=diff ============================================================================== --- cfe/trunk/lib/Sema/SemaExpr.cpp (original) +++ cfe/trunk/lib/Sema/SemaExpr.cpp Thu Apr 13 16:49:46 2017 @@ -1772,7 +1772,10 @@ Sema::BuildDeclRefExpr(ValueDecl *D, Qua !Diags.isIgnored(diag::warn_arc_repeated_use_of_weak, E->getLocStart())) recordUseOfEvaluatedWeak(E); - if (FieldDecl *FD = dyn_cast<FieldDecl>(D)) { + FieldDecl *FD = dyn_cast<FieldDecl>(D); + if (IndirectFieldDecl *IFD = dyn_cast<IndirectFieldDecl>(D)) + FD = IFD->getAnonField(); + if (FD) { UnusedPrivateFields.remove(FD); // Just in case we're building an illegal pointer-to-member. if (FD->isBitField()) Modified: cfe/trunk/test/Sema/expr-address-of.c URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/expr-address-of.c?rev=300264&r1=300263&r2=300264&view=diff ============================================================================== --- cfe/trunk/test/Sema/expr-address-of.c (original) +++ cfe/trunk/test/Sema/expr-address-of.c Thu Apr 13 16:49:46 2017 @@ -102,8 +102,9 @@ char* f7() { register struct {char* x;} t1 = {"Hello"}; char* dummy1 = &(t1.x[0]); - struct {int a : 10;} t2; + struct {int a : 10; struct{int b : 10;};} t2; int* dummy2 = &(t2.a); // expected-error {{address of bit-field requested}} + int* dummy3 = &(t2.b); // expected-error {{address of bit-field requested}} void* t3 = &(*(void*)0); } Modified: cfe/trunk/test/SemaCXX/ptrtomember.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/ptrtomember.cpp?rev=300264&r1=300263&r2=300264&view=diff ============================================================================== --- cfe/trunk/test/SemaCXX/ptrtomember.cpp (original) +++ cfe/trunk/test/SemaCXX/ptrtomember.cpp Thu Apr 13 16:49:46 2017 @@ -13,9 +13,13 @@ int foo(int S::* ps, S *s) struct S2 { int bitfield : 1; + struct { + int anon_bitfield : 1; + }; }; int S2::*pf = &S2::bitfield; // expected-error {{address of bit-field requested}} +int S2::*anon_pf = &S2::anon_bitfield; // expected-error {{address of bit-field requested}} struct S3 { void m(); _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
