majnemer added inline comments.
Comment at: lib/CodeGen/CGCoroutine.cpp:85
+ unsigned No = 0;
+ const char* AwaitKindStr = 0;
+ switch (Kind) {
I'd use a StringRef here.
https://reviews.llvm.org/D30809
___
cfe-c
GorNishanov marked 4 inline comments as done.
GorNishanov added inline comments.
Comment at: lib/CodeGen/CGCoroutine.cpp:32
struct CGCoroData {
+ AwaitKind CurrentAwaitKind = AwaitKind::Init;
majnemer wrote:
> Shouldn't this struct be in an anonymous namespac
GorNishanov updated this revision to Diff 91486.
GorNishanov added a comment.
Addressed review feedback
- clang-format three functions in CGExprScalar.cpp
- got rid of AwaitKindStr array and select appropriate string in the switch
statement in buildAwaitKindPrefix
https://reviews.llvm.org/D308
majnemer added inline comments.
Comment at: lib/CodeGen/CGCoroutine.cpp:26
+enum class AwaitKind { Init, Normal, Yield, Final };
+char const *AwaitKindStr[] = {"init", "await", "yield", "final"};
+}
I'd move this into buildSuspendSuffixStr.
Com
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D30841#698634, @fgross wrote:
> I just assumed it would traverse in the "right" way, is there any
> documentation about AST / matcher traversal?
I do not kn
mati865 added a subscriber: asl.
mati865 added a comment.
@asl it is still not commited.
Something went wrong?
Repository:
rL LLVM
https://reviews.llvm.org/D29772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
In addition to that: If I remember correctly, -fms-extensions is only
enabled if your triple's OS is win32 and your triple's environment is MSVC.
It's not enabled when targeting MinGW for example. The reason it's enabled
with an foo-windows-msvc triple is that it's required to parse the system's
he
Hi Zahira,
-fms-extensions can obviously be disabled with -fno-ms-extensions. This
won't necessarily mirrors /Za exactly, though -- as according to MS, /Za
disables *all* C++ extensions, not only MS-specific ones. I doubt anyone
tried to implement a mode that mirrors /Za exactly.
Yours,
Andrey
--
rsmith added a comment.
Functionally, this looks good. How do the diagnostics look in the case where
lookup only finds a non-namespace name? Eg,
struct A { struct B {}; };
namespace X = A::B;
https://reviews.llvm.org/D30848
___
cfe-commits mai
amaiorano added a comment.
In https://reviews.llvm.org/D29221#688697, @hans wrote:
> >>> My only nit is that I'd prefer "clang-format" instead of "ClangFormat".
> >>>
> >>> Manuel: the menu options under Tools currently say "Clang Format
> >>> {Selection,Document}". What do you think about usin
GorNishanov added a comment.
+ @majnemer who is most familiar with LLVM Coroutines representation.
https://reviews.llvm.org/D30809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna added a comment.
Correct, this will suppress some valid warnings that occur due to user errors
and valid warnings coming from the standard library.
However, I believe this is the right choice right now since we know that the
analyzer is not currently effective in understanding invaria
zaks.anna added a comment.
Thank you!
Repository:
rL LLVM
https://reviews.llvm.org/D30593
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fgross updated this revision to Diff 91473.
fgross added a comment.
Replaced std::map with llvm::DenseMap, added comment about traversal.
I just assumed it would traverse in the "right" way, is there any documentation
about AST / matcher traversal?
https://reviews.llvm.org/D30841
Files:
cla
GorNishanov accepted this revision.
GorNishanov added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D30859
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
kastiglione added a comment.
Thanks @malcolm.parsons. I don't have commit access, will you be able to commit
this?
https://reviews.llvm.org/D30854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
EricWF updated this revision to Diff 91468.
EricWF added a comment.
- Remove unused diagnostics about `set_exception` and `current_exception`.
https://reviews.llvm.org/D30859
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaCoroutine.c
idlecode updated this revision to Diff 91466.
idlecode added a comment.
Addressed Alexander's comments
https://reviews.llvm.org/D30748
Files:
lib/Lex/Lexer.cpp
unittests/Lex/LexerTest.cpp
Index: unittests/Lex/LexerTest.cpp
===
idlecode marked 3 inline comments as done.
idlecode added inline comments.
Comment at: lib/Lex/Lexer.cpp:457
+static bool isNewLineEscaped(const char *BufferStart, const char *Str) {
+ while (Str > BufferStart && isWhitespace(*Str))
+--Str;
alexfh wrote:
> W
sylvestre.ledru created this revision.
no functional changes
https://reviews.llvm.org/D30863
Files:
docs/tools/dump_ast_matchers.py
docs/tools/dump_format_style.py
Index: docs/tools/dump_format_style.py
===
--- docs/tools/dump
sylvestre.ledru added inline comments.
Comment at: docs/tools/dump_format_style.py:67
def __str__(self):
-return '* ``%s`` %s' % (self.name, doxygen2rst(self.comment))
+return '\n* ``%s`` %s' % (self.name, doxygen2rst(self.comment))
This is needed to
sylvestre.ledru created this revision.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D30860
Files:
docs/ClangFormatStyleOptions.rst
docs/tools/dump_format_style.py
include/clang/Format/Format.h
Index: include/clang/Format/Format.h
=
EricWF created this revision.
Herald added a subscriber: mehdi_amini.
This patch adopts the recent changes that renamed
`set_exception(exception_pointer)` to `unhandled_exception()`.
Additionally `unhandled_exception()` is now required, and so an error is
emitted when exceptions are enabled but
mgorny added inline comments.
Comment at: tools/clang-format/git-clang-format:306
+try:
+return to_string(bytes.decode('utf-8'))
+except AttributeError: # 'str' object has no attribute 'decode'.
EricWF wrote:
> mgorny wrote:
> > EricWF wrote:
> >
xazax.hun added a comment.
Functionally LGTM!
Note that while the traversal of AST Matchers are not defined in general, in
this particular case of chained ifs, it is guaranteed that parent nodes will be
matched before the child nodes. For this reason I think it is ok to have a
state like this.
EricWF updated this revision to Diff 91456.
EricWF added a comment.
- Rewrite `to_string` for clarities sake.
https://reviews.llvm.org/D30773
Files:
tools/clang-format/git-clang-format
Index: tools/clang-format/git-clang-format
EricWF added inline comments.
Comment at: tools/clang-format/git-clang-format:306
+try:
+return to_string(bytes.decode('utf-8'))
+except AttributeError: # 'str' object has no attribute 'decode'.
mgorny wrote:
> EricWF wrote:
> > mgorny wrote:
> >
mgorny added a comment.
I'm sorry, I've completely forgot that the path contains version number. In
this case, it indeed probably doesn't make much sense to add rpath for that.
https://reviews.llvm.org/D30733
___
cfe-commits mailing list
cfe-commit
joerg added a comment.
Installing libc++ along clang makes a lot of sense for non-system compilers. It
doesn't imply any version locking like in GCC, i.e. you are still free to
install whatever version of libunwind and libc++ you want. I'm somewhat
conflicted about this patch. I think it is an
29 matches
Mail list logo
