idlecode marked 3 inline comments as done. idlecode added inline comments.
================ Comment at: lib/Lex/Lexer.cpp:457 +static bool isNewLineEscaped(const char *BufferStart, const char *Str) { + while (Str > BufferStart && isWhitespace(*Str)) + --Str; ---------------- alexfh wrote: > We only care about two specific sequences here: `\\\r\n` or `\\\n`, not a > backslash followed by arbitrary whitespace. I just saw that some functions (e.g. line 1285 in this file) accept whitespaces between escape character and new line. How about now? https://reviews.llvm.org/D30748 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits