[PATCH] D28451: [AVR] Add support for the 'interrupt' and 'naked' attributes

dylanmckay updated this revision to Diff 87365. dylanmckay marked 4 inline comments as done. dylanmckay added a comment. Remove 'Attr.setInvalid()' https://reviews.llvm.org/D28451 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td lib/CodeGen/TargetInfo.cpp lib/Sema/Sema

[PATCH] D28451: [AVR] Add support for the 'interrupt' and 'naked' attributes

dylanmckay added inline comments. Comment at: test/CodeGen/avr/attributes/interrupt.c:3 + +// CHECK: define void @foo() #0 +__attribute__((interrupt)) void foo(void) { } aaron.ballman wrote: > dylanmckay wrote: > > aaron.ballman wrote: > > > As should this. > > I

[PATCH] D29267: [clang-tidy] safety-no-assembler

jbcoe marked an inline comment as done. jbcoe added inline comments. Comment at: clang-tools-extra/clang-tidy/safety/NoAssemblerCheck.cpp:13 +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include "clang/Lex/Lexer.h" + Eugene.Zelenko wrote: > aaron.ballman wrote

[clang-tools-extra] r294283 - [clang-tidy] Cleanup of no-assembler check

Author: jbcoe Date: Tue Feb 7 00:19:38 2017 New Revision: 294283 URL: http://llvm.org/viewvc/llvm-project?rev=294283&view=rev Log: [clang-tidy] Cleanup of no-assembler check Address outstanding comments from https://reviews.llvm.org/D29267 Modified: clang-tools-extra/trunk/clang-tidy/safety

[PATCH] D29267: [clang-tidy] safety-no-assembler

jbcoe added a comment. @aaron.ballman I will address post-approval comments post-commit. Repository: rL LLVM https://reviews.llvm.org/D29267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D26949: [libc++abi] Clean up visibility

smeenai added inline comments. Comment at: src/abort_message.cpp:25 -#pragma GCC visibility push(hidden) - EricWF wrote: > Is this really redundant? There is an `#include ` > after it. Is this not going to affect those symbols? That's a fair point. I think it'

[PATCH] D26949: [libc++abi] Clean up visibility

smeenai updated this revision to Diff 87362. smeenai edited the summary of this revision. smeenai added a comment. Addressing comments https://reviews.llvm.org/D26949 Files: include/__cxxabi_config.h src/abort_message.cpp src/abort_message.h src/cxa_exception.cpp src/cxa_exception.hpp

[PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

bmharper updated this revision to Diff 87361. bmharper added a comment. This looks a lot better IMO. Thanks @daphnediane - you should recognize the code ;) The special closing paren logic inside of nestingAndIndentLevel() is indeed redundant now. https://reviews.llvm.org/D21279 Files: lib/F

[PATCH] D29162: AMDGPU: Add a test checking alignments of emitted globals/allocas

arsenm closed this revision. arsenm added a comment. r294278 https://reviews.llvm.org/D29162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r294278 - AMDGPU: Add a test checking alignments of emitted globals/allocas

Author: arsenm Date: Mon Feb 6 22:28:02 2017 New Revision: 294278 URL: http://llvm.org/viewvc/llvm-project?rev=294278&view=rev Log: AMDGPU: Add a test checking alignments of emitted globals/allocas Make sure the spec required type alignments are used in preparation for a possible change which ma

Buildbot numbers for the week of 01/22/2017 - 01/28/2017

Hello everyone, Below are some buildbot numbers for the week of 01/22/2017 - 01/28/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

buildbot numbers for the week of 01/15/2017 - 01/21/2017

Hello everyone, Below are some buildbot numbers for the week of 01/15/2017 - 01/21/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

LLBM master is back to work

LLBM master is back to work now. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29545: Driver: Do not link safestack with --whole-archive.

This revision was automatically updated to reflect the committed changes. Closed by commit rL294274: Driver: Do not link safestack with --whole-archive. (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D29545?vs=87106&id=87358#toc Repository: rL LLVM https://reviews.llvm

r294274 - Driver: Do not link safestack with --whole-archive.

Author: pcc Date: Mon Feb 6 21:21:57 2017 New Revision: 294274 URL: http://llvm.org/viewvc/llvm-project?rev=294274&view=rev Log: Driver: Do not link safestack with --whole-archive. This allows it to be used with the other sanitizers. Differential Revision: https://reviews.llvm.org/D29545 Modif

Re: LLVM buildmaster is unavailable due to power outage in our area

It does not make much difference but it's ATT network outage not power. Thanks Galina On Mon, Feb 6, 2017 at 6:19 PM, Galina Kistanova wrote: > Hello everyone, > > LLVM buildmaster is unavailable currently due to power outage in our area. > Thank you for understanding. > > Thanks > > Galina >

[libcxx] r294270 - filesystem: return the constructed object

Author: compnerd Date: Mon Feb 6 20:46:59 2017 New Revision: 294270 URL: http://llvm.org/viewvc/llvm-project?rev=294270&view=rev Log: filesystem: return the constructed object This really should get identified properly by the compiler to convert to a NVRO, but compress the code anyways. This ma

LLVM buildmaster is unavailable due to power outage in our area

Hello everyone, LLVM buildmaster is unavailable currently due to power outage in our area. Thank you for understanding. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r294266 - P0091R3: Implement basic parsing support for C++17 deduction-guides.

Author: rsmith Date: Mon Feb 6 19:37:30 2017 New Revision: 294266 URL: http://llvm.org/viewvc/llvm-project?rev=294266&view=rev Log: P0091R3: Implement basic parsing support for C++17 deduction-guides. We model deduction-guides as functions with a new kind of name that identifies the template who

[PATCH] D26654: [CMake] Add Fuchsia toolchain CMake cache files

phosek updated this revision to Diff 87339. Repository: rL LLVM https://reviews.llvm.org/D26654 Files: cmake/caches/Fuchsia-stage2.cmake cmake/caches/Fuchsia.cmake Index: cmake/caches/Fuchsia.cmake === --- /dev/null +++ cmake

[PATCH] D29530: [ubsan] Reduce null checking of C++ object pointers (PR27581)

vsk updated this revision to Diff 87334. vsk edited the summary of this revision. vsk added a comment. @arphaman thank you for the feedback! Per Alex's comments: - Add test for explicit use of the 'this' pointer. - Handle cases where the 'this' pointer may be casted (implicitly, or otherwise).

Re: r294177 - [AVR] Allow specifying the CPU on the command line

No problem - thanks for reverting this. I'll fix up the patch and re-commit later today. On Tue, Feb 7, 2017 at 12:47 AM, Diana Picus via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Dylan, > > I reverted this in r294180 because I think it broke some of the > buildbots. See for example

[PATCH] D29267: [clang-tidy] safety-no-assembler

aaron.ballman added a comment. There were review comments still outstanding when you commit the patch. Can you please address those post-commit? Repository: rL LLVM https://reviews.llvm.org/D29267 ___ cfe-commits mailing list cfe-commits@lists.l

[clang-tools-extra] r294255 - [clang-tidy] safety-no-assembler

Author: jbcoe Date: Mon Feb 6 16:57:14 2017 New Revision: 294255 URL: http://llvm.org/viewvc/llvm-project?rev=294255&view=rev Log: [clang-tidy] safety-no-assembler Summary: Add a new clang-tidy module for safety-critical checks. Include a check for inline assembler. Reviewers: Prazek, dtarditi

[PATCH] D29267: [clang-tidy] safety-no-assembler

This revision was automatically updated to reflect the committed changes. Closed by commit rL294255: [clang-tidy] safety-no-assembler (authored by jbcoe). Changed prior to commit: https://reviews.llvm.org/D29267?vs=87207&id=87314#toc Repository: rL LLVM https://reviews.llvm.org/D29267 Files

[PATCH] D21626: Lit C++11 Compatibility Patch #10

tigerleapgorge updated this revision to Diff 87312. tigerleapgorge added a comment. Remove 2 tests reviewed under https://reviews.llvm.org/D29520. https://reviews.llvm.org/D21626 Files: test/Modules/Inputs/merge-using-decls/a.h test/Modules/Inputs/merge-using-decls/b.h test/Modules/merge-

[PATCH] D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used

mgorny updated this revision to Diff 87311. mgorny added a comment. Removed the i386 branch. Now the i486+ are used unconditionally. https://reviews.llvm.org/D29542 Files: lib/Basic/Targets.cpp test/CodeGen/atomic-ops.c test/CodeGen/ms-volatile.c test/CodeGenCXX/atomicinit.cpp test/Se

[PATCH] D20710: Lit C++11 Compatibility Patch #9

tigerleapgorge updated this revision to Diff 87309. tigerleapgorge added a comment. 2 tests have been reviewed in https://reviews.llvm.org/D29520 They are: implicit-virtual-member-functions.cpp and virtual-member-functions.cpp Remove these from this patch. https://reviews.llvm.org/D20710 Files:

Re: [libcxx] r294138 - Adjust Linux ABI list after r294133

The diff here is huge compared to the Apple one (r294139). Did the file format change and this file was previously not updated? This makes it hard to merge the change. Can you advise on how to generate this file or how to do the same change on 4.0? On Sun, Feb 5, 2017 at 12:14 PM, Eric Fiselier

Re: [libcxx] r294133 - Change the base class of std::bad_optional_access. This is a (subtle) ABI change, and is in response to http://http://wg21.link/LWG2806, which I *expect* to be adopted in Kona.

I've merged this, together with your r294142, to 4.0 in r294249, as requested. If I understand correctly, we should also merge Eric's follow-ups r294138 and r294139, but I get merge conflicts for the Linux one so I've asked about how to handle that. Thanks, Hans On Sun, Feb 5, 2017 at 12:06 PM,

[libcxx] r294249 - Merging r294133 and r294142:

Author: hans Date: Mon Feb 6 15:59:19 2017 New Revision: 294249 URL: http://llvm.org/viewvc/llvm-project?rev=294249&view=rev Log: Merging r294133 and r294142: r294133 | marshall | 2017-02-05 12:06:38 -0800 (Sun, 05 Feb 2017)

[PATCH] D29267: [clang-tidy] safety-no-assembler

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/safety/NoAssemblerCheck.cpp:13 +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include "clang/Lex/Lexer.h" + aaron.ballman wrote: > Is this include needed? Will be good idea to run In

[PATCH] D29151: [clang-tidy] Add misc-invalidated-iterators check.

Prazek added a comment. In https://reviews.llvm.org/D29151#668197, @zaks.anna wrote: > > I tried to come up with some advice on where checks should go in > > http://clang.llvm.org/extra/clang-tidy/#choosing-the-right-place-for-your-check > > The guidelines stated on the clang-tidy page seem reas

[PATCH] D29151: [clang-tidy] Add misc-invalidated-iterators check.

zaks.anna added a comment. > I tried to come up with some advice on where checks should go in > http://clang.llvm.org/extra/clang-tidy/#choosing-the-right-place-for-your-check The guidelines stated on the clang-tidy page seem reasonable to me. > For example, IMO, AST-based analyses make more se

[PATCH] D29267: [clang-tidy] safety-no-assembler

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/safety/NoAssemblerCheck.cpp:13 +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include "clang/Lex/Lexer.h" + Is this include needed? Comment at: clang-tools-extra/cl

[PATCH] D29221: clang-format-vsix: "format on save" feature

amaiorano added a comment. Hello! Just a small ping to see if anyone has taken a look at this change? I fully understand that everyone's really busy, but perhaps you can recommend another reviewer? Or if you're presently giving this change a whirl, just let me know! Cheers :) https://reviews.

[PATCH] D29267: [clang-tidy] safety-no-assembler

idlecode accepted this revision. idlecode added a comment. This revision is now accepted and ready to land. Sure, but I don't have commit rights so someone else have to push it :) https://reviews.llvm.org/D29267 ___ cfe-commits mailing list cfe-comm

[PATCH] D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used

efriedma added a comment. I think you're running into https://llvm.org/bugs/show_bug.cgi?id=31620 . https://reviews.llvm.org/D29542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used

dim added a comment. There's still something strange here. If I compile the following on i386-freebsd12, with `clang -march=i486 -O2 -S`: _Atomic(long long) ll; void f(void) { ++ll; } the result is: .globl f .p2align4, 0x90 .type f,@function

[PATCH] D29520: Lit C++11 Compatibility - Microsoft diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rL294225: [Lit Test] Make tests C++11 compatible - Microsoft diagnostics (authored by lcharles). Changed prior to commit: https://reviews.llvm.org/D29520?vs=87044&id=87274#toc Repository: rL LLVM http

r294225 - [Lit Test] Make tests C++11 compatible - Microsoft diagnostics

Author: lcharles Date: Mon Feb 6 13:32:38 2017 New Revision: 294225 URL: http://llvm.org/viewvc/llvm-project?rev=294225&view=rev Log: [Lit Test] Make tests C++11 compatible - Microsoft diagnostics Differential Revision: https://reviews.llvm.org/D29520 Modified: cfe/trunk/test/SemaCXX/Micros

[PATCH] D29599: Clang Changes for alloc_align

erichkeane added a comment. Requires this LLVM commit: https://reviews.llvm.org/D29598 https://reviews.llvm.org/D29599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29599: Clang Changes for alloc_align

erichkeane created this revision. GCC has the alloc_align attribute, which is similar to assume_aligned, except the attribute's parameter is the index of the integer parameter that needs aligning to. https://reviews.llvm.org/D29599 Files: include/clang/Basic/Attr.td include/clang/Basic/At

[PATCH] D29267: [clang-tidy] safety-no-assembler

jbcoe added a comment. @idlecode please can you approve if it LGTY? https://reviews.llvm.org/D29267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28299: Module: use PCMCache to manage memory buffers for pcm files.

dexonsmith requested review of this revision. dexonsmith added a comment. This has changed enough it needs another review. Richard or Ben, could you take a(nother) look? https://reviews.llvm.org/D28299 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used

jlebar added a comment. > Well, the thing is, we don't call HostTarget->setCPU() before this function. > We just call AllocateTarget(), and it does not set the CPU. Ah, got it. LGTM for the nvptx changes. https://reviews.llvm.org/D29542 ___ cfe-c

[PATCH] D28299: Module: use PCMCache to manage memory buffers for pcm files.

dexonsmith updated this revision to Diff 87257. dexonsmith added a comment. Herald added subscribers: mgorny, nemanjai. Rebased on top of the current https://reviews.llvm.org/D27689. This also has some substantive changes: - Renamed the data structure PCMCache to MemoryBufferCache, and split it

[PATCH] D29520: Lit C++11 Compatibility - Microsoft diagnostics

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D29520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28299: Module: use PCMCache to manage memory buffers for pcm files.

dexonsmith commandeered this revision. dexonsmith edited reviewers, added: manmanren; removed: dexonsmith. dexonsmith added a comment. Taking this over to rebase it. https://reviews.llvm.org/D28299 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D27689: Module: hash the pcm content and use it as SIGNATURE for implicit modules.

dexonsmith updated this revision to Diff 87256. dexonsmith added a comment. Rebased past r293123, which filled in diagnostic pragma records for modules. I've moved the DIAG_PRAGMA_MAPPINGS to the unhashed block, as suggested by Richard, so the tests now pass. Richard, can you take a look? ht

r294207 - [CMake] Add CLANG_INCLUDE_DIRS to CMake exports

Author: cbieneman Date: Mon Feb 6 12:17:23 2017 New Revision: 294207 URL: http://llvm.org/viewvc/llvm-project?rev=294207&view=rev Log: [CMake] Add CLANG_INCLUDE_DIRS to CMake exports This patch adds setting CLANG_INCLUDE_DIRS in the generated CMake package configuration files. Modified: cf

[PATCH] D25267: cmake: Set CMAKE_INSTALL_RPATH in Clang when building separately from LLVM

plevine abandoned this revision. plevine added a comment. Fixed with rL285714 . https://reviews.llvm.org/D25267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D28451: [AVR] Add support for the 'interrupt' and 'naked' attributes

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:5137 + if (!checkAttributeNumArgs(S, Attr, 0)) { +Attr.setInvalid(); +return; No need to call `Attr.setInvalid()` here or below. Comment at: test/CodeGen/avr/at

[PATCH] D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used

ahatanak added inline comments. Comment at: lib/Basic/Targets.cpp:4244 +} else // allow locked atomics up to 4 bytes + MaxAtomicPromoteWidth = 32; + } mgorny wrote: > ahatanak wrote: > > mgorny wrote: > > > dim wrote: > > > > Are you purposefully not se

[PATCH] D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used

mgorny added inline comments. Comment at: lib/Basic/Targets.cpp:4244 +} else // allow locked atomics up to 4 bytes + MaxAtomicPromoteWidth = 32; + } ahatanak wrote: > mgorny wrote: > > dim wrote: > > > Are you purposefully not setting `MaxAtomicInlineWi

[PATCH] D28835: [coroutines] NFC: Refactor Sema::CoroutineBodyStmt construction.

GorNishanov added a comment. Gentle and melodic ping. https://reviews.llvm.org/D28835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used

ahatanak added inline comments. Comment at: lib/Basic/Targets.cpp:4244 +} else // allow locked atomics up to 4 bytes + MaxAtomicPromoteWidth = 32; + } mgorny wrote: > dim wrote: > > Are you purposefully not setting `MaxAtomicInlineWidth` here? (It seem

[PATCH] D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used

joerg added a comment. Generic should imply i486+. I don't think any general purpose system supports i386 at this point, simply because it has an annoying number of bugs in critical components. The i486 (esp. the non-crippled ones) are reasonable easy to support and there are still people aroun

[PATCH] D16135: Macro Debug Info support in Clang

aprantl added a comment. Few more inline comments. I think the code itself is looking good now. Why doesn't this patch include any test cases? I would have expected some that exercise the command line include handling, etc., ... Comment at: lib/CodeGen/MacroPPCallbacks.h:35 +

[PATCH] D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used

mgorny added a comment. In https://reviews.llvm.org/D29542#667814, @joerg wrote: > At this point, I don't think there is any use on pretending that > i386-as-default makes sense. So I would request that the i386 case should be > made explicit or just dropped, with a preference for the latter.

[PATCH] D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used

mgorny added inline comments. Comment at: lib/Basic/Targets.cpp:1808 +if (HostTriple.getArch() == llvm::Triple::x86) + HostTarget->setCPU("i586"); + jlebar wrote: > mgorny wrote: > > jlebar wrote: > > > Okay, is this still needed now? > > Yes. I've speci

[PATCH] D28445: [Analyzer] Extend taint propagation and checking

vlad.tsyrklevich updated this revision to Diff 87237. vlad.tsyrklevich marked 4 inline comments as done. vlad.tsyrklevich added a comment. As Artem mentioned, I reworked `getLCVSymbol()` to get the default bindings directly from the StoreManager which required adding a new method. I also reverte

[PATCH] D29267: [clang-tidy] safety-no-assembler

aaron.ballman added a comment. In https://reviews.llvm.org/D29267#667487, @alexfh wrote: > I wonder whether there's a compiler diagnostic for this purpose. Compiler > diagnostics are more efficient at reaching users and should be preferred > where they are appropriate (this seems like one of su

r294197 - [SystemZ] Provide predefined __ARCH__ and __VX__ macros

Author: uweigand Date: Mon Feb 6 11:04:22 2017 New Revision: 294197 URL: http://llvm.org/viewvc/llvm-project?rev=294197&view=rev Log: [SystemZ] Provide predefined __ARCH__ and __VX__ macros GCC 7 will predefine two new macros on s390x: - __ARCH__ indicates the ISA architecture level - __VX__ in

[PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

daphnediane added a comment. In https://reviews.llvm.org/D21279#667471, @bmharper wrote: > Thanks @daphnediane. I only read your comment after merging, but that would > have been helpful. If you still want my diff let me know as it is slightly different from yours. No longer has NestingAndInd

[PATCH] D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used

joerg added a comment. At this point, I don't think there is any use on pretending that i386-as-default makes sense. So I would request that the i386 case should be made explicit or just dropped, with a preference for the latter. https://reviews.llvm.org/D29542 _

[PATCH] D29162: AMDGPU: Add a test checking alignments of emitted globals/allocas

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks! https://reviews.llvm.org/D29162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used

jlebar added inline comments. Comment at: lib/Basic/Targets.cpp:1808 +if (HostTriple.getArch() == llvm::Triple::x86) + HostTarget->setCPU("i586"); + mgorny wrote: > jlebar wrote: > > Okay, is this still needed now? > Yes. I've specifically tested with it

[PATCH] D29162: AMDGPU: Add a test checking alignments of emitted globals/allocas

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D29162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D29162: AMDGPU: Add a test checking alignments of emitted globals/allocas

arsenm added a comment. ping https://reviews.llvm.org/D29162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r294195 - [OpenMP] Remove fixme comment in regression test and related unnecessary statement

Author: cbertol Date: Mon Feb 6 10:03:41 2017 New Revision: 294195 URL: http://llvm.org/viewvc/llvm-project?rev=294195&view=rev Log: [OpenMP] Remove fixme comment in regression test and related unnecessary statement https://reviews.llvm.org/D29501 It looks like I forgot to remove a FIXME comme

[libcxx] r294194 - Add some tests to verify that we implement LWG#2837 correctly. No functional change.

Author: marshall Date: Mon Feb 6 10:03:23 2017 New Revision: 294194 URL: http://llvm.org/viewvc/llvm-project?rev=294194&view=rev Log: Add some tests to verify that we implement LWG#2837 correctly. No functional change. Modified: libcxx/trunk/test/std/numerics/numeric.ops/numeric.ops.gcd/gcd

[clang-tools-extra] r294193 - [clang-tidy] misc-argument-comment support for gmock

Author: alexfh Date: Mon Feb 6 09:47:17 2017 New Revision: 294193 URL: http://llvm.org/viewvc/llvm-project?rev=294193&view=rev Log: [clang-tidy] misc-argument-comment support for gmock Now for real. The use case supported previously is used by approximately nobody. What's needed is support for m

[clang-tools-extra] r294192 - [clang-tidy] getPreviousNonCommentToken -> getPreviousToken

Author: alexfh Date: Mon Feb 6 09:46:33 2017 New Revision: 294192 URL: http://llvm.org/viewvc/llvm-project?rev=294192&view=rev Log: [clang-tidy] getPreviousNonCommentToken -> getPreviousToken Modified: clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang

[libcxx] r294190 - Fix a typo - extra '>'

Author: marshall Date: Mon Feb 6 09:29:03 2017 New Revision: 294190 URL: http://llvm.org/viewvc/llvm-project?rev=294190&view=rev Log: Fix a typo - extra '>' Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm-pr

[PATCH] D24933: Enable configuration files in clang

sepavloff marked 2 inline comments as done. sepavloff added inline comments. Comment at: lib/Driver/ToolChain.cpp:183 std::string Target; - if (llvm::TargetRegistry::lookupTarget(Prefix, IgnoredError)) { + if (!VerifyTarget || llvm::TargetRegistry::lookupTarget(Prefix, Igno

[PATCH] D24933: Enable configuration files in clang

sepavloff updated this revision to Diff 87229. sepavloff added a comment. Herald added a subscriber: klimek. Updated patch https://reviews.llvm.org/D24933 Files: docs/UsersManual.rst include/clang/Basic/DiagnosticDriverKinds.td include/clang/Config/config.h.cmake include/clang/Driver/Dr

[libcxx] r294189 - Set up 'upcoming meeting' bug list

Author: marshall Date: Mon Feb 6 09:17:22 2017 New Revision: 294189 URL: http://llvm.org/viewvc/llvm-project?rev=294189&view=rev Log: Set up 'upcoming meeting' bug list Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/vi

[PATCH] D20689: [clang-tidy] Suspicious Call Argument checker

xazax.hun added a comment. I think this might be better as a readability checker to find misleading variable or parameter names. It would also be great to consider types. Unfortunately it probably means reimplementing some of the logic from Sema, since that information is not available at this

[PATCH] D28768: [clang-tidy] Add check 'modernize-return-braced-init-list'

JDevlieghere updated this revision to Diff 87228. JDevlieghere added a comment. - Add explicit check to matcher as suggested by @aaron.ballman Repository: rL LLVM https://reviews.llvm.org/D28768 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp cla

[PATCH] D29451: Add a prototype for clangd v0.1

bkramer updated this revision to Diff 87226. bkramer marked 8 inline comments as done. bkramer added a comment. Address review comments. Make test actually run (missing cmake file) https://reviews.llvm.org/D29451 Files: CMakeLists.txt clangd/CMakeLists.txt clangd/ClangDMain.cpp clangd/D

[PATCH] D29451: Add a prototype for clangd v0.1

bkramer marked 19 inline comments as done. bkramer added a comment. In https://reviews.llvm.org/D29451#667606, @arphaman wrote: > This might be a bad question, but is there any particular reason why you > didn't use the YAML Traits API for parsing instead of the raw YAML Stream > API? In my exp

[PATCH] D23423: [Clang-tidy] Comparison Function Address

xazax.hun added a comment. Hi Benedek, could you do the merge or should anybody commandeer these revisions? Repository: rL LLVM https://reviews.llvm.org/D23423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D23421: [Clang-tidy] CERT-MSC53-CPP (checker for std namespace modification)

xazax.hun added a comment. Benedek, do you have time to address the review comments or do you want me to commandeer this revision? Repository: rL LLVM https://reviews.llvm.org/D23421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] [clang-format]: Add support for changing case/default indent/outdent with clang-format

Hi all, First time submitting a patch here. Any feedback is appreciated. This proposed patch adds a new configuration option CaseLabelOffset for clang-format which behaves similarly to AccessModifierOffset. Namely, it permits modifying the indent/outdent of case and default labels. With ind

[PATCH] D29267: [clang-tidy] safety-no-assembler

idlecode added a comment. LGTM. HIC++ Standard seems worth implementing. https://reviews.llvm.org/D29267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r294177 - [AVR] Allow specifying the CPU on the command line

Hi Dylan, I reverted this in r294180 because I think it broke some of the buildbots. See for example http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15/builds/3599 http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/2271 Sorry, Diana On 6 February 2017 at 10:07, Dylan McKay

r294180 - Revert "[AVR] Allow specifying the CPU on the command line"

Author: rovka Date: Mon Feb 6 05:35:42 2017 New Revision: 294180 URL: http://llvm.org/viewvc/llvm-project?rev=294180&view=rev Log: Revert "[AVR] Allow specifying the CPU on the command line" This reverts commit r294177. It seems to have broken some buildbots. Removed: cfe/trunk/test/CodeGen

[PATCH] D29267: [clang-tidy] safety-no-assembler

JonasToth added a comment. In https://reviews.llvm.org/D29267#667614, @jbcoe wrote: > @alexfh Can we defer moving this to a compiler diagnostic? I'm keen to get a > target in place for people to write more safety checks. +1 from me :) and assembler might be bad style, but is it worth a warnin

[PATCH] D29267: [clang-tidy] safety-no-assembler

jbcoe added a comment. @alexfh Can we defer moving this to a compiler diagnostic? I'm keen to get a target in place for people to write more safety checks. https://reviews.llvm.org/D29267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D29530: [ubsan] Reduce null checking of C++ object pointers (PR27581)

arphaman added a comment. I feel like you should have at least one statement in the test that uses explicit 'this' to access a field/method. Does your patch handle fields/methods in base classes as well? I think 'this' might be implicitly converted in the base of the member expression. Also, w

[PATCH] D29451: Add a prototype for clangd v0.1

arphaman added a comment. This might be a bad question, but is there any particular reason why you didn't use the YAML Traits API for parsing instead of the raw YAML Stream API? In my experience the traits based API is quite convenient for structured data like various options and parameters in

[PATCH] D24703: [clang-format] BreakBeforeBinaryOperations and AlignAfterOpenBracket conflict, bug 30304

djasper closed this revision. djasper added a comment. Submitted as r294179. Sorry I missed this before. https://reviews.llvm.org/D24703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

r294179 - clang-format: Fix bug with conflicting BreakBeforeBinaryOperations and AlignAfterOpenBracket

Author: djasper Date: Mon Feb 6 04:55:49 2017 New Revision: 294179 URL: http://llvm.org/viewvc/llvm-project?rev=294179&view=rev Log: clang-format: Fix bug with conflicting BreakBeforeBinaryOperations and AlignAfterOpenBracket Fix for the formatting options combination of BreakBeforeBinaryOperat

[PATCH] D29267: [clang-tidy] safety-no-assembler

JonasToth added a comment. alright :) https://reviews.llvm.org/D29267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29267: [clang-tidy] safety-no-assembler

jbcoe added a comment. @JonasToth My main intention with this patch is to provide such a starting point. A few people have mentioned that they'd be keen to contribute checks. https://reviews.llvm.org/D29267 ___ cfe-commits mailing list cfe-commits@

[PATCH] D29267: [clang-tidy] safety-no-assembler

JonasToth added a comment. out of curiousity: i would like to contribute to the safety module as well. but currently there is no starting point in master. is there a way to get some code that i can start with? I think the module file where the registration happens would be enough. this is not s

[PATCH] D29267: [clang-tidy] safety-no-assembler

jbcoe marked an inline comment as done. jbcoe added inline comments. Comment at: clang-tools-extra/clang-tidy/safety/NoAssemblerCheck.cpp:32 + + diag(ASM->getAsmLoc(), "'%0' is an inline assembler statement") << SourceText; +} aaron.ballman wrote: > The diagnos

[PATCH] D29267: [clang-tidy] safety-no-assembler

jbcoe updated this revision to Diff 87207. jbcoe marked an inline comment as done. jbcoe added a comment. Improve diagnostic message. Find other sorts of inline assembler. Minor fixes for other review comments. https://reviews.llvm.org/D29267 Files: clang-tools-extra/clang-tidy/CMakeLists.tx

Re: r294008 - [Sema][ObjC++] Typo correction should handle ivars and properties

Thanks! On 3 February 2017 at 22:34, Hans Wennborg wrote: > Thanks! r294059. > > On Fri, Feb 3, 2017 at 2:29 PM, Richard Smith > wrote: > > It looks like the only cases it should have any real impact on are those > > where we would previously miscompile/crash, so this seems OK to me to > merge

  1   2   >