[libcxx] r289367 - Actually re-disable -Wsign-compare

2016-12-10 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Dec 10 23:54:43 2016 New Revision: 289367 URL: http://llvm.org/viewvc/llvm-project?rev=289367&view=rev Log: Actually re-disable -Wsign-compare Modified: libcxx/trunk/test/libcxx/test/config.py Modified: libcxx/trunk/test/libcxx/test/config.py URL: http://llvm.org/vi

[libcxx] r289366 - Re-disable -Wsign-compare for now. I didn't catch all occurrences

2016-12-10 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Dec 10 23:45:55 2016 New Revision: 289366 URL: http://llvm.org/viewvc/llvm-project?rev=289366&view=rev Log: Re-disable -Wsign-compare for now. I didn't catch all occurrences Modified: libcxx/trunk/test/libcxx/test/config.py Modified: libcxx/trunk/test/libcxx/test/con

[libcxxabi] r289365 - Fix signed comparison warning

2016-12-10 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Dec 10 23:43:20 2016 New Revision: 289365 URL: http://llvm.org/viewvc/llvm-project?rev=289365&view=rev Log: Fix signed comparison warning Modified: libcxxabi/trunk/test/uncaught_exceptions.pass.cpp Modified: libcxxabi/trunk/test/uncaught_exceptions.pass.cpp URL: htt

Re: r289019 - [c++1z] P0003R5: Removing dynamic exception specifications.

2016-12-10 Thread Eric Fiselier via cfe-commits
No worries. There were also some libc++ test failures for the same reason. These have also been addressed. /Eric On Sat, Dec 10, 2016 at 9:51 PM, Richard Smith wrote: > Thanks Eric! > > On 10 Dec 2016 5:58 pm, "Eric Fiselier via cfe-commits" < > cfe-commits@lists.llvm.org> wrote: > > To others

Re: r289019 - [c++1z] P0003R5: Removing dynamic exception specifications.

2016-12-10 Thread Richard Smith via cfe-commits
Thanks Eric! On 10 Dec 2016 5:58 pm, "Eric Fiselier via cfe-commits" < cfe-commits@lists.llvm.org> wrote: To others who follow the libc++abi test failures back to this commit: The unwind_* failures have been addressed in r289353 by using -Wno-dynamic-exception-spec to suppress the C++17 behavior

r289361 - [CrashReproducer] Setup a module collector callback for HeaderInclude

2016-12-10 Thread Bruno Cardoso Lopes via cfe-commits
Author: bruno Date: Sat Dec 10 22:27:31 2016 New Revision: 289361 URL: http://llvm.org/viewvc/llvm-project?rev=289361&view=rev Log: [CrashReproducer] Setup a module collector callback for HeaderInclude Collect missing include that cannot be fetched otherwise (e.g. when using headermaps). rdar://

r289360 - [CrashReproducer] Collect headermap files

2016-12-10 Thread Bruno Cardoso Lopes via cfe-commits
Author: bruno Date: Sat Dec 10 22:27:28 2016 New Revision: 289360 URL: http://llvm.org/viewvc/llvm-project?rev=289360&view=rev Log: [CrashReproducer] Collect headermap files Include headermaps (.hmap files) in the .cache directory and add VFS entries. All headermaps are known after HeaderSearch s

[libcxx] r289359 - Fix copy/paste errors introduced in r289358

2016-12-10 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Dec 10 22:00:26 2016 New Revision: 289359 URL: http://llvm.org/viewvc/llvm-project?rev=289359&view=rev Log: Fix copy/paste errors introduced in r289358 Modified: libcxx/trunk/test/std/containers/associative/multimap/multimap.special/non_member_swap.pass.cpp libcx

[libcxx] r289358 - Fix undefined behavior in container swap tests.

2016-12-10 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Dec 10 21:41:12 2016 New Revision: 289358 URL: http://llvm.org/viewvc/llvm-project?rev=289358&view=rev Log: Fix undefined behavior in container swap tests. These swap tests were swapping non-POCS non-equal allocators which is undefined behavior. This patch changes the tes

[libcxx] r289357 - Fix yet another dynamic exception spec

2016-12-10 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Dec 10 20:49:37 2016 New Revision: 289357 URL: http://llvm.org/viewvc/llvm-project?rev=289357&view=rev Log: Fix yet another dynamic exception spec Modified: libcxx/trunk/test/std/thread/thread.threads/thread.thread.class/thread.thread.constr/F.pass.cpp Modified: li

[libcxx] r289356 - Fix more uses of dynamic exception specifications in C++17

2016-12-10 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Dec 10 20:47:36 2016 New Revision: 289356 URL: http://llvm.org/viewvc/llvm-project?rev=289356&view=rev Log: Fix more uses of dynamic exception specifications in C++17 Modified: libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_

[libcxx] r289355 - Fix count_new.hpp to work w/o dynamic exception specifications

2016-12-10 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Dec 10 20:20:17 2016 New Revision: 289355 URL: http://llvm.org/viewvc/llvm-project?rev=289355&view=rev Log: Fix count_new.hpp to work w/o dynamic exception specifications Modified: libcxx/trunk/test/support/count_new.hpp Modified: libcxx/trunk/test/support/count_new.

Re: r289019 - [c++1z] P0003R5: Removing dynamic exception specifications.

2016-12-10 Thread Eric Fiselier via cfe-commits
To others who follow the libc++abi test failures back to this commit: The unwind_* failures have been addressed in r289353 by using -Wno-dynamic-exception-spec to suppress the C++17 behavior (for now). Currently the libc++ and libc++abi test suite run using -std=c++1z unless otherwise specified.

[libcxxabi] r289353 - Workaround the removal of dynamic exception specifications in C++17

2016-12-10 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Dec 10 19:35:55 2016 New Revision: 289353 URL: http://llvm.org/viewvc/llvm-project?rev=289353&view=rev Log: Workaround the removal of dynamic exception specifications in C++17 Modified: libcxxabi/trunk/test/libcxxabi/test/config.py Modified: libcxxabi/trunk/test/libc

r289351 - [AVX-512] Remove masking from 512-bit vpermil builtins. The backend now has versions without masking so wrap it with select.

2016-12-10 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Dec 10 19:26:52 2016 New Revision: 289351 URL: http://llvm.org/viewvc/llvm-project?rev=289351&view=rev Log: [AVX-512] Remove masking from 512-bit vpermil builtins. The backend now has versions without masking so wrap it with select. This will allow the backend to consta

[libcxx] r289347 - [libc++] Fix support for multibyte thousands_sep and decimal_point in moneypunct_byname and numpunct_byname.

2016-12-10 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Dec 10 18:20:59 2016 New Revision: 289347 URL: http://llvm.org/viewvc/llvm-project?rev=289347&view=rev Log: [libc++] Fix support for multibyte thousands_sep and decimal_point in moneypunct_byname and numpunct_byname. Summary: The underlying C locales provide the `thousan

r289345 - [AVX-512] Remove masking from 512-bit pshufb builtin. The backend now has a version without masking so wrap it with select.

2016-12-10 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Dec 10 17:09:52 2016 New Revision: 289345 URL: http://llvm.org/viewvc/llvm-project?rev=289345&view=rev Log: [AVX-512] Remove masking from 512-bit pshufb builtin. The backend now has a version without masking so wrap it with select. This will allow the backend to constan

r289338 - [AVX-512] Remove 128/256-bit masked vpermilvar builtins and replace with select and the avx unmasked builtins.

2016-12-10 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Dec 10 14:27:39 2016 New Revision: 289338 URL: http://llvm.org/viewvc/llvm-project?rev=289338&view=rev Log: [AVX-512] Remove 128/256-bit masked vpermilvar builtins and replace with select and the avx unmasked builtins. Modified: cfe/trunk/include/clang/Basic/Builtin

Re: [PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

2016-12-10 Thread Aaron Ballman via cfe-commits
I'll need a few days. I am on vacation until the 15th and have limited Internet access. I can do post commit review if this can't wait that long. -Aaron On Dec 7, 2016 9:07 PM, "David Majnemer via Phabricator" < revi...@reviews.llvm.org> wrote: majnemer added a comment. This LGTM but Aaron shou

r289328 - Simplify parseShowColorsArgs logic, NFC.

2016-12-10 Thread Yaron Keren via cfe-commits
Author: yrnkrn Date: Sat Dec 10 08:55:14 2016 New Revision: 289328 URL: http://llvm.org/viewvc/llvm-project?rev=289328&view=rev Log: Simplify parseShowColorsArgs logic, NFC. Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp URL:

Re: r289308 - [clang-format] Another attempt at python 3 compatibility

2016-12-10 Thread Nico Weber via cfe-commits
Shouldn't this at least use >=? (But it feels like there is probably a way that doesn't have to do UA sniffing, so to speak) On Dec 9, 2016 8:04 PM, "Vedant Kumar via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > Author: vedantk > Date: Fri Dec 9 18:54:13 2016 > New Revision: 289308 > > UR

[PATCH] D27123: Add AVR target and toolchain to Clang

2016-12-10 Thread Dylan McKay via Phabricator via cfe-commits
dylanmckay added inline comments. Comment at: lib/Basic/Targets.cpp:8543 + case llvm::Triple::avr: +return new AVRTargetInfo(Triple, Opts); case llvm::Triple::bpfeb: If we build clang without `LLVM_EXPERIMENTAL_TARGETS_TO_BUILD=AVR`, how will this work?

Re: [PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

2016-12-10 Thread Mads Ravn via cfe-commits
Hi guys, Do you have any extra comments for this? Best regards On Sat, Dec 3, 2016 at 1:34 PM Mads Ravn via Phabricator < revi...@reviews.llvm.org> wrote: > madsravn updated this revision to Diff 80177. > madsravn added a comment. > > Did as comments suggested: Fixed the description about compa

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and &s to the right

2016-12-10 Thread Ken-Patrick Lehrmann via Phabricator via cfe-commits
KP created this revision. KP added a reviewer: djasper. KP added a subscriber: cfe-commits. Herald added a subscriber: klimek. With AlignConsecutiveDeclarations and PointerAlignment: Right *s and &s were left dangling. For instance const char* const* v1; float const* v2; SomeVeryLongType