Hi guys, Do you have any extra comments for this?
Best regards On Sat, Dec 3, 2016 at 1:34 PM Mads Ravn via Phabricator < revi...@reviews.llvm.org> wrote: > madsravn updated this revision to Diff 80177. > madsravn added a comment. > > Did as comments suggested: Fixed the description about compare returning > -1, 0 or 1. Fixed the ast matcher to only find compare with one argument. > Clang-formatted everything. Added a new test (str.compare("foo")) and wrote > a FIXME for the fixit. > > > https://reviews.llvm.org/D27210 > > Files: > clang-tidy/misc/CMakeLists.txt > clang-tidy/misc/MiscTidyModule.cpp > clang-tidy/misc/StringCompareCheck.cpp > clang-tidy/misc/StringCompareCheck.h > docs/ReleaseNotes.rst > docs/clang-tidy/checks/list.rst > docs/clang-tidy/checks/misc-string-compare.rst > test/clang-tidy/misc-string-compare.cpp > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits