NoQ added a comment.
Chatted about this a bit more. Because `CallEvent` is an API designed mostly
for convenience, and `ProgramState` is a core API that needs to stay as clean
and separate from other entities and easy to understand as possible, it would
be the best to
1. construct a `CallEvent
ahatanak added inline comments.
Comment at: lib/Sema/SemaStmt.cpp:1165
if (!hasCasesNotInSwitch)
SS->setAllEnumCasesCovered();
This function used to call setAllEnumCasesCovered() when parsing a switch
statement with an opaque enum condition, bu
zaks.anna accepted this revision.
zaks.anna added a comment.
Looks great!
Thank you.
https://reviews.llvm.org/D26768
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: chapuni
Date: Thu Dec 1 23:09:21 2016
New Revision: 288478
URL: http://llvm.org/viewvc/llvm-project?rev=288478&view=rev
Log:
clang/test/Driver/defsym.s: Appease targeting msc. It is incapable of external
assembler in trunk.
Modified:
cfe/trunk/test/Driver/defsym.s
Modified: cfe/tru
anemet created this revision.
anemet added reviewers: hfinkel, mehdi_amini.
anemet added a subscriber: cfe-commits.
This is to match the behavior of non-LTO; when -fsave-optmization-record
is passed and PGO is available we enable the generation of hotness
information in the optimization records.
Zeson added a comment.
In https://reviews.llvm.org/D27251#610629, @kbarton wrote:
> Please make explicit the signed for the parameters to the functions you are
> changing and remove unnecessary casts. I marked the first few that I found,
> but stopped marking them after the first several.
I t
Author: tstellar
Date: Thu Dec 1 21:45:52 2016
New Revision: 288469
URL: http://llvm.org/viewvc/llvm-project?rev=288469&view=rev
Log:
Creating release candidate rc2 from release_391 branch
Added:
libcxx/tags/RELEASE_391/rc2/ (props changed)
- copied from r288468, libcxx/branches/rele
Author: tstellar
Date: Thu Dec 1 21:46:03 2016
New Revision: 288476
URL: http://llvm.org/viewvc/llvm-project?rev=288476&view=rev
Log:
Creating release candidate rc2 from release_391 branch
Added:
libunwind/tags/RELEASE_391/rc2/ (props changed)
- copied from r288475, libunwind/branche
Author: tstellar
Date: Thu Dec 1 21:45:53 2016
New Revision: 288470
URL: http://llvm.org/viewvc/llvm-project?rev=288470&view=rev
Log:
Creating release candidate rc2 from release_391 branch
Added:
libcxxabi/tags/RELEASE_391/rc2/ (props changed)
- copied from r288469, libcxxabi/branche
flx added a comment.
Do you have any more comments, Alex?
https://reviews.llvm.org/D27187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Zeson updated this revision to Diff 80021.
Zeson marked 3 inline comments as done.
Zeson added a comment.
Remove some unnecessary cast
https://reviews.llvm.org/D27251
Files:
lib/Headers/altivec.h
test/CodeGen/builtins-ppc-altivec.c
test/CodeGen/builtins-ppc-p8vector.c
test/CodeGen/built
Author: rsmith
Date: Thu Dec 1 20:06:53 2016
New Revision: 288457
URL: http://llvm.org/viewvc/llvm-project?rev=288457&view=rev
Log:
Update implementation of ABI support for throwing noexcept function pointers
and catching as non-noexcept to match the final design per discusson on
cxx-abi-dev.
Mo
Author: jhen
Date: Thu Dec 1 20:04:43 2016
New Revision: 288453
URL: http://llvm.org/viewvc/llvm-project?rev=288453&view=rev
Log:
[CUDA] Fix faulty test from rL288448
Summary:
The test introduced by rL288448 is currently failing because
unimportant but unexpected errors appear as output from a t
Author: rsmith
Date: Thu Dec 1 20:02:23 2016
New Revision: 288452
URL: http://llvm.org/viewvc/llvm-project?rev=288452&view=rev
Log:
p0012r1: define corresponding feature test macro
Modified:
cfe/trunk/lib/Frontend/InitPreprocessor.cpp
cfe/trunk/test/Lexer/cxx-features.cpp
Modified: cfe/
jlebar added a comment.
Thank you very much for the reviews, @alexfh.
https://reviews.llvm.org/D27284
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jhen updated this revision to Diff 80012.
jhen added a comment.
- Switch to more specific error
https://reviews.llvm.org/D27328
Files:
test/Driver/cuda-no-sanitizers.cu
Index: test/Driver/cuda-no-sanitizers.cu
===
--- test/Driv
jlebar updated this revision to Diff 80011.
jlebar added a comment.
Suggest std::foo instead of ::foof.
I spoke with rtrieu IRL and he suggested I do this to match what he did in
SemaChecking.cpp for calls to "abs". Seems reasonable to me. This also lets
me sidestep the question of lexing the q
jhen created this revision.
jhen added a reviewer: jlebar.
jhen added a subscriber: cfe-commits.
The test introduced by https://reviews.llvm.org/rL288448 is currently failing
because
unimportant but unexpected errors appear as output from a test compile
line. This patch removes the faulty test fo
Author: rsmith
Date: Thu Dec 1 19:52:28 2016
New Revision: 288449
URL: http://llvm.org/viewvc/llvm-project?rev=288449&view=rev
Log:
Recover better from an incompatible .pcm file being provided by -fmodule-file=.
We try to include the headers of the module textually in this case, still
enforcing t
Author: jhen
Date: Thu Dec 1 19:42:54 2016
New Revision: 288448
URL: http://llvm.org/viewvc/llvm-project?rev=288448&view=rev
Log:
[CUDA] "Support" ASAN arguments in CudaToolChain
This fixes a bug that was introduced in rL287285. The bug made it
illegal to pass -fsanitize=address during CUDA comp
jlebar added a comment.
This takes it back to how it used to be before I regressed it, which I think is
good enough for now. If we want to revisit how we make this work for
offloading toolchains in general, we can do that separately.
https://reviews.llvm.org/D27316
jhen updated this revision to Diff 80003.
jhen added a comment.
- "Support" ASAN in CudaToolChain
https://reviews.llvm.org/D27316
Files:
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
test/Driver/cuda-no-sanitizers.cu
Index: test/Driver/cuda-no-sanitizers.cu
=
Author: djg
Date: Thu Dec 1 19:12:40 2016
New Revision: 288447
URL: http://llvm.org/viewvc/llvm-project?rev=288447&view=rev
Log:
[WebAssembly] Add an -mdirect flag for the direct wasm object feature.
Add a target flag for enabling the new direct wasm object emission
feature.
Modified:
cfe/t
efriedma added a comment.
There's nothing wrong with this change, as far as I can tell. That said, if
you're planning to use getRealTypeByWidth anywhere other than AddModeAttr, it's
probably a bug; the behavior of getRealTypeByWidth isn't useful for any other
purpose given that clang supports
Author: jroelofs
Date: Thu Dec 1 18:51:58 2016
New Revision: 288444
URL: http://llvm.org/viewvc/llvm-project?rev=288444&view=rev
Log:
Delete tautological assertion.
After r256463, both the LHS and RHS now refer to the same variable. Before,
they referred to the member, the parameter respectively
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at:
clang-tools-extra/clang-tidy/performance/TypePromotionInMathFnCheck.cpp:62-67
+ Finder->addMatcher(
+ callExpr(callee(functionDecl(TwoDoubleA
joerg updated the summary for this revision.
joerg set the repository for this revision to rL LLVM.
joerg updated this revision to Diff 79997.
joerg added a comment.
Add test case.
Repository:
rL LLVM
https://reviews.llvm.org/D27140
Files:
include/clang/Basic/DiagnosticDriverKinds.td
inc
ddcc updated this revision to Diff 79996.
ddcc added a comment.
Change definition
https://reviews.llvm.org/D26955
Files:
lib/Basic/TargetInfo.cpp
lib/Sema/SemaDeclAttr.cpp
Index: lib/Sema/SemaDeclAttr.cpp
===
--- lib/Sema/Sem
Author: rjmccall
Date: Thu Dec 1 17:51:30 2016
New Revision: 288440
URL: http://llvm.org/viewvc/llvm-project?rev=288440&view=rev
Log:
Struct GEPs must use i32, not whatever size_t is. It should be safe
to do this unconditionally, given that the indices will always be small
constant integers anyw
Author: akirtzidis
Date: Thu Dec 1 17:41:27 2016
New Revision: 288438
URL: http://llvm.org/viewvc/llvm-project?rev=288438&view=rev
Log:
[libclang] Add APIs to check the result of an integer expression in
CXEvalResult without overflow
Patch by Emilio Cobos Álvarez!
See https://reviews.llvm.org/D
dcoughlin marked 2 inline comments as done.
dcoughlin added a comment.
In https://reviews.llvm.org/D26768#607157, @zaks.anna wrote:
> Not sure if we should make pure vs not an option so that users could turn the
> checking off. Is there a way to suppress the warning?
There is not a way to supp
dcoughlin updated this revision to Diff 79992.
dcoughlin added a comment.
- Add a PureOnly analyzer-config option that, when set, will limit diagnostics
to calls to only pure virtual functions.
This should have gone in with the prevision updated diff; my apologies for the
noise.
https://revie
Author: joerg
Date: Thu Dec 1 17:37:45 2016
New Revision: 288436
URL: http://llvm.org/viewvc/llvm-project?rev=288436&view=rev
Log:
Extend CompilationDatabase by a field for the output filename
In bigger projects like an Operating System, the same source code is
often compiled in slightly differe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288436: Extend CompilationDatabase by a field for the output
filename (authored by joerg).
Changed prior to commit:
https://reviews.llvm.org/D27138?vs=79320&id=79993#toc
Repository:
rL LLVM
https://
jhen added a comment.
In https://reviews.llvm.org/D27316#611162, @kcc wrote:
> I am not sure this is going to work.
> You essentially break on the first iteration in the beginning of the loop.
> Why not exit the function before the loop?
> Also, the loop "claims" the args and by breaking ea
kcc added a comment.
I am not sure this is going to work.
You essentially break on the first iteration in the beginning of the loop.
Why not exit the function before the loop?
Also, the loop "claims" the args and by breaking early you leave the args
unclaimed.
I don't remember this code well
jlebar added a comment.
In https://reviews.llvm.org/D27316#611160, @kcc wrote:
> at the very least this requires a test... Let me thing about the logic a bit
> more...
I think we just need to fix the test from the previous CL, which is buggy and
didn't catch this regression.
https://reviews
kcc added a comment.
at the very least this requires a test... Let me thing about the logic a bit
more...
https://reviews.llvm.org/D27316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
dcoughlin updated this revision to Diff 79981.
dcoughlin added a comment.
- Update the diagnostic to be explicit about whether the issue occurs during
construction or destruction
- Add test for pure, intraprocedural case (Sema also catches this).
https://reviews.llvm.org/D26768
Files:
includ
joerg added a comment.
The frontend is the wrong place as it doesn't even know if the register is ever
going to be used. E.g. if it is a static function, all instances could be
inlined away.
https://reviews.llvm.org/D27304
___
cfe-commits mailing
jlebar added a comment.
> where would be the right place for me to put a test to check that it is
> working (i.e. ASAN still works for CUDA host code).
I just ran the test from https://reviews.llvm.org/rL281680, and it passes
because it doesn't notice clang raising the "unsupported option
'-fs
efriedma added a comment.
The logic to compute whether a calling convention uses SSE registers does exist
in clang/lib/CodeGen/TargetInfo.cpp, so it might be possible to reuse that...
but I'm not sure that's better than just detecting it in the backend.
https://reviews.llvm.org/D27304
_
v.g.vassilev added a comment.
Thanks for working on this Sean!
Since long time we are planning to propose a patch moving some parts of cling
(eg. libInterpreter) mainline.
Now I should have a little more time to do this and it'd be great if we can
share some code between cling and lldb. This t
hfinkel added a comment.
In https://reviews.llvm.org/D25686#571894, @mgorny wrote:
> In https://reviews.llvm.org/D25686#571857, @hfinkel wrote:
>
> > It seems like we should teach Triple how to parse this triples correctly
> > (i.e. to recognize that the vendor is ARM), and then canonicalize the
On 1 Dec 2016 8:37 p.m., "Mads Ravn" wrote:
> I see the idea for the fixit clearly for case 3 & 4. Just erase
.compare(str2) and replace 0 with str2. I have a quick question though:
Given the declRefExpr().bind("str2"), how do I read the name of it in
clang-tidy? Or should I just bind 0 as well an
jhen added a reviewer: kcc.
jhen added a comment.
Before this patch, the following command would fail:
clang++ -fsanitize=address --cuda-gpu-arch=sm_20 -c example.cu
with error:
clang-4.0: error: unsupported option '-fsanitize=address' for target
'nvptx64-nvidia-cuda'
After this patch, th
ahatanak added a comment.
In https://reviews.llvm.org/D27304#610944, @thegameg wrote:
> In https://reviews.llvm.org/D27304#610697, @joerg wrote:
>
> > I think this is the absolutely wrong place to put such logic. It really can
> > not be anywhere but the backend.
>
>
> I am aware of this. But th
ahatanak accepted this revision.
ahatanak added a comment.
This revision is now accepted and ready to land.
I think this is fine.
I guess we can print a more helpful error message than "error: property
requires fields to be named", but we can probably do it later.
Repository:
rL LLVM
https:
hfinkel added a comment.
In https://reviews.llvm.org/D27304#610944, @thegameg wrote:
> In https://reviews.llvm.org/D27304#610697, @joerg wrote:
>
> > I think this is the absolutely wrong place to put such logic. It really can
> > not be anywhere but the backend.
>
>
> I am aware of this. But the
Hi Malcolm,
Thanks for the suggestions, I have been reading up on the fixits.
My initial four cases has been reduced to two a little more general cases:
1 & 2: implicitCast to bool str1.compare(str2). This case covers both
!str1.compare(str2) and str1.compare(str2)
3 & 4: str1.compare(str2) == 0 a
thegameg added a comment.
In https://reviews.llvm.org/D27304#610697, @joerg wrote:
> I think this is the absolutely wrong place to put such logic. It really can
> not be anywhere but the backend.
I am aware of this. But the way the backend informs the Diagnostics looks like
a crash, and asks
Author: gbiv
Date: Thu Dec 1 14:16:56 2016
New Revision: 288414
URL: http://llvm.org/viewvc/llvm-project?rev=288414&view=rev
Log:
Add a space in a run line. NFC.
Modified:
cfe/trunk/test/CodeGenCXX/enable_if.cpp
Modified: cfe/trunk/test/CodeGenCXX/enable_if.cpp
URL:
http://llvm.org/viewvc/
jhen created this revision.
jhen added a reviewer: jlebar.
jhen added a subscriber: cfe-commits.
This adds to the work from https://reviews.llvm.org/rL281680. This patch
takes care of another execution path in which sanitizer arguments can be
considered for NVPTX because they are used for the corr
madsravn updated this revision to Diff 79961.
madsravn added a comment.
Fixed broken tests.
https://reviews.llvm.org/D27210
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/StringCompareCheck.cpp
clang-tidy/misc/StringCompareCheck.h
docs/Release
tcanens added inline comments.
Comment at: include/__string:543
+_LIBCPP_CONSTEXPR_AFTER_CXX11
+_RandomAccessIterator
+__search_substring(_RandomAccessIterator __first1, _RandomAccessIterator
__last1,
A character traits class need only accept pointers, so the na
Author: tra
Date: Thu Dec 1 13:34:35 2016
New Revision: 288406
URL: http://llvm.org/viewvc/llvm-project?rev=288406&view=rev
Log:
Send compiler output to /dev/null in defsym.s test.
Fixes test failures if tests are run in a read-only source tree.
Modified:
cfe/trunk/test/Driver/defsym.s
Mod
Author: ahatanak
Date: Thu Dec 1 13:25:14 2016
New Revision: 288404
URL: http://llvm.org/viewvc/llvm-project?rev=288404&view=rev
Log:
[CodeGen][ARM] Make sure the value and type used to create a bitcast
have the same size.
This fixes an asset that is triggered when an address of a boolean
variab
madsravn updated this revision to Diff 79958.
madsravn marked 5 inline comments as done.
madsravn added a comment.
Updated according to comments. Still missing fixit.
https://reviews.llvm.org/D27210
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/S
dcoughlin added a comment.
In https://reviews.llvm.org/D26691#610292, @zaks.anna wrote:
> I am not a big fan of loosing svn blame only to fix formatting, but since you
> are modifying this code anyway, it's fine by me.
>
> Artem and Devin, what is your opinion on this?
I agree that in general
jlebar added inline comments.
Comment at:
clang-tools-extra/clang-tidy/performance/TypePromotionInMathFnCheck.cpp:62-67
+ Finder->addMatcher(
+ callExpr(callee(functionDecl(TwoDoubleArgFns, parameterCountIs(2),
+ hasBuiltinTyParam(0, Doubl
jlebar updated this revision to Diff 79951.
jlebar marked 2 inline comments as done.
jlebar added a comment.
Update test, use "auto". Still need to figure out how to lex these function
calls properly.
https://reviews.llvm.org/D27284
Files:
clang-tools-extra/clang-tidy/performance/CMakeLists
Author: mgrang
Date: Thu Dec 1 12:42:16 2016
New Revision: 288397
URL: http://llvm.org/viewvc/llvm-project?rev=288397&view=rev
Log:
[clang] Implement support for -defsym assembler option
Summary:
Adds support for -Wa,-defsym,abc=1 option.
Related llvm patch: https://reviews.llvm.org/D26214
Rev
bruno accepted this revision.
bruno added a comment.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D27298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rogfer01 created this revision.
rogfer01 added reviewers: EricWF, mclow.lists, rmaprath.
rogfer01 added a subscriber: cfe-commits.
Under libcpp-no-exceptions, noexcept is trivially true. Some tests expect in
the usual setting to return false. Wrap these tests in a convenience macro.
https://rev
Author: arnolds
Date: Thu Dec 1 12:07:38 2016
New Revision: 288394
URL: http://llvm.org/viewvc/llvm-project?rev=288394&view=rev
Log:
swiftcc: Add an api to query whether a target ABI stores swifterror in a
register
Modified:
cfe/trunk/include/clang/CodeGen/SwiftCallingConv.h
cfe/trunk/l
Committed in r288393.
Cheers,
Hans
On Thu, Dec 1, 2016 at 9:22 AM, Hans Wennborg wrote:
> Looks good to me!
>
> Do you have commit access, or would you like me to commit it for you?
>
> Thanks,
> Hans
>
> On Wed, Nov 30, 2016 at 8:10 PM, Antonio Maiorano wrote:
>> Updated version of patch attac
Author: hans
Date: Thu Dec 1 12:05:41 2016
New Revision: 288393
URL: http://llvm.org/viewvc/llvm-project?rev=288393&view=rev
Log:
Fix VS2015 build of clang-format-vsix by using NuGet to pull in required
assemblies
Also added a gitignore to help track the right items to commit.
Patch by Antonio
joerg added a comment.
I think this is the absolutely wrong place to put such logic. It really can not
be anywhere but the backend.
https://reviews.llvm.org/D27304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Author: gbiv
Date: Thu Dec 1 11:52:39 2016
New Revision: 288388
URL: http://llvm.org/viewvc/llvm-project?rev=288388&view=rev
Log:
[TableGen] Ignore fake args for parsing-related arg counts.
We should complain about the following:
```
void foo() __attribute__((unavailable("a", "b")));
```
Inste
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D27298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
Author: malcolm.parsons
Date: Thu Dec 1 11:38:54 2016
New Revision: 288384
URL: http://llvm.org/viewvc/llvm-project?rev=288384&view=rev
Log:
Add a blank line to make sphinx happy.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-default.rst
Modified:
clang-tools-extra
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288383: Protect sequences test under libcpp-no-exceptions
(authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D27252?vs=79717&id=79934#toc
Repository:
rL LLVM
https://reviews.l
Author: rogfer01
Date: Thu Dec 1 11:36:41 2016
New Revision: 288383
URL: http://llvm.org/viewvc/llvm-project?rev=288383&view=rev
Log:
Protect sequences test under libcpp-no-exceptions
Replace throw with TEST_THROW and protect tests that do throw. Also add missing
assert(false).
Differential Re
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288382: Protect futures test under libcpp-no-exceptions
(authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D27253?vs=79718&id=79933#toc
Repository:
rL LLVM
https://reviews.llv
Author: rogfer01
Date: Thu Dec 1 11:34:57 2016
New Revision: 288382
URL: http://llvm.org/viewvc/llvm-project?rev=288382&view=rev
Log:
Protect futures test under libcpp-no-exceptions
Skip tests that expect an exception be thrown.
Differential Revision: https://reviews.llvm.org/D27253
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288379: Protect optional test under libcpp-no-exceptions
(authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D27254?vs=79765&id=79932#toc
Repository:
rL LLVM
https://reviews.ll
Author: rogfer01
Date: Thu Dec 1 11:33:36 2016
New Revision: 288379
URL: http://llvm.org/viewvc/llvm-project?rev=288379&view=rev
Log:
Protect optional test under libcpp-no-exceptions
Replace throw with TEST_THROW and skip tests that throw exceptions
Differential Revision: https://reviews.llvm.o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288378: Protect std::ostream::sentry test under
libcpp-no-exceptions (authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D27255?vs=79720&id=79931#toc
Repository:
rL LLVM
https:
Author: rogfer01
Date: Thu Dec 1 11:31:38 2016
New Revision: 288378
URL: http://llvm.org/viewvc/llvm-project?rev=288378&view=rev
Log:
Protect std::ostream::sentry test under libcpp-no-exceptions
Skip test that throws an exception.
Differential Revision: https://reviews.llvm.org/D27255
Modifie
malcolm.parsons added a comment.
ping.
https://reviews.llvm.org/D26750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288376: [change-namespace] don't generate replacements for
files that don't match file… (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D27302?vs=79927&id=79929#toc
Repository:
Author: ioeric
Date: Thu Dec 1 11:25:55 2016
New Revision: 288376
URL: http://llvm.org/viewvc/llvm-project?rev=288376&view=rev
Log:
[change-namespace] don't generate replacements for files that don't match file
pattern.
Reviewers: hokein
Subscribers: cfe-commits
Differential Revision: https:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288375: [clang-tidy] Rename modernize-use-default to
modernize-use-equals-default (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D26511?vs=79919&id=79928#toc
Repositor
Author: malcolm.parsons
Date: Thu Dec 1 11:24:42 2016
New Revision: 288375
URL: http://llvm.org/viewvc/llvm-project?rev=288375&view=rev
Log:
[clang-tidy] Rename modernize-use-default to modernize-use-equals-default
Reviewers: angelgarcia, aaron.ballman, alexfh
Subscribers: JDevlieghere, Prazek,
malcolm.parsons added a comment.
In https://reviews.llvm.org/D26453#592934, @flx wrote:
> In https://reviews.llvm.org/D26453#590720, @malcolm.parsons wrote:
>
> > Add ValuesOnly option to modernize-pass-by-value.
>
>
> Thanks for doing this. Alex, would this work for us?
ping.
https://reviews
erik.pilkington added a comment.
Ping!
https://reviews.llvm.org/D24639
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric updated this revision to Diff 79927.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Addressed comments.
https://reviews.llvm.org/D27302
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
test/change-namespace/macro.cpp
Index: test/ch
Looks good to me!
Do you have commit access, or would you like me to commit it for you?
Thanks,
Hans
On Wed, Nov 30, 2016 at 8:10 PM, Antonio Maiorano wrote:
> Updated version of patch attached with the changes you suggested. Let me
> know if there's anything else you'd like.
>
>
> On Tue, 29 N
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thanks!
https://reviews.llvm.org/D26511
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
malcolm.parsons added inline comments.
Comment at: docs/clang-tidy/checks/misc-string-compare.rst:21
+
+ if(str1.compare(str2)) {} // use str1 != str2 instead
+
Please clang-format this code.
Comment at: test/clang-tidy/misc-string-compare
Author: ddcc
Date: Thu Dec 1 11:06:39 2016
New Revision: 288372
URL: http://llvm.org/viewvc/llvm-project?rev=288372&view=rev
Log:
[analyzer] Drop explicit mention of range constraint solver
Summary: The basic constraint solver was dropped in rL162384, leaving the range
constraint solver as the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288372: [analyzer] Drop explicit mention of range constraint
solver (authored by ddcc).
Changed prior to commit:
https://reviews.llvm.org/D26694?vs=78060&id=79924#toc
Repository:
rL LLVM
https://rev
kbarton requested changes to this revision.
kbarton added a comment.
This revision now requires changes to proceed.
Please make explicit the signed for the parameters to the functions you are
changing and remove unnecessary casts. I marked the first few that I found, but
stopped marking them aft
On 1 December 2016 at 16:42, Mads Ravn wrote:
> I have now implemented your suggestions - all but the fixit one. If I have
> added bindings for str1 and str2 in ast matcher, how would I go about
> creating a replacement for the entire implicitCastExpr or binaryOperator? I
> can't find any example
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM with two nits.
Comment at: change-namespace/ChangeNamespace.cpp:786
+ for (auto &Entry : FileToReplacements)
+if (!FilePatternRE.match(Entry.first))
+ Entry.se
thegameg created this revision.
thegameg added reviewers: craig.topper, majnemer.
thegameg added a subscriber: cfe-commits.
The following program hits a fatal_error in the X86 backend, when the
program is compiled with -mno-sse or -mno-sse2, which is understandable
due to the calling convention:
Hi Alexander,
I have now implemented your suggestions - all but the fixit one. If I have
added bindings for str1 and str2 in ast matcher, how would I go about
creating a replacement for the entire implicitCastExpr or binaryOperator? I
can't find any example in the code for clang-tidy to suggest ho
Alpha added a comment.
I don't have commit access.
Thank you for the review @alexfh
Repository:
rL LLVM
https://reviews.llvm.org/D26137
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
malcolm.parsons updated this revision to Diff 79919.
malcolm.parsons added a comment.
Re-remove doubled space in modernize-use-equals-default.rst.
https://reviews.llvm.org/D26511
Files:
clang-tidy/add_new_check.py
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModul
Alpha updated this revision to Diff 79917.
Alpha added a comment.
Rebase on top of HEAD.
Repository:
rL LLVM
https://reviews.llvm.org/D26137
Files:
include/clang/Tooling/Core/Diagnostic.h
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/DiagnosticsYaml.h
include/clang/T
1 - 100 of 147 matches
Mail list logo
