jhen added a comment. In https://reviews.llvm.org/D27316#611162, @kcc wrote:
> I am not sure this is going to work. > You essentially break on the first iteration in the beginning of the loop. > Why not exit the function before the loop? > Also, the loop "claims" the args and by breaking early you leave the args > unclaimed. > > I don't remember this code well enough to argue about it w/o tests. :( Thanks for taking a look. I just wanted to make sure nobody knew of a simple solution for this problem before I dug in further. Since none of us seems too familiar with this code, I'll do more investigation to try to find the right way to fix this. Once I do that I'll post it to this review (with a test or two to make sure it's working). https://reviews.llvm.org/D27316 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
