NoQ added a comment.
Yep, looks correct now :)
https://reviews.llvm.org/D26773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/Checker.h:325
+ const CallEvent *Call,
+ const LocationContext *LCtx) {
+return ((const CHECKER *) checker)->checkRegionChanges(state, invalidated,
---
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin, xazax.hun, a.sidorin.
NoQ added a subscriber: cfe-commits.
Put a lot of run-time checks on how our SVals are constructed, in order to
maintain the existing status quo.
This should make understanding the hierarchy easier, and pr
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin, xazax.hun, a.sidorin.
NoQ added subscribers: nandor, cfe-commits.
1. Re-use approach used in codegen. `MaterializeTemporaryExpr` may be
positioned in a strange manner, above the member access to the temporary, which
makes it a
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin.
NoQ added a subscriber: cfe-commits.
This looked useful for https://reviews.llvm.org/D25909 at first, but i
hesitated to rely on the explainer for composing the error messages. Still, i
hope that with some work it might amount
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin, xazax.hun, a.sidorin.
NoQ added a subscriber: cfe-commits.
Put a lot of compile-time and run-time checks on classes of super regions of
all `SubRegion` classes, in order to maintain the existing status quo.
This should make und
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin, xazax.hun, a.sidorin.
NoQ added a subscriber: cfe-commits.
- Fix the bug with transition handling in `checkDeadSymbols`, that was noticed
back in https://reviews.llvm.org/D18860, which never landed.
- Test this bug by adding a
EricWF added a comment.
I really dislike this change. I'm afraid that these changes allow the tests to
silently fail for reasons other than `test.dat` being read only. For example
if `test.dat` ever gets deleted, or if libc++'s remote test-harness fails to
copy the input file to the remote hos
EricWF added a comment.
Fun libc++ fact: We implement almost all of the C++11 library in C++03.
These tests use `assert` because `min()` is not constexpr in C++03. If you
don't mind please change the tests to:
#if TEST_STD_VER >= 11
static_assert(...);
#else
assert(...);
#endif
Feel
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at:
test/std/algorithms/alg.modifying.operations/alg.random.sample/sample.pass.cpp:74
assert(end.base() - oa == std::min(os, is));
- assert(std::equal(oa,
EricWF added a comment.
Please add tests to `cxx1y-user-defined-literals.cpp` (and probably rename it).
Other than that this LGTM, but I don't feel comfortable approving clang patches.
https://reviews.llvm.org/D26829
___
cfe-commits mailing list
cf
Author: ericwf
Date: Fri Nov 18 00:42:17 2016
New Revision: 287321
URL: http://llvm.org/viewvc/llvm-project?rev=287321&view=rev
Log:
Remove _LIBCPP_HAS_NO_DEFAULTED_FUNCTIONS
libc++ no longer supports C++11 compilers that don't implement `= default`.
This patch removes all instances of the featur
mayurpandey updated this revision to Diff 78471.
mayurpandey added a comment.
Hi,
Updated the patch. Can you please commit it on my behalf as I don't have commit
access.
Thanks,
Mayur
https://reviews.llvm.org/D22334
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.
Author: kromanova
Date: Fri Nov 18 00:26:01 2016
New Revision: 287317
URL: http://llvm.org/viewvc/llvm-project?rev=287317&view=rev
Log:
Add doxygen comments for lzcntintrin.h's intrinsics.
The doxygen comments are automatically generated based on Sony's intrinsics
document.
I got an OK from Eri
anemet added a comment.
Nothing strong, just trying to go step-by-step. I haven't thought about it how
this should map to ThinLTO. We can discuss it tomorrow.
https://reviews.llvm.org/D26833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mehdi_amini added a comment.
I'm not incline to agree with this, unless you have very strong arguments.
https://reviews.llvm.org/D26833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
anemet added a comment.
In https://reviews.llvm.org/D26833#599382, @mehdi_amini wrote:
> Well, maybe not entirely, what do you expect for output with ThinLTO?
For now, I'd like to just ignore it. So I need to somehow restrict this to
LTO-only...
https://reviews.llvm.org/D26833
__
mehdi_amini requested changes to this revision.
mehdi_amini added a comment.
This revision now requires changes to proceed.
Well, maybe not entirely, what do you expect for output with ThinLTO?
https://reviews.llvm.org/D26833
___
cfe-commits mailing
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D26833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
anemet created this revision.
anemet added reviewers: hfinkel, mehdi_amini.
anemet added a subscriber: cfe-commits.
I guess this would have to be added for each linker.
https://reviews.llvm.org/D26833
Files:
lib/Driver/Tools.cpp
test/Driver/darwin-ld.c
Index: test/Driver/darwin-ld.c
=
Author: ctopper
Date: Thu Nov 17 23:04:51 2016
New Revision: 287313
URL: http://llvm.org/viewvc/llvm-project?rev=287313&view=rev
Log:
[AVX-512] Replace masked 16-bit element variable shift builtins with new
unmasked versions and selects.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX86.de
mgorny updated this revision to Diff 78462.
mgorny added a comment.
Thanks for the review. I've rebased on top of current master (UbuntuZesty
added), and now I will update the unit tests.
https://reviews.llvm.org/D25949
Files:
include/clang/Driver/Distro.h
lib/Driver/CMakeLists.txt
lib/D
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287309: [libc++] Fix preprocessor guard for overload
declaration (authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D26825?vs=78447&id=78461#toc
Repository:
rL LLVM
https://rev
Author: smeenai
Date: Thu Nov 17 22:31:09 2016
New Revision: 287309
URL: http://llvm.org/viewvc/llvm-project?rev=287309&view=rev
Log:
[libc++] Fix preprocessor guard for overload declaration
Fix a typo in the conditional. Caught by going through list of removed
symbols when building with hidden
EricWF added a comment.
Which paper is this implementing?
Also please update the synopsis comment at the top of the header.
Comment at: include/string_view:749
+inline namespace literals
+{
If this is new to C++17 then the new declarations should be guarded
EricWF updated this revision to Diff 78459.
EricWF added a comment.
Add tests that explicit default constructors are still allowed outside of
copy-initialization.
https://reviews.llvm.org/D25654
Files:
lib/AST/DeclCXX.cpp
test/CXX/dcl.decl/dcl.init/dcl.init.aggr/p1.cpp
test/CXX/dcl.decl/
AntonBikineev created this revision.
AntonBikineev added reviewers: mclow.lists, rsmith, cfe-commits.
Herald added a reviewer: EricWF.
https://reviews.llvm.org/D26830
Files:
include/string_view
test/std/strings/string.view/string.view.literals/literal.pass.cpp
test/std/strings/string.view/s
AntonBikineev created this revision.
AntonBikineev added reviewers: mclow.lists, rsmith, cfe-commits.
https://reviews.llvm.org/D26829
Files:
lib/Lex/Lexer.cpp
Index: lib/Lex/Lexer.cpp
===
--- lib/Lex/Lexer.cpp
+++ lib/Lex/Lexer.c
On Thu, Nov 17, 2016 at 2:14 PM, Sasha Bermeister
wrote:
> Although I agree with your philosophical discussion and suggestions, the
> reality is that MSVC's behavior is not a bug and compilers are free to
> interpret enum bitfields with no explicit underlying type in any way they
> want (see spec
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D26825
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
dyung created this revision.
dyung added a reviewer: ABataev.
dyung added a subscriber: cfe-commits.
These two tests in many places looks for a pattern:
...
br ... label % ...
...
In non-release builds of the compiler, this works fine. For example:
br label %omp.inner.for.cond, !dbg !313
omp.i
EricWF created this revision.
EricWF added reviewers: mclow.lists, rsmith.
EricWF added a subscriber: cfe-commits.
Because `locale.h` isn't part of the libc++ modules the class definitions it
provides are exported as part of `__locale` (since it happens to be build
first). This breaks `` which e
bruno added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:7978
+/// without causing truncation of Scalar.
+
+static bool tryGCCVectorConvertAndSpalt(Sema &S, ExprResult *Scalar,
Remove this empty line.
Comment at: lib/Sema/SemaExpr.cpp:799
smeenai created this revision.
smeenai added reviewers: mclow.lists, EricWF.
smeenai added a subscriber: cfe-commits.
Fix a typo in the conditional. Caught by going through list of removed
symbols when building with hidden visibility.
https://reviews.llvm.org/D26825
Files:
include/new
Inde
smeenai added a comment.
I should clarify that the ABI omissions are for Linux.
https://reviews.llvm.org/D25208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai added a comment.
Ping.
I used @EricWF's ABI list verification work to confirm that this diff doesn't
change the ABI of libc++ on both Darwin and Linux, so it should be completely
safe.
Building with hidden visibility on top of this patch gives the following ABI
removals: https://revie
Author: kromanova
Date: Thu Nov 17 19:42:01 2016
New Revision: 287295
URL: http://llvm.org/viewvc/llvm-project?rev=287295&view=rev
Log:
Add doxygen comments to fxsrintrin.h's intrinsics.
The doxygen comments are automatically generated based on Sony's intrinsics
document.
I got an OK from Eric
pcc added inline comments.
Comment at: test/ubsan/TestCases/TypeCheck/null.cpp:1
-// RUN: %clangxx -fsanitize=null %s -O3 -o %t
-// RUN: %run %t l 2>&1 | FileCheck %s --check-prefix=CHECK-LOAD
-// RUN: %expect_crash %run %t s 2>&1 | FileCheck %s --check-prefix=CHECK-STORE
-// RUN
Author: jlebar
Date: Thu Nov 17 19:11:32 2016
New Revision: 287292
URL: http://llvm.org/viewvc/llvm-project?rev=287292&view=rev
Log:
[CUDA] Attempt to fix test failures in cuda-macos-includes.cu.
Run clang -cc1 -E instead of -S, in an attempt to make this test work
cross-platform.
Modified:
Author: rjmccall
Date: Thu Nov 17 19:08:24 2016
New Revision: 287291
URL: http://llvm.org/viewvc/llvm-project?rev=287291&view=rev
Log:
Forward ns_consumed delegate arguments with a move.
StartFunction enters a release cleanup for ns_consumed arguments in
ARC, so we need to balance that somehow.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287288: [CUDA] Wrapper header changes necessary to support
MacOS. (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D26780?vs=78298&id=78438#toc
Repository:
rL LLVM
https://rev
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287286: [CUDA] Initialize our header search using the host
triple. (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D26776?vs=78290&id=78436#toc
Repository:
rL LLVM
https://re
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287287: [CUDA] Use the right section and constant names for
fatbins when compiling for… (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D26777?vs=78291&id=78437#toc
Repository:
Author: jlebar
Date: Thu Nov 17 18:41:35 2016
New Revision: 287288
URL: http://llvm.org/viewvc/llvm-project?rev=287288&view=rev
Log:
[CUDA] Wrapper header changes necessary to support MacOS.
Reviewers: tra
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D26780
Modified
Author: jlebar
Date: Thu Nov 17 18:41:22 2016
New Revision: 287285
URL: http://llvm.org/viewvc/llvm-project?rev=287285&view=rev
Log:
[CUDA] Driver changes to support CUDA compilation on MacOS.
Summary:
Compiling CUDA device code requires us to know the host toolchain,
because CUDA device-side com
Author: jlebar
Date: Thu Nov 17 18:41:31 2016
New Revision: 287287
URL: http://llvm.org/viewvc/llvm-project?rev=287287&view=rev
Log:
[CUDA] Use the right section and constant names for fatbins when compiling for
macos.
Reviewers: tra
Subscribers: cfe-commits
Differential Revision: https://revi
This revision was automatically updated to reflect the committed changes.
jlebar marked 2 inline comments as done.
Closed by commit rL287285: [CUDA] Driver changes to support CUDA compilation on
MacOS. (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D26774?vs=78286&id=78
Author: jlebar
Date: Thu Nov 17 18:41:27 2016
New Revision: 287286
URL: http://llvm.org/viewvc/llvm-project?rev=287286&view=rev
Log:
[CUDA] Initialize our header search using the host triple.
Summary:
This used to work because system headers are found in a (somewhat)
predictable set of locations
jlebar marked 2 inline comments as done.
jlebar added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:3650-3654
+
+ // Intentionally omitted from the switch above: llvm::Triple::CUDA. CUDA
+ // compiles always need two toolchains, the CUDA toolchain and the host
+ //
Hello everyone,
Below are some buildbot numbers for the last week of 11/06/2016 -
11/12/2016.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status fro
Hello everyone,
Below are some buildbot numbers for the week of 10/30/2016 - 11/05/2016.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from gre
Author: compnerd
Date: Thu Nov 17 17:53:35 2016
New Revision: 287283
URL: http://llvm.org/viewvc/llvm-project?rev=287283&view=rev
Log:
EHABI: mark some functions as exported
These are part of the EHABI specification and are exported to be available to
users. Mark them as `_LIBUNWIND_EXPORT` like
aaron.ballman added inline comments.
Comment at: test/clang-tidy/readability-delete-null-pointer.cpp:7
+ int *p = 0;
+ if (p) {
+// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: 'if' statement is unnecessary;
deleting null pointer has no effect [readability-delete-null-pointer]
Author: kromanova
Date: Thu Nov 17 17:02:00 2016
New Revision: 287278
URL: http://llvm.org/viewvc/llvm-project?rev=287278&view=rev
Log:
Minor changes in x86 intrinsics headers; NFC
I made several changes for consistency with the rest of x86 instrinsics header
files. Some of these changes help to
Although I agree with your philosophical discussion and suggestions, the
reality is that MSVC's behavior is not a bug and compilers are free to
interpret enum bitfields with no explicit underlying type in any way they
want (see spec reference in GCC bug link), with a signed interpretation
being a v
SilverGeri added inline comments.
Comment at: test/clang-tidy/readability-delete-null-pointer.cpp:7
+ int *p = 0;
+ if (p) {
+// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: 'if' statement is unnecessary;
deleting null pointer has no effect [readability-delete-null-pointer]
--
Author: bruno
Date: Thu Nov 17 16:45:31 2016
New Revision: 287275
URL: http://llvm.org/viewvc/llvm-project?rev=287275&view=rev
Log:
[Preprocessor] Support for '-dI' flag
Re-introduce r285411.
Implement the -dI as supported by GCC: Output ‘#include’ directives in addition
to the result of preproc
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Very nice! LGTM
https://reviews.llvm.org/D25949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: bruno
Date: Thu Nov 17 15:41:22 2016
New Revision: 287262
URL: http://llvm.org/viewvc/llvm-project?rev=287262&view=rev
Log:
[CrashReproducer][Darwin] Suggest attaching .crash diagnostic file
In addition to the preprocessed sources file and reproducer script, also
point to the .crash diagn
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix non-Standard assumptions when testing sample().
sample() isn't specified with a reproducible algorithm, so expecting
exact output is non-Standard. Mark thos
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix an assumption about the state of moved-from std::functions.
The Standard doesn't provide any guarantees beyond "valid but unspecified" for
moved-from std::f
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
[libcxx] [test] Change ifstream constructor tests to handle read-only files.
Certain source control systems like to set the read-only bit o
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] allocator is non-Standard.
N4582 17.6.3.5 [allocator.requirements] says that allocators are given
cv-unqualified object types, and N4582 20.9.9 [default.allocat
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] In random tests, use real static_asserts and silence a warning.
One test triggers MSVC's warning C4310 "cast truncates constant value".
The code is valid, and y
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM, with couple of minor nits.
Comment at: clang/lib/Driver/Driver.cpp:3650-3654
+
+ // Intentionally omitted from the switch above: llvm::Triple::CUDA. CUDA
+ // compiles alw
EricWF updated this revision to Diff 78410.
EricWF added a comment.
OK, I've applied the fix to C++11 and C++14. Although the
inheriting-constructor part still only matters in C++1z since it requires
having base classes.
I also fixed aggregate initialization for types with non-aggregate base
c
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: malcolm.parsons
Date: Thu Nov 17 15:00:09 2016
New Revision: 287258
URL: http://llvm.org/viewvc/llvm-project?rev=287258&view=rev
Log:
Fixes for r287241. Use placement new. Apply clang-format.
Modified:
cfe/trunk/lib/Parse/ParseDeclCXX.cpp
cfe/trunk/lib/Sema/DeclSpec.cpp
cfe/tr
krasin updated this revision to Diff 78405.
krasin added a comment.
sync
https://reviews.llvm.org/D26560
Files:
test/ubsan/TestCases/TypeCheck/null.cpp
Index: test/ubsan/TestCases/TypeCheck/null.cpp
===
--- test/ubsan/TestCases
On Thu, Nov 17, 2016 at 9:52 AM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 17 Nov 2016 8:56 am, "Reid Kleckner" wrote:
>> In https://reviews.llvm.org/D24289#598169, @rsmith wrote:
>>> This is causing warnings to fire for headers shared between C and C++,
>>> where the
ahatanak updated this revision to Diff 78399.
ahatanak added a comment.
Address Alex's review comments.
Define a static function for setting SrcAlign.
https://reviews.llvm.org/D21099
Files:
lib/Sema/SemaChecking.cpp
test/Sema/warn-cast-align.c
Index: test/Sema/warn-cast-align.c
=
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM with nits
Comment at: lib/Sema/SemaChecking.cpp:110
+S.Diag(ValArg->getLocStart(), diag::err_typecheck_cond_expect_float)
+ << ValArg->getType() << ValArg->
Author: ericwf
Date: Thu Nov 17 14:08:43 2016
New Revision: 287255
URL: http://llvm.org/viewvc/llvm-project?rev=287255&view=rev
Log:
Workaround compilers w/o C++1z inline variables
Modified:
libcxx/trunk/include/__config
libcxx/trunk/include/utility
Modified: libcxx/trunk/include/__confi
mayurpandey updated this revision to Diff 78390.
mayurpandey added a comment.
Hi,
Updated the patch to incorporate the review comments. I had missed adding
ValArg->getType() when emitting the diagnostic which was cauing the crash.
Testing done, no regressions.
Thanks,
Mayur
https://reviews.l
a.sidorin added a comment.
Thank you! I'll update this review again when I have a test for
NestedNameSpecifierLocs.
Comment at: lib/AST/ASTImporter.cpp:458
+ }
+ return true;
+}
spyffe wrote:
> Is this really an appropriate default result? I would argue for
a.sidorin updated this revision to Diff 78382.
a.sidorin added a comment.
Address review comments; fix tests.
https://reviews.llvm.org/D26753
Files:
include/clang/AST/TemplateBase.h
lib/AST/ASTImporter.cpp
test/ASTMerge/class-template-partial-spec/Inputs/class-template-partial-spec1.cpp
ahatanak created this revision.
ahatanak added reviewers: doug.gregor, spyffe.
ahatanak added a subscriber: cfe-commits.
This patch fixes an assert in CodeGenFunction::EmitCallExprLValue that is
triggered when the CallExpr's return type is not a reference type:
assert(E->getCallReturnType(getCon
rsmith added inline comments.
Comment at: lib/AST/DeclCXX.cpp:564
+// C++1z [dcl.init.aggr]p1:
+// - no user-provided, explicit, or inherited constructors,
+if (getASTContext().getLangOpts().CPlusPlus1z && Constructor->isExplicit())
rsmith wrote:
> D
EricWF closed this revision.
EricWF added a comment.
r287249. Thanks again!
https://reviews.llvm.org/D26782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Thu Nov 17 13:24:34 2016
New Revision: 287251
URL: http://llvm.org/viewvc/llvm-project?rev=287251&view=rev
Log:
Remove files missed in r287250
Removed:
libcxx/trunk/test/libcxx/utilities/utility/utility.inplace/
___
cfe-commits
Author: ericwf
Date: Thu Nov 17 13:24:04 2016
New Revision: 287250
URL: http://llvm.org/viewvc/llvm-project?rev=287250&view=rev
Log:
Implement P0504R0: Revisiting in-place tag types for any/optional/variant
Modified:
libcxx/trunk/include/any
libcxx/trunk/include/utility
Modified: libcxx/
Author: ericwf
Date: Thu Nov 17 13:23:35 2016
New Revision: 287249
URL: http://llvm.org/viewvc/llvm-project?rev=287249&view=rev
Log:
Test changes for P0504R0 "Revisiting in-place tag types for
any/optional/variant". Patch from Casey Carter
Modified:
libcxx/trunk/test/std/utilities/any/any.c
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. This patch misses `any.modifiers/emplace.pass.cpp` but I'll fix that up
and commit with the libc++ changes!
https://reviews.llvm.org/D26782
__
On 17 November 2016 at 09:52, Malcolm Parsons via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: malcolm.parsons
> Date: Thu Nov 17 11:52:58 2016
> New Revision: 287241
>
> URL: http://llvm.org/viewvc/llvm-project?rev=287241&view=rev
> Log:
> Use unique_ptr for cached tokens for defaul
EricWF added a comment.
@rsmith ping. This is kind-of blocking making libc++'s tag types not
constructible from `{}`.
https://reviews.llvm.org/D25654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
ddcc added a comment.
I believe you're correct, the original code terminates early because of the
short circuit evaluation on line 553, and visits all reachable nodes but
doesn't recurse on non-SymbolData.
https://reviews.llvm.org/D26773
___
cfe-c
ddcc updated this revision to Diff 78392.
ddcc added a comment.
Fix visitation, add early termination, add comments
https://reviews.llvm.org/D26773
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h
lib/StaticAnalyzer/Core/ProgramState.cpp
Index: lib/StaticAnalyzer/Core
jlebar added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:479
+// the device toolchain we create depends on both.
+ToolChain *&CudaTC = ToolChains[CudaTriple.str() + "/" + HostTriple.str()];
+if (!CudaTC) {
sfantao wrote:
> I am not sure I
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287245: [tests] Use __SSE2__ (rather than __i686__...) for
SSE2 ASAN test (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D26763?vs=78245&id=78391#toc
Repository:
rL LLVM
htt
Author: mren
Date: Thu Nov 17 12:41:18 2016
New Revision: 287244
URL: http://llvm.org/viewvc/llvm-project?rev=287244&view=rev
Log:
ObjC Module: try to make objc module deterministic.
Make sure that comparing selectors in DeclarationName does its job.
rdar://problem/28988750
Added:
cfe/trunk/
mgorny added a comment.
I did, even twice ;-). Thanks.
https://reviews.llvm.org/D26763
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/ProgramState.cpp:535
+if (!isa(*SI))
+ continue;
Hmm, the original code does actually visit non-SymbolData.
https://reviews.llvm.org/D26773
anemet created this revision.
anemet added a reviewer: hfinkel.
anemet added a subscriber: cfe-commits.
https://reviews.llvm.org/D26807
Files:
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cpp
===
--- lib/Driver/Tools.cpp
+++ lib/
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/ProgramState.cpp:542
+if (!visitor.VisitSymbol(*SI))
+ Result = false;
}
I guess we should break the loop here.
https://reviews.llvm.org/D26773
___
Anastasia added a comment.
I have created a bug to Khronos regarding this, but unfortunately I don't see
it being progressed yet.
https://cvs.khronos.org/bugzilla/show_bug.cgi?id=15659
The problem here is that I am not sure we should deviate from the ObjC
implementation because OpenCL blocks ar
CaseyCarter updated this revision to Diff 78379.
CaseyCarter marked an inline comment as done.
CaseyCarter added a comment.
Don't `STATIC_ASSERT`; `static_assert`.
https://reviews.llvm.org/D26782
Files:
test/std/utilities/any/any.class/any.cons/in_place_type.pass.cpp
test/std/utilities/any/
mgorny updated this revision to Diff 78378.
mgorny marked 2 inline comments as done.
mgorny added a comment.
Updated the -print-libgcc-file-name test name. Additionally, I've added another
subvariant of that test using i686-* target to ensure that the mapping works
for that function too, in case
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287241: Use unique_ptr for cached tokens for default
arguments in C++. (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D26435?vs=78375&id=78380#toc
Repository:
rL LLV
CaseyCarter marked an inline comment as done.
CaseyCarter added a comment.
> Do these tests pass with the current `` implementation, or will they
> have to wait?
These tests **do not pass** without making the changes required in P0504R0 to
`` and ``. (Interestingly is unaffected; its use of
Author: malcolm.parsons
Date: Thu Nov 17 11:52:58 2016
New Revision: 287241
URL: http://llvm.org/viewvc/llvm-project?rev=287241&view=rev
Log:
Use unique_ptr for cached tokens for default arguments in C++.
Summary:
This changes pointers to cached tokens for default arguments in C++ from raw
point
1 - 100 of 155 matches
Mail list logo
