EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land.
LGTM. ================ Comment at: test/std/algorithms/alg.modifying.operations/alg.random.sample/sample.pass.cpp:74 assert(end.base() - oa == std::min(os, is)); - assert(std::equal(oa, oa + os, oa1)); + LIBCPP_ASSERT(std::equal(oa, oa + os, oa1)); end = std::sample(PopulationIterator(ia), ---------------- Please add a comment here explaining that the algorithm is non-reproducable. https://reviews.llvm.org/D26816 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
