malcolm.parsons added a comment.
In https://reviews.llvm.org/D26511#592665, @Prazek wrote:
> It is introduced because of "modernize-use-delete" was too ambiguous because
> of operator delete, so it was changed to "modernize-use-equals-delete". But
> this case is not ambiguous at all, so I don't
Prazek added inline comments.
Comment at: test/clang-tidy/misc-delete-null-pointer.cpp:11
+ }
+ // CHECK-FIXES: delete p;
+ int *p3 = new int[3];
Is there check-fixes-not? This seems to be required here, because even if the
fixit won't happen here, the test w
Prazek added a comment.
I think this change is not required at first place.
It is introduced because of "modernize-use-delete" was too ambiguous because of
operator delete, so it was changed to "modernize-use-equals-delete". But this
case is not ambiguous at all, so I don't see point changing th
rjmccall added a comment.
This looks great. One minor tweak and then it's ready.
Comment at: lib/CodeGen/CGBlocks.cpp:1057
+void CodeGenModule::putAddrOfGlobalBlock(const BlockExpr *BE,
+ llvm::Constant *Addr) {
+ bool Ok = EmittedGloba
Author: tejohnson
Date: Thu Nov 10 23:35:12 2016
New Revision: 286567
URL: http://llvm.org/viewvc/llvm-project?rev=286567&view=rev
Log:
Mirror the llvm changes that split Bitcode/ReaderWriter.h
The change in D26502 splits ReaderWriter.h, which contains the APIs
into both the BitReader and BitWrit
Is it OK to commit this patch?
Thanks,
--Serge
2016-10-21 18:21 GMT+07:00 Alex Lorenz :
> arphaman added a subscriber: rsmith.
> arphaman added a comment.
>
> LGTM, I added Richard in case he has something to add.
>
> > I chose to retain current clang behavior and reject questionable code.
> GCC
dvyukov accepted this revision.
dvyukov added a comment.
This revision is now accepted and ready to land.
> Alternatively, I could drop this aspect of the test altogether since I have
> an assert in the llvm pass.
Dropping the check is fine in this case.
https://reviews.llvm.org/D25857
sepavloff added a comment.
>> Config file set by environment variable is similar to default config file as
>> user does not specify anything in command line. But the user must explicitly
>> specify the file, it is not made automatically.
>
> Sorry, I don't understand this part.
If a user speci
On Thu, Nov 10, 2016 at 6:12 PM, Mehdi Amini via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Thinking again, the method “can” be implemented I think. Forget it…
>
It can be, but the context is a virtual dispatch, so an overrider won't
actually be used, and you do get undefined behavior.
E
phosek created this revision.
phosek added a subscriber: cfe-commits.
phosek set the repository for this revision to rL LLVM.
This is a GCC extension, Clang should accept the attribute without a warning
for compatibility with GCC.
https://llvm.org/bugs/show_bug.cgi?id=30980
Repository:
rL LL
mehdi_amini added a comment.
> So when this modification tells the developer to add 'unsigned' to their
> enum, they are subsequently causing a warning to occur in GCC.
>
> I have commented on the bug on GCC for this
> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51242#c28), but it looks
> un
sashab added a comment.
Sorry, had this discussion elsewhere
(https://bugs.chromium.org/p/chromium/issues/detail?id=648462).
I'm uncertain at this point. There is currently a bug in GCC that means enums
with an explicit underlying type (or enum classes, although the latter is to be
fixed) are
Thinking again, the method “can” be implemented I think. Forget it…
—
Mehdi
> On Nov 10, 2016, at 6:11 PM, Mehdi Amini wrote:
>
> Could we emit llvm.unreachable in this case?
>
> —
> Mehdi
>
>> On Nov 10, 2016, at 5:01 PM, Richard Smith via cfe-commits
>> wrote:
>>
>> Author: rsmith
>> D
Could we emit llvm.unreachable in this case?
—
Mehdi
> On Nov 10, 2016, at 5:01 PM, Richard Smith via cfe-commits
> wrote:
>
> Author: rsmith
> Date: Thu Nov 10 19:01:31 2016
> New Revision: 286534
>
> URL: http://llvm.org/viewvc/llvm-project?rev=286534&view=rev
> Log:
> PR30937: don't devir
sfertile created this revision.
sfertile added reviewers: nemanjai, amehsan, kbarton, syzaara, jtony, lei.
sfertile added subscribers: cfe-commits, echristo.
sfertile set the repository for this revision to rL LLVM.
Change adds 2 functions to altivec.h
vector float vec_extract_fp32_from_shorth (v
jordan_rose added a comment.
One more fix-up in https://reviews.llvm.org/rL286542. Hopefully the last one.
Repository:
rL LLVM
https://reviews.llvm.org/D26227
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286543: Define __ANDROID_API__ when specified as part of an
Android target. (authored by srhines).
Changed prior to commit:
https://reviews.llvm.org/D26491?vs=77446&id=77578#toc
Repository:
rL LLVM
Author: srhines
Date: Thu Nov 10 19:29:39 2016
New Revision: 286543
URL: http://llvm.org/viewvc/llvm-project?rev=286543&view=rev
Log:
Define __ANDROID_API__ when specified as part of an Android target.
Summary:
This macro should be defined only when the user directly specifies an
API level as par
Author: jrose
Date: Thu Nov 10 19:29:18 2016
New Revision: 286542
URL: http://llvm.org/viewvc/llvm-project?rev=286542&view=rev
Log:
Don't require nullability on 'va_list', even when it's a pointer.
Take 3! This should finally fix the Hexagon, PPC, and Windows bots.
rdar://problem/25846421
Modif
Author: jrose
Date: Thu Nov 10 19:29:15 2016
New Revision: 286541
URL: http://llvm.org/viewvc/llvm-project?rev=286541&view=rev
Log:
Revert "Speculative fix for va_list/nullability test on Hexagon and PPC."
This reverts commit r286533. At this point an array really is still an
array, but the probl
Author: rsmith
Date: Thu Nov 10 19:01:31 2016
New Revision: 286534
URL: http://llvm.org/viewvc/llvm-project?rev=286534&view=rev
Log:
PR30937: don't devirtualize if we find that the callee is a pure virtual
function. In that case, there is no requirement that the callee is actually
defined, and the
Author: jrose
Date: Thu Nov 10 18:55:14 2016
New Revision: 286533
URL: http://llvm.org/viewvc/llvm-project?rev=286533&view=rev
Log:
Speculative fix for va_list/nullability test on Hexagon and PPC.
PowerPC's va_list, at least, is a typedef for an array, which means it
decays to a pointer in parame
jordan_rose closed this revision.
jordan_rose added a comment.
Committed in https://reviews.llvm.org/rL286522, with a fix-up to make the check
for va_lists more conservative in https://reviews.llvm.org/rL286531.
Repository:
rL LLVM
https://reviews.llvm.org/D26227
_
jordan_rose closed this revision.
jordan_rose added a comment.
Committed as https://reviews.llvm.org/rL286521.
Repository:
rL LLVM
https://reviews.llvm.org/D26109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
jordan_rose closed this revision.
jordan_rose added a comment.
Committed as https://reviews.llvm.org/rL286520, with a slight fix-up for MSVC
in https://reviews.llvm.org/rL286525.
Repository:
rL LLVM
https://reviews.llvm.org/D26108
___
cfe-commit
jordan_rose closed this revision.
jordan_rose added a comment.
Committed as https://reviews.llvm.org/rL286519.
Repository:
rL LLVM
https://reviews.llvm.org/D25850
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
Author: jrose
Date: Thu Nov 10 18:23:59 2016
New Revision: 286531
URL: http://llvm.org/viewvc/llvm-project?rev=286531&view=rev
Log:
Don't require nullability on 'va_list' harder.
Platform headers don't always define 'va_list' in terms of Clang's
'__builtin_va_list', so in addition to checking for
chandlerc updated this revision to Diff 77574.
chandlerc added a comment.
Update the tests accordingly.
https://reviews.llvm.org/D26530
Files:
include/clang/Basic/DiagnosticParseKinds.td
include/clang/Basic/DiagnosticSemaKinds.td
test/Parser/objc-property-syntax.m
test/Sema/constant-con
chandlerc created this revision.
chandlerc added a reviewer: rsmith.
chandlerc added a subscriber: cfe-commits.
Herald added a subscriber: mcrosier.
The latter agrees with most existing diagnostics and the C and C++ standards.
https://reviews.llvm.org/D26530
Files:
include/clang/Basic/Diagnos
Author: jrose
Date: Thu Nov 10 17:41:18 2016
New Revision: 286525
URL: http://llvm.org/viewvc/llvm-project?rev=286525&view=rev
Log:
[Sema] Fix-up for MSVC, which is stricter about template types.
Modified:
cfe/trunk/lib/Sema/SemaType.cpp
Modified: cfe/trunk/lib/Sema/SemaType.cpp
URL:
http:/
dberris added inline comments.
Comment at: lib/Driver/Tools.cpp:4903-4906
+if (Triple.getOS() != llvm::Triple::Linux)
+ D.Diag(diag::err_drv_clang_unsupported)
+ << (std::string(XRayInstrumentOption) + " on non-Linux target OS.");
+switch (Triple.getArch())
Author: jrose
Date: Thu Nov 10 17:28:30 2016
New Revision: 286521
URL: http://llvm.org/viewvc/llvm-project?rev=286521&view=rev
Log:
Warn when 'assume_nonnull' infers nullability within an array.
...or within a reference. Both of these add an extra level of
indirection that make us less certain th
Author: jrose
Date: Thu Nov 10 17:28:26 2016
New Revision: 286520
URL: http://llvm.org/viewvc/llvm-project?rev=286520&view=rev
Log:
Add -Wnullability-completeness-on-arrays.
This is an addition to (and sub-warning of) -Wnullability-completeness
that warns when an array parameter is missing nullab
Author: jrose
Date: Thu Nov 10 17:28:17 2016
New Revision: 286519
URL: http://llvm.org/viewvc/llvm-project?rev=286519&view=rev
Log:
Accept nullability qualifiers on array parameters.
Since array parameters decay to pointers, '_Nullable' and friends
should be available for use there as well. This
Author: jrose
Date: Thu Nov 10 17:28:34 2016
New Revision: 286522
URL: http://llvm.org/viewvc/llvm-project?rev=286522&view=rev
Log:
Don't require nullability on 'va_list'.
There are many non-portable typedefs, but va_list is one that nobody
ever thinks of as a pointer or an array. (When's the las
Author: akirtzidis
Date: Thu Nov 10 17:27:11 2016
New Revision: 286518
URL: http://llvm.org/viewvc/llvm-project?rev=286518&view=rev
Log:
[index] Add SymbolSubKind for the GKInspectable annotation.
Modified:
cfe/trunk/include/clang/Index/IndexSymbol.h
cfe/trunk/lib/Index/IndexSymbol.cpp
Author: vedantk
Date: Thu Nov 10 16:31:06 2016
New Revision: 286512
URL: http://llvm.org/viewvc/llvm-project?rev=286512&view=rev
Log:
[test] Remove implicit deps on libLTO.dylib on Darwin (NFC)
This un-breaks the `check-clang` target.
Modified:
cfe/trunk/test/Driver/nostdlib.c
cfe/trunk/
Author: nico
Date: Thu Nov 10 15:49:25 2016
New Revision: 286507
URL: http://llvm.org/viewvc/llvm-project?rev=286507&view=rev
Log:
[clang-format] Fix PR30527: Regression when clang-format insert spaces in []
when in template
Actual regression was introduced in r272668. This revision fixes JS scr
thakis closed this revision.
thakis added a comment.
Landed in r286507. Thanks!
https://reviews.llvm.org/D26163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: gbiv
Date: Thu Nov 10 15:47:12 2016
New Revision: 286506
URL: http://llvm.org/viewvc/llvm-project?rev=286506&view=rev
Log:
[Sema] Range-ify for loop, add period to comment. NFC.
Modified:
cfe/trunk/lib/Sema/SemaDeclAttr.cpp
cfe/trunk/lib/Sema/SemaOverload.cpp
Modified: cfe/trunk/
rjmccall added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:7040
+ auto AS = PT->getAddressSpace();
+ return AS != Ctx.getTargetAddressSpace(LangAS::opencl_local) && AS != 0;
+}
yaxunl wrote:
> rjmccall wrote:
> > This check is definitely not correct;
mehdi_amini created this revision.
mehdi_amini added a reviewer: arphaman.
mehdi_amini added a subscriber: cfe-commits.
Instead of always displaying the mangled name, try to do better
and get something closer to regular functions.
https://reviews.llvm.org/D26522
Files:
clang/lib/AST/Expr.cpp
jgravelle-google abandoned this revision.
jgravelle-google added a comment.
Abandoning in favor of https://github.com/kripken/emscripten/pull/4718
https://reviews.llvm.org/D26431
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
hans added a comment.
In https://reviews.llvm.org/D24933#591943, @sepavloff wrote:
> >> Default config file is searched for only in the directory where clang
> >> executable resides. It allows SDK suppliers to customize compiler, for
> >> instance by turning off unneeded warnings, by providing
jtony created this revision.
jtony added reviewers: nemanjai, sfertile, syzaara, lei, kbarton, amehsan.
jtony added subscribers: llvm-commits, cfe-commits, echristo.
This patch implements all the overloads for vec_xl_be and vec_xst_be. On BE,
they behaves exactly the same with vec_xl and vec_xst,
branko added a comment.
Thanks. @djasper - can you commit this for me, please?
https://reviews.llvm.org/D26163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: gbiv
Date: Thu Nov 10 14:43:52 2016
New Revision: 286500
URL: http://llvm.org/viewvc/llvm-project?rev=286500&view=rev
Log:
Clean up uses of unique_ptr for RAII objects. NFC.
- EnterExpressionEvaluationContext allows you to specify whether you
*actually* want to enter an evaluation conte
jtony created this revision.
jtony added reviewers: nemanjai, amehsan, kbarton, sfertile, syzaara, lei.
jtony added subscribers: cfe-commits, echristo, llvm-commits.
This patch implements all the overloads for vec_xl_be and vec_xst_be. On BE,
they behaves exactly the same with vec_xl and vec_xst,
rSerge marked 5 inline comments as done.
rSerge added inline comments.
Comment at: lib/Driver/Tools.cpp:4903-4906
if (Triple.getOS() == llvm::Triple::Linux &&
(Triple.getArch() == llvm::Triple::arm ||
- Triple.getArch() == llvm::Triple::x86_64)) {
+
rSerge updated this revision to Diff 77537.
https://reviews.llvm.org/D26415
Files:
lib/Driver/Tools.cpp
test/Driver/XRay/xray-instrument-cpu.c
test/Driver/XRay/xray-instrument-os.c
Index: test/Driver/XRay/xray-instrument-os.c
===
yaxunl updated this revision to Diff 77525.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Changed APValue to differentiate with null pointer and pointers casted from
integer. Fixed casting integer to pointer.
Refactored isNullPtrZero to use just QualType as parameter.
Added t
Author: aaronballman
Date: Thu Nov 10 13:45:49 2016
New Revision: 286494
URL: http://llvm.org/viewvc/llvm-project?rev=286494&view=rev
Log:
Correcting a documentation formatting bug; NFC.
Modified:
cfe/trunk/include/clang/Basic/AttrDocs.td
Modified: cfe/trunk/include/clang/Basic/AttrDocs.td
U
ioeric added inline comments.
Comment at: clang-move/ClangMove.cpp:144
+ void run(const ast_matchers::MatchFinder::MatchResult &Result) override {
+if (const auto *CMD =
+Result.Nodes.getNodeAs("class_method")) {
hokein wrote:
> ioeric wrote:
> >
eugenis accepted this revision.
eugenis added a reviewer: eugenis.
eugenis added a comment.
Looks great!
https://reviews.llvm.org/D26491
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
NoQ added a comment.
Wow, this crash must have been hard to notice!
I think we shouldn't be default-binding non-lazy compound values. Normally we
unpack them into field bindings right away, but it seems that nobody cared to
implement this for unions.
The current crash goes through `RegionStore
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:144
+ void run(const ast_matchers::MatchFinder::MatchResult &Result) override {
+if (const auto *CMD =
+Result.Nodes.getNodeAs("class_method")) {
ioeric wrote:
> It'd be more read
hokein updated this revision to Diff 77521.
hokein marked 3 inline comments as done.
hokein added a comment.
Address comments.
https://reviews.llvm.org/D26515
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
Index: clang-move/ClangMove.h
==
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorPastEndChecker.cpp:219
+
+ assert(LCtx->getKind() == LocationContext::StackFrame &&
+ "Function does not begin with stack frame context");
a.sidorin wrote:
> `isa(LCtx)`?
>
yaxunl marked 12 inline comments as done.
yaxunl added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:7040
+ auto AS = PT->getAddressSpace();
+ return AS != Ctx.getTargetAddressSpace(LangAS::opencl_local) && AS != 0;
+}
rjmccall wrote:
> This check is de
ioeric added inline comments.
Comment at: clang-move/ClangMove.cpp:144
+ void run(const ast_matchers::MatchFinder::MatchResult &Result) override {
+if (const auto *CMD =
+Result.Nodes.getNodeAs("class_method")) {
It'd be more readable if you pull
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
No functionality change.
This is a refactoring patch, which makes the code more readable and easy
to extend it to support more types.
https://reviews.llvm.org/D26515
Files:
clang-move/Clang
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D26479
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
pirama accepted this revision.
pirama added a reviewer: pirama.
pirama added a comment.
This revision is now accepted and ready to land.
The bug points back to this Phab page instead of a bug. LGTM otherwise.
https://reviews.llvm.org/D26491
___
cfe
NoQ added a comment.
Maybe you could instead make a checker that subscribes for `checkEndAnalysis`
and scans the provided `ExplodedGraph`'s `nodes_begin()..nodes_end()` for
visited statement-based program points (as in
`PathDiagnosticLocation::getStmt(N)`)? This should give you per-statement
p
ioeric added inline comments.
Comment at: clang-move/ClangMove.cpp:273
}
+bool IsNamespaceStart = false;
while (DeclIt != DeclNamespaces.end()) {
It's been a while since the last time I reviewed this, and I need to struggle
to understand what Curre
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286486: Handle adding new nested namespace in old namespace.
(authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D26456?vs=77511&id=77513#toc
Repository:
rL LLVM
https://reviews.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286487: Add -Wduplicate-protocol for existing diagnostic
(authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D26406?vs=77232&id=77514#toc
Repository:
rL LLVM
https://reviews.ll
Author: arphaman
Date: Thu Nov 10 12:30:26 2016
New Revision: 286487
URL: http://llvm.org/viewvc/llvm-project?rev=286487&view=rev
Log:
Add -Wduplicate-protocol for existing diagnostic
Expose a warning flag for warn_duplicate_protocol_def. This allows control
over the severity of duplicate protoco
Author: ioeric
Date: Thu Nov 10 12:29:01 2016
New Revision: 286486
URL: http://llvm.org/viewvc/llvm-project?rev=286486&view=rev
Log:
Handle adding new nested namespace in old namespace.
Reviewers: hokein
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D26456
Modified:
ioeric updated this revision to Diff 77511.
ioeric added a comment.
- Merged origin/master
https://reviews.llvm.org/D26456
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespace/ChangeNamespaceTests.cpp
ioeric updated this revision to Diff 77509.
ioeric added a comment.
- Address comments.
https://reviews.llvm.org/D26456
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespace/ChangeNamespaceTests.cpp
===
sepavloff added a comment.
>> Default config file is searched for only in the directory where clang
>> executable resides. It allows SDK suppliers to customize compiler, for
>> instance by turning off unneeded warnings, by providing their own clang.cfg.
>> On the other hand developers cannot by
ioeric added inline comments.
Comment at: clang-tools-extra/trunk/change-namespace/ChangeNamespace.cpp:396
+ // Calculate the name of the `NsDecl` after it is moved to new namespace.
+ std::string OldNs = NsDecl->getQualifiedNameAsString();
+ llvm::StringRef Postfix = OldNs;
-
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM with two nits.
Comment at: change-namespace/ChangeNamespace.cpp:475
+ // If there is no outer namespace (i.e. DiffOldNamespace is empty), the new
+ // namespace will b
Author: ioeric
Date: Thu Nov 10 12:15:34 2016
New Revision: 286485
URL: http://llvm.org/viewvc/llvm-project?rev=286485&view=rev
Log:
[change-namespace] dyn_cast -> cast.
Modified:
clang-tools-extra/trunk/change-namespace/ChangeNamespace.cpp
Modified: clang-tools-extra/trunk/change-namespace/
arphaman added a comment.
It seems sufficient enough, I will commit it with the summary. Thanks!
https://reviews.llvm.org/D26406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mehdi_amini added inline comments.
Comment at: clang-tools-extra/trunk/change-namespace/ChangeNamespace.cpp:396
+ // Calculate the name of the `NsDecl` after it is moved to new namespace.
+ std::string OldNs = NsDecl->getQualifiedNameAsString();
+ llvm::StringRef Postfix = Old
kastiglione added a comment.
@arphaman Is the summary here sufficient, or should I elaborate in some way?
I'm fine with this summary if you are.
https://reviews.llvm.org/D26406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:262
+
+static void dumpCoverageInfo(llvm::SmallVectorImpl &Path,
+ SourceManager &SM) {
xazax.hun wrote:
> zaks.anna wrote:
> > xazax.hun wrote:
> > >
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:58
"modernize-use-bool-literals");
-CheckFactories.registerCheck("modernize-use-default");
+
CheckFactories.registerCheck("modernize-use-equals-default");
CheckFact
malcolm.parsons added inline comments.
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:58
"modernize-use-bool-literals");
-CheckFactories.registerCheck("modernize-use-default");
+
CheckFactories.registerCheck("modernize-use-equals-default");
CheckFa
rogfer01 added inline comments.
Comment at:
test/std/input.output/iostreams.base/ios/basic.ios.members/copyfmt.pass.cpp:171-173
+#else
+ios1.copyfmt(ios2);
+#endif
This is a bit unexpected. It looks like if the copyfmt, even if it throws, were
able to copy
rogfer01 created this revision.
rogfer01 added reviewers: EricWF, mclow.lists, rmaprath.
rogfer01 added a subscriber: cfe-commits.
Skip tests that expect an exception be thrown.
https://reviews.llvm.org/D26512
Files:
test/std/input.output/iostreams.base/ios/basic.ios.members/copyfmt.pass.cpp
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:58
"modernize-use-bool-literals");
-CheckFactories.registerCheck("modernize-use-default");
+
CheckFactories.registerCheck("modernize-use-equals-default");
CheckFact
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, alexfh, angelgarcia.
malcolm.parsons added a subscriber: cfe-commits.
Herald added a subscriber: mgorny.
https://reviews.llvm.org/D26511
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/Moder
rogfer01 added a comment.
@rmaprath well each case is testing a different special member: the assignment
operator, the copy constructor and the default constructor. My feeling is that
at least the non-throwing part must be tested under no-exceptions. But I
understand, that this class is probabl
Author: rogfer01
Date: Thu Nov 10 10:54:55 2016
New Revision: 286474
URL: http://llvm.org/viewvc/llvm-project?rev=286474&view=rev
Log:
Protect bitset tests under libcpp-no-exceptions
Bitset tests feature a sequence of tests of increasing bitset sizes,
but these tests rely on exceptions when the b
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286472: [clang-tidy] Add modernize-use-equals-delete check
(authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D26138?vs=76971&id=77500#toc
Repository:
rL LLVM
https://r
Author: malcolm.parsons
Date: Thu Nov 10 10:46:59 2016
New Revision: 286472
URL: http://llvm.org/viewvc/llvm-project?rev=286472&view=rev
Log:
[clang-tidy] Add modernize-use-equals-delete check
Summary: Fixes PR27872
Reviewers: klimek, hokein, alexfh, aaron.ballman
Subscribers: Prazek, Eugene.Ze
rogfer01 updated this revision to Diff 77498.
rogfer01 added a comment.
- Address comments.
- Rebase test with current trunk
- Make the check resilient under errors
If no comments arise from this change I will be commiting it Monday next week.
https://reviews.llvm.org/D23657
Files:
include/c
Anastasia created this revision.
Anastasia added a reviewer: yaxunl.
Anastasia added a subscriber: cfe-commits.
Parameters representing number of events as well as sizes of enqueued block
arguments in enqueue_kernel function are specified as uint type. This prevents
passing sizeof(int) type expr
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
Comment at: clang-tidy/modernize/UseEqualsDeleteCheck.cpp:58
+ << FixItHint::CreateInsertion(StartLoc, "public: ")
+ << FixItHint::Cr
On Thu, Nov 10, 2016 at 11:19 AM, Malcolm Parsons via cfe-commits
wrote:
> Author: malcolm.parsons
> Date: Thu Nov 10 10:19:17 2016
> New Revision: 286466
>
> URL: http://llvm.org/viewvc/llvm-project?rev=286466&view=rev
> Log:
> [clang-tidy] Add missing meta refresh for cert-msc30-c doc. NFC
Than
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:71
+
+static const StringRef Message = "prefer transparent functors (%0)";
+
You should quote the %0 to clarify that you're referring to syntax.
==
nemanjai updated this revision to Diff 77494.
nemanjai added a comment.
Accidentally uploaded the wrong patch so it was missing full context.
Repository:
rL LLVM
https://reviews.llvm.org/D26479
Files:
include/clang/Basic/BuiltinsPPC.def
lib/Headers/altivec.h
test/CodeGen/builtins-ppc-c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286468: clang-format: [JS] do not break after declare
namespace. (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D26274?vs=76831&id=77493#toc
Repository:
rL LLVM
https://rev
nemanjai added a comment.
In https://reviews.llvm.org/D26479#591723, @amehsan wrote:
> more context?
Really sorry. It appears that I uploaded the wrong patch file. Updating now.
Repository:
rL LLVM
https://reviews.llvm.org/D26479
___
cfe-commi
Author: mprobst
Date: Thu Nov 10 10:20:58 2016
New Revision: 286467
URL: http://llvm.org/viewvc/llvm-project?rev=286467&view=rev
Log:
clang-format: [JS] do not break after declare namespace.
See TypeScript grammar for tokens following 'declare':
https://github.com/Microsoft/TypeScript/blob/master
Author: mprobst
Date: Thu Nov 10 10:21:04 2016
New Revision: 286469
URL: http://llvm.org/viewvc/llvm-project?rev=286469&view=rev
Log:
drop kw_module from ASI protection block
Modified:
cfe/trunk/lib/Format/TokenAnnotator.cpp
Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp
URL:
http://llvm
Author: mprobst
Date: Thu Nov 10 10:21:02 2016
New Revision: 286468
URL: http://llvm.org/viewvc/llvm-project?rev=286468&view=rev
Log:
clang-format: [JS] do not break after declare namespace.
Summary:
See TypeScript grammar for tokens following 'declare':
https://github.com/Microsoft/TypeScript/bl
1 - 100 of 130 matches
Mail list logo
