aaron.ballman added inline comments.
================ Comment at: clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:71 + +static const StringRef Message = "prefer transparent functors (%0)"; + ---------------- You should quote the %0 to clarify that you're referring to syntax. ================ Comment at: clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:89 + diag(FuncInst->getLocStart(), Message) + << (FuncClass->getName() + "<>").str(); + return; ---------------- Is the `.str()` required? (Same question applies below.) https://reviews.llvm.org/D24894 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits