nkakuev added a comment.
In https://reviews.llvm.org/D26418#590168, @alexfh wrote:
> What's the biggest complexity with -header-filter? Lack of way to specify
> ? Will it help to make -header-filter a
> GlobList?
See my previous comment. Header filter isn't to help when a (false positive)
wa
nkakuev added a comment.
In https://reviews.llvm.org/D26418#590170, @alexfh wrote:
> I also don't understand the use case for turning off only some checks for
> third-party headers. Either you care about third-party stuff or not, why only
> switch off certain checks?
The use case is ignoring
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286340: [AVX-512] Make VBMI instruction set enabling imply
that the BWI instruction set… (authored by ctopper).
Changed prior to commit:
https://reviews.llvm.org/D26306?vs=76961&id=77310#toc
Repository
Author: ctopper
Date: Tue Nov 8 22:51:03 2016
New Revision: 286340
URL: http://llvm.org/viewvc/llvm-project?rev=286340&view=rev
Log:
[AVX-512] Make VBMI instruction set enabling imply that the BWI instruction set
is also enabled.
Summary: This is needed to make the v64i8 and v32i16 types legal
ikudrin added a comment.
Done: https://reviews.llvm.org/rL286337.
https://reviews.llvm.org/D26150
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ikudrin
Date: Tue Nov 8 22:14:31 2016
New Revision: 286337
URL: http://llvm.org/viewvc/llvm-project?rev=286337&view=rev
Log:
[libc++abi] Remove the test for checking using of fallback malloc in case of
dynamic memory exhaustion.
This test is too fragile and doesn't add significant value
Author: kromanova
Date: Tue Nov 8 21:58:30 2016
New Revision: 286336
URL: http://llvm.org/viewvc/llvm-project?rev=286336&view=rev
Log:
Doxygen comments for avxintrin.h.
Added doxygen comments to avxintrin.h's intrinsics. As of now, around 75% of the
intrinsics in this file are documented here. T
EricWF added a comment.
Go ahead and remove it. Ill try and fix it later next week when I get time.
https://reviews.llvm.org/D26150
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: phosek
Date: Tue Nov 8 21:38:21 2016
New Revision: 286334
URL: http://llvm.org/viewvc/llvm-project?rev=286334&view=rev
Log:
Revert "[CMake] Check runtimes subdir when looking for libcxx and libuwind"
This reverts commit eecb79506d88b268fb0d00cce178213b4aa17933.
Modified:
libcxxabi/t
Author: phosek
Date: Tue Nov 8 21:22:28 2016
New Revision: 286333
URL: http://llvm.org/viewvc/llvm-project?rev=286333&view=rev
Log:
[CMake] Check runtimes subdir when looking for libcxxabi
The runtimes subdir is the new location for runtimes, we should
include it when looking for libcxxabi heade
Author: phosek
Date: Tue Nov 8 21:22:19 2016
New Revision: 286332
URL: http://llvm.org/viewvc/llvm-project?rev=286332&view=rev
Log:
[CMake] Check runtimes subdir when looking for libcxx and libuwind
The runtimes subdir is the new location for runtimes, we should
include it when looking for libcx
ikudrin added a comment.
The test is too implementation-specific, and trying to override a function like
`calloc` makes it fragile. Unfortunately, I didn't find a better way to test
the library's behavior in case of memory exhaustion, but now I believe that
this test doesn't add any significant
Author: akirtzidis
Date: Tue Nov 8 20:47:07 2016
New Revision: 286331
URL: http://llvm.org/viewvc/llvm-project?rev=286331&view=rev
Log:
[index] Fix issue with protocol name locations in conformance list of an ObjC
class when they come from a typedef.
The ObjC class protocol list assumes there i
jordan_rose added a dependency: D26108: Add
-Wnullability-completeness-on-arrays..
jordan_rose added a comment.
Depends on https://reviews.llvm.org/D26108 too, for the tests to apply cleanly.
Repository:
rL LLVM
https://reviews.llvm.org/D26109
_
jordan_rose added a dependency: D26108: Add
-Wnullability-completeness-on-arrays..
jordan_rose added a comment.
Depends on https://reviews.llvm.org/D26108 too (for the tests to apply cleanly).
Repository:
rL LLVM
https://reviews.llvm.org/D26227
jordan_rose added a comment.
It works fine for me, though note the "depends on
https://reviews.llvm.org/D25850";. The other patches in the series do seem to
have been thrown off by https://reviews.llvm.org/D26226 landing first, though,
so I'll update those.
Repository:
rL LLVM
https://revi
dschuff added a comment.
Yeah, I don't mean for this to be the final word; mostly this just matches
asm.js.
I do agree with you that the unixy stuff goes with the emscripten environment
rather than wasm per se. I had thought we might define emscripten as an "OS"
(i.e. the third or maybe even 4t
dtarditi created this revision.
dtarditi added a subscriber: cfe-commits.
This changes pointers to cached tokens for default arguments in C++ from raw
pointers to unique_ptrs. There was a fixme in the code where the cached tokens
are created about using a smart pointer.
The change is straight
jgravelle-google added a comment.
I think you're right, it's the Emscripten embedding that's unixy, therefore
Emscripten should be responsible for telling clang to be unixy.
To play devil's advocate, it might be advantageous for all compile-to-wasm code
to assume a common environment, and unix
Author: hans
Date: Tue Nov 8 18:56:42 2016
New Revision: 286324
URL: http://llvm.org/viewvc/llvm-project?rev=286324&view=rev
Log:
clang-cl: Pass /Zc:threadSafeInit through to MSVC with /fallback (PR30948)
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Driver/cl-fallback.c
Modif
hokein updated this revision to Diff 77292.
hokein marked 3 inline comments as done.
hokein added a comment.
Add comments.
https://reviews.llvm.org/D26423
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/template_class_test.cpp
test/clang-move/Inputs/template_class_test.h
test/cla
sunfish added a comment.
The other main way we could provide __unix et al would be to add them to
tools/shared.py in Emscripten (see the comment "wasm target does not
automatically define emscripten stuff"). It's not clear to me whether that's
better than adding the macros to clang itself or no
Author: adrian
Date: Tue Nov 8 18:42:03 2016
New Revision: 286322
URL: http://llvm.org/viewvc/llvm-project?rev=286322&view=rev
Log:
Emit debug info for global constants whose address is taken exactly once.
Add a check to the DeclCache before emitting debug info for a
GlobalVariable a second time
manmanren accepted this revision.
manmanren added a comment.
This revision is now accepted and ready to land.
LGTM.
Manman
Repository:
rL LLVM
https://reviews.llvm.org/D26071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
jgravelle-google added a comment.
For the emscripten testsuite, specifically test_zlib relies on `#ifdef
__unix__` to `#include `, which it needs. The rest of the unistd
tests don't actually care. So we could make that test pass by explicitly adding
a define for __unix__ for it, but I figure it
alexfh added a comment.
I also don't understand the use case for turning off only some checks for
third-party headers. Either you care about third-party stuff or not, why only
switch off certain checks?
https://reviews.llvm.org/D26418
___
cfe-comm
alexfh added a comment.
What's the biggest complexity with -header-filter? Lack of way to specify ? Will it help to make -header-filter a GlobList?
https://reviews.llvm.org/D26418
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
sunfish added a comment.
When adding new predefined macros, please also add the new macros to
test/Preprocessor/init.c (and remove negative tests that no longer apply).
Also though, I'd also like to understand this a little more. Even with
emulation, there will be limits to how Unixy a Web envi
dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.
Also it matches asm.js @sunfish is planning on unifying the triples, and this
will be part of that (and there may be more defines that we want to add and/or
subtract), but for now it makes m
ioeric added a comment.
Nice!
First round of comments.
Comment at: clang-move/ClangMove.cpp:414
RemovedDecls.push_back(MovedDecls.back());
+ if (const auto *FTD = CMD->getDescribedFunctionTemplate()) {
+UnremovedDeclsInOldHeader.erase(FTD);
jgravelle-google created this revision.
jgravelle-google added reviewers: dschuff, sunfish.
jgravelle-google added a subscriber: cfe-commits.
Herald added a subscriber: jfb.
Unix is a convenient common denominator for embeddings to implement
syscalls for. This makes it explicit that wasm is unix-y
Author: jlebar
Date: Tue Nov 8 17:45:51 2016
New Revision: 286313
URL: http://llvm.org/viewvc/llvm-project?rev=286313&view=rev
Log:
[CUDA] Use only the GVALinkage on function definitions.
Summary:
Previously we'd look at the GVALinkage of whatever FunctionDecl you
happened to be calling.
This i
This revision was automatically updated to reflect the committed changes.
jlebar marked 2 inline comments as done.
Closed by commit rL286313: [CUDA] Use only the GVALinkage on function
definitions. (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D26268?vs=76808&id=77280#
jlebar marked 2 inline comments as done.
jlebar added a comment.
Thank you for the review! Submitting...
Comment at: clang/test/SemaCUDA/add-inline-in-definition.cu:13-14
+//
+// The trickiness here comes from the fact that the FunctionDecl bar() sees for
+// foo() does not ha
khazem updated this revision to Diff 77277.
khazem added a comment.
If a double-lock or double-release is detected, path notes are now emitted on
the _first_ lock or release event. Also updated the tests to check for these
notes.
https://reviews.llvm.org/D26340
Files:
include/clang/StaticAn
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: clang/test/SemaCUDA/add-inline-in-definition.cu:13-14
+//
+// The trickiness here comes from the fact that the FunctionDecl bar() sees for
+// foo() does not have
khazem updated this revision to Diff 77275.
khazem added a comment.
The strings for Spin{Unl,L}ockFuncName and LockErrorCategory are now
initialized when constructing a SpinLockChecker object rather than being static
globals, in order to avoid adverse effects on startup time.
Also, the Spin*Fun
khazem added a comment.
Good to meet you too, thanks for the useful comments and pointers to helpful
examples! I'm going to update the diff twice: the first one to address your
first two comments, and the second one to address your last two.
https://reviews.llvm.org/D26340
_
hfinkel added a comment.
In https://reviews.llvm.org/D25403#590049, @jlebar wrote:
> Use TEST_STD_VER macro.
This is fine with me; @EricWF , @mclow.lists ?
https://reviews.llvm.org/D25403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
Author: phosek
Date: Tue Nov 8 17:02:49 2016
New Revision: 286308
URL: http://llvm.org/viewvc/llvm-project?rev=286308&view=rev
Log:
[CMake] Get libunwind building under LLVM/runtimes
The new LLVM runtimes directory requires the same conventions to be
followed across the runtime projects. These c
jlebar added a comment.
Friendly ping
https://reviews.llvm.org/D26268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dberris added inline comments.
Comment at: lib/Driver/Tools.cpp:4903-4906
if (Triple.getOS() == llvm::Triple::Linux &&
(Triple.getArch() == llvm::Triple::arm ||
- Triple.getArch() == llvm::Triple::x86_64)) {
+ Triple.getArch() == llvm::Triple::x86_64
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286307: [change-namespace] shorten namespace qualifier based
on UsingDecl and… (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D25771?vs=77270&id=77272#toc
Repository:
rL LLVM
Author: ioeric
Date: Tue Nov 8 16:44:17 2016
New Revision: 286307
URL: http://llvm.org/viewvc/llvm-project?rev=286307&view=rev
Log:
[change-namespace] shorten namespace qualifier based on UsingDecl and
UsingDirectiveDecl.
Summary:
when replacing symbol references in moved namespaces, trying to
jlebar updated this revision to Diff 77271.
jlebar added a comment.
Use TEST_STD_VER macro.
https://reviews.llvm.org/D25403
Files:
libcxx/include/cmath
libcxx/test/libcxx/numerics/c.math/constexpr-fns.pass.cpp
Index: libcxx/test/libcxx/numerics/c.math/constexpr-fns.pass.cpp
==
ioeric updated this revision to Diff 77270.
ioeric marked an inline comment as done.
ioeric added a comment.
- Addressed comment.
https://reviews.llvm.org/D25771
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
unittests/change-namespace/ChangeNamespaceTests.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286306: [analyzer] Provide Contains() on ImmutableMap
program state partial trait. (authored by ddcc).
Changed prior to commit:
https://reviews.llvm.org/D26373?vs=77109&id=77269#toc
Repository:
rL LL
Author: ddcc
Date: Tue Nov 8 16:39:14 2016
New Revision: 286306
URL: http://llvm.org/viewvc/llvm-project?rev=286306&view=rev
Log:
[analyzer] Provide Contains() on ImmutableMap program state partial trait.
Reviewers: zaks.anna, dcoughlin
Subscribers: cfe-commits
Differential Revision: https://r
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM with one nit.
Comment at: change-namespace/ChangeNamespace.cpp:275
+ (DiffOldNsSplitted.empty() ? "-" : DiffOldNsSplitted.front()))
+ .str();
+ auto IsIn
rjmccall added a comment.
In https://reviews.llvm.org/D26196#589493, @yaxunl wrote:
> Fixed list initialization of large struct which are mostly initialized by 0
> through memset.
> Added tests for casting literal 0 and non-literal integer to pointer.
>
> There are many more places need to be c
dcoughlin added a comment.
In https://reviews.llvm.org/D26373#589614, @ddcc wrote:
> Even though there isn't a performance difference, I think it is semantically
> clearer since it is explicit that the value is unneeded.
Makes sense to me!
https://reviews.llvm.org/D26373
_
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D26423
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/template_class_test.cpp
test/clang-move/Inputs/template_class_test.h
test/clang-move/move-template-
rjmccall added inline comments.
Comment at: lib/CodeGen/CGExprConstant.cpp:1340
+ return C;
+return getNullPtr(PT, DestType);
}
yaxunl wrote:
> efriedma wrote:
> > yaxunl wrote:
> > > yaxunl wrote:
> > > > rjmccall wrote:
> > > > > efriedm
ioeric marked an inline comment as done.
ioeric added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:275
+ (DiffOldNsSplitted.empty() ? "-" : DiffOldNsSplitted.front()))
+ .str();
+ auto IsInMovedNs =
hokein wrote:
> Using an in
hfinkel added inline comments.
Comment at: libcxx/test/libcxx/numerics/c.math/constexpr-fns.pass.cpp:24
+
+#if __cplusplus >= 201103L
+constexpr bool a = std::__libcpp_isnan(0.);
I think the preferred form here is:
#if TEST_STD_VER >= 11
https://reviews.llvm.o
Yes, some bots don't build all the targets.
I think the test should go into Preprocessor/init.c.
On Tue, Nov 8, 2016 at 2:07 PM, Stephen Hines wrote:
> srhines added a comment.
>
> Reverted because this broke builds:
>
> clang-hexagon-elf
> llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast
> clang-ppc6
srhines added a comment.
Reverted because this broke builds:
clang-hexagon-elf
llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast
clang-ppc64be-linux-multistage
llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast
It isn't clear from the logs why these builds failed, since I did a general
build, but perhap
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286298: Revert "Define __ANDROID_API__ for all Android
builds." (authored by srhines).
Changed prior to commit:
https://reviews.llvm.org/D26422?vs=77254&id=77256#toc
Repository:
rL LLVM
https://revi
Author: srhines
Date: Tue Nov 8 15:54:49 2016
New Revision: 286298
URL: http://llvm.org/viewvc/llvm-project?rev=286298&view=rev
Log:
Revert "Define __ANDROID_API__ for all Android builds."
Summary: This reverts commit a8804ddd9fe71304b28e5b834d134fe93e568ee0.
Subscribers: cfe-commits, pirama, e
srhines created this revision.
srhines added subscribers: danalbert, eugenis, pirama, cfe-commits.
Herald added a subscriber: tberghammer.
This reverts commit a8804ddd9fe71304b28e5b834d134fe93e568ee0.
https://reviews.llvm.org/D26422
Files:
lib/Basic/Targets.cpp
test/Driver/android-targets.c
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: lib/CodeGen/CGExprConstant.cpp:1340
+ return C;
+return getNullPtr(PT, DestType);
}
efriedma wrote:
> yaxunl wrote:
> > yaxunl wrote:
> > > rjmccall wrote:
Eugene.Zelenko added a comment.
I think will be good idea to mention this in documentation and release notes.
https://reviews.llvm.org/D26418
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
srhines added a comment.
Ugh, phabricator dropped my updated commit message, so that is completely wrong
now. Oh well. I guess I will just use repo/gerrit for staging things in the
future (and get consensus there) before asking for any upstream reviews.
Repository:
rL LLVM
https://reviews.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286295: Define __ANDROID_API__ for all Android builds.
(authored by srhines).
Changed prior to commit:
https://reviews.llvm.org/D26385?vs=77236&id=77250#toc
Repository:
rL LLVM
https://reviews.llvm.
Author: srhines
Date: Tue Nov 8 15:23:26 2016
New Revision: 286295
URL: http://llvm.org/viewvc/llvm-project?rev=286295&view=rev
Log:
Define __ANDROID_API__ for all Android builds.
Summary:
Bug: https://llvm.org/bugs/show_bug.cgi?id=30940
This macro (along with __ANDROID__) should always be defi
efriedma added inline comments.
Comment at: lib/CodeGen/CGExprConstant.cpp:1340
+ return C;
+return getNullPtr(PT, DestType);
}
yaxunl wrote:
> yaxunl wrote:
> > rjmccall wrote:
> > > efriedma wrote:
> > > > Consider code like the followin
nkakuev created this revision.
nkakuev added reviewers: malcolm.parsons, alexfh.
nkakuev added a subscriber: cfe-commits.
Currently clang-tidy doesn't provide a practical way to suppress diagnostics
from headers you don't have control over. If using a function defined in such
header causes a fal
yaxunl marked 3 inline comments as done.
yaxunl added inline comments.
Comment at: lib/CodeGen/CGExprConstant.cpp:1340
+ return C;
+return getNullPtr(PT, DestType);
}
yaxunl wrote:
> rjmccall wrote:
> > efriedma wrote:
> > > Consider code
On Tue, Nov 8, 2016 at 3:52 PM, Kostya Serebryany via cfe-commits
wrote:
>
>
> On Tue, Nov 8, 2016 at 11:27 AM, Douglas Katzman wrote:
>>
>> oh, sorry for missing this email.
>> I'll say "no" - I was hoping you'd audit it!
>
>
> We do indeed have this practice for post-commit audit, but only for
On Tue, Nov 8, 2016 at 11:27 AM, Douglas Katzman wrote:
> oh, sorry for missing this email.
> I'll say "no" - I was hoping you'd audit it!
>
We do indeed have this practice for post-commit audit, but only for the
authors or active maintainers of the piece of code in question.
I afraid I do not f
yaxunl updated this revision to Diff 77238.
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
Added isNullPtrZero to TargetCodeGenInfo.
https://reviews.llvm.org/D26196
Files:
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGExprAgg.cpp
lib/CodeGen/CGExprConstant.cpp
lib/CodeGen/CGExp
eugenis accepted this revision.
eugenis added a reviewer: eugenis.
eugenis added a comment.
LGTM
https://reviews.llvm.org/D26385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pcc added a comment.
Ping
https://reviews.llvm.org/D24431
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danalbert accepted this revision.
danalbert added a reviewer: danalbert.
danalbert added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
srhines updated this revision to Diff 77236.
srhines added a comment.
Switched to conditionally defining __ANDROID_API__ instead.
https://reviews.llvm.org/D26385
Files:
lib/Basic/Targets.cpp
test/Driver/android-targets.cpp
Index: test/Driver/android-targets.cpp
hokein added a comment.
One more comment, otherwise looks good.
Comment at: change-namespace/ChangeNamespace.cpp:275
+ (DiffOldNsSplitted.empty() ? "-" : DiffOldNsSplitted.front()))
+ .str();
+ auto IsInMovedNs =
Using an invalid name `-` is not
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286281: [clang-move] Move all code from old.h/cc directly
when moving all class… (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D26236?vs=77223&id=77233#toc
Repository:
rL LL
rSerge created this revision.
rSerge added reviewers: dberris, rengolin.
rSerge added subscribers: iid_iunknown, cfe-commits.
Herald added a subscriber: aemerson.
This patch adds XRay support in Clang for AArch64 target.
https://reviews.llvm.org/D26415
Files:
lib/Driver/Tools.cpp
test/Drive
srhines added a comment.
In https://reviews.llvm.org/D26385#589589, @eugenis wrote:
> This is a good change, but I don't think it is the right fix for PR30940.
> Instead of handling this in the NDK, we should change *::getIRStackGuard to
> fallback to __stack_chk_guard when targeting an old ver
george.burgess.iv created this revision.
george.burgess.iv added a reviewer: rjmccall.
george.burgess.iv added a subscriber: cfe-commits.
https://reviews.llvm.org/D14274 makes our constexpr evaluator more aggressive
with some variables marked `const`. This changes how we behave on code like the
pcc added a comment.
Ping
https://reviews.llvm.org/D22296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kastiglione updated this revision to Diff 77232.
kastiglione added a comment.
Added test
https://reviews.llvm.org/D26406
Files:
include/clang/Basic/DiagnosticSemaKinds.td
test/Misc/warning-flags.c
test/SemaObjC/check-dup-objc-decls-1.m
Index: test/SemaObjC/check-dup-objc-decls-1.m
=
Author: hokein
Date: Tue Nov 8 13:55:13 2016
New Revision: 286281
URL: http://llvm.org/viewvc/llvm-project?rev=286281&view=rev
Log:
[clang-move] Move all code from old.h/cc directly when moving all class
declarations from old.h.
Summary: When moving all code to new.h/cc, these code also will b
ioeric updated this revision to Diff 77228.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Addressed comments.
https://reviews.llvm.org/D25771
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
unittests/change-namespace/ChangeNamespaceTests
Fixed in r286279.
On Tue, Nov 8, 2016 at 10:45 AM, Galina Kistanova
wrote:
> Hello Daniel,
>
> This commit broke at least one of our builders:
> http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/234
>
> Please have a look at this?
>
> Thanks
>
> Galina
>
> On Tue, Nov 8, 2016 a
alexfh added a comment.
> and generally frowned upon in many codebases (e.g. LLVM)
Should it still be a part of google/? The old check was enforcing a part of the
Google C++ style guide, but the new one seems to be somewhat broader. Am I
mistaken?
https://reviews.llvm.org/D23130
__
Author: djasper
Date: Tue Nov 8 13:47:19 2016
New Revision: 286279
URL: http://llvm.org/viewvc/llvm-project?rev=286279&view=rev
Log:
Remove FormatContext from libClang as it is now unused.
Modified:
cfe/trunk/include/clang/Index/CommentToXML.h
cfe/trunk/lib/Index/CommentToXML.cpp
Modifi
danalbert added a comment.
> It is defines with a value of 0. This allows you to actually do something
> better, IMO.
Can we stick with undefined? That's historically how things have been, and I'm
sure there's code out there depending on that (I had actually written a test
that would depend on
Ah, I see - your follow up in 285950 mentions that this unique_ptr was
always null, so none of it really mattered/did anything.
On Tue, Nov 8, 2016 at 11:42 AM David Blaikie wrote:
> On Thu, Nov 3, 2016 at 10:52 AM Chandler Carruth via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> Autho
ddcc added a comment.
Even though there isn't a performance difference, I think it is semantically
clearer since it is explicit that the value is unneeded.
The interface of ProgramState provides a `contains()` function that calls into
`Contains()` of the underlying partial traits as part of its
On Thu, Nov 3, 2016 at 10:52 AM Chandler Carruth via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: chandlerc
> Date: Thu Nov 3 12:42:32 2016
> New Revision: 285946
>
> URL: http://llvm.org/viewvc/llvm-project?rev=285946&view=rev
> Log:
> Using release to free memory is at best confus
george.burgess.iv updated this revision to Diff 77222.
george.burgess.iv added a comment.
Rebased and made the `__builtin_object_size` code a tiny bit cleaner.
The blocks bugfix I mentioned will be up as a separate review in a few minutes.
:)
https://reviews.llvm.org/D14274
Files:
include/c
On Fri, Oct 14, 2016 at 3:55 PM, Douglas Katzman via cfe-commits
wrote:
> Author: dougk
> Date: Fri Oct 14 14:55:09 2016
> New Revision: 284272
>
> URL: http://llvm.org/viewvc/llvm-project?rev=284272&view=rev
> Log:
> Implement no_sanitize_address for global vars
>
> Modified:
> cfe/trunk/incl
hokein updated this revision to Diff 77223.
hokein marked 2 inline comments as done.
hokein added a comment.
Update test to check old header.
https://reviews.llvm.org/D26236
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
test/clang-move/Inputs/test.h
test/clang-move/move-class.c
yaxunl added inline comments.
Comment at: lib/CodeGen/CodeGenTypes.cpp:743
+auto NullPtr = CGM.getNullPtr(LLPT, T);
+return isa(NullPtr);
+ }
tony-tye wrote:
> Is this correct if the target does not represent a NULL pointer as the
> address with value 0
eugenis added a comment.
This is a good change, but I don't think it is the right fix for PR30940.
Instead of handling this in the NDK, we should change *::getIRStackGuard to
fallback to __stack_chk_guard when targeting an old version.
https://reviews.llvm.org/D26385
___
oh, sorry for missing this email.
I'll say "no" - I was hoping you'd audit it!
jyknight looked at it and gave me the suggestion to fail the attribute
parsing if, in the non-deprecated syntax, _any_ of the no_sanitize
modifiers are inapplicable to global vars.
On Tue, Oct 25, 2016 at 7:19 PM, Kost
aaron.ballman added inline comments.
Comment at: clang-tidy/google/GlobalNamesCheck.cpp:77
+}
+diag(
+D->getLocStart(),
Is this formatting that clang-format generates?
Comment at: test/clang-tidy/google-global-names.cpp:13-14
+/
srhines added a comment.
In https://reviews.llvm.org/D26385#589534, @danalbert wrote:
> > This macro (along with ANDROID) should always be defined for Android
> > targets.
>
> What if only `arm-linux-androideabi` (without a version) is specified? We
> should be falling back to the old behavior
hokein added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:233
+ const DeclContext *DeclCtx, SourceLocation Loc) {
+ return SM.isBeforeInTranslationUnit(SM.getSpellingLoc(D->getLocation()),
+ SM
1 - 100 of 159 matches
Mail list logo