This revision was automatically updated to reflect the committed changes.
Closed by commit rL286219: Use AnalyzerOptions::getRegisteredCheckers() instead
of… (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D26311?vs=77112&id=77154#toc
Repository:
rL LLVM
https://revi
Author: alexfh
Date: Tue Nov 8 01:43:42 2016
New Revision: 286219
URL: http://llvm.org/viewvc/llvm-project?rev=286219&view=rev
Log:
Use AnalyzerOptions::getRegisteredCheckers() instead of
clang/StaticAnalyzer/Checkers/Checkers.inc
Summary: Depends on D26310.
Reviewers: zaks.anna, hokein
Subsc
Author: alexfh
Date: Tue Nov 8 01:23:32 2016
New Revision: 286218
URL: http://llvm.org/viewvc/llvm-project?rev=286218&view=rev
Log:
Add a method to get the list of registered static analyzer checkers.
Summary:
This provides a better interface for clang-tidy and encapsulates the knowledge
about e
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286218: Add a method to get the list of registered static
analyzer checkers. (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D26310?vs=77098&id=77151#toc
Repository:
rL LLVM
pekka.jaaskelainen added a comment.
> target architecture). So if there are no memory segments, nothing can be done
> to optimize for this and therefore providing
> the "fake" segment information doesn't seem to be useful? I am just trying
> to understand the use case.
The uses for the OpenCL
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Looks good. Thank you!
https://reviews.llvm.org/D26310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Author: pcc
Date: Tue Nov 8 00:03:43 2016
New Revision: 286214
URL: http://llvm.org/viewvc/llvm-project?rev=286214&view=rev
Log:
IR, Bitcode: Change bitcode reader to no longer own its memory buffer.
Unique ownership is just one possible ownership pattern for the memory buffer
underlying the bit
Author: alexfh
Date: Mon Nov 7 23:58:07 2016
New Revision: 286213
URL: http://llvm.org/viewvc/llvm-project?rev=286213&view=rev
Log:
[clang-tidy] Simplify matchers
Modified:
clang-tools-extra/trunk/clang-tidy/misc/NonCopyableObjects.cpp
Modified: clang-tools-extra/trunk/clang-tidy/misc/NonCo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286212: clang-format: Use git-ls-tree to get file mode in
diff mode (authored by srhines).
Changed prior to commit:
https://reviews.llvm.org/D26287?vs=76878&id=77142#toc
Repository:
rL LLVM
https://
Author: srhines
Date: Mon Nov 7 23:50:14 2016
New Revision: 286212
URL: http://llvm.org/viewvc/llvm-project?rev=286212&view=rev
Log:
clang-format: Use git-ls-tree to get file mode in diff mode
Summary:
If a file has been renamed/deleted from the filesystem and --diff mode
with two commits is act
srhines created this revision.
srhines added subscribers: danalbert, eugenis, pirama, cfe-commits.
Herald added a subscriber: tberghammer.
Bug: https://llvm.org/bugs/show_bug.cgi?id=30940
This macro (along with __ANDROID__) should always be defined for Android
targets. We set it to the major (onl
Author: bogner
Date: Mon Nov 7 23:02:33 2016
New Revision: 286210
URL: http://llvm.org/viewvc/llvm-project?rev=286210&view=rev
Log:
cmake: Don't try to install exports if there aren't any
When using LLVM_DISTRIBUTION_COMPONENTS, it's possible for clang's
export list to be empty. If this happens
Author: pcc
Date: Mon Nov 7 22:17:11 2016
New Revision: 286207
URL: http://llvm.org/viewvc/llvm-project?rev=286207&view=rev
Log:
Bitcode: Decouple block info block state from reader.
As proposed on llvm-dev:
http://lists.llvm.org/pipermail/llvm-dev/2016-October/106630.html
Move block info block
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286202: [libc++] Remove unnecessary MSVCRT exclusions
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D26377?vs=77119&id=77136#toc
Repository:
rL LLVM
https://reviews.llvm.o
Author: smeenai
Date: Mon Nov 7 21:31:42 2016
New Revision: 286202
URL: http://llvm.org/viewvc/llvm-project?rev=286202&view=rev
Log:
[libc++] Remove unnecessary MSVCRT exclusions
Visual Studio 2013 and up have these functions, and we don't need to
support older versions.
There are some remainin
beanz added a comment.
This patch doesn't make sense to me.
In an in-tree build `CMAKE_SOURCE_DIR` would be the LLVM source directory which
shouldn't match your `CMAKE_BINARY_DIR`.
In an out-of-tree build `CMAKE_SOURCE_DIR` would match the libcxx sure
directory, which shouldn't match `CMAKE_BI
Author: gbiv
Date: Mon Nov 7 21:30:49 2016
New Revision: 286201
URL: http://llvm.org/viewvc/llvm-project?rev=286201&view=rev
Log:
Make a const variable static. NFC.
Modified:
cfe/trunk/lib/CodeGen/CGBlocks.cpp
Modified: cfe/trunk/lib/CodeGen/CGBlocks.cpp
URL:
http://llvm.org/viewvc/llvm-pr
hiraditya abandoned this revision.
hiraditya added a comment.
In https://reviews.llvm.org/D25624#588748, @mehdi_amini wrote:
> I think @EricWF already committed the patch with just the inline keyword?
Yes he's done already. Closing this.
Thanks for your feedback.
https://reviews.llvm.org/D256
Author: rsmith
Date: Mon Nov 7 19:07:26 2016
New Revision: 286189
URL: http://llvm.org/viewvc/llvm-project?rev=286189&view=rev
Log:
Correctly ignore unnamed bit-fields when checking whether a union has fields.
Modified:
cfe/trunk/lib/Sema/SemaDeclCXX.cpp
cfe/trunk/test/CodeGenCXX/mangle-
NoQ added a comment.
It's great to see more domain-specific checks coming in! We're glad to be
useful. The code is also well-commented, and a lot of tests are provided, which
is great.
This checker seems to be relatively similar to the existing
`alpha.unix.PthreadLock` checker (which also hand
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286186: [clang-tidy] Don't warn implicit variables in
peformance-unnecessary-copy… (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25911?vs=75595&id=77122#toc
Repository:
rL
Author: hokein
Date: Mon Nov 7 18:45:34 2016
New Revision: 286186
URL: http://llvm.org/viewvc/llvm-project?rev=286186&view=rev
Log:
[clang-tidy] Don't warn implicit variables in
peformance-unnecessary-copy-initialization.
Summary:
This will prevent the check warning the variables which have be
rjmccall added a comment.
In https://reviews.llvm.org/D25764#588752, @hfinkel wrote:
> This makes sense to me; @anemet , @rjmccall , any thoughts?
Why are the constructor arguments optional? Are there actually any loops that
we push that lack start and end locs?
https://reviews.llvm.org/D2
smeenai updated this revision to Diff 77119.
smeenai updated the summary for this revision.
smeenai added a comment.
Fixing some more exclusions
https://reviews.llvm.org/D26377
Files:
include/cmath
include/cstdio
include/cwchar
Index: include/cwchar
=
alexfh added inline comments.
Comment at: test/clang-tidy/nolint.cpp:36
+}
+// CHECK-NOT: trigger_warning.h:{{.*}} warning: The left operand of '>' is a
garbage value
+// CHECK-NOT: :[[@LINE-4]]:{{.*}} note
The test is too brittle: if the functionality breaks af
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
This seems reasonable and it looks good to me (as long as there is a later
patch coming that calls the new method).
However: is there a situation where `Contains()` is preferable to `Loo
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
Visual Studio 2013 and up have these functions, and we don't need to
support older versions.
https://reviews.llvm.org/D26377
Files:
include/cstdio
Index: include/c
mehdi_amini created this revision.
mehdi_amini added a reviewer: rsmith.
mehdi_amini added a subscriber: cfe-commits.
This solved compiling:
#include
#include
https://reviews.llvm.org/D26376
Files:
libcxx/include/atomic
Index: libcxx/include/atomic
===
ioeric updated this revision to Diff 77115.
ioeric added a comment.
- Get rid of redundant PrefixRef
https://reviews.llvm.org/D25771
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-
ioeric added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:277
+ auto IsVisibleInOldNs =
+ anyOf(IsInMovedNs, unless(hasAncestor(namespaceDecl(hasName(Prefix);
+ // Match using declarations.
hokein wrote:
> Ignoring using-decls in `
ioeric updated this revision to Diff 77114.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Ignore using decls in old ns but not the inner-most old ns.
- Add a missing test case.
- Addressed comments
https://reviews.llvm.org/D25771
Files:
change-namespace/ChangeNamespace.cp
hokein accepted this revision.
hokein added a comment.
LGTM, thanks.
https://reviews.llvm.org/D26311
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai created this revision.
smeenai added reviewers: beanz, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
Herald added a subscriber: mgorny.
When ensuring an out-of-source build, compare to the libc++ source
directory instead of the top-level cmake source directory (which would
alexfh updated this revision to Diff 77112.
alexfh added a comment.
- Address review comments.
https://reviews.llvm.org/D26311
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
Index: clang-tidy/ClangTidy.h
===
--- clang-
hokein added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:297
+ const auto &RegisteredCheckers =
+ AnalyzerOptions::getRegisteredCheckers(IncludeExperimentalCheckers);
+ bool AnalyzerChecksEnabled = false;
alexfh wrote:
> hokein wrote:
> > Since t
Author: bogner
Date: Mon Nov 7 17:46:05 2016
New Revision: 286181
URL: http://llvm.org/viewvc/llvm-project?rev=286181&view=rev
Log:
cmake: Support exports correctly with LLVM_DISTRIBUTION_COMPONENTS
We need to apply the same export logic in clang as in llvm for
LLVM_DISTRIBUTION_COMPONENTS, or t
alexfh added inline comments.
Comment at:
clang-tools-extra/trunk/test/clang-tidy/performance-unnecessary-value-param.cpp:241
+
+// Ensure that incomplete types result in an error from the frontend and not a
+// clang-tidy diagnostic about IncompleteType being expensive to copy.
rjmccall added inline comments.
Comment at: lib/CodeGen/CGExprConstant.cpp:1340
+ return C;
+return getNullPtr(PT, DestType);
}
efriedma wrote:
> Consider code like the following:
>
> int x = 0;
> auto y1 = (__specialaddrspace int
kubabrecka added a comment.
This passes TSan tests on Darwin. LGTM.
https://reviews.llvm.org/D24991
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hfinkel added a comment.
This makes sense to me; @anemet , @rjmccall , any thoughts?
https://reviews.llvm.org/D25764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mehdi_amini added a comment.
I think @EricWF already committed the patch with just the inline keyword?
https://reviews.llvm.org/D25624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hiraditya added a comment.
In https://reviews.llvm.org/D25624#582756, @mehdi_amini wrote:
> In https://reviews.llvm.org/D25624#582752, @mehdi_amini wrote:
>
> > (The commit message is confusing, it mentions "Currently basic_string's
> > destructor is not getting inlined. So adding 'inline' attri
ddcc created this revision.
ddcc added reviewers: zaks.anna, dcoughlin.
ddcc added a subscriber: cfe-commits.
https://reviews.llvm.org/D26373
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h
Index: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h
=
hxy9243 added a comment.
In https://reviews.llvm.org/D24991#586248, @kubabrecka wrote:
> In https://reviews.llvm.org/D24991#586219, @sebpop wrote:
>
> > I just ran ninja check-all with and without this patch and there are no
> > regressions in compiler-rt on an x86_64-linux machine.
>
>
> The TS
jlebar updated this revision to Diff 77105.
jlebar added a comment.
Add a test.
https://reviews.llvm.org/D25403
Files:
libcxx/include/cmath
libcxx/test/libcxx/numerics/c.math/constexpr-fns.pass.cpp
Index: libcxx/test/libcxx/numerics/c.math/constexpr-fns.pass.cpp
==
jlebar added a comment.
Hal, whadya think?
https://reviews.llvm.org/D25403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Sorry for the delay.
https://reviews.llvm.org/D25911
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
efriedma added inline comments.
Comment at: lib/CodeGen/CGExprConstant.cpp:1340
+ return C;
+return getNullPtr(PT, DestType);
}
Consider code like the following:
int x = 0;
auto y1 = (__specialaddrspace int*)0;
auto y2 = (__sp
alexfh added a comment.
Benjamin, what's the plan here?
https://reviews.llvm.org/D23130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:297
+ const auto &RegisteredCheckers =
+ AnalyzerOptions::getRegisteredCheckers(IncludeExperimentalCheckers);
+ bool AnalyzerChecksEnabled = false;
hokein wrote:
> Since the default argumen
Author: mehdi_amini
Date: Mon Nov 7 16:16:27 2016
New Revision: 286164
URL: http://llvm.org/viewvc/llvm-project?rev=286164&view=rev
Log:
Fix typo in CMakeLists.txt: provide the path to libcxx checkout and not the
include subdir
Modified:
libcxxabi/trunk/CMakeLists.txt
Modified: libcxxabi/t
ioeric added inline comments.
Comment at: unittests/clang-move/ClangMoveTests.cpp:278
+ const char Code[] = "#include \"foo.h\"\nint A::f() { return 0; }";
+ Spec.Names = {std::string("A")};
+ Spec.OldHeader = "foo.h";
hokein wrote:
> ioeric wrote:
> > Maybe j
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
In https://reviews.llvm.org/D25659#588658, @alexfh wrote:
> I think, silently choosing one of the checks may be confusing and
> counter-intuitive. Should we just warn in case we see
Author: mehdi_amini
Date: Mon Nov 7 16:07:43 2016
New Revision: 286161
URL: http://llvm.org/viewvc/llvm-project?rev=286161&view=rev
Log:
Fix libcxxabi CMake detection of libcxx path to handle
LLVM_EXTERNAL_LIBCXX_SOURCE_DIR flag
Differential Revision: https://reviews.llvm.org/D26364
Modified:
alexfh added a comment.
I think, silently choosing one of the checks may be confusing and
counter-intuitive. Should we just warn in case we see the same check enabled by
multiple aliases?
https://reviews.llvm.org/D25659
___
cfe-commits mailing lis
alexfh updated this revision to Diff 77098.
alexfh added a comment.
- Don't expose debug checkers.
https://reviews.llvm.org/D26310
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
unittests/StaticAnalyzer/AnalyzerOptionsTest.cpp
Inde
yaxunl retitled this revision from "AMDGPU: Translate null pointers in private
and local addr space" to "[WIP] Add support for non-zero null pointers".
yaxunl updated this revision to Diff 77097.
yaxunl added a comment.
This is work in progress. Revised by John's comments.
Refactored getNullPtr
hokein added a comment.
friendly ping.
https://reviews.llvm.org/D25911
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hokein
Date: Mon Nov 7 15:46:24 2016
New Revision: 286156
URL: http://llvm.org/viewvc/llvm-project?rev=286156&view=rev
Log:
[clang-tidy] Fix a regression issue introduced by r285239.
Summary:
r285239 changes the behavior of AST CXXDefaultArgExpr node.
Update `modernize-use-nullptr` to h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286155: [clang-tidy] Move incomplete type test into separate
test file (authored by flx).
Changed prior to commit:
https://reviews.llvm.org/D26369?vs=77094&id=77095#toc
Repository:
rL LLVM
https://r
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286156: [clang-tidy] Fix a regression issue introduced by
r285239. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D26301?vs=76920&id=77096#toc
Repository:
rL LLVM
https://re
Author: flx
Date: Mon Nov 7 15:45:58 2016
New Revision: 286155
URL: http://llvm.org/viewvc/llvm-project?rev=286155&view=rev
Log:
[clang-tidy] Move incomplete type test into separate test file
Summary: Move in complete type test which does not compile into its own test
file.
Reviewers: alexfh,
Hello everyone,
LLVM buildmaster will be restarted at 5 PM Pacific time today for
maintenance.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
flx marked an inline comment as done.
flx added inline comments.
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:257
-
-void PositiveNonConstDeclaration(ExpensiveToCopyType A);
-// CHECK-FIXES: void PositiveNonConstDeclaration(const ExpensiveToCopyType& A);
--
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:257
-
-void PositiveNonConstDeclaration(ExpensiveToCopyType A);
-// CHECK-FIXES: void
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from a commenting nit, LGTM.
Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:130
+ // Do not propose fixes when:
+ // 1. in macros sin
flx marked an inline comment as done.
flx added inline comments.
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:257
-
-void PositiveNonConstDeclaration(ExpensiveToCopyType A);
-// CHECK-FIXES: void PositiveNonConstDeclaration(const ExpensiveToCopyType& A);
--
flx removed rL LLVM as the repository for this revision.
flx updated this revision to Diff 77094.
https://reviews.llvm.org/D26369
Files:
test/clang-tidy/performance-unnecessary-value-param-incomplete-type.cpp
test/clang-tidy/performance-unnecessary-value-param.cpp
Index: test/clang-tidy/per
aaron.ballman added inline comments.
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:257
-
-void PositiveNonConstDeclaration(ExpensiveToCopyType A);
-// CHECK-FIXES: void PositiveNonConstDeclaration(const ExpensiveToCopyType& A);
Why are these
hokein added a comment.
> The patch summary says "one moved declaration." Why it is just one moved
> declaration? Doesn't this also support moving all classes in one file?
Oh, the patch summary is not totally correct. It actually does what you mention
above. Have updated the summary.
===
hokein updated this revision to Diff 77093.
hokein marked 5 inline comments as done.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D26236
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
test/clang-move/Inputs/test.h
test/clang-move/move-class.cpp
uni
Author: akirtzidis
Date: Mon Nov 7 15:20:15 2016
New Revision: 286154
URL: http://llvm.org/viewvc/llvm-project?rev=286154&view=rev
Log:
[index] Handle properly C++14's template variables.
- Infer the right symbol kind.
- Provide a templated USR, similar to how we handle class templates.
rdar://
Author: akirtzidis
Date: Mon Nov 7 15:20:08 2016
New Revision: 286153
URL: http://llvm.org/viewvc/llvm-project?rev=286153&view=rev
Log:
[index] Make sure to mark class template symbols as having 'generic' sub-kind.
Modified:
cfe/trunk/lib/Index/IndexSymbol.cpp
cfe/trunk/test/Index/Core/i
Author: spyffe
Date: Mon Nov 7 15:10:31 2016
New Revision: 286151
URL: http://llvm.org/viewvc/llvm-project?rev=286151&view=rev
Log:
Updated ASTMerge/macro.m to use _Nullable.
Modified:
cfe/trunk/test/ASTMerge/Inputs/macro1.h
Modified: cfe/trunk/test/ASTMerge/Inputs/macro1.h
URL:
http://llv
spyffe added a comment.
Fixed the testcase to use _Nullable instead of __nullable, for Linux buildbots
$ svn commit test
Sendingtest/ASTMerge/Inputs/macro1.h
Transmitting file data .done
Committing transaction...
Committed revision 286151.
https://reviews.llvm.org/D26054
__
hans added inline comments.
Comment at: lib/Headers/x86intrin.h:49
+static __inline__ unsigned int __attribute__((__always_inline__, __nodebug__))
+__tzcnt_u32(unsigned int __X) { return __X ? __builtin_ctz(__X) : 32; }
+#ifdef __x86_64__
probinson wrote:
> hans
> On Nov 4, 2016, at 12:36 AM, Yaron Keren wrote:
> Hi John,
>
> clang warns on this:
>
> /llvm/tools/zapccs/../clang/include/../lib/CodeGen/CGCall.h:79:7: warning:
> anonymous types declared in an anonymous union are an extension
> [-Wnested-anon-types]
> struct {
> ^
> /llvm/too
Author: rjmccall
Date: Mon Nov 7 15:13:27 2016
New Revision: 286152
URL: http://llvm.org/viewvc/llvm-project?rev=286152&view=rev
Log:
Name some anonymous structs to avoid using a (very common) extension.
Modified:
cfe/trunk/lib/CodeGen/CGCall.h
Modified: cfe/trunk/lib/CodeGen/CGCall.h
URL:
flx added a comment.
Comment at:
clang-tools-extra/trunk/test/clang-tidy/performance-unnecessary-value-param.cpp:241
+
+// Ensure that incomplete types result in an error from the frontend and not a
+// clang-tidy diagnostic about IncompleteType being expensive to copy.
-
flx created this revision.
flx added reviewers: alexfh, aaron.ballman, sbenza.
flx added a subscriber: cfe-commits.
flx set the repository for this revision to rL LLVM.
Move in complete type test which does not compile into its own test file.
Repository:
rL LLVM
https://reviews.llvm.org/D2636
On Mon, Nov 7, 2016 at 11:44 AM, Alex Lorenz wrote:
> arphaman added a comment.
>
> I looked at the way `HasFallthroughStmt` is used, and it didn't seem so, no.
> It's used in the following manner in AnalysisBasedWarnings.cpp:
>
> bool FallThroughDiagFull =
> !Diags.isIgnored(diag::warn_u
Author: eugenis
Date: Mon Nov 7 15:02:11 2016
New Revision: 286148
URL: http://llvm.org/viewvc/llvm-project?rev=286148&view=rev
Log:
Use -fsanitize-recover instead of -mllvm -msan-keep-going: clang.
Summary: Use -fsanitize-recover instead of -mllvm -msan-keep-going: pass
-fsanitize-recover valu
smeenai added a comment.
In https://reviews.llvm.org/D26150#587973, @ikudrin wrote:
> This test is extremely fragile. Maybe, it is better to disable it, or even
> delete it altogether.
I'll take your word for it, as the original author of the test, though I'm
curious about where the fragility
rnk added a comment.
I'd like to preserve the old behavior under -Wshadow-all. The last time I came
here to try to quiet a shadowing warning on constructor parameters, we went to
great lengths to try to satisfy users who really want to warn on any and all
kinds of shadowing. I think you can do
spyffe closed this revision.
spyffe added a comment.
$ svn commit lib test
Sendinglib/AST/ASTImporter.cpp
Adding test/ASTMerge/Inputs/macro.modulemap
Adding test/ASTMerge/Inputs/macro1.h
Adding test/ASTMerge/Inputs/macro1.m
Adding test/ASTMerge/I
Author: spyffe
Date: Mon Nov 7 14:42:25 2016
New Revision: 286144
URL: http://llvm.org/viewvc/llvm-project?rev=286144&view=rev
Log:
When the ASTImporter imports a source location, it avoids importing macro
expansions by calling getSpellingLoc(). That's great in most cases, but for
macros defined
ahatanak added a comment.
Hi Jordan,
It seems that this patch doesn't apply cleanly. Can you rebase it?
Repository:
rL LLVM
https://reviews.llvm.org/D26108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
Hi Dimitry,
I think so
Best regards,
Alexey Bataev
> 7 нояб. 2016 г., в 22:36, Dimitry Andric написал(а):
>
> Hi Alexey,
>
> Does this look like a good candidate for 3.9.1?
>
> -Dimitry
>
>> On 07 Nov 2016, at 19:15, Alexey Bataev via cfe-commits
>> wrote:
>>
>> Author: abataev
>> Date: M
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Thank you for resurrecting this patch! A few comments inline.
Comment at: include/clang/Tooling/Core/Diagnostic.h:35
+ DiagnosticMessage(llvm::StringRef Message, c
Hi Alexey,
Does this look like a good candidate for 3.9.1?
-Dimitry
> On 07 Nov 2016, at 19:15, Alexey Bataev via cfe-commits
> wrote:
>
> Author: abataev
> Date: Mon Nov 7 12:15:02 2016
> New Revision: 286129
>
> URL: http://llvm.org/viewvc/llvm-project?rev=286129&view=rev
> Log:
> [OPENMP
hokein added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:566
+ break;
+if (isDeclVisibleAtLocation(*Result.SourceManager, Using, DeclCtx, Start))
{
+ for (const auto *UsingShadow : Using->shadows()) {
ioeric wrote:
> ioeric wr
ioeric added a comment.
First round of comments.
The patch summary says "one moved declaration." Why it is just one moved
declaration? Doesn't this also support moving all classes in one file?
Maybe also mention the new behavior in the class comment.
Comment at: clang-move/
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
One nit. Otherwise looks good. Thank you!
Comment at: clang-tidy/rename_check.py:89
- header_guard_old = module.upper() + '_' + check_name.upper().replace('-',
'_')
- he
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Thank you for tracking and fixing this! One nit inline.
Comment at: clang-tidy/modernize/UseNullptrCheck.cpp:194
+// Catch the castExpr inside cxxDefaultArgExpr.
+if
alekseyshl created this revision.
alekseyshl added a reviewer: eugenis.
alekseyshl added a subscriber: cfe-commits.
Use -fsanitize-recover instead of -mllvm -msan-keep-going: pass
-fsanitize-recover value to msan.
https://reviews.llvm.org/D26354
Files:
lib/CodeGen/BackendUtil.cpp
Index: li
probinson added inline comments.
Comment at: lib/Headers/x86intrin.h:49
+static __inline__ unsigned int __attribute__((__always_inline__, __nodebug__))
+__tzcnt_u32(unsigned int __X) { return __X ? __builtin_ctz(__X) : 32; }
+#ifdef __x86_64__
hans wrote:
> I'm w
khazem added a comment.
Thank you Sean! I've asked Petr Hosek to commit this change.
https://reviews.llvm.org/D26328
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans added inline comments.
Comment at: lib/Headers/x86intrin.h:49
+static __inline__ unsigned int __attribute__((__always_inline__, __nodebug__))
+__tzcnt_u32(unsigned int __X) { return __X ? __builtin_ctz(__X) : 32; }
+#ifdef __x86_64__
I'm worried about the co
Anastasia added a comment.
Cool! Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D26302
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Thanks!
On Mon, Nov 7, 2016 at 10:53 AM, Eric Liu wrote:
> r286132 should fix this.
>
> On Mon, Nov 7, 2016 at 10:40 AM Eric Liu wrote:
>
> Thanks Kostya! I'll look into this now.
>
> On Mon, Nov 7, 2016 at 10:39 AM Kostya Serebryany wrote:
>
> Hi Eric,
>
> the asan bootstrap bot shows a leak
1 - 100 of 155 matches
Mail list logo
