alexfh added a comment.
Thank you for the fix! One late comment inline.
Comment at:
clang-tools-extra/trunk/test/clang-tidy/performance-unnecessary-value-param.cpp:241
+
+// Ensure that incomplete types result in an error from the frontend and not a
+// clang-tidy diagnostic a
craig.topper updated this revision to Diff 76961.
https://reviews.llvm.org/D26306
Files:
lib/Basic/Targets.cpp
test/Preprocessor/x86_target_features.c
Index: test/Preprocessor/x86_target_features.c
===
--- test/Preprocessor/x86
craig.topper added inline comments.
Comment at: test/Preprocessor/x86_target_features.c:212
+// RUN: %clang -target i386-unknown-unknown -march=atom -mavx512vbmi
-mno-avx512vbmi -x c -E -dM -o - %s | FileCheck -match-full-lines
--check-prefix=AVX512VBMINOAVX512BW %s
+
---
EricWF added a comment.
> It looks like this is caused by functions in libc++'s headers that are marked
> to always be inlined. Since they are always inlined there is external
> definition for the linker to get the address of. I have worked around this by
> adding the no_instrument_function att
EricWF added inline comments.
Comment at: test/std/strings/string.conversions/stold.pass.cpp:39
assert(idx == 2);
+#ifndef TEST_HAS_NO_EXCEPTIONS
try
Hmm. All of these `#ifdef`s get ugly fast. I think it might be better to add
`TEST_TRY` and `TEST_CATC
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM after addressing inline comments.
Thanks again!
Comment at:
test/std/experimental/optional/optional.object/optional.object.ctor/copy.pass.cpp:30
try
+#endif
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. It seems like it was added to libstdc++ in 4.9, which works for me since
building with GCC 4.8 isn't really supported.
https://reviews.llvm.org/D26186
___
jordan_rose created this revision.
jordan_rose added a reviewer: vsk.
jordan_rose added a subscriber: cfe-commits.
jordan_rose set the repository for this revision to rL LLVM.
The fixed code is basically identical to the same loop below, which might
indicate an opportunity for refactoring. I just
EricWF created this revision.
EricWF added reviewers: rsmith, GorNishanov.
EricWF added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini.
This patch adds passing a `coroutine_handle` object to `await_suspend` calls.
It builds the `coroutine_handle` using
`coroutine_handle::from
EricWF updated this revision to Diff 76953.
EricWF added a comment.
- Address review comments about `DependentCoawaitExpr` and using
`UnresolvedLookupExpr`.
- Fix building of the initial/final coroutine suspends points.
- Fix transformation of `CoroutineBodyStmt` so that it transforms the
final/
EricWF retitled this revision from "[coroutines] Add CoawaitDependentExpr AST
node and use it to properly build await_transform." to "[coroutines] Add
DependentCoawaitExpr and fix re-building CoroutineBodyStmt.".
EricWF updated the summary for this revision.
EricWF updated this revision to Diff 7
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
test/std/depr/depr.c.headers/inttypes_h.pass.cpp
test/std/input.output/file.streams/c.files/cinttypes.pass.cpp
test/std/input.output/iostream.forward/iosfwd.pass.cpp
Add test()
nemanjai added a comment.
Zaara, prior to committing this patch, can you write a test case that will
actually use these builtins in an executable test case and confirm the results.
We'll then run it on the simulator to ensure functional correctness.
Comment at: lib/Headers/al
rjmccall added a comment.
In https://reviews.llvm.org/D26196#587135, @yaxunl wrote:
> In https://reviews.llvm.org/D26196#586433, @rjmccall wrote:
>
> > I think there are a number of conceptual questions here, chiefly among them
> > whether an llvm::ConstantPointerNull in an address-space type sh
alexfh created this revision.
alexfh added reviewers: zaks.anna, hokein.
alexfh added a subscriber: cfe-commits.
alexfh added a dependency: D26310: Add a method to get the list of registered
static analyzer checkers..
Depends on https://reviews.llvm.org/D26310.
https://reviews.llvm.org/D26311
alexfh created this revision.
alexfh added a reviewer: zaks.anna.
alexfh added a subscriber: cfe-commits.
This provides a better interface for clang-tidy and encapsulates the knowledge
about experimental checkers instead of leaving this to the clients.
https://reviews.llvm.org/D26310
Files:
i
nemanjai created this revision.
nemanjai added reviewers: hfinkel, echristo, kbarton, amehsan, syzaara,
sfertile, jtony, lei.
nemanjai added a subscriber: cfe-commits.
nemanjai set the repository for this revision to rL LLVM.
Herald added a subscriber: mehdi_amini.
This patch adds the following i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286010: [ClangTidy - performance-unnecessary-value-param]
Only add "const" when current… (authored by flx).
Changed prior to commit:
https://reviews.llvm.org/D26207?vs=76877&id=76940#toc
Repository:
Author: flx
Date: Fri Nov 4 15:51:31 2016
New Revision: 286010
URL: http://llvm.org/viewvc/llvm-project?rev=286010&view=rev
Log:
[ClangTidy - performance-unnecessary-value-param] Only add "const" when current
parameter is not already const qualified
Reviewers: alexfh, sbenza, aaron.ballman
Sub
craig.topper created this revision.
craig.topper added reviewers: delena, zvi.
craig.topper added a subscriber: cfe-commits.
This is needed to make the v64i8 and v32i16 types legal for the 512-bit VBMI
instructions. Fixes PR30912.
https://reviews.llvm.org/D26306
Files:
lib/Basic/Targets.cpp
STL_MSFT closed this revision.
STL_MSFT added a comment.
Committed as r286007.
https://reviews.llvm.org/D26294
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nemanjai added inline comments.
Comment at: lib/Headers/altivec.h:15618
+
+#if defined(__POWER8_VECTOR__) && defined(__powerpc64__)
+static inline __ATTRS_o_ai vector signed __int128
Please move the __int128 overloads below the 64-bit ones to keep the overloads
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286008: [clang-tidy] Ignore incomplete types when
determining whether they are… (authored by flx).
Changed prior to commit:
https://reviews.llvm.org/D26195?vs=76934&id=76935#toc
Repository:
rL LLVM
Author: flx
Date: Fri Nov 4 15:29:22 2016
New Revision: 286008
URL: http://llvm.org/viewvc/llvm-project?rev=286008&view=rev
Log:
[clang-tidy] Ignore incomplete types when determining whether they are
expensive to copy
Summary: IsExpensiveToCopy can return false positives for incomplete types, s
flx updated this revision to Diff 76934.
https://reviews.llvm.org/D26195
Files:
clang-tidy/utils/TypeTraits.cpp
test/clang-tidy/performance-unnecessary-value-param.cpp
Index: test/clang-tidy/performance-unnecessary-value-param.cpp
xazax.hun added a comment.
In https://reviews.llvm.org/D25985#580270, @zaks.anna wrote:
> Please, add multi-file tests and tests where a line is covered more than once.
Ok, I will add it in the next iteration.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:262
+
+static
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Holy crap. Thanks STL!
Just a note `_LIBCPP_STD_VER` is set to 11 in C++03 mode, it's silly but that's
the way it is. So that makes me wonder if some of the `_LIBCPP_STD_VER > 11`
reall
xazax.hun updated this revision to Diff 76933.
xazax.hun marked 5 inline comments as done.
xazax.hun added a comment.
- Improved performance.
- Fixed an off by one error.
- Also export unexecuted lines.
- Added context.
https://reviews.llvm.org/D25985
Files:
include/clang/StaticAnalyzer/Core/
yaxunl updated this revision to Diff 76932.
yaxunl added a comment.
Revised as Anastasia suggested.
https://reviews.llvm.org/D26302
Files:
test/Headers/opencl-c-header.cl
Index: test/Headers/opencl-c-header.cl
===
--- test/Head
mgorny added a comment.
I don't agree with the argumentation of @hans; however, I have my own concerns.
I personally dislike the idea of reusing command-line option format for this.
While I can see this is the simplest solution, it brings at least a few
problems and questions. I'm afraid that t
bruno updated this revision to Diff 76931.
bruno marked an inline comment as done.
bruno added a comment.
Update patch after Vassil's comments!
https://reviews.llvm.org/D26267
Files:
include/clang/Lex/ModuleMap.h
lib/Frontend/FrontendActions.cpp
lib/Lex/ModuleMap.cpp
test/Modules/Inputs
bruno marked an inline comment as done.
bruno added a comment.
In https://reviews.llvm.org/D26267#586971, @v.g.vassilev wrote:
> Could you include more context when creating the diff eg. git diff -U, or
> equivalent.
I did, -U9 actually, not sure why you're not getting it...
===
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, modulo a small commenting request.
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:242
+struct IncompleteType;
+void NegativeForIncomp
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:242
+// Case where parameter in declaration is already const-qualified but not in
+//
syzaara created this revision.
syzaara added reviewers: nemanjai, kbarton, amehsan, sfertile, jtony, lei.
syzaara added subscribers: echristo, cfe-commits.
Add builtin functions for prototypes:
vector signed char vec_xl_len (signed char *, size_t);
vector unsigned char vec_xl_len (unsigned char *
flx added a comment.
In https://reviews.llvm.org/D26195#585917, @aaron.ballman wrote:
> In https://reviews.llvm.org/D26195#585198, @flx wrote:
>
> > In https://reviews.llvm.org/D26195#585091, @aaron.ballman wrote:
> >
> > > In https://reviews.llvm.org/D26195#584958, @flx wrote:
> > >
> > > > In h
flx removed rL LLVM as the repository for this revision.
flx updated this revision to Diff 76928.
https://reviews.llvm.org/D26195
Files:
clang-tidy/utils/TypeTraits.cpp
test/clang-tidy/performance-unnecessary-value-param.cpp
Index: test/clang-tidy/performance-unnecessary-value-param.cpp
===
yaxunl added a comment.
In https://reviews.llvm.org/D26196#586433, @rjmccall wrote:
> I think there are a number of conceptual questions here, chiefly among them
> whether an llvm::ConstantPointerNull in an address-space type should have the
> correct representation for the target. If the deci
Anastasia added inline comments.
Comment at: test/Headers/opencl-c-header.cl:48
-// ===
-// Compile for OpenCL 1.0 for the first time. A module should be generated.
-// RUN: %clang_cc1 -triple spir-unknown-unknown -emit-llvm -o -
-finclude-default-header -fmodules -fimplicit-mod
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285999: [clang-tidy] Fixed readability-else-after-return for
cascade statements (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D26125?vs=76604&id=76924#toc
Repository:
flx added a comment.
Aaron, do you have any other comments or does the patch look good to you?
https://reviews.llvm.org/D26207
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein created this revision.
hokein added a reviewer: alexfh.
hokein added a subscriber: cfe-commits.
r285239 changes the behavior of AST CXXDefaultArgExpr node.
Update `modernize-use-nullptr` to handle CXXDefaultArgExpr correctly.
https://reviews.llvm.org/D26301
Files:
clang-tidy/modernize
yaxunl created this revision.
yaxunl added a reviewer: Anastasia.
yaxunl added subscribers: cfe-commits, rsmith.
https://reviews.llvm.org/D26302
Files:
test/Headers/opencl-c-header.cl
Index: test/Headers/opencl-c-header.cl
===
--
Author: malcolm.parsons
Date: Fri Nov 4 11:32:14 2016
New Revision: 285999
URL: http://llvm.org/viewvc/llvm-project?rev=285999&view=rev
Log:
[clang-tidy] Fixed readability-else-after-return for cascade statements
Summary:
Fix generated by this check changed program semantics
in the case where 'i
Even if we use string for address space MD, we still need to define them
somewhere. On the other hand, if we use SPIR enum, we just need to refer to the
SPIR spec in the documenting comments.
Sam
-Original Message-
From: Pekka Jääskeläinen [mailto:pekka.jaaskelai...@gmail.com]
Sent: Th
Great! Thanks!
From: Liu, Yaxun (Sam) [mailto:yaxun@amd.com]
Sent: 04 November 2016 13:52
To: Anastasia Stulova; Richard Smith
Cc: nd; cfe-commits@lists.llvm.org
Subject: RE: r273191 - [OpenCL] Include opencl-c.h by default as a clang module
Hi Richard/Anastasia,
I agree some tests are redun
Hi Richard/Anastasia,
I agree some tests are redundant. I will try to remove them.
Thanks.
Sam
From: Anastasia Stulova [mailto:anastasia.stul...@arm.com]
Sent: Friday, November 04, 2016 7:43 AM
To: Richard Smith ; Liu, Yaxun (Sam)
Cc: nd ; cfe-commits@lists.llvm.org
Subject: RE: r273191 - [Ope
On Fri, Nov 4, 2016 at 8:50 AM, Serge Pavlov wrote:
> This following commit r285981 (Enhancement to test for -ast-print tests)
> tests this change. Without it the test 'Coverage/ast-printing.c' fails on
> Windows.
Ah, thank you! :-)
~Aaron
>
> Thanks,
> --Serge
>
> 2016-11-04 19:09 GMT+07:00 Aa
This following commit r285981 (Enhancement to test for -ast-print tests)
tests this change. Without it the test 'Coverage/ast-printing.c' fails on
Windows.
Thanks,
--Serge
2016-11-04 19:09 GMT+07:00 Aaron Ballman :
> On Fri, Nov 4, 2016 at 2:03 AM, Serge Pavlov via cfe-commits
> wrote:
> > Auth
Author: ogoffart
Date: Fri Nov 4 07:04:16 2016
New Revision: 285994
URL: http://llvm.org/viewvc/llvm-project?rev=285994&view=rev
Log:
[test] Test that static_assert is properly visited in liblcang
Added:
cfe/trunk/test/Index/load-staticassert.cpp
Added: cfe/trunk/test/Index/load-staticasser
On Fri, Nov 4, 2016 at 2:03 AM, Serge Pavlov via cfe-commits
wrote:
> Author: sepavloff
> Date: Fri Nov 4 01:03:34 2016
> New Revision: 285979
>
> URL: http://llvm.org/viewvc/llvm-project?rev=285979&view=rev
> Log:
> Do not print enum underlying type if language is not C++11
>
> Output generated
Hi Richard,
I guess the problem is that the header file itself is really large and we have
all these configurations that depending on versions/extensions expose different
builtin libraries. They are all based on the core part though which is already
large.
Ideally it would be nice to test the
Hi John,
clang warns on this:
/llvm/tools/zapccs/../clang/include/../lib/CodeGen/CGCall.h:79:7: warning:
anonymous types declared in an anonymous union are an extension
[-Wnested-anon-types]
struct {
^
/llvm/tools/zapccs/../clang/include/../lib/CodeGen/CGCall.h:83:7: warning:
anonymou
Author: ogoffart
Date: Fri Nov 4 01:50:59 2016
New Revision: 285986
URL: http://llvm.org/viewvc/llvm-project?rev=285986&view=rev
Log:
[python bindings] Expose CXCursor_FriendDecl as CursorKind.FRIEND_DECL
CXCursor_FriendDecl was added in r285984
Modified:
cfe/trunk/bindings/python/clang/cin
54 matches
Mail list logo
