EricWF added inline comments.
================
Comment at: test/std/strings/string.conversions/stold.pass.cpp:39
assert(idx == 2);
+#ifndef TEST_HAS_NO_EXCEPTIONS
try
----------------
Hmm. All of these `#ifdef`s get ugly fast. I think it might be better to add
`TEST_TRY` and `TEST_CATCH(...)` macros defined like:
```
#ifndef TEST_HAS_NO_EXCEPTIONS
#define TEST_TRY try
#define TEST_CATCH(...) catch(__VA_ARGS__)
#else
#define TEST_TRY
#define TEST_CATCH(...) if (false)
#endif
```
What do you think? Feel free to add those macros to `test_macros.h` if you like
the idea.
https://reviews.llvm.org/D26139
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
