[PATCH] D23765: Fix for clang PR 29087

twoh updated this revision to Diff 76817. twoh added a comment. Addressing comments from @rsmith. Thanks! https://reviews.llvm.org/D23765 Files: lib/Sema/SemaExprCXX.cpp test/SemaCXX/cxx11-crashes.cpp Index: test/SemaCXX/cxx11-crashes.cpp ==

r285879 - [Sema] Remove a dead assignment, NFC.

Author: vedantk Date: Thu Nov 3 01:35:16 2016 New Revision: 285879 URL: http://llvm.org/viewvc/llvm-project?rev=285879&view=rev Log: [Sema] Remove a dead assignment, NFC. The assignment to NextIsDereference is either followed by (1) another, unrelated assignment to NextIsDereference or by (2) an

[PATCH] D26271: [PPC} add extract significand/ extract exponent/test data class for vector float and vector double -- clang portion

sfertile created this revision. sfertile added reviewers: kbarton, nemanjai, amehsan, syzaara, jtony, lei. sfertile added subscribers: cfe-commits, echristo. sfertile set the repository for this revision to rL LLVM. Add support in altivec.h for the following functions, as well as matching builtin

r285873 - [CodeGen] Use StringRef. NFC.

Author: gbiv Date: Wed Nov 2 21:21:43 2016 New Revision: 285873 URL: http://llvm.org/viewvc/llvm-project?rev=285873&view=rev Log: [CodeGen] Use StringRef. NFC. Looks like CurFn's name outlives FunctionName, so we can just pass StringRefs around rather than going from a StringRef to a std::string

r285872 - [Sema] Allow static_cast(e) to check explicit conversions for non-reference-related types.

Author: ericwf Date: Wed Nov 2 21:13:17 2016 New Revision: 285872 URL: http://llvm.org/viewvc/llvm-project?rev=285872&view=rev Log: [Sema] Allow static_cast(e) to check explicit conversions for non-reference-related types. Summary: [expr.cast.static] states: > 3. A glvalue of type “cv1 T1” can

[PATCH] D26231: [Sema] Allow static_cast(e) to check explicit conversions for non-reference-related types.

EricWF marked 2 inline comments as done. EricWF added inline comments. Comment at: lib/Sema/SemaCast.cpp:1148 + // FIXME C++1z doesn't allow this conversions for xvalues. if (!SrcExpr->isGLValue()) rsmith wrote: > Actually, it does, but it's covered by p4.

[PATCH] D26166: [Sema] Don't issue analysis-based warnings when a fatal error has occurred

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaTemplateInstantiate.cpp:213-214 + // Don't allow further instantiation if a fatal error and an uncompilable + // error have occcured. Any diagn

[PATCH] D21298: [Clang-tidy] delete null check

SilverGeri removed rL LLVM as the repository for this revision. SilverGeri updated this revision to Diff 76803. Herald added a subscriber: mgorny. https://reviews.llvm.org/D21298 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/DeleteNullPointerCheck.cpp clang-tidy/misc/DeleteNullPoint

[PATCH] D26268: [CUDA] Use only the GVALinkage on function definitions.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: rsmith, cfe-commits. Previously we'd look at the GVALinkage of whatever FunctionDecl you happened to be calling. This is not right. In the absence of the gnu_inline attribute, to be handled separately, the func

[PATCH] D26267: [Modules] Include builtins with #include instead of #import for ObjC

bruno created this revision. bruno added a reviewer: rsmith. bruno added subscribers: cfe-commits, manmanren. After r284797 builins are treated like textual includes. When compiling for ObjC++, the in-memory header file generated for the modules is composed only of #import's instead of includes.

r285870 - Update manglings for C++17 noexcept function types to match Jason Merrill's

Author: rsmith Date: Wed Nov 2 19:27:54 2016 New Revision: 285870 URL: http://llvm.org/viewvc/llvm-project?rev=285870&view=rev Log: Update manglings for C++17 noexcept function types to match Jason Merrill's proposal on cxx-abi-dev earlier today. Modified: cfe/trunk/lib/AST/ItaniumMangle.cpp

r285869 - Teach clang-query to dump types. I couldn't find any existing tests for clang-query's dumping functionality. =(

Author: rsmith Date: Wed Nov 2 18:57:18 2016 New Revision: 285869 URL: http://llvm.org/viewvc/llvm-project?rev=285869&view=rev Log: Teach clang-query to dump types. I couldn't find any existing tests for clang-query's dumping functionality. =( Modified: cfe/trunk/include/clang/AST/Type.h

r285868 - [index] Fix assertion hit when handling a declaration of C++'s 'operator new' function.

Author: akirtzidis Date: Wed Nov 2 18:42:33 2016 New Revision: 285868 URL: http://llvm.org/viewvc/llvm-project?rev=285868&view=rev Log: [index] Fix assertion hit when handling a declaration of C++'s 'operator new' function. Part of this is to allow creating a USR for the canonical decl of that

[libcxxabi] r285867 - [p0012] Implement ABI support for throwing a noexcept function pointer and

Author: rsmith Date: Wed Nov 2 18:41:51 2016 New Revision: 285867 URL: http://llvm.org/viewvc/llvm-project?rev=285867&view=rev Log: [p0012] Implement ABI support for throwing a noexcept function pointer and catching as non-noexcept This implements the following proposal from cxx-abi-dev: http:/

[PATCH] D26196: AMDGPU: Translate null pointers in private and local addr space

rjmccall added a comment. I think there are a number of conceptual questions here, chiefly among them whether an llvm::ConstantPointerNull in an address-space type should have the correct representation for the target. If the decision for that is "no", then ok, we can produce an explicit repre

[PATCH] D21298: [Clang-tidy] delete null check

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/misc-delete-null-pointer.rst:10 +.. code:: c++ +int *p; + if (p) Please indent variable declaration. https://reviews.llvm.org/D21298 ___ cfe

Re: r285856 - Don't require nullability on template parameters in typedefs.

> On Nov 2, 2016, at 16:20, Richard Smith wrote: > > On Wed, Nov 2, 2016 at 3:51 PM, Jordan Rose via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > >> On Nov 2, 2016, at 15:48, Richard Smith > > wrote: >> >> On Wed, Nov 2, 2016 at 2:34 PM, Jordan Rose

Re: r285856 - Don't require nullability on template parameters in typedefs.

On Wed, Nov 2, 2016 at 3:51 PM, Jordan Rose via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Nov 2, 2016, at 15:48, Richard Smith wrote: > > On Wed, Nov 2, 2016 at 2:34 PM, Jordan Rose via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> On Nov 2, 2016, at 14:31, Richard Smit

[PATCH] D26231: [Sema] Allow static_cast(e) to check explicit conversions for non-reference-related types.

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5946 +def err_bad_rvalue_to_rvalue_cast : Error< + "cannot cast from rvalue reference of type %1 to rvalue referen

Re: r285856 - Don't require nullability on template parameters in typedefs.

> On Nov 2, 2016, at 15:48, Richard Smith wrote: > > On Wed, Nov 2, 2016 at 2:34 PM, Jordan Rose via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > >> On Nov 2, 2016, at 14:31, Richard Smith > > wrote: >> >> On 2 Nov 2016 1:53 pm, "Jordan Rose via cfe

Re: r285856 - Don't require nullability on template parameters in typedefs.

On Wed, Nov 2, 2016 at 2:34 PM, Jordan Rose via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Nov 2, 2016, at 14:31, Richard Smith wrote: > > On 2 Nov 2016 1:53 pm, "Jordan Rose via cfe-commits" < > cfe-commits@lists.llvm.org> wrote: > > Author: jrose > Date: Wed Nov 2 15:44:07 2016 >

[PATCH] D26118: [clang-tidy] Change readability-redundant-member-init to get base type from constructor

malcolm.parsons updated this revision to Diff 76797. malcolm.parsons added a comment. Add test. https://reviews.llvm.org/D26118 Files: clang-tidy/readability/RedundantMemberInitCheck.cpp test/clang-tidy/readability-redundant-member-init.cpp Index: test/clang-tidy/readability-redundant-mem

[PATCH] D26207: [ClangTidy - performance-unnecessary-value-param] Only add "const" when current parameter is not already const qualified

flx added inline comments. Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:242 +// Case where parameter in declaration is already const-qualified but not in +// implementation. Make sure a second 'const' is not added to the declaration. +void PositiveConstDecl

[PATCH] D26196: AMDGPU: Translate null pointers in private and local addr space

yaxunl added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:7039 + if (CGM.getTarget().getTriple().getArch() != llvm::Triple::amdgcn || +(AS != Ctx.getTargetAddressSpace(LangAS::opencl_local) && AS != 0)) +return C; arsenm wrote: > Shouldn't the

[PATCH] D26196: AMDGPU: Translate null pointers in private and local addr space

yaxunl updated the summary for this revision. yaxunl updated this revision to Diff 76792. yaxunl added a comment. Fixed translation of a pointer to bool. Added more tests. https://reviews.llvm.org/D26196 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CGExprConstant.cpp lib/CodeGen/CGExprScalar

[PATCH] D26218: [clang-tidy] Ignore notes along with a warning when processing NOLINT

malcolm.parsons closed this revision. malcolm.parsons added a comment. Committed as r285861. Thanks! https://reviews.llvm.org/D26218 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r285856 - Don't require nullability on template parameters in typedefs.

> On Nov 2, 2016, at 14:31, Richard Smith wrote: > > On 2 Nov 2016 1:53 pm, "Jordan Rose via cfe-commits" > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: jrose > Date: Wed Nov 2 15:44:07 2016 > New Revision: 285856 > > URL: http://llvm.org/viewvc/llvm-project?rev=285856&view=rev >

Re: r285856 - Don't require nullability on template parameters in typedefs.

On 2 Nov 2016 1:53 pm, "Jordan Rose via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: jrose Date: Wed Nov 2 15:44:07 2016 New Revision: 285856 URL: http://llvm.org/viewvc/llvm-project?rev=285856&view=rev Log: Don't require nullability on template parameters in typedefs. Previously t

[clang-tools-extra] r285861 - [clang-tidy] Suppress notes for warnings that were ignored

Author: malcolm.parsons Date: Wed Nov 2 16:14:22 2016 New Revision: 285861 URL: http://llvm.org/viewvc/llvm-project?rev=285861&view=rev Log: [clang-tidy] Suppress notes for warnings that were ignored Fixes PR30565. Patch by Nikita Kakuev Added: clang-tools-extra/trunk/test/clang-tidy/Input

[PATCH] D26226: Don't require nullability on template parameters in typedefs.

jordan_rose closed this revision. jordan_rose added a comment. Committed in r285856. Repository: rL LLVM https://reviews.llvm.org/D26226 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

r285856 - Don't require nullability on template parameters in typedefs.

Author: jrose Date: Wed Nov 2 15:44:07 2016 New Revision: 285856 URL: http://llvm.org/viewvc/llvm-project?rev=285856&view=rev Log: Don't require nullability on template parameters in typedefs. Previously the following code would warn on the use of "T": template struct X { typedef T *ty

[PATCH] D24991: Inline hot functions in libcxx shared_ptr implementation.

kubabrecka added a comment. In https://reviews.llvm.org/D24991#586219, @sebpop wrote: > I just ran ninja check-all with and without this patch and there are no > regressions in compiler-rt on an x86_64-linux machine. The TSan interceptors (and testcases) are Darwin-only at this point. I'll ru

[PATCH] D26231: [Sema] Allow static_cast(e) to check explicit conversions for non-reference-related types.

EricWF updated this revision to Diff 76775. EricWF added a comment. - Add tests under `test/CXX` - Add FIXME regarding the C++1z change from glvalue to lvalue in p3. https://reviews.llvm.org/D26231 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCast.cpp test/CXX/expr/expr.

[PATCH] D26082: Support for Python 3 in libclang python bindings

jbcoe added inline comments. Comment at: bindings/python/clang/cindex.py:77 +# Python 3 strings are unicode, translate them to/from utf8 for C-interop +if type(u"") == str: +class c_string_p(c_char_p): mgorny wrote: > What is the Python3 version you're aiming

[PATCH] D26082: Support for Python 3 in libclang python bindings

jbcoe updated this revision to Diff 76774. jbcoe marked an inline comment as done. jbcoe added a comment. Respond to review comments. https://reviews.llvm.org/D26082 Files: bindings/python/clang/cindex.py bindings/python/tests/cindex/test_translation_unit.py Index: bindings/python/tests/ci

[PATCH] D25760: [AVX512][Clang] Adding missing instructions' variations

coby abandoned this revision. coby added a comment. Amending vpmultishiftqb is currently being maintained at the following patches: https://reviews.llvm.org/D26258 https://reviews.llvm.org/D26257 All other changes are discarded Repository: rL LLVM https://reviews.llvm.org/D25760 __

[PATCH] D24991: Inline hot functions in libcxx shared_ptr implementation.

sebpop added a comment. In https://reviews.llvm.org/D24991#583877, @kubabrecka wrote: > Just a question: TSan intercepts on the dylib functions, namely > `__release_shared`, to track the atomic accesses. Can you make sure this > doesn't break? There's a few testcases for this in compiler-rt.

[PATCH] D26218: [clang-tidy] Ignore notes along with a warning when processing NOLINT

nkakuev added a comment. @malcolm.parsons, can you please commit this patch? I don't have commit rights. https://reviews.llvm.org/D26218 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D26258: [AVX512][llvm] Amending vpmultishiftqb

coby created this revision. coby added reviewers: craig.topper, m_zuckerman, igorb, delena, AsafBadouh. coby added a subscriber: cfe-commits. coby set the repository for this revision to rL LLVM. The 'vpmultishiftqb' instruction was implemented falsely, this patch amend it. This is the clang part,

r285852 - [analyzer] StdLibraryFunctions: provide platform-specific function summaries.

Author: dergachev Date: Wed Nov 2 14:35:20 2016 New Revision: 285852 URL: http://llvm.org/viewvc/llvm-project?rev=285852&view=rev Log: [analyzer] StdLibraryFunctions: provide platform-specific function summaries. Because standard functions can be defined differently on different platforms, this

[PATCH] D25940: [analyzer] LibraryFunctions: Fix errors due to different integral types and typedefs on different architectures.

This revision was automatically updated to reflect the committed changes. Closed by commit rL285852: [analyzer] StdLibraryFunctions: provide platform-specific function summaries. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D25940?vs=76731&id=76771#toc Repository:

[PATCH] D26218: [clang-tidy] Ignore notes along with a warning when processing NOLINT

nkakuev updated this revision to Diff 76769. nkakuev marked an inline comment as done. nkakuev added a comment. Fix a typo. https://reviews.llvm.org/D26218 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h test/clang-tidy/Inputs/nolint/trigger_warn

[PATCH] D25204: Register Calling Convention, Clang changes

This revision was automatically updated to reflect the committed changes. Closed by commit rL285849: regcall: Implement regcall Calling Conv in clang (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D25204?vs=76717&id=76755#toc Repository: rL LLVM https://reviews.

[clang-tools-extra] r285848 - [Documentation] Fix Clang-tidy misc-use-after-move and cert-msc50-cpp style and misspelling.

Author: eugenezelenko Date: Wed Nov 2 13:23:52 2016 New Revision: 285848 URL: http://llvm.org/viewvc/llvm-project?rev=285848&view=rev Log: [Documentation] Fix Clang-tidy misc-use-after-move and cert-msc50-cpp style and misspelling. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/ce

r285849 - regcall: Implement regcall Calling Conv in clang

Author: erichkeane Date: Wed Nov 2 13:29:35 2016 New Revision: 285849 URL: http://llvm.org/viewvc/llvm-project?rev=285849&view=rev Log: regcall: Implement regcall Calling Conv in clang This patch implements the register call calling convention, which ensures as many values as possible are passed

[libunwind] r285845 - Add support for old versions of MacOS to libunwind. Fixes PR22203. Thanks to Jeremy for the bug report and the patch.

Author: marshall Date: Wed Nov 2 12:56:05 2016 New Revision: 285845 URL: http://llvm.org/viewvc/llvm-project?rev=285845&view=rev Log: Add support for old versions of MacOS to libunwind. Fixes PR22203. Thanks to Jeremy for the bug report and the patch. Modified: libunwind/trunk/include/libun

[PATCH] D25811: [libcxx] Fix toupper/tolower tests for UTF-8 locale

arphaman added a comment. In https://reviews.llvm.org/D25811#586053, @kparzysz wrote: > In https://reviews.llvm.org/D25811#586000, @arphaman wrote: > > > I've tested this patch on OS X and these 4 tests that you've changed now > > fail. > > > > The `XFAIL: with_system_cxx_lib` lines don't have a

[PATCH] D25811: [libcxx] Fix toupper/tolower tests for UTF-8 locale

kparzysz added a comment. And thanks for help. :) Repository: rL LLVM https://reviews.llvm.org/D25811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r285842 - [clang-tidy] Extend misc-use-after-move to support unique_ptr and shared_ptr.

Author: mboehme Date: Wed Nov 2 12:34:47 2016 New Revision: 285842 URL: http://llvm.org/viewvc/llvm-project?rev=285842&view=rev Log: [clang-tidy] Extend misc-use-after-move to support unique_ptr and shared_ptr. Summary: As a unique_ptr or shared_ptr that has been moved from is guaranteed to be n

[PATCH] D26041: [clang-tidy] Extend misc-use-after-move to support unique_ptr and shared_ptr.

This revision was automatically updated to reflect the committed changes. mboehme marked 2 inline comments as done. Closed by commit rL285842: [clang-tidy] Extend misc-use-after-move to support unique_ptr and shared_ptr. (authored by mboehme). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D25811: [libcxx] Fix toupper/tolower tests for UTF-8 locale

kparzysz added a comment. In https://reviews.llvm.org/D25811#586000, @arphaman wrote: > I've tested this patch on OS X and these 4 tests that you've changed now fail. > > The `XFAIL: with_system_cxx_lib` lines don't have any effect on my system - > these tests get invoked as expected by lit. Let

[PATCH] D26218: [clang-tidy] Ignore notes along with a warning when processing NOLINT

malcolm.parsons accepted this revision. malcolm.parsons added a comment. This revision is now accepted and ready to land. LGTM, with typo below fixed. Comment at: test/clang-tidy/nolint.cpp:36 +} +// CHECK-NOT: header.h:{{.*}} warning: The left operand of '>' is a garbage valu

[PATCH] D25204: Register Calling Convention, Clang changes

rnk accepted this revision. rnk added a reviewer: rnk. rnk added a comment. This revision is now accepted and ready to land. Looks good to me. https://reviews.llvm.org/D25204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D26082: Support for Python 3 in libclang python bindings

mgorny added a comment. A few comments/questions. However, please note that those are generic Python comments and I haven't used or tested the clang Python API yet. Comment at: bindings/python/clang/cindex.py:77 +# Python 3 strings are unicode, translate them to/from utf8 for

[PATCH] D14274: Add alloc_size attribute to clang

george.burgess.iv added a comment. With any luck, this'll be on the top of my to-do list next week. :) https://reviews.llvm.org/D14274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25811: [libcxx] Fix toupper/tolower tests for UTF-8 locale

arphaman added a comment. I've tested this patch on OS X and these 4 tests that you've changed now fail. The `XFAIL: with_system_cxx_lib` lines don't have any effect on my system - these tests get invoked as expected by lit. Let me know if there's anything else I can do to help you. Repositor

[PATCH] D26118: [clang-tidy] Change readability-redundant-member-init to get base type from constructor

malcolm.parsons added inline comments. Comment at: clang-tidy/readability/RedundantMemberInitCheck.cpp:57 "initializer for base class %0 is redundant") - << Init->getTypeSourceInfo()->getType() + << Construct->getType() << FixItHint::Creat

[PATCH] D26138: [clang-tidy] Add modernize-use-equals-delete check

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseEqualsDeleteCheck.cpp:58 + << FixItHint::CreateInsertion(StartLoc, "public: ") + << FixItHint::CreateInsertion(AfterLoc, " private:"); +} malcolm.parsons wrote: > aaron.ballman wro

[PATCH] D25940: [analyzer] LibraryFunctions: Fix errors due to different integral types and typedefs on different architectures.

NoQ updated this revision to Diff 76731. NoQ added a comment. Comment up on variants. https://reviews.llvm.org/D25940 Files: lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp test/Analysis/std-c-library-functions.c Index: test/Analysis/std-c-library-functions.c ===

[PATCH] D26138: [clang-tidy] Add modernize-use-equals-delete check

malcolm.parsons added inline comments. Comment at: clang-tidy/modernize/UseEqualsDeleteCheck.cpp:58 + << FixItHint::CreateInsertion(StartLoc, "public: ") + << FixItHint::CreateInsertion(AfterLoc, " private:"); +} aaron.ballman wrote: > I am on the fence

[PATCH] D26118: [clang-tidy] Change readability-redundant-member-init to get base type from constructor

aaron.ballman added inline comments. Comment at: clang-tidy/readability/RedundantMemberInitCheck.cpp:57 "initializer for base class %0 is redundant") - << Init->getTypeSourceInfo()->getType() + << Construct->getType() << FixItHint::CreateR

[PATCH] D26082: Support for Python 3 in libclang python bindings

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. It would be nice if there is a simple way to handle the possible performance impact for python 2. Worst case, we can deal with it when it becomes an issue. Comment at:

[PATCH] D26138: [clang-tidy] Add modernize-use-equals-delete check

malcolm.parsons updated this revision to Diff 76729. malcolm.parsons added a comment. Take out renaming of modernize-use-default. https://reviews.llvm.org/D26138 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseEqualsDeleteChe

[PATCH] D26041: [clang-tidy] Extend misc-use-after-move to support unique_ptr and shared_ptr.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you! https://reviews.llvm.org/D26041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] r285831 - Add conditions for PPC to libunwind. Fixes PR22200. Thanks to Jeremy for the bug report and the patch.

Author: marshall Date: Wed Nov 2 11:39:55 2016 New Revision: 285831 URL: http://llvm.org/viewvc/llvm-project?rev=285831&view=rev Log: Add conditions for PPC to libunwind. Fixes PR22200. Thanks to Jeremy for the bug report and the patch. Modified: libunwind/trunk/src/config.h Modified: libu

[PATCH] D26195: Ignore incomplete types when determining whether they are expensive to copy

aaron.ballman added a comment. In https://reviews.llvm.org/D26195#585198, @flx wrote: > In https://reviews.llvm.org/D26195#585091, @aaron.ballman wrote: > > > In https://reviews.llvm.org/D26195#584958, @flx wrote: > > > > > In https://reviews.llvm.org/D26195#584730, @aaron.ballman wrote: > > > >

[PATCH] D26207: [ClangTidy - performance-unnecessary-value-param] Only add "const" when current parameter is not already const qualified

aaron.ballman added inline comments. Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:131 *Result.Context); -if (!IsConstQualified) +if (!CurrentParam.getType().getCanonicalType().isConstQualifie

Re: r285543 - Make output of ast-print closer to C++ code

Test? On 30 Oct 2016 10:20 pm, "Serge Pavlov via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > Author: sepavloff > Date: Mon Oct 31 00:11:12 2016 > New Revision: 285543 > > URL: http://llvm.org/viewvc/llvm-project?rev=285543&view=rev > Log: > Make output of ast-print closer to C++ code > >

[PATCH] D26138: [clang-tidy] Add modernize-use-equals-delete check

aaron.ballman added a comment. Can you split the modernize-use-default changes into a separate patch? I think that change requires additional discussion, because renaming the check may break users relying on the old name. The changes aren't really related (aside from naming consistency), and I'

[PATCH] D14274: Add alloc_size attribute to clang

hfinkel added a comment. What's the status of this? https://reviews.llvm.org/D14274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r285289 - [Sema] -Wunused-variable warning for array variables should behave

On 1 November 2016 at 14:22, David Blaikie wrote: > > > On Tue, Nov 1, 2016 at 3:13 AM Alex L wrote: > >> On 31 October 2016 at 15:34, David Blaikie wrote: >> >> >> >> On Thu, Oct 27, 2016 at 6:40 AM Alex Lorenz via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >> Author: arphaman >> D

r285825 - Simplify the test case from r285289.

Author: arphaman Date: Wed Nov 2 11:11:30 2016 New Revision: 285825 URL: http://llvm.org/viewvc/llvm-project?rev=285825&view=rev Log: Simplify the test case from r285289. This commit simplifies and clarifies the test code that was added in r285289. Suggested by David Blaikie. Modified: cf

[PATCH] D25263: [Driver] Allow setting the default linker during build

phosek updated this revision to Diff 76720. phosek marked 3 inline comments as done. Repository: rL LLVM https://reviews.llvm.org/D25263 Files: CMakeLists.txt include/clang/Config/config.h.cmake include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/ToolChains.cpp lib

Re: r285625 - DebugInfo: support for DW_TAG_atomic_type

Ping? > On Oct 31, 2016, at 12:41 PM, Adrian Prantl via cfe-commits > wrote: > >> >> On Oct 31, 2016, at 12:09 PM, Victor Leschuk via cfe-commits >> wrote: >> >> Author: vleschuk >> Date: Mon Oct 31 14:09:47 2016 >> New Revision: 285625 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=28

[PATCH] D26218: [clang-tidy] Ignore notes along with a warning when processing NOLINT

nkakuev added a reviewer: malcolm.parsons. nkakuev updated this revision to Diff 76718. nkakuev added a comment. Fixed review comments: replaced a static variable with a class member. https://reviews.llvm.org/D26218 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagn

[PATCH] D25204: Register Calling Convention, Clang changes

erichkeane updated this revision to Diff 76717. erichkeane added a comment. It was brought to my attention that regcall isn't a calling convention that should cause MSVC to switch to C++ mangling. Switched that and updated the tests. https://reviews.llvm.org/D25204 Files: include/clang-c/I

[PATCH] D22955: [MSVC] Improved late parsing of template functions.

ABataev added a comment. Ping! https://reviews.llvm.org/D22955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26189: Add a note that points to the linkage specifier for the "must have C++ linkage" errors

This revision was automatically updated to reflect the committed changes. Closed by commit rL285823: Add a note that points to the linkage specifier for the C++ linkage errors (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D26189?vs=76577&id=76716#toc Repository: r

[PATCH] D25940: [analyzer] LibraryFunctions: Fix errors due to different integral types and typedefs on different architectures.

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. LGTM other than the missing explanation in comments. https://reviews.llvm.org/D25940 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

r285823 - Add a note that points to the linkage specifier for the C++ linkage errors

Author: arphaman Date: Wed Nov 2 10:46:34 2016 New Revision: 285823 URL: http://llvm.org/viewvc/llvm-project?rev=285823&view=rev Log: Add a note that points to the linkage specifier for the C++ linkage errors This commit improves the "must have C++ linkage" error diagnostics that are emitted for

r285820 - [asan] Use the dynamic ASan runtime if -shared-libasan is passed

Author: rnk Date: Wed Nov 2 10:38:51 2016 New Revision: 285820 URL: http://llvm.org/viewvc/llvm-project?rev=285820&view=rev Log: [asan] Use the dynamic ASan runtime if -shared-libasan is passed -shared-libasan is likely to be used as a link flag if the user is using the GCC-style clang driver.

[libcxx] r285818 - Implement another part of P0031; adding constexpr to move_iterator

Author: marshall Date: Wed Nov 2 10:30:26 2016 New Revision: 285818 URL: http://llvm.org/viewvc/llvm-project?rev=285818&view=rev Log: Implement another part of P0031; adding constexpr to move_iterator Modified: libcxx/trunk/include/iterator libcxx/trunk/test/std/iterators/predef.iterato

[PATCH] D25828: Implement part of P0031; adding `constexpr` to `move_iterator`

mclow.lists accepted this revision. mclow.lists added a reviewer: mclow.lists. mclow.lists added a comment. This revision is now accepted and ready to land. Committed as revision 285818 https://reviews.llvm.org/D25828 ___ cfe-commits mailing list cf

[PATCH] D19979: [analyzer] ScopeContext - initial implementation

NoQ added a comment. https://llvm.org/bugs/show_bug.cgi?id=28450 ^Another impressing test case for variable scopes, which should ideally be fixed by scope contexts, even though i doubt this patch (or the CFG patch) addresses this issue. Variable-length arrays might actually mess up things quite

r285810 - Turn on the /bigobj switch for RecursiveASTVisitorTest.cpp; we are now bumping up against that limit with MSVC 2015 in Win64 debug build mode.

Author: aaronballman Date: Wed Nov 2 09:31:36 2016 New Revision: 285810 URL: http://llvm.org/viewvc/llvm-project?rev=285810&view=rev Log: Turn on the /bigobj switch for RecursiveASTVisitorTest.cpp; we are now bumping up against that limit with MSVC 2015 in Win64 debug build mode. Modified:

[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

falho added a comment. Thanks ! https://reviews.llvm.org/D22346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r285809 - Add a new clang-tidy check for cert-msc50-cpp (and cert-msc30-c) that corresponds to the CERT C++ secure coding rule: https://www.securecoding.cert.org/confluence/display

Author: aaronballman Date: Wed Nov 2 09:16:36 2016 New Revision: 285809 URL: http://llvm.org/viewvc/llvm-project?rev=285809&view=rev Log: Add a new clang-tidy check for cert-msc50-cpp (and cert-msc30-c) that corresponds to the CERT C++ secure coding rule: https://www.securecoding.cert.org/confl

[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've commit in r285809 https://reviews.llvm.org/D22346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26244: [Driver] Prefer libraries installed next to Clang over those from GCC

Hahnfeld created this revision. Hahnfeld added reviewers: mgorny, rsmith, EricWF. Hahnfeld added a subscriber: cfe-commits. This is for example needed to make sure we get LLVM's `libunwind.so.1` and don't end up with the system default non-GNU `libunwind.so.8` as reported in https://reviews.llvm

[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

falho added a comment. I just figured out that I don't have right to commit to llvm so I would appreciate if you could commit this check for me. Do you need any info about me? Thank you! https://reviews.llvm.org/D22346 ___ cfe-commits mailing list

[PATCH] D26157: [OpenCL] always use SPIR address spaces for kernel_arg_addr_space MD

pekka.jaaskelainen added a comment. In https://reviews.llvm.org/D26157#585688, @bader wrote: > @pekka.jaaskelainen, I have related question: what is the problem with > retaining OpenCL address space information in LLVM IR? > My understanding is that target CodeGen can ignore this information fo

[PATCH] D26157: [OpenCL] always use SPIR address spaces for kernel_arg_addr_space MD

bader added a comment. @pekka.jaaskelainen, I have related question: what is the problem with retaining OpenCL address space information in LLVM IR? My understanding is that target CodeGen can ignore this information for the machines with 'flat' address space model. On the other hand I would exp

[PATCH] D26206: Fix Clang-tidy readability-redundant-string-cstr warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rL285799: Fix Clang-tidy readability-redundant-string-cstr warnings (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D26206?vs=76642&id=76685#toc Repository: rL LLVM ht

[PATCH] D26218: [clang-tidy] Ignore notes along with a warning when processing NOLINT

malcolm.parsons added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:312 DiagnosticsEngine::Level DiagLevel, const Diagnostic &Info) { + static bool ShouldIgnoreNotes = false; + if (ShouldIgnoreNotes && DiagLevel == DiagnosticsEngine::Note) ---

r285799 - Fix Clang-tidy readability-redundant-string-cstr warnings

Author: malcolm.parsons Date: Wed Nov 2 05:39:27 2016 New Revision: 285799 URL: http://llvm.org/viewvc/llvm-project?rev=285799&view=rev Log: Fix Clang-tidy readability-redundant-string-cstr warnings Reviewers: aaron.ballman, mehdi_amini, dblaikie Subscribers: cfe-commits Differential Revision:

[PATCH] D26234: [Frontend] Add a predefined macro that describes the Objective-C bool type

arphaman created this revision. arphaman added reviewers: bob.wilson, steven_wu. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch adds a new predefined macro named `__OBJC_BOOL_IS_BOOL` that describes the Objective-C boolean type: its

[PATCH] D26139: Tests for strings conversions under libcpp-no-exceptions

rmaprath added a comment. Would it be more cleaner to separate out the exceptions-related tests into their own functions? So, we'd have the two functions `test_withexceptions()` and `test_noexceptions()`; the former will only be invoked when testing the normal library variant, the latter will b

[libcxx] r285792 - Remove spurious token from #endif

Author: rogfer01 Date: Wed Nov 2 03:36:43 2016 New Revision: 285792 URL: http://llvm.org/viewvc/llvm-project?rev=285792&view=rev Log: Remove spurious token from #endif Modified: libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_array_nothrow.pass.cpp M

[PATCH] D26197: Protect tests for new/delete under libcpp-no-exceptions

This revision was automatically updated to reflect the committed changes. Closed by commit rL285791: Protect tests for new/delete under libcpp-no-exceptions (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D26197?vs=76575&id=76675#toc Repository: rL LLVM https://rev

[PATCH] D25008: [cmake] Split linked libraries into private & public, for linker script

Hahnfeld added a comment. Please disregard the noise, I think the error lays in the testing of `compiler-rt` which clears `LIBRARY_PATH` and therefore doesn't find the right `libunwind`! Repository: rL LLVM https://reviews.llvm.org/D25008 ___ c

  1   2   >