I think this breaks windows bot:
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/30745/steps/build%20clang%20lld/logs/stdio
C:\PROGRA~2\MICROS~1.0\VC\bin\AMD64_~2\cl.exe /nologo /TP
-DCLANG_ENABLE_ARCMT -DCLANG_ENABLE_OBJC_REWRITER
-DCLANG_ENABLE_STATIC_ANALYZER -DGTEST_HAS_RTTI=0 -D
vsk created this revision.
vsk added reviewers: rjmccall, pcc.
vsk added a subscriber: cfe-commits.
If we see a virtual method call to Base::foo() but can infer that the
object is an instance of Derived, and that 'foo' is marked 'final' in
Derived, we can devirtualize the call to Derived::foo().
craig.topper added inline comments.
Comment at: lib/Headers/avx512vbmivlintrin.h:225
static __inline__ __m256i __DEFAULT_FN_ATTRS
-_mm256_maskz_multishift_epi64_epi8 (__mmask32 __M, __m256i __X, __m256i __Y)
+_mm256_maskz_multishift_epi64_epi8 (__mmask8 __M, __m256i __X, __m256i
EricWF added a comment.
Seems like we should figure out why these pass on ToT OS X.
Repository:
rL LLVM
https://reviews.llvm.org/D25811
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Brad Smith wrote:
> On Fri, Oct 14, 2016 at 09:47:17PM -0400, Brad Smith via cfe-commits wrote:
> > On Fri, Oct 14, 2016 at 05:59:54PM -, Ed Maste via cfe-commits wrote:
> > > Author: emaste
> > > Date: Fri Oct 14 12:59:53 2016
> > > New Revision: 284256
> > >
> > > URL: http://llvm.org/viewvc
Author: ericwf
Date: Wed Oct 19 22:31:07 2016
New Revision: 284691
URL: http://llvm.org/viewvc/llvm-project?rev=284691&view=rev
Log:
Attempt to workaround XPASS for aligned allocation tests
Modified:
libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align
Author: epilk
Date: Wed Oct 19 21:46:22 2016
New Revision: 284690
URL: http://llvm.org/viewvc/llvm-project?rev=284690&view=rev
Log:
Replace uses of LLVM_FUNCTION_NAME with __func__, this was macro was removed
from llvm/Support in r284681
Modified:
cfe/trunk/tools/libclang/CIndexHigh.cpp
kparzysz created this revision.
kparzysz added a reviewer: EricWF.
kparzysz added a subscriber: cfe-commits.
kparzysz set the repository for this revision to rL LLVM.
The characters like '\xDA' or '\xFA' are not valid representations of anything
in UTF-8, so toupper and tolower return the charact
Author: rsmith
Date: Wed Oct 19 20:20:00 2016
New Revision: 284685
URL: http://llvm.org/viewvc/llvm-project?rev=284685&view=rev
Log:
Refactor and simplify Sema::FindCompositePointerType. No functionality change
intended.
Modified:
cfe/trunk/lib/Sema/SemaExprCXX.cpp
Modified: cfe/trunk/lib/S
Author: rsmith
Date: Wed Oct 19 19:55:15 2016
New Revision: 284684
URL: http://llvm.org/viewvc/llvm-project?rev=284684&view=rev
Log:
PR26276: Fix detection of non-cast-expressions as operands of fold-expressions.
Modified:
cfe/trunk/include/clang/AST/ExprCXX.h
cfe/trunk/lib/AST/ExprCXX.cp
Author: vleschuk
Date: Wed Oct 19 19:37:07 2016
New Revision: 284683
URL: http://llvm.org/viewvc/llvm-project?rev=284683&view=rev
Log:
Upgrade debug-info-vla test: we do not pass default alignment now
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-vla.cpp
Modified: cfe/trunk/test/CodeGenCXX/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284679: DebugInfo: pass alignment value only if it was
forced (authored by vleschuk).
Changed prior to commit:
https://reviews.llvm.org/D24426?vs=74686&id=75261#toc
Repository:
rL LLVM
https://revie
tra created this revision.
tra added reviewers: jlebar, rsmith.
tra added a subscriber: cfe-commits.
Current behavior:
- __host__ __device__ (HD) functions are considered to be redeclarations of
`__host__` (H) of `__device__` (D) functions with same signature.
- Target attributes are not taken i
Author: vleschuk
Date: Wed Oct 19 19:13:19 2016
New Revision: 284679
URL: http://llvm.org/viewvc/llvm-project?rev=284679&view=rev
Log:
DebugInfo: pass alignment value only if it was forced
Preparation to implement DW_AT_alignment support:
- We pass non-zero align value to DIBuilder only when ali
srhines added a comment.
This looks good to me, but I would prefer if one of the more experienced Clang
folks could officially LGTM this. Thanks.
https://reviews.llvm.org/D24010
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
On Wed, Oct 19, 2016 at 5:05 PM, Manman Ren wrote:
> manmanren created this revision.
> manmanren added reviewers: bruno, rsmith, benlangmuir.
> manmanren added a subscriber: cfe-commits.
>
> I don't quite like the if statement in the patch, but given that
> ASTReader::Error and DelayedDiagnostic
Author: rsmith
Date: Wed Oct 19 19:01:36 2016
New Revision: 284673
URL: http://llvm.org/viewvc/llvm-project?rev=284673&view=rev
Log:
Fix crash on noreturn conversion in unprototyped function type. Thanks to Keith
Walker for spotting the bug.
Modified:
cfe/trunk/lib/Sema/SemaOverload.cpp
c
manmanren created this revision.
manmanren added reviewers: bruno, rsmith, benlangmuir.
manmanren added a subscriber: cfe-commits.
I don't quite like the if statement in the patch, but given that
ASTReader::Error and DelayedDiagnostic only take strings, it is hard to just
change err_fe_pch_file_
Sunil_Srivastava added a comment.
ping
https://reviews.llvm.org/D22057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Wed Oct 19 18:47:37 2016
New Revision: 284669
URL: http://llvm.org/viewvc/llvm-project?rev=284669&view=rev
Log:
Extend hack to work around bad exception specifications for 'swap' members to
also cover libstdc++'s std::__debug::array and std::__profile::array.
Modified:
cf
Author: rnk
Date: Wed Oct 19 18:39:55 2016
New Revision: 284667
URL: http://llvm.org/viewvc/llvm-project?rev=284667&view=rev
Log:
Use noexcept instead of LLVM_NOEXCEPT now that all compilers support it
Modified:
cfe/trunk/include/clang/AST/Attr.h
cfe/trunk/include/clang/AST/Stmt.h
cfe
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Thanks, looks good with some nits
Comment at: lib/CodeGen/CGDebugInfo.cpp:1397
const auto *Base =
cast(BI.getType()->getAs()->getDecl());
rnk wrote
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D25595
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
On Wed, Oct 19, 2016 at 3:38 PM, David Majnemer
wrote:
>
>
> On Wed, Oct 19, 2016 at 2:04 PM, Hans Wennborg via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: hans
>> Date: Wed Oct 19 13:04:27 2016
>> New Revision: 284624
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=284624&
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25797
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mgottesman
Date: Wed Oct 19 17:46:06 2016
New Revision: 284658
URL: http://llvm.org/viewvc/llvm-project?rev=284658&view=rev
Log:
[cmake] Follow LLVM's lead in creating exported tool targets for clang tools.
This is needed by downstream projects such as swift to get proper cmake
dependency
efriedma added a comment.
Ping
https://reviews.llvm.org/D24378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
elsteveogrande added a comment.
ping - seems I'm unable to commit this myself. Thanks!
https://reviews.llvm.org/D25153
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Wed, Oct 19, 2016 at 2:04 PM, Hans Wennborg via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: hans
> Date: Wed Oct 19 13:04:27 2016
> New Revision: 284624
>
> URL: http://llvm.org/viewvc/llvm-project?rev=284624&view=rev
> Log:
> MS ABI: Fix assert when generating virtual function c
Author: rsmith
Date: Wed Oct 19 17:18:42 2016
New Revision: 284653
URL: http://llvm.org/viewvc/llvm-project?rev=284653&view=rev
Log:
Add optimization to sizeof...(X) handling: if none of parameter pack X's
corresponding arguments are unexpanded pack expansions, we can compute the
result without su
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284652: Don't crash generating debug info for VLA in
function prototype. (authored by efriedma).
Changed prior to commit:
https://reviews.llvm.org/D25793?vs=75219&id=75243#toc
Repository:
rL LLVM
ht
Author: efriedma
Date: Wed Oct 19 17:16:32 2016
New Revision: 284652
URL: http://llvm.org/viewvc/llvm-project?rev=284652&view=rev
Log:
Don't crash generating debug info for VLA in function prototype.
Fixes regression from r279445.
Differential Revision: https://reviews.llvm.org/D25793
Modified
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284651: DebugInfo: use uint32_t for alignment variables.
(authored by vleschuk).
Changed prior to commit:
https://reviews.llvm.org/D25621?vs=75143&id=75241#toc
Repository:
rL LLVM
https://reviews.ll
Author: vleschuk
Date: Wed Oct 19 17:11:07 2016
New Revision: 284651
URL: http://llvm.org/viewvc/llvm-project?rev=284651&view=rev
Log:
DebugInfo: use uint32_t for alignment variables.
LLVM now uses uint32_t for DebugInfo alignment for space efficiency,
in this patch we change frontend DebugInfo-r
manmanren added a comment.
It makes sense to rebuild the expression when a field designator stores a
FieldDecl.
Thanks for working on this!
Manman
Comment at: lib/Sema/TreeTransform.h:8926
D.getFieldLoc()));
+ if (D.getFiel
jlebar created this revision.
jlebar added a reviewer: rnk.
jlebar added a subscriber: cfe-commits.
NFC
https://reviews.llvm.org/D25797
Files:
clang/include/clang/Sema/Sema.h
clang/lib/Sema/SemaCUDA.cpp
Index: clang/lib/Sema/SemaCUDA.cpp
===
tra created this revision.
tra added a reviewer: jlebar.
tra added a subscriber: cfe-commits.
Implicit functions are treated as if they were __host__ __device__ and clang
does not allow overloading
those with __host__ or __device__ variants.
In order for users to provide their own standard allo
bruno added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3903
+if (!Data.split('.').first.getAsInteger(10, MajorVersion)) {
+ switch (MajorVersion) {
+case 5:
clang-format the `switch`: `case`'s should be aligned with it.
Author: cbieneman
Date: Wed Oct 19 16:18:48 2016
New Revision: 284648
URL: http://llvm.org/viewvc/llvm-project?rev=284648&view=rev
Log:
[CMake] Add clang-bootstrap-deps target
Having this target allows other parts of the build system to add to the
bootstrap dependencies without needing to be def
bruno added a comment.
Thanks for looking into this. It's a nice FixIt to have.
I don't see any dep cycle; clangFormat depends on clangToolingCore, which also
depends clangRewrite, which means there are going to be 3 new dependencies for
libSema in the end: clangToolingCore, clangRewrite and cl
Author: jlebar
Date: Wed Oct 19 16:15:01 2016
New Revision: 284647
URL: http://llvm.org/viewvc/llvm-project?rev=284647&view=rev
Log:
[CUDA] When we emit an error that might have been deferred, also print a
callstack.
Summary:
Previously, when you did something not allowed in a host+device functi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284647: [CUDA] When we emit an error that might have been
deferred, also print a… (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25704?vs=75178&id=75226#toc
Repository:
rL L
dblaikie accepted this revision.
dblaikie added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/CodeGen/CGDebugInfo.cpp:2183-2185
+ if (VAT->getSizeExpr()) {
+llvm::APSInt V;
+if (VAT->getSizeExpr()->EvaluateAsInt(V, CGM.getC
Author: cbieneman
Date: Wed Oct 19 16:12:04 2016
New Revision: 284646
URL: http://llvm.org/viewvc/llvm-project?rev=284646&view=rev
Log:
[CMake] Support thin LTO in PGO CMake cache
This allows you to set PGO_INSTRUMENT_LTO=Thin and have it work correctly.
Modified:
cfe/trunk/cmake/caches/PGO.
efriedma created this revision.
efriedma added a reviewer: dblaikie.
efriedma added a subscriber: cfe-commits.
efriedma set the repository for this revision to rL LLVM.
Fixes regression from r279445.
Repository:
rL LLVM
https://reviews.llvm.org/D25793
Files:
lib/CodeGen/CGDebugInfo.cpp
t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284643: [CUDA] Emit errors for wrong-side calls made on the
same line as non-wrong-side… (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25702?vs=74910&id=75220#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284644: [AST] Add CanonicalDeclPtr. (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25703?vs=74911&id=75222#toc
Repository:
rL LLVM
https://reviews.llvm.org/D25703
Files:
Author: jlebar
Date: Wed Oct 19 16:03:42 2016
New Revision: 284644
URL: http://llvm.org/viewvc/llvm-project?rev=284644&view=rev
Log:
[AST] Add CanonicalDeclPtr.
Summary:
CanonicalDeclPtr is just like a T*, except it calls
T::getCanonicalDecl() on construction.
This is useful as the key in a "set
Author: jlebar
Date: Wed Oct 19 16:03:38 2016
New Revision: 284643
URL: http://llvm.org/viewvc/llvm-project?rev=284643&view=rev
Log:
[CUDA] Emit errors for wrong-side calls made on the same line as non-wrong-side
calls.
Summary:
This fixes two related bugs:
1) Previously, if you had a non-wrong
jlebar marked 2 inline comments as done.
jlebar added a comment.
Thank you for the review, Reid.
https://reviews.llvm.org/D25704
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar marked 2 inline comments as done.
jlebar added a comment.
I'm going to submit this and send a patch to reuse FunctionDeclAndLoc. But I'm
happy to add a comment about the note as well.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6707
+def note_called_
Author: vedantk
Date: Wed Oct 19 15:53:16 2016
New Revision: 284642
URL: http://llvm.org/viewvc/llvm-project?rev=284642&view=rev
Log:
[ubsan] Drop dependency on a 64-bit arch in a test (NFC)
This should fix:
http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/46184
Modified:
cfe/
Author: vedantk
Date: Wed Oct 19 15:28:35 2016
New Revision: 284639
URL: http://llvm.org/viewvc/llvm-project?rev=284639&view=rev
Log:
[ubsan] Re-work check lines to try to appease a bot (NFC)
This bot does not produce the IR I expect -- it's missing some
'handler.dynamic_type_cache_miss:' labels.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284636: [ubsan] Use the object pointer's type info for
devirtualized calls (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D25448?vs=75168&id=75211#toc
Repository:
rL LLVM
h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284638: New clang option -mpie-copy-relocations to use copy
relocations for PIE builds. (authored by tmsriram).
Changed prior to commit:
https://reviews.llvm.org/D19996?vs=75189&id=75212#toc
Repository
Author: tmsriram
Date: Wed Oct 19 15:24:06 2016
New Revision: 284638
URL: http://llvm.org/viewvc/llvm-project?rev=284638&view=rev
Log:
New clang option -mpie-copy-relocations to use copy relocations for PIE builds.
Differential Revision: https://reviews.llvm.org/D19996
Modified:
cfe/trunk/in
Author: vedantk
Date: Wed Oct 19 15:21:16 2016
New Revision: 284636
URL: http://llvm.org/viewvc/llvm-project?rev=284636&view=rev
Log:
[ubsan] Use the object pointer's type info for devirtualized calls
ubsan reports a false positive 'invalid member call' diagnostic on the
following example (PR3047
mgorny added a comment.
Do you think I should just focus on the suffix, or maybe try to make the whole
path configurable?
https://reviews.llvm.org/D23752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
aaron.ballman added inline comments.
Comment at: include/clang/AST/TypeLoc.h:513
struct BuiltinLocInfo {
- SourceLocation BuiltinLoc;
+ SourceRange BuiltinRange;
};
malcolm.parsons wrote:
> aaron.ballman wrote:
> > malcolm.parsons wrote:
> > > aaron.ballman w
yaxunl added a comment.
> Should we deprecate noduplicate then as convergent should cover both use
> cases for OpenCL I believe? As far as I understand noduplicate was added
> specifically for SPMD use cases...
noduplicate has different semantics than convergent. Although it is proposed
for SP
yaxunl updated this revision to Diff 75203.
yaxunl marked 4 inline comments as done.
yaxunl added a comment.
Fix typo in test.
https://reviews.llvm.org/D25343
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/CGCall.cpp
lib/Headers/opencl-c.h
lib/Sema/Sema
hans added a comment.
In https://reviews.llvm.org/D25779#574630, @majnemer wrote:
> Why did this only fail with -flto? Seems strange.
I was asking myself the same thing :-) It's because of this code in
MicrosoftCXXABI::getVirtualFunctionPointer:
if (CGM.getCodeGenOpts().PrepareForLTO) // XX
majnemer added a comment.
Why did this only fail with -flto? Seems strange.
Repository:
rL LLVM
https://reviews.llvm.org/D25779
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malcolm.parsons added inline comments.
Comment at: include/clang/AST/TypeLoc.h:513
struct BuiltinLocInfo {
- SourceLocation BuiltinLoc;
+ SourceRange BuiltinRange;
};
aaron.ballman wrote:
> malcolm.parsons wrote:
> > aaron.ballman wrote:
> > > malcolm.parsons
timshen updated this revision to Diff 75186.
timshen added a comment.
Add tests for regex_match.
https://reviews.llvm.org/D25595
Files:
libcxx/include/regex
libcxx/test/std/re/re.const/re.matchflag/match_not_null.pass.cpp
Index: libcxx/test/std/re/re.const/re.matchflag/match_not_null.pass
tmsriram updated this revision to Diff 75189.
tmsriram added a comment.
- Fix Help text.
- Fix indentation.
https://reviews.llvm.org/D19996
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/BackendUtil.cpp
lib/Driver/Tools.cpp
lib/Frontend/Co
timshen added a comment.
In https://reviews.llvm.org/D25595#574364, @mclow.lists wrote:
> Do we need to test calling `regex_match` with `match_not_null`?
> If not, then I think this is good to go.
Done.
> Do you have commit access, or would you rather I committed it?
Yes, I have the commit a
tmsriram added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:589
Args.hasArg(OPT_mincremental_linker_compatible);
+ Opts.PIECopyRelocations =
+ Args.hasArg(OPT_mpie_copy_relocations);
mgrang wrote:
> You should also check for the n
mgrang added inline comments.
Comment at: lib/Driver/Tools.cpp:4502
+ if (Args.hasFlag(options::OPT_mpie_copy_relocations,
options::OPT_mno_pie_copy_relocations,
+ false)) {
Please fix indentation.
Comment at: lib/Frontend
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: include/clang/Driver/Options.td:1696
+ Flags<[CC1Option]>,
+ HelpText<"Copy Relocations support for PIE builds">;
+def mno_pie_copy_relocations : Flag<["-"], "mn
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6707
+def note_called_by : Note<"called by %0">;
def err_kern_type_not_void_return : Error<
Do
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Looks great, thanks.
https://reviews.llvm.org/D25448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
tmsriram updated this revision to Diff 75179.
tmsriram added a comment.
- Changed help text to "Avail copy relocations support for PIE builds"
- Removed mno-pie... as a CC1 option
- Removed help text from mno-pie..
https://reviews.llvm.org/D19996
Files:
include/clang/Driver/Options.td
inclu
rnk added a comment.
In https://reviews.llvm.org/D19996#422906, @rafael wrote:
> Is there a gcc option or they just assume they are targeting the
> linker that was around when gcc was built?
IIRC there's no GCC option. They base their decision on the configure-time
check like you suggested.
jlebar added inline comments.
Comment at: clang/include/clang/Sema/Sema.h:9292
+ llvm::DenseMap,
+ /* Callees = */ llvm::SetVector>
+ CUDACallGraph;
rnk wrote:
> Rather than having a custom key type, maybe it would be better to phrase this
sdardis added a comment.
Thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D25017
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar updated this revision to Diff 75178.
jlebar marked 2 inline comments as done.
jlebar added a comment.
Address rnk's comments.
https://reviews.llvm.org/D25704
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/include/clang/Sema/Sema.h
clang/lib/Sema/SemaCUDA.cpp
clang/
aaron.ballman added inline comments.
Comment at: include/clang/AST/TypeLoc.h:513
struct BuiltinLocInfo {
- SourceLocation BuiltinLoc;
+ SourceRange BuiltinRange;
};
malcolm.parsons wrote:
> aaron.ballman wrote:
> > malcolm.parsons wrote:
> > > aaron.ballman w
mclow.lists added a comment.
This is the same problem as is facing https://reviews.llvm.org/D24991
https://reviews.llvm.org/D25624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hans
Date: Wed Oct 19 13:04:27 2016
New Revision: 284624
URL: http://llvm.org/viewvc/llvm-project?rev=284624&view=rev
Log:
MS ABI: Fix assert when generating virtual function call with virtual bases and
-flto (PR30731)
getClassAtVTableLocation() was calling
ASTRecordLayout::getBaseClassO
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284624: MS ABI: Fix assert when generating virtual function
call with virtual bases and… (authored by hans).
Changed prior to commit:
https://reviews.llvm.org/D25779?vs=75171&id=75177#toc
Repository:
mclow.lists added a comment.
I don't have a problem with this being marked as inline, as long as it doesn't
disappear out of the dylib.
There *has* to be a version of `basic_string,
Allocator>::~basic_string` in the dylib - existing applications depend
upon it. (same for `wchar_t`).
https://
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284620: [mips][msa] Range check MSA intrinsics with
immediates (authored by sdardis).
Changed prior to commit:
https://reviews.llvm.org/D25017?vs=74499&id=75173#toc
Repository:
rL LLVM
https://revie
srhines updated this revision to Diff 75174.
srhines added a comment.
Added a test for this behavior.
I missed that "-### -v" was actually working correctly last night. Tests added
so I am more satisfied that this won't break accidentally in the future.
https://reviews.llvm.org/D25761
Files:
Author: sdardis
Date: Wed Oct 19 12:50:52 2016
New Revision: 284620
URL: http://llvm.org/viewvc/llvm-project?rev=284620&view=rev
Log:
[mips][msa] Range check MSA intrinsics with immediates
This patch teaches clang to range check immediates for MIPS MSA instrinsics.
This checking is done strictly
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D25779
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans created this revision.
hans added a reviewer: pcc.
hans added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini.
getClassAtVTableLocation() was calling ASTRecordLayout::getBaseClassOffset() on
a virtual base, causing an assert.
https://reviews.llvm.org/D25779
Files:
lib/
Anastasia added a comment.
In https://reviews.llvm.org/D25343#567374, @tstellarAMD wrote:
> In https://reviews.llvm.org/D25343#565288, @Anastasia wrote:
>
> > Do you have any code example where Clang/LLVM performs wrong optimizations
> > with respect to the control flow of SPMD execution?
> >
>
mclow.lists added a comment.
Do we need to test calling `regex_match` with `match_not_null`?
If not, then I think this is good to go.
Do you have commit access, or would you rather I committed it?
https://reviews.llvm.org/D25595
___
cfe-commits mai
Author: dougk
Date: Wed Oct 19 12:30:40 2016
New Revision: 284617
URL: http://llvm.org/viewvc/llvm-project?rev=284617&view=rev
Log:
[Myriad] Find libc++ headers next to clang binary
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
cfe/trunk/test/Driver/myriad-toolchain.c
Modified: cfe/trunk
mclow.lists added a comment.
In https://reviews.llvm.org/D25595#572043, @timshen wrote:
> BTW, `re.const/re.matchflag/match_flag_type.pass.cpp` contains match_not_bow,
> but it doesn't actually test the functionality.
It tests that it exists and that it has a sane value - which are a good thin
vsk updated this revision to Diff 75168.
vsk added a comment.
Thanks for the feedback!
Patch update:
- Pass in the right CalleeDecl to EmitCXXMemberOrOperatorCall. This lets us
drop the unnecessary 'DevirtualizedClassTy' optional parameter.
- Extend the test case with John's example (devirt for
Anastasia added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1272
+if (getLangOpts().OpenCL) {
+ UA = llvm::GlobalValue::UnnamedAddr::None;
+ AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant);
Why this change?
https://rev
arphaman created this revision.
arphaman added reviewers: rjmccall, manmanren.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch fixes an invalid `Winitializer-overrides` warning that's shown for a
piece of code like this:
template
rnk added inline comments.
Comment at: clang/include/clang/Sema/Sema.h:9292
+ llvm::DenseMap,
+ /* Callees = */ llvm::SetVector>
+ CUDACallGraph;
Rather than having a custom key type, maybe it would be better to phrase this
as a `MapVector,
jlebar added a comment.
In https://reviews.llvm.org/D25702#574289, @rnk wrote:
> lgtm
>
> I'm assuming you're going to follow this up with CanonicalDeclPtr usage.
Yes, that's in https://reviews.llvm.org/D25704.
https://reviews.llvm.org/D25702
___
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
I'm assuming you're going to follow this up with CanonicalDeclPtr usage.
https://reviews.llvm.org/D25702
___
cfe-commi
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25703
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/Target/X86/X86ISelLowering.cpp:32315
+}
+ // Else fall through (handle "Y" constraint).
case 'v':
Use LLVM_FALLTHROUGH here to avoid w
mclow.lists closed this revision.
mclow.lists marked 3 inline comments as done.
mclow.lists added a comment.
Landed as revision 284602
https://reviews.llvm.org/D25534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
1 - 100 of 152 matches
Mail list logo
