jlebar added inline comments.

================
Comment at: clang/include/clang/Sema/Sema.h:9292
+  llvm::DenseMap</* Caller = */ CanonicalDeclPtr<FunctionDecl>,
+                 /* Callees = */ llvm::SetVector<FunctionDeclAndLoc>>
+      CUDACallGraph;
----------------
rnk wrote:
> Rather than having a custom key type, maybe it would be better to phrase this 
> as a `MapVector<CanonicalDeclPtr<FunctionDecl>, SourceLocation>` ? Despite 
> all the comments, I assumed FunctionDeclAndLoc was hashed by both elements 
> for a long time.
That's much better; thank you.


https://reviews.llvm.org/D25704



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to