Author: mehdi_amini
Date: Fri Sep 30 21:56:57 2016
New Revision: 283004
URL: http://llvm.org/viewvc/llvm-project?rev=283004&view=rev
Log:
Use StringRef in Pass/PassManager APIs (NFC)
Modified:
cfe/trunk/lib/CodeGen/CodeGenAction.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp
URL:
htt
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
I'm OK accepting this, but I'm going to weak it before committing so that
`test_macros.h` define `TEST_STACK_ALLOCATOR_WORKAROUND` for non-libc++ builds.
https://reviews.llvm.org/D22973
__
Author: mehdi_amini
Date: Fri Sep 30 20:16:22 2016
New Revision: 282996
URL: http://llvm.org/viewvc/llvm-project?rev=282996&view=rev
Log:
Use StringRef in Triple API (NFC)
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp
URL:
http://llvm.org/viewvc
EricWF added a comment.
This LGTM but I can't approve Clang patches, so it'll have to wait on @rsmith .
https://reviews.llvm.org/D25130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
jlebar created this revision.
jlebar added reviewers: tra, rnk.
jlebar added a subscriber: cfe-commits.
https://reviews.llvm.org/D25150
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/lib/Sema/SemaDecl.cpp
clang/test/SemaCUDA/device-var-init.cu
clang/test/SemaCUDA/static-var
EricWF marked an inline comment as done.
EricWF added inline comments.
> rsmith wrote in SemaDeclCXX.cpp:8157-8160
> If you're going to track the namespace on creation, you need to add
> serialization code for your `Sema::StdExperimentalNamespace` storage. But I'd
> suggest taking a different a
EricWF updated this revision to Diff 73181.
EricWF added a comment.
Address comments about caching the std::experimental namespace. @rsmith could
you please double check that `lookupStdExperimentalNamespace()` is correct?
https://reviews.llvm.org/D25068
Files:
include/clang/Basic/Diagnostic
smeenai added a comment.
My initial understanding of the problem was incorrect; I did some further
experimentation and I think I properly understand what's going on here now.
Sorry for the churn.
https://reviews.llvm.org/D25145
___
cfe-commits mai
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
The behavior of this macro actually needs to apply universally on
Windows and not just when using the Microsoft CRT. Update the macro
definition and documentation accordi
jlebar updated this revision to Diff 73172.
jlebar added a comment.
Update to new CUDADiagIfHostCode API.
https://reviews.llvm.org/D25143
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/lib/Sema/SemaDeclAttr.cpp
clang/test/SemaCUDA/bad-attributes.cu
Index: clang/test/SemaC
jlebar updated this revision to Diff 73171.
jlebar added a comment.
Tweak API a bit.
Now we rely on an implicit conversion to bool. Which is not great, I know, but
in practice I think works better than an explicit named function.
https://reviews.llvm.org/D25139
Files:
clang/include/clang/Ba
Author: rtrieu
Date: Fri Sep 30 19:15:24 2016
New Revision: 282989
URL: http://llvm.org/viewvc/llvm-project?rev=282989&view=rev
Log:
Fix crash when emitting error.
With templated classes, is possible to not be able to determine is a member
function is a special member function before the class is
smeenai added a comment.
@mclow.lists Do you have any preference between this and
https://reviews.llvm.org/D14259? I'm fine either way, but I'd want one of them
to be committed sooner rather than later.
https://reviews.llvm.org/D25053
___
cfe-comm
Author: jlebar
Date: Fri Sep 30 18:57:34 2016
New Revision: 282986
URL: http://llvm.org/viewvc/llvm-project?rev=282986&view=rev
Log:
[CUDA] Disallow __constant__ local variables.
Reviewers: tra, rnk
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D25129
Modified:
c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282986: [CUDA] Disallow __constant__ local variables.
(authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25129?vs=73139&id=73168#toc
Repository:
rL LLVM
https://reviews.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282985: [CUDA] Disallow 'extern __shared__' variables.
(authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25125?vs=73136&id=73167#toc
Repository:
rL LLVM
https://reviews.llvm.o
Author: jlebar
Date: Fri Sep 30 18:57:38 2016
New Revision: 282987
URL: http://llvm.org/viewvc/llvm-project?rev=282987&view=rev
Log:
[CUDA] Harmonize asserts in SemaCUDA, NFC.
Modified:
cfe/trunk/lib/Sema/SemaCUDA.cpp
Modified: cfe/trunk/lib/Sema/SemaCUDA.cpp
URL:
http://llvm.org/viewvc/llv
Author: jlebar
Date: Fri Sep 30 18:57:30 2016
New Revision: 282985
URL: http://llvm.org/viewvc/llvm-project?rev=282985&view=rev
Log:
[CUDA] Disallow 'extern __shared__' variables.
Also add a test that we disallow
__constant__ __shared__ int x;
because it's possible to break this without break
jlebar added inline comments.
> tra wrote in DiagnosticSemaKinds.td:6727
> It's not clear whether you mean global storage class or global namespace.
> The code checks for global storage, but error message is could be interpreted
> either way, IMO.
>
> I'll leave phrasing up to you.
> It's not
Author: rsmith
Date: Fri Sep 30 18:47:58 2016
New Revision: 282984
URL: http://llvm.org/viewvc/llvm-project?rev=282984&view=rev
Log:
Fix tests to not assume they know exactly what will be in Clang's predefines
buffer.
Modified:
clang-tools-extra/trunk/test/pp-trace/pp-trace-conditional.cpp
jlebar created this revision.
jlebar added reviewers: tra, rnk.
jlebar added a subscriber: cfe-commits.
https://reviews.llvm.org/D25143
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/lib/Sema/SemaDeclAttr.cpp
clang/test/SemaCUDA/bad-attributes.cu
Index: clang/test/SemaCUDA/
STL_MSFT added a comment.
I know that this stack_allocator issue is a huge headache, but would it be
possible to accept this small, non-intrusive diff upstream? This is the last
local change that I have.
https://reviews.llvm.org/D22973
___
cfe-com
jlebar updated this revision to Diff 73165.
jlebar added a comment.
Add CUDADiagIfHostCode().
https://reviews.llvm.org/D25139
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/include/clang/Sema/Sema.h
clang/lib/Sema/SemaCUDA.cpp
clang/lib/Sema/SemaExprCXX.cpp
clang/lib/Se
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
MSVC has finally fixed the compiler bug that was warning about unreferenced
parameters when invoking destructors, so we can remove the void casts that were
working around the
STL_MSFT closed this revision.
STL_MSFT added a comment.
This was checked in ages ago.
https://reviews.llvm.org/D23685
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar created this revision.
jlebar added a reviewer: rnk.
jlebar added subscribers: tra, cfe-commits.
Together these let you easily create diagnostics that
- are never emitted for host code
- are always emitted for __device__ and __global__ functions, and
- are emitted for __host__ __device__ f
rsmith added inline comments.
> SemaDeclCXX.cpp:8157-8160
> + CurContext->getRedeclContext()->isStdNamespace()) {
> + PrevNS = getStdExperimentalNamespace();
> + IsStdExperimental = true;
> + AddToKnown = !IsInline;
If you're going to track the namespace on creation,
Author: rsmith
Date: Fri Sep 30 18:16:08 2016
New Revision: 282981
URL: http://llvm.org/viewvc/llvm-project?rev=282981&view=rev
Log:
Fix bogus "inline namespace cannot be reopened as non-inline" diagnostic to
just warn that the second declaration is missing the 'inline' keyword. This is
valid, and
Author: compnerd
Date: Fri Sep 30 18:11:05 2016
New Revision: 282980
URL: http://llvm.org/viewvc/llvm-project?rev=282980&view=rev
Log:
CodeGen: inherit DLLExport attribute in Windows Itanium
When emitting the fundamental type information constants, inherit the
DLLExportAttr from `__fundamental_ty
szepet added inline comments.
> alexfh wrote in SuspiciousEnumUsageCheck.cpp:155
> Why?
Because the hasDisjointValueRange function could not decide the values
properly. So in case of an empty Enum it would not make sense. Fortunately we
know that the empty case should not be reported so used e
szepet updated this revision to Diff 73157.
szepet marked 13 inline comments as done.
szepet added a comment.
Updates based on comments (the testfile note comments will be added in the next
commit)
Some changes in the algorithm/design:
In non-strict mode the checker will only investigate the ope
Author: rsmith
Date: Fri Sep 30 17:41:36 2016
New Revision: 282974
URL: http://llvm.org/viewvc/llvm-project?rev=282974&view=rev
Log:
P0035R4: add predefined __STDCPP_DEFAULT_NEW_ALIGNMENT__ macro. By default, we
assume that ::operator new provides no more alignment than is necessary for any
primit
Author: ericwf
Date: Fri Sep 30 17:38:31 2016
New Revision: 282973
URL: http://llvm.org/viewvc/llvm-project?rev=282973&view=rev
Log:
[coroutines] Diagnose when 'main' is declared as a coroutine.
Summary: The title says it all.
Reviewers: rsmith, GorNishanov
Subscribers: mehdi_amini, cfe-commits
Currently, this warning is on by default. As you said, the results you
found look intentional in many cases, so there is a high false positive
rate. For on by default warnings, we expect a high true positive rate and
intend for users to not disable the warning. From my analysis on a
separate cod
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Minor comment, otherwise LGTM.
> DeclPrinter.cpp:1350-1351
> +
> + // PR 28885: Use the correct record name when the using declaration is used
> + // for inheriting constructors.
> + for (
bruno closed this revision.
bruno added a comment.
Thanks Reid & Akira,
Committed r282968
https://reviews.llvm.org/D24472
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bruno
Date: Fri Sep 30 17:19:38 2016
New Revision: 282968
URL: http://llvm.org/viewvc/llvm-project?rev=282968&view=rev
Log:
[Sema] Support lax conversions for compound assignments
Support lax convertions on compound assignment expressions like:
typedef __attribute__((vector_size(8))) d
GorNishanov added reviewers: rnk, EricWF.
GorNishanov updated this revision to Diff 73155.
GorNishanov marked an inline comment as done.
GorNishanov added a comment.
Improved diagnostics in CGCoroutine and ping...
https://reviews.llvm.org/D24373
Files:
docs/LanguageExtensions.rst
include/cl
Author: kcc
Date: Fri Sep 30 16:57:10 2016
New Revision: 282962
URL: http://llvm.org/viewvc/llvm-project?rev=282962&view=rev
Log:
[sanitizer-coverage] fix docs
Modified:
cfe/trunk/docs/SanitizerCoverage.rst
Modified: cfe/trunk/docs/SanitizerCoverage.rst
URL:
http://llvm.org/viewvc/llvm-proj
tra added inline comments.
> jlebar wrote in DiagnosticSemaKinds.td:6727
> That's still a "global variable"? Or do you think calling it such will be
> confusing?
It's not clear whether you mean global storage class or global namespace.
The code checks for global storage, but error message is c
jlebar added inline comments.
> tra wrote in DiagnosticSemaKinds.td:6727
> Nit: Technically they are allowed in namespace scope.
That's still a "global variable"? Or do you think calling it such will be
confusing?
https://reviews.llvm.org/D25129
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
> DiagnosticSemaKinds.td:6727
> def err_cuda_extern_shared : Error<"__shared__ variable %0 cannot be
> 'extern'">;
> +def err_cuda_nonglobal_constant : Error<"__constant__ variables must be
arphaman created this revision.
arphaman added a reviewer: rsmith.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch ensures that the AST printer outputs the correct C++ type for an
inheriting constructor using declaration.
For example
dcoughlin requested changes to this revision.
dcoughlin added a comment.
This revision now requires changes to proceed.
Upon reflection, I don't think this is the right approach.
Desugaring any AttributedType in the return type seems like a really, really
big hammer and could be an unexpected su
Uploaded to phabricator as https://reviews.llvm.org/D25130
__cpp_coroutines stays as it is.
On Fri, Sep 30, 2016 at 10:11 AM, Gor Nishanov
wrote:
> I noticed that other TSes has experimental in their SD-6 macro name,
> hence, I changed it to match the concepts TS macro
> __cpp_experimental_conc
GorNishanov created this revision.
GorNishanov added reviewers: rsmith, rnk, EricWF, cfe-commits.
Herald added a subscriber: mehdi_amini.
Also makes -fcoroutines_ts to be both a Driver and CC1 flag.
Patch mostly by EricWF.
https://reviews.llvm.org/D25130
Files:
include/clang/Basic/LangOption
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282949: Add missing std::move in Replacements::add (authored
by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D25049?vs=72902&id=73140#toc
Repository:
rL LLVM
https://reviews.llvm.org
Author: alexshap
Date: Fri Sep 30 16:05:45 2016
New Revision: 282949
URL: http://llvm.org/viewvc/llvm-project?rev=282949&view=rev
Log:
Add missing std::move in Replacements::add
This diff adds std::move to avoid copying of
the Replacement NewR in the method Replacements::add.
Test plan: make -j
jlebar created this revision.
jlebar added reviewers: tra, rnk.
jlebar added a subscriber: cfe-commits.
https://reviews.llvm.org/D25129
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/lib/Sema/SemaDeclAttr.cpp
clang/test/SemaCUDA/bad-attributes.cu
Index: clang/test/SemaCUDA/
Author: aizatsky
Date: Fri Sep 30 16:02:56 2016
New Revision: 282948
URL: http://llvm.org/viewvc/llvm-project?rev=282948&view=rev
Log:
[sancov] -symbolize documentation update
Modified:
cfe/trunk/docs/SanitizerCoverage.rst
Modified: cfe/trunk/docs/SanitizerCoverage.rst
URL:
http://llvm.org/
tra accepted this revision.
tra added a reviewer: tra.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D25125
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
jlebar updated this revision to Diff 73136.
jlebar added a comment.
Fix typo (and add a test to catch it).
https://reviews.llvm.org/D25125
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/lib/Sema/SemaDeclAttr.cpp
clang/test/SemaCUDA/bad-attributes.cu
clang/test/SemaCUDA/ex
jlebar created this revision.
jlebar added a reviewer: rnk.
jlebar added subscribers: tra, cfe-commits.
https://reviews.llvm.org/D25125
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/lib/Sema/SemaDeclAttr.cpp
clang/test/SemaCUDA/extern-shared.cu
Index: clang/test/SemaCUDA/e
pcc added a comment.
Perhaps it would be better to enable -ffunction-sections/-fdata-sections
unconditionally at the linker level if the linker supports it? See also PR22999.
https://reviews.llvm.org/D24644
___
cfe-commits mailing list
cfe-commits@
phosek created this revision.
phosek added a subscriber: cfe-commits.
Provide toolchain and tool support for Fuchsia operating system. Fuchsia uses
compiler-rt as the runtime library and libc++, libc++abi and libunwind as the
C++ standard library. lld is used as a default linker.
https://revie
phosek added a comment.
The patch with LLVM triple for Fuchsia is here: https://reviews.llvm.org/D25116
https://reviews.llvm.org/D25117
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
Author: jlebar
Date: Fri Sep 30 15:17:37 2016
New Revision: 282927
URL: http://llvm.org/viewvc/llvm-project?rev=282927&view=rev
Log:
[CUDA] Fix implicit-device-lambda.cu after r282911.
This commit added a warning that we're (correctly) hitting in this test.
Just ignore it.
Modified:
cfe/trun
yaxunl created this revision.
yaxunl added a reviewer: Anastasia.
yaxunl added subscribers: cfe-commits, b-sumner, bader.
__builtin_astype is used to cast OpenCL opaque types to other types, as such,
it needs to be able to handle casting from and to pointer types correctly.
Current it cannot han
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282910: [CUDA] Fix up MaybeParseGNUAttributes call used for
out-of-place attributes on… (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25114?vs=73104&id=73122#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282911: [CUDA] Emit a warning if a CUDA host/device/global
attribute is placed after '(. (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25115?vs=73105&id=73123#toc
Repository:
Author: jlebar
Date: Fri Sep 30 14:55:59 2016
New Revision: 282912
URL: http://llvm.org/viewvc/llvm-project?rev=282912&view=rev
Log:
[CUDA] Remove incorrect comment in CUDASetLambdaAttrs.
I'd said that nvcc doesn't allow you to add __host__ or __device__
attributes on lambdas in all circumstances
Author: jlebar
Date: Fri Sep 30 14:55:55 2016
New Revision: 282911
URL: http://llvm.org/viewvc/llvm-project?rev=282911&view=rev
Log:
[CUDA] Emit a warning if a CUDA host/device/global attribute is placed after
'(...)'.
Summary:
This is probably the sane place for the attribute to go, but nvcc
sp
Author: jlebar
Date: Fri Sep 30 14:55:48 2016
New Revision: 282910
URL: http://llvm.org/viewvc/llvm-project?rev=282910&view=rev
Log:
[CUDA] Fix up MaybeParseGNUAttributes call used for out-of-place attributes on
CUDA lambdas.
Summary: There's an overload that we can use to make this a bit cleane
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25114
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric updated this revision to Diff 73116.
ioeric added a comment.
- Remove redundant variable.
https://reviews.llvm.org/D25065
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespace/ChangeNamespaceTests.cpp
=
rogfer01 added a comment.
Ping?
https://reviews.llvm.org/D23657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282900: [MS] Implement __iso_volatile loads/stores as
builtins (authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D24986?vs=72988&id=73113#toc
Repository:
rL LLVM
https://revi
Author: mstorsjo
Date: Fri Sep 30 14:13:46 2016
New Revision: 282900
URL: http://llvm.org/viewvc/llvm-project?rev=282900&view=rev
Log:
[MS] Implement __iso_volatile loads/stores as builtins
These are supposed to produce the same as normal volatile
pointer loads/stores. When -volatile:ms is specif
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25115
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
majnemer added inline comments.
> mstorsjo wrote in ms-volatile-arm.c:2
> Well, originally, the point was to clarify that these volatile stores end up
> without atomic semantics, regardless of whether -volatile:ms has been
> specified. The original version of this patch (with an inline implemen
jlebar created this revision.
jlebar added a reviewer: rnk.
jlebar added subscribers: tra, cfe-commits.
This is probably the sane place for the attribute to go, but nvcc
specifically rejects it. Other GNU-style attributes are allowed in this
position (although judging from the warning it emits fo
jlebar created this revision.
jlebar added a reviewer: rnk.
jlebar added subscribers: tra, cfe-commits.
There's an overload that we can use to make this a bit cleaner.
https://reviews.llvm.org/D25114
Files:
clang/lib/Parse/ParseExprCXX.cpp
Index: clang/lib/Parse/ParseExprCXX.cpp
===
dcoughlin added a comment.
Sorry, missed this patch.
I think it would good to add a test to make sure we do warn when the var decl
has an initializer, since that will not be executed.
void varDecl(int X) {
switch (X) {
int A = 12; // We do want a warning here, since the variable wil
arphaman created this revision.
arphaman added a reviewer: rsmith.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch improves the displayed diagnostics when encountering a redefinition
of a function whose previous definition was typo-co
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM. Please commit!
https://reviews.llvm.org/D24759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
mstorsjo added inline comments.
> majnemer wrote in ms-volatile-arm.c:2
> You don't need -fms-volatile.
Well, originally, the point was to clarify that these volatile stores end up
without atomic semantics, regardless of whether -volatile:ms has been
specified. The original version of this pat
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
> ms-volatile-arm.c:2
> +// REQUIRES: arm-registered-target
> +// RUN: %clang_cc1 -triple thumbv7-win32 -emit-llvm -fms-extensions
> -fms-volatile -o - < %s | FileCheck %s
> +
You
GorNishanov added a comment.
LGTM
I am happy either way. Fixes for co_return can come later.
https://reviews.llvm.org/D25078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added a comment.
Combined with https://reviews.llvm.org/D25076 (on llvm), this lets me run
libcxx test suite on top of installed LLVM+lit, without LLVM sources.
https://reviews.llvm.org/D25093
___
cfe-commits mailing list
cfe-commits@lists.l
jlebar added inline comments.
> rnk wrote in ParseExprCXX.cpp:1135
> Does nvcc support __declspec style attributes? Maybe we should check for
> those too?
nvcc doesn't seem to support __declspec attributes.
I have no strong opinion on whether or not we should add them ourselves, though
I gues
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282880: [CUDA] Make lambdas inherit __host__ and __device__
attributes from the scope… (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25105?vs=73073&id=73089#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282879: [CUDA] Handle attributes on CUDA lambdas appearing
between [...] and (...). (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25103?vs=73085&id=73088#toc
Repository:
rL
Author: jlebar
Date: Fri Sep 30 12:14:44 2016
New Revision: 282878
URL: http://llvm.org/viewvc/llvm-project?rev=282878&view=rev
Log:
[CUDA] Add missing comment on Sema::CheckCUDAVLA.
Modified:
cfe/trunk/include/clang/Sema/Sema.h
Modified: cfe/trunk/include/clang/Sema/Sema.h
URL:
http://llvm
Author: jlebar
Date: Fri Sep 30 12:14:53 2016
New Revision: 282880
URL: http://llvm.org/viewvc/llvm-project?rev=282880&view=rev
Log:
[CUDA] Make lambdas inherit __host__ and __device__ attributes from the scope
in which they're created.
Summary: NVCC compat. Fixes bug 30567.
Reviewers: tra
Su
Author: jlebar
Date: Fri Sep 30 12:14:48 2016
New Revision: 282879
URL: http://llvm.org/viewvc/llvm-project?rev=282879&view=rev
Log:
[CUDA] Handle attributes on CUDA lambdas appearing between [...] and (...).
Summary: This is ugh, but it makes us compatible with NVCC. Fixes bug 26341.
Reviewers
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
> jlebar wrote in ParseExprCXX.cpp:1135
> nvcc doesn't seem to support __declspec attributes.
>
> I have no strong opinion on whether or not we should add them ourselves,
> though I guess I
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
jlebar updated this revision to Diff 73085.
jlebar marked an inline comment as done.
jlebar added a comment.
Don't hallucinate a function declarator.
https://reviews.llvm.org/D25103
Files:
clang/lib/Parse/ParseExprCXX.cpp
clang/test/Parser/lambda-attr.cu
Index: clang/test/Parser/lambda-at
I noticed that other TSes has experimental in their SD-6 macro name, hence,
I changed it to match the concepts TS macro __cpp_experimental_concepts.
We are reviewing the wording coming Monday and can tweak the SD-6 macro as
needed.
Also, Richard mentioned in the feedback that:
>> However, we *sho
rsmith added a comment.
LGTM, go ahead when Gor is happy.
https://reviews.llvm.org/D25078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
> SemaExpr.cpp:8084
> +// type. Note that this is already done by non-compound assignments in
> +// CheckAssignmentConstraints. If it's a scalar type, only biscast for
> +// <1 x T
arphaman removed rL LLVM as the repository for this revision.
arphaman updated this revision to Diff 73076.
arphaman added a comment.
I had to reuploaded the diff as Phabricator seemed to have removed the 'lib'
and 'test' paths prefixes from the filenames in the original diff.
https://reviews.l
rnk added inline comments.
> ParseExprCXX.cpp:1135
> +// "[...]", even if there is no "(...)" before the lambda body.
> +MaybeParseGNUAttributes(Attr, &DeclEndLoc);
> + }
Does nvcc support __declspec style attributes? Maybe we should check for those
too?
> ParseExprCXX.cpp:1280
>
rmaprath added a comment.
Sigh. I've bumped into some downstream problems. Will commit as soon as I've
verified these problems are not related to the patch.
https://reviews.llvm.org/D24864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
arphaman created this revision.
arphaman added reviewers: aaron.ballman, rogfer01.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch improves the packed member warning by showing the name of the
anonymous structure/union when it was def
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: rnk, cfe-commits.
NVCC compat. Fixes bug 30567.
https://reviews.llvm.org/D25105
Files:
clang/include/clang/Sema/Sema.h
clang/lib/Sema/SemaCUDA.cpp
clang/lib/Sema/SemaLambda.cpp
clang/test/SemaCUDA/imp
agutowski added inline comments.
> BuiltinsX86_32.def:1
> +//===--- BuiltinsX86_32.def - X86-32 Builtin function database --*- C++
> -*-===//
> +//
Will we ever need that file? It seems to nicely complement the 64-bit one, but
if it's going to be empty forever maybe it's better to remove it.
jlebar created this revision.
jlebar added a reviewer: rnk.
jlebar added subscribers: tra, cfe-commits.
This is ugh, but it makes us compatible with NVCC. Fixes bug 26341.
https://reviews.llvm.org/D25103
Files:
clang/lib/Parse/ParseExprCXX.cpp
clang/test/Parser/lambda-attr.cu
Index: clang
zaks.anna added a comment.
Looks good overall. Very minor nits.
> BugReporterVisitors.cpp:1274
>
> + // In the code below, Term is a CFG terminator, and Cond is a branch
> + // condition expression upon which the decision is made on this terminator.
nit: no comma before "and".
> BugReport
hiraditya added a comment.
I had to revert the patch because this test case was failing. The problem was
that the destructors have different return type for different targets. So I'll
modify the testcase and put the patch back in.
Repository:
rL LLVM
https://reviews.llvm.org/D24682
_
1 - 100 of 153 matches
Mail list logo
