tra added inline comments.

> jlebar wrote in DiagnosticSemaKinds.td:6727
> That's still a "global variable"?  Or do you think calling it such will be 
> confusing?

It's not clear whether you mean global storage class or global namespace.
The code checks for global storage, but error message is could be interpreted 
either way, IMO.

I'll leave phrasing up to you.

https://reviews.llvm.org/D25129



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to