Re: [PATCH] D24759: [RFC][StaticAnalyser] fix unreachable code false positives when block numbers mismatch

danielmarjamaki added a comment. Thanks! I somehow missed your answer in cfe-dev. I will continue working on this and hopefully have a proper patch soon. https://reviews.llvm.org/D24759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

Re: [PATCH] D24785: [AVX512] Fix return types on __builtin_ia32_gather3XivXdi builtins

igorb accepted this revision. igorb added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D24785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

jlebar added a comment. > I was not able to figure out how to comandeer a revision, so i just went > ahead and pushed it. Under "leap into action", one of the options is to commandeer the revision. https://reviews.llvm.org/D9168 ___ cfe-commits m

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

jlebar added a subscriber: jlebar. jlebar added a comment. FWIW I have run into this in the past and just not managed to muster up the energy to fix it. So, thank you! https://reviews.llvm.org/D9168 ___ cfe-commits mailing list cfe-commits@lists.l

Re: Modules: Suggestion on how to fix a regression caused by r259901

Hi Richard, Any suggestion on this? Thanks, Manman > On Sep 7, 2016, at 12:40 PM, Manman wrote: > > Hi Richard, > > We noticed a regression for this simple testing case: > rm -rf tmp3 > clang -cc1 -fimplicit-module-maps -x objective-c -fmodules > -fmodules-cache-path=tmp3 -emit-obj standalon

[PATCH] D24785: [AVX512] Fix return types on __builtin_ia32_gather3XivXdi builtins

cameron.mcinally created this revision. cameron.mcinally added reviewers: delena, igorb, craig.topper. cameron.mcinally added a subscriber: cfe-commits. cameron.mcinally set the repository for this revision to rL LLVM. The return types on the AVX512 __builtin_ia32_gather3XivXdi builtins are incor

Re: [PATCH] D24759: [RFC][StaticAnalyser] fix unreachable code false positives when block numbers mismatch

dcoughlin added a comment. Here is the discussion on cfe-dev. http://lists.llvm.org/pipermail/cfe-dev/2016-September/050800.html What's going on is that the path-sensitive unreachable code checker traverses blocks in the unoptimized CFG and emits a diagnostic if a block in that CFG is not reac

Re: [PATCH] D24759: [RFC][StaticAnalyser] fix unreachable code false positives when block numbers mismatch

dcoughlin added a comment. @danielmarjamaki I see what you mean -- thanks for providing the patch. I don't think this is the right approach. It should be sufficient to reason about blocks and not individual statements; further some blocks may be non-empty but not have any statements. Instead,

Re: [PATCH] D24192: [clang-refactor] introducing clang-refactor

arphaman added inline comments. Comment at: clang-refactor/driver/Driver.cpp:36 @@ +35,3 @@ +argv[1] = (llvm::Twine(argv[0]) + " " + llvm::Twine(argv[1])).str().c_str(); +Manager.dispatch(Command, argc - 1, argv + 1); + } else { Is there a particular rea

[PATCH] D24784: [change-namespace] fix name qualifiers in UsingShadowDecl and NestedNameSpecifier.

ioeric created this revision. ioeric added a reviewer: hokein. ioeric added a subscriber: cfe-commits. https://reviews.llvm.org/D24784 Files: change-namespace/ChangeNamespace.cpp change-namespace/ChangeNamespace.h unittests/change-namespace/ChangeNamespaceTests.cpp Index: unittests/change-

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

compnerd added a comment. Im happy to do so, but, could you please rebase the patch? https://reviews.llvm.org/D24609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21506: [analyzer] Block in critical section

This revision was automatically updated to reflect the committed changes. Closed by commit rL282011: [analyzer] Add a checker that detects blocks in critical sections (authored by zaks). Changed prior to commit: https://reviews.llvm.org/D21506?vs=71375&id=71977#toc Repository: rL LLVM https

r282011 - [analyzer] Add a checker that detects blocks in critical sections

Author: zaks Date: Tue Sep 20 15:28:50 2016 New Revision: 282011 URL: http://llvm.org/viewvc/llvm-project?rev=282011&view=rev Log: [analyzer] Add a checker that detects blocks in critical sections This checker should find the calls to blocking functions (for example: sleep, getc, fgets,read,recv

Re: [PATCH] D24192: [clang-refactor] introducing clang-refactor

arphaman added inline comments. Comment at: clang-refactor/core/SymbolIndexClient.h:31 @@ +30,3 @@ +} // end namespace refactor +} // end namespace refactor + End namespace clang? https://reviews.llvm.org/D24192 ___

Re: [PATCH] D24775: Add -Wignored-pragma-intrinsic flag

OK, thanks for the note about referring to Chromium, I fixed that. As to -Wunknown-pragma, I feel that it would be inconsistent with other pragmas unless I moved whole pragma to lexer instead of parser - I've just discovered that I can do that, how should I decide if it's supposed to be here or the

Re: [PATCH] D24513: [AMDGPU] Expose flat work group size, register and wave control attributes

kzhuravl added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:4967 @@ +4966,3 @@ + + D->addAttr(::new (S.Context) + AMDGPUFlatWorkGroupSizeAttr(Attr.getLoc(), S.Context, Min, Max, aaron.ballman wrote: > Is it okay to supply `0, 0` as the min,

Re: [PATCH] D24513: [AMDGPU] Expose flat work group size, register and wave control attributes

kzhuravl updated this revision to Diff 71970. kzhuravl added a comment. Herald added a subscriber: kzhuravl. Mention `0, 0` case in the docs. https://reviews.llvm.org/D24513 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td lib

r282007 - Remove some boilerplate comments that don't explain anything.

Author: echristo Date: Tue Sep 20 14:45:06 2016 New Revision: 282007 URL: http://llvm.org/viewvc/llvm-project?rev=282007&view=rev Log: Remove some boilerplate comments that don't explain anything. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: http://

Re: r281277 - [Sema] Fix PR30346: relax __builtin_object_size checks.

Noted; thanks for the correction. :) On Tue, Sep 20, 2016 at 3:04 AM, Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Sep 19, 2016 at 09:21:33PM -0700, George Burgess IV wrote: > > I'm entirely unfamiliar with struct-path-tbaa, so Hal, do you see a > reason > > w

Re: [PATCH] D24775: Add -Wignored-pragma-intrinsic flag

Thanks! Some bikesheddy comments, ignore as you see fit: - I think it's good to keep Chromium's bug tracker out of LLVM as far as possible (most LLVM devs don't need to care about Chromium, and since Chromium's bug tracker refers to LLVM's bug tracker frequently since chromium depends on llvm, add

Re: [PATCH] D24775: Add -Wignored-pragma-intrinsic flag

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm! https://reviews.llvm.org/D24775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

r282004 - Fix a regex error breaking tests.

Author: zturner Date: Tue Sep 20 14:10:56 2016 New Revision: 282004 URL: http://llvm.org/viewvc/llvm-project?rev=282004&view=rev Log: Fix a regex error breaking tests. Modified: cfe/trunk/test/Driver/warning-options.cpp Modified: cfe/trunk/test/Driver/warning-options.cpp URL: http://llvm.or

r282003 - [CMake] Support overriding CLANG_VERSION_*

Author: cbieneman Date: Tue Sep 20 14:09:21 2016 New Revision: 282003 URL: http://llvm.org/viewvc/llvm-project?rev=282003&view=rev Log: [CMake] Support overriding CLANG_VERSION_* As with how we handle LLVM_VERSION_* variables we should support overriding clang version variables. Modified: cf

r281997 - CodeGen: further merge cstring literal construction

Author: compnerd Date: Tue Sep 20 13:38:54 2016 New Revision: 281997 URL: http://llvm.org/viewvc/llvm-project?rev=281997&view=rev Log: CodeGen: further merge cstring literal construction Use the new CreateCStringLiteral in an additional site. Now all the C string literals are created in one func

Re: [PATCH] D22494: [analyzer] Explain why analyzer report is not generated (fix for PR12421).

zaks.anna added a comment. LGTM. Thanks. https://reviews.llvm.org/D22494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r281998 - Add some entropy to the folder name in Driver/warning-options.cpp.

Author: zturner Date: Tue Sep 20 13:41:19 2016 New Revision: 281998 URL: http://llvm.org/viewvc/llvm-project?rev=281998&view=rev Log: Add some entropy to the folder name in Driver/warning-options.cpp. It was trying to check that things behave correctly when a non-existant folder was specified for

r281996 - Fix typo in documentation.

Author: nicholas Date: Tue Sep 20 13:37:25 2016 New Revision: 281996 URL: http://llvm.org/viewvc/llvm-project?rev=281996&view=rev Log: Fix typo in documentation. Since this is a header it will break links to this section. Modified: cfe/trunk/docs/UndefinedBehaviorSanitizer.rst Modified: cfe

OpenBSD/arm types

As discussed in cfe-dev@: Like NetBSD, OpenBSD prefers having a consistent set of typedefs across the architectures it supports over strictly following the ARM ABIs. The diff below makes sure that clang's view of those types matches OpenBSD's system header files. It also adds a test that checks

Re: [PATCH] D24751: [cleanup] Remove excessive padding from TextTokenRetokenizer::Position

This revision was automatically updated to reflect the committed changes. Closed by commit rL281995: [cleanup] Remove excessive padding from TextTokenRetokenizer::Position (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D24751?vs=71897&id=71963#toc Repository: rL LL

r281995 - [cleanup] Remove excessive padding from TextTokenRetokenizer::Position

Author: alexshap Date: Tue Sep 20 13:32:48 2016 New Revision: 281995 URL: http://llvm.org/viewvc/llvm-project?rev=281995&view=rev Log: [cleanup] Remove excessive padding from TextTokenRetokenizer::Position Reorder the fields of the struct TextTokenRetokenizer::Position to remove excessive paddin

[PATCH] D24775: Add -Wignored-pragma-intrinsic flag

agutowski created this revision. agutowski added reviewers: thakis, hans. agutowski added a subscriber: cfe-commits. https://bugs.chromium.org/p/chromium/issues/detail?id=644841#c9 https://reviews.llvm.org/D24775 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticPa

Re: [PATCH] D24481: make “#pragma STDC FP_CONTRACT” on by default

Abe updated this revision to Diff 71959. Abe added a comment. Collapsed 4 test-case files that didn`t really need to be separate into 1 file, as suggested by Yaxun Liu. https://reviews.llvm.org/D24481 Files: clang/lib/Frontend/CompilerInvocation.cpp clang/test/CodeGen/aarch64-neon-fma.c

Re: [PATCH] D24507: Add attribute for return values that shouldn't be cast to bool

zaks.anna added inline comments. Comment at: test/Analysis/ReturnNonBoolTest.c:67 @@ +66,3 @@ + + if (rc < 0) +// error handling How about addressing this as follows: in checkBranchCondition, you check for any comparisons of the tracked value other than comp

Re: [PATCH] D24759: [RFC][StaticAnalyser] fix unreachable code false positives when block numbers mismatch

zaks.anna added a comment. Sorry, I do not understand the question. What are block numbers? https://reviews.llvm.org/D24759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24481: make “#pragma STDC FP_CONTRACT” on by default

Abe added a comment. In https://reviews.llvm.org/D24481#547694, @yaxunl wrote: > Is it possible to merge > cfe/trunk/test/CodeGen/fp-contract-pragma___on-by-default___-O[0-3]___aarch64-backend.c > as one and remove > cfe/trunk/test/CodeGen/fp-contract-pragma___on-by-default___-O1...3___aarch64

Re: [PATCH] D24481: make “#pragma STDC FP_CONTRACT” on by default

Abe updated this revision to Diff 71953. Abe added a comment. Removed some comments that I felt were good for clarity but at least 2 people disagreed. https://reviews.llvm.org/D24481 Files: cfe/trunk/lib/Frontend/CompilerInvocation.cpp cfe/trunk/test/CodeGen/aarch64-neon-fma.c cfe/trunk/

Re: [PATCH] D24481: make “#pragma STDC FP_CONTRACT” on by default

yaxunl added a comment. > ... then that will cause 3 compilations and 3 tests, right? Right. https://reviews.llvm.org/D24481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24770: [libcxxabi] cleanup the use of LIBCXXABI_HAS_NO_THREADS macro (NFC)

jroelofs added a subscriber: jroelofs. jroelofs accepted this revision. jroelofs added a reviewer: jroelofs. jroelofs added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D24770 ___ cfe-commits mailing list

Re: [PATCH] D24481: make “#pragma STDC FP_CONTRACT” on by default

yaxunl added a comment. Is it possible to merge cfe/trunk/test/CodeGen/fp-contract-pragma___on-by-default___-O[0-3]___aarch64-backend.c as one and remove cfe/trunk/test/CodeGen/fp-contract-pragma___on-by-default___-O1...3___aarch64-backend.h? They look the same except the RUN commands. Why not

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

vchuravy added a comment. @jpienaar Since I don't have commit access, I think somebody else needs to commit this. https://reviews.llvm.org/D9168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

vchuravy updated this revision to Diff 71951. vchuravy added a comment. Fix spelling in comment https://reviews.llvm.org/D9168 Files: lib/Target/NVPTX/NVPTXISelLowering.cpp lib/Target/NVPTX/NVPTXISelLowering.h test/CodeGen/NVPTX/zero-cs.ll Index: test/CodeGen/NVPTX/zero-cs.ll ===

r281988 - [docs] Extend the code coverage docs some more

Author: vedantk Date: Tue Sep 20 12:11:18 2016 New Revision: 281988 URL: http://llvm.org/viewvc/llvm-project?rev=281988&view=rev Log: [docs] Extend the code coverage docs some more Flesh out the section on interpreting coverage reports, mention the coverage export feature, and add notes on how to

[PATCH] D24770: [libcxxabi] cleanup the use of LIBCXXABI_HAS_NO_THREADS macro (NFC)

rmaprath created this revision. rmaprath added reviewers: mclow.lists, EricWF. rmaprath added a subscriber: cfe-commits. Herald added subscribers: mgorny, beanz. Align the naming / use of the macro ``LIBCXXABI_HAS_NO_THREADS`` to follow what we have in `libcxx`. This change is mostly NFC, though

Re: [PATCH] D24674: [mips] MSA intrinsics header file

sdardis closed this revision. sdardis added a comment. As stated I'll do a follow-up patch to fix the test. Committed as r281975. Thanks, Simon https://reviews.llvm.org/D24674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

Re: [PATCH] D24767: clang-format: [JS] do not wrapp @returns tags.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D24767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

jpienaar accepted this revision. jpienaar added a reviewer: jpienaar. jpienaar added a comment. This revision is now accepted and ready to land. Looks good to me, do you need help submitting? Comment at: lib/Target/NVPTX/NVPTXISelLowering.cpp:1032 @@ +1031,3 @@ + if (!CS) { +

Re: [PATCH] D24674: [mips] MSA intrinsics header file

vkalintiris accepted this revision. vkalintiris added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D24674#547589, @vkalintiris wrote: > @sdardis: can you update the review request before committing this because I > don't think that test/CodeGen/builtins

r281979 - Replace 'isProvablyNonNull' with existing utility llvm::IsKnownNonNull which handles more cases. Noticed by inspection.

Author: nicholas Date: Tue Sep 20 10:49:58 2016 New Revision: 281979 URL: http://llvm.org/viewvc/llvm-project?rev=281979&view=rev Log: Replace 'isProvablyNonNull' with existing utility llvm::IsKnownNonNull which handles more cases. Noticed by inspection. Because of how the IR generation works, t

Re: [PATCH] D24674: [mips] MSA intrinsics header file

vkalintiris requested changes to this revision. vkalintiris added a comment. This revision now requires changes to proceed. @sdardis: can you update the review request before committing this because I don't think that test/CodeGen/builtins-mips-msa.c has ever been properly reviewed before. htt

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

vchuravy updated this revision to Diff 71946. vchuravy added a comment. addresses review comments. https://reviews.llvm.org/D9168 Files: lib/Target/NVPTX/NVPTXISelLowering.cpp lib/Target/NVPTX/NVPTXISelLowering.h test/CodeGen/NVPTX/zero-cs.ll Index: test/CodeGen/NVPTX/zero-cs.ll

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

vchuravy added a comment. > You don't own revision D9168: "[NVPTX] Check if callsite is defined when > computing argument allignment". Normally, you should only update > revisions you own. You can "Commandeer" this revision from the web > interface if you want to become the owner. I w

Re: [PATCH] D24448: [atomics] New warning -Watomic-libcall when atomic operation expands to a library call

vkalintiris added a subscriber: vkalintiris. vkalintiris added a comment. I removed myself from the reviewers because I'm not quite familiar with this area. @joerg I added you as reviewer because you've already commented, feel free to undo my change if you don't have time to review this. https

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

jpienaar added a comment. Cool. I didn't know the review system allows having the patch updated like this :) It still reports me as the author and you as a subscriber. I don't think that matters. Comment at: lib/Target/NVPTX/NVPTXISelLowering.cpp:1033 @@ +1032,3 @@ +

Re: [PATCH] D23712: [OpenCL] Override supported OpenCL extensions with -cl-ext option

yaxunl added a comment. I think we need two more tests for concatenating and overriding the option, e.g -cl-ext=-cl_khr_fp64 -cl-ext=+cl_khr_fp64 and -cl-ext=-cl_khr_fp64,+cl_khr_fp64 Comment at: include/clang/Basic/OpenCLOptions.h:35 @@ +34,3 @@ + void setAll(bool Enabl

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

vchuravy updated this revision to Diff 71936. vchuravy added a comment. Rebases the original changes and adds a test-case https://reviews.llvm.org/D9168 Files: lib/Target/NVPTX/NVPTXISelLowering.cpp lib/Target/NVPTX/NVPTXISelLowering.h test/CodeGen/NVPTX/zero-cs.ll Index: test/CodeGen/NV

Re: [PATCH] D24674: [mips] MSA intrinsics header file

mpf added inline comments. Comment at: test/CodeGen/builtins-mips-msa.c:8 @@ -13,4 +7,3 @@ + typedef __fp16 v8f16 __attribute__ ((vector_size(16))); vkalintiris wrote: > @mpf > > Would it be problematic to expose this typedef from msa.h? Yes it would unfortuna

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

vchuravy added a comment. This is my first contribution to llvm so please let me know if I did something wrong in the process https://reviews.llvm.org/D9168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

Re: [PATCH] D22507: Clang-tidy - Enum misuse check

szepet updated the summary for this revision. szepet updated this revision to Diff 71925. szepet marked 7 inline comments as done. szepet added a comment. Herald added subscribers: mgorny, beanz. In order to decrease false positive rate, the bitmask specific checker part investigate only the enum

[PATCH] D24767: clang-format: [JS] do not wrapp @returns tags.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. @returns is incorrect code, the standard is @return. However wrapping it can still confuse users. https://reviews.llvm.org/D24767 Files: lib/Format/For

Re: [PATCH] D24674: [mips] MSA intrinsics header file

sdardis added a comment. @mpf I'll correct the incorrect uses in a followup patch. Thanks, Simon https://reviews.llvm.org/D24674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

tavianator updated this revision to Diff 71934. tavianator marked an inline comment as done. tavianator added a comment. s/indended/intended/ https://reviews.llvm.org/D21803 Files: src/cxa_thread_atexit.cpp test/CMakeLists.txt test/cxa_thread_atexit_test.pass.cpp test/libcxxabi/test/con

Re: [PATCH] D24235: [OpenCL] Improve double literal handling

yaxunl added inline comments. Comment at: lib/Sema/SemaExpr.cpp:3431 @@ -3410,1 +3430,3 @@ +.getSupportedOpenCLOpts() +.cl_khr_fp64) || getOpenCLOptions().cl_khr_fp64)) { neil.hickey wrote: > yaxu

Re: [PATCH] D24507: Add attribute for return values that shouldn't be cast to bool

urusant added inline comments. Comment at: lib/StaticAnalyzer/Checkers/ReturnNonBoolChecker.cpp:50 @@ +49,3 @@ + if (!State->contains(SR)) return; + + ExplodedNode *N = C.generateErrorNode(C.getState()); I have just noticed that I didn't specify the style option

Re: [PATCH] D24507: Add attribute for return values that shouldn't be cast to bool

urusant updated this revision to Diff 71927. Repository: rL LLVM https://reviews.llvm.org/D24507 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/StaticAnalyzer/Checkers/Checkers.td lib/Sema/SemaChecking.cpp

Re: [PATCH] D24674: [mips] MSA intrinsics header file

vkalintiris accepted this revision. vkalintiris added a subscriber: mpf. vkalintiris added a comment. This revision is now accepted and ready to land. LGTM with one comment/question inline. Comment at: test/CodeGen/builtins-mips-msa.c:8 @@ -13,4 +7,3 @@ + typedef __fp16 v8f16 _

Re: [PATCH] D24507: Add attribute for return values that shouldn't be cast to bool

danielmarjamaki added a subscriber: danielmarjamaki. Comment at: include/clang/Basic/AttrDocs.td:2055 @@ -2054,1 +2054,3 @@ } +def WarnImpcastToBoolDocs : Documentation { + let Category = DocCatFunction; I saw your email on cfe-dev. This sounds like a good idea

Re: [PATCH] D24712: Replace 'isProvablyNonNull' with existing utility llvm::IsKnownNonNull.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. In that case, you probably will not be able to test this difference, because the argument is basically required to be the address of a local variable, a parameter, or null (or a various th

Re: [PATCH] D24507: Add attribute for return values that shouldn't be cast to bool

urusant updated this revision to Diff 71921. urusant added a comment. In https://reviews.llvm.org/D24507#546380, @aaron.ballman wrote: > We try to keep our tests segregated by functionality. e.g., tests relating to > the way the attribute is handled (what it appertains to, args, etc) should > l

Re: [PATCH] D23712: [OpenCL] Override supported OpenCL extensions with -cl-ext option

asavonic added a comment. Hi @Anastasia, Sorry for my late reply. > > > What would be the use case to override the supported extensions for the > > > end user? > > > > > > > > > Some extensions may be supported by the platform in general, but not by the > > > specific version of

Re: r281277 - [Sema] Fix PR30346: relax __builtin_object_size checks.

On Mon, Sep 19, 2016 at 09:21:33PM -0700, George Burgess IV wrote: > I'm entirely unfamiliar with struct-path-tbaa, so Hal, do you see a reason > why struct-path-tbaa wouldn't play nicely with flexible arrays at the end > of types? Glancing at it, I don't think it should cause problems, but a > mor

Re: [PATCH] D24235: [OpenCL] Improve double literal handling

neil.hickey added inline comments. Comment at: lib/Sema/SemaExpr.cpp:3431 @@ -3410,1 +3430,3 @@ +.getSupportedOpenCLOpts() +.cl_khr_fp64) || getOpenCLOptions().cl_khr_fp64)) { yaxunl wrote: > This

Re: [PATCH] D24704: PR30401: Fix substitutions for functions with abi_tag

DmitryPolukhin added a comment. Richard, please take another look. https://reviews.llvm.org/D24704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24754: [cleanup] Remove excessive padding from RedeclarableResult

alexshap added a comment. F2435929: Screen Shot 2016-09-20 at 12.19.51 AM.png Repository: rL LLVM https://reviews.llvm.org/D24754 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D24754: [cleanup] Remove excessive padding from RedeclarableResult

alexshap created this revision. alexshap added reviewers: rtrieu, rsmith, bkramer, mehdi_amini. alexshap added a subscriber: cfe-commits. alexshap set the repository for this revision to rL LLVM. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "Al

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

mstorsjo added a comment. Thanks! Can you/someone commit it? https://reviews.llvm.org/D24609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits