It is marked LLVM_ATTRIBUTE_UNUSED_RESULT (which boils down to having
__warn_unused_result__). I am not sure why this didn't trigger during any
local build/test that we did.
Steve
On Thu, Sep 15, 2016 at 11:45 PM, David Majnemer
wrote:
> sext should probably be marked WARN_UNUSED_RESULT
>
>
> O
sext should probably be marked WARN_UNUSED_RESULT
On Thursday, September 15, 2016, Stephen Hines via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> srhines created this revision.
> srhines added a reviewer: cfe-commits.
> srhines added a subscriber: meikeb.
>
> Offset was doubled in size, but
srhines created this revision.
srhines added a reviewer: cfe-commits.
srhines added a subscriber: meikeb.
Offset was doubled in size, but the assignment was missing. We just need
to reassign to the original variable in this case to fix it.
https://reviews.llvm.org/D24648
Files:
lib/Sema/SemaCh
ABataev added a subscriber: ABataev.
Comment at: lib/Sema/SemaChecking.cpp:6588
@@ -6587,2 +6587,3 @@
stackE = EvalAddr(RetValExp, refVars, /*ParentDecl=*/nullptr);
+
} else if (lhsType->isReferenceType()) {
Remove empty line
Comment at:
ABataev added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:5137-5138
@@ -5137,1 +5136,4 @@
+ Stmt *CurStmt = AStmt;
+ if (auto CapS = dyn_cast_or_null(CurStmt))
+CurStmt = CapS->getCapturedStmt();
for (unsigned Cnt = 0; Cnt < NestedLoopCount; ++Cnt) {
EricWF added a comment.
I'll commit this change tomorrow barring any objections.
https://reviews.llvm.org/D24642
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:2055
@@ -2054,1 +2054,3 @@
}
+def WarnImpcastToBoolDocs : Documentation {
+ let Category = DocCatFunction;
You probably need to "propose" the attribute to the clang community. I'd send
EricWF updated this revision to Diff 71594.
EricWF added a comment.
Use spaces not tabs.
https://reviews.llvm.org/D24646
Files:
cmake/modules/AddSphinxTarget.cmake
Index: cmake/modules/AddSphinxTarget.cmake
===
--- cmake/modules
Sorry I haven't had a chance to get back to this. Things got busy at work.
I do plan to get back to this as I'm hoping to add some features to this
extension :)
On Thu, Sep 15, 2016 at 7:31 PM Zachary Turner wrote:
> Strange. FWIW you can dump all the variables that are present in your
> environ
EricWF created this revision.
EricWF added reviewers: rnk, delcypher.
EricWF added subscribers: llvm-commits, cfe-commits.
Herald added subscribers: mgorny, beanz.
The actual logic to build http://llvm.org/libcxx/docs does so with "-W" and
"-n" enabled, meaning that the website will not be update
Author: ericwf
Date: Thu Sep 15 22:47:53 2016
New Revision: 281697
URL: http://llvm.org/viewvc/llvm-project?rev=281697&view=rev
Log:
Attempt to fix Sphinx build
Modified:
libcxx/trunk/docs/BuildingLibcxx.rst
libcxx/trunk/docs/Makefile.sphinx
libcxx/trunk/docs/TestingLibcxx.rst
Modifi
compnerd added inline comments.
Comment at: lib/Headers/intrin.h:504
@@ +503,3 @@
+_interlockedbittestandset_acq(long volatile *_BitBase, long _BitPos) {
+ long _PrevVal = __atomic_fetch_or(_BitBase, 1l << _BitPos, __ATOMIC_ACQUIRE);
+ return (_PrevVal >> _BitPos) & 1;
-
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
The new overloads taking string_view's need to guard against self-aliasing
string_views. Once that is fixed I would double check that your tests for
`!is_convertible<_Tp const&, const _CharT*>
Author: ericwf
Date: Thu Sep 15 21:51:26 2016
New Revision: 281695
URL: http://llvm.org/viewvc/llvm-project?rev=281695&view=rev
Log:
Update _LIBCPP_EXCEPTION_ABI doc with @mclow's feedback
Modified:
libcxx/trunk/docs/DesignDocs/VisibilityMacros.rst
Modified: libcxx/trunk/docs/DesignDocs/Visi
tejohnson created this revision.
tejohnson added reviewers: mehdi_amini, pcc.
tejohnson added a subscriber: cfe-commits.
Herald added subscribers: mehdi_amini, dschuff, jfb.
These options need to be passed to the plugin in order to have
an effect on LTO/ThinLTO compiles.
https://reviews.llvm.org/
Author: rjmccall
Date: Thu Sep 15 21:40:45 2016
New Revision: 281693
URL: http://llvm.org/viewvc/llvm-project?rev=281693&view=rev
Log:
Alter the iOS/tvOS ARM64 C++ ABI to ignore the upper half of the
virtual table offset in a member function pointer.
We are reserving this space for future ABI use
EricWF updated this revision to Diff 71590.
EricWF added a comment.
- Add `always_inline` to _LIBCPP_INLINE_VISIBILITY. In future I think only
_LIBCPP_ALWAYS_INLINE should actually apply `always_inline`, but I'll make that
change separately.
- Change `_LIBCPP_ALWAYS_INLINE` to use `internal_link
Author: ericwf
Date: Thu Sep 15 21:16:23 2016
New Revision: 281692
URL: http://llvm.org/viewvc/llvm-project?rev=281692&view=rev
Log:
Move _LIBCPP_INLINE_VISIBILITY to first declaration in
Modified:
libcxx/trunk/include/experimental/propagate_const
Modified: libcxx/trunk/include/experimental
Author: ericwf
Date: Thu Sep 15 21:09:26 2016
New Revision: 281691
URL: http://llvm.org/viewvc/llvm-project?rev=281691&view=rev
Log:
Move _LIBCPP_INLINE_VISIBILITY to first declaration in sstream.
Modified:
libcxx/trunk/include/sstream
Modified: libcxx/trunk/include/sstream
URL:
http://llvm
rsmith added a comment.
> But not here, because we would have to verify that the pointer in lam wasn't
> mutated in a previous call of the lambda:
Isn't that guaranteed, because the lambda is not marked `mutable`?
Comment at: lib/Sema/SemaChecking.cpp:6594
@@ -6590,1 +6593,3
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
Looks great.
Thank you for seeing it through!
https://reviews.llvm.org/D24642
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281686: Do not warn about format strings that are indexed
string literals. (authored by srhines).
Changed prior to commit:
https://reviews.llvm.org/D24584?vs=71585&id=71586#toc
Repository:
rL LLVM
h
Author: srhines
Date: Thu Sep 15 20:07:04 2016
New Revision: 281686
URL: http://llvm.org/viewvc/llvm-project?rev=281686&view=rev
Log:
Do not warn about format strings that are indexed string literals.
Summary:
The warning for a format string not being a string literal and therefore
being potentia
meikeb updated this revision to Diff 71585.
meikeb added a comment.
.
https://reviews.llvm.org/D24584
Files:
lib/Sema/SemaChecking.cpp
test/Sema/format-strings.c
Index: test/Sema/format-strings.c
===
--- test/Sema/format-strin
meikeb updated this revision to Diff 71584.
meikeb added a comment.
Rebase
https://reviews.llvm.org/D24584
Files:
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGBlocks.h
lib/Sema/SemaChecking.cpp
test/CodeGenObjCXX/lambda-expressions.mm
test/Sema/format-strings.c
Index: test/Sema/format-stri
meikeb updated this revision to Diff 71583.
meikeb added a comment.
Try to drop randomly uploaded commit.
https://reviews.llvm.org/D24584
Files:
lib/Sema/SemaChecking.cpp
test/Sema/format-strings.c
Index: test/Sema/format-strings.c
==
meikeb updated this revision to Diff 71581.
meikeb added a comment.
Rebase to current commit.
https://reviews.llvm.org/D24584
Files:
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGBlocks.h
lib/Sema/SemaChecking.cpp
test/CodeGenObjCXX/lambda-expressions.mm
test/Sema/format-strings.c
Index: te
EricWF updated this revision to Diff 71579.
EricWF added a comment.
Revert accidental change.
https://reviews.llvm.org/D24642
Files:
include/__config
src/string.cpp
Index: src/string.cpp
===
--- src/string.cpp
+++ src/string.c
EricWF created this revision.
EricWF added reviewers: mclow.lists, eugenis.
EricWF added subscribers: cfe-commits, eugenis.
This patch has been a long time coming (Thanks @eugenis). It changes
`_LIBCPP_INLINE_VISIBILITY` to use `__attribute__((internal_linkage))` instead
of `__attribute__((visib
Author: ericwf
Date: Thu Sep 15 19:13:55 2016
New Revision: 281684
URL: http://llvm.org/viewvc/llvm-project?rev=281684&view=rev
Log:
Use _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY in valarray to support
attribute((internal_linkage)).
The externally instantiated member functions must be declared u
Author: ericwf
Date: Thu Sep 15 19:07:16 2016
New Revision: 281683
URL: http://llvm.org/viewvc/llvm-project?rev=281683&view=rev
Log:
Move inline attributes in filesystem to first declaration
Modified:
libcxx/trunk/include/experimental/filesystem
Modified: libcxx/trunk/include/experimental/fi
Author: ahatanak
Date: Thu Sep 15 19:02:06 2016
New Revision: 281682
URL: http://llvm.org/viewvc/llvm-project?rev=281682&view=rev
Log:
[CodeGen][ObjC] Block captures should inherit the type of the captured
field in the enclosing lambda or block.
This patch fixes a bug in code-gen where it uses th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281682: [CodeGen][ObjC] Block captures should inherit the
type of the captured (authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D21104?vs=64199&id=71575#toc
Repository:
rL LL
Author: ericwf
Date: Thu Sep 15 19:00:48 2016
New Revision: 281681
URL: http://llvm.org/viewvc/llvm-project?rev=281681&view=rev
Log:
[libc++] Add _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY to support GCC ABI
compatibility
Summary:
GCC and Clang handle visibility attributes on the out-of-line defi
EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
Accepting to commit. Post commit review is very welcome (but nobody likes
looking at visibility patches).
https://reviews.llvm.org/D24600
_
EricWF updated this revision to Diff 71574.
EricWF added a comment.
- Update the patch based on r281673.
- Add doc for `_LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY`
- Move all uses of `_LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY` to the first
declaration in order to support `__attribute__((internal_l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281680: [CUDA] Don't try to run sanitizers on NVPTX.
(authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D24640?vs=71572&id=71573#toc
Repository:
rL LLVM
https://reviews.llvm.org
Author: jlebar
Date: Thu Sep 15 18:44:13 2016
New Revision: 281680
URL: http://llvm.org/viewvc/llvm-project?rev=281680&view=rev
Log:
[CUDA] Don't try to run sanitizers on NVPTX.
Summary:
Sanitizers aren't supported on NVPTX -- don't try to run them.
This lets you e.g. pass -fsanitize=address and
kcc accepted this revision.
kcc added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D24640
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar created this revision.
jlebar added a reviewer: kcc.
jlebar added subscribers: jhen, tra, cfe-commits.
Sanitizers aren't supported on NVPTX -- don't try to run them.
This lets you e.g. pass -fsanitize=address and get asan on your host
code.
https://reviews.llvm.org/D24640
Files:
clang/
ahatanak abandoned this revision.
ahatanak added a comment.
The crash I was trying to fix was fixed in https://reviews.llvm.org/D23643.
https://reviews.llvm.org/D14471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Strange. FWIW you can dump all the variables that are present in your
environment. You need to go to Tools -> Options -> Projects and Solutions
-> Build and Run and choose either Normal, Detailed, or Diagnostic for the
MSBuild project build output verbosity. Then in the output window you will
ge
When I first opened the solution in VS it prompted me to install it and I did.
On Thu, Sep 15, 2016 at 4:17 PM, Zachary Turner wrote:
> You may need to install the Visual Studio SDK. Did you do that when you
> initially installed VS 2015?
>
> On Thu, Sep 15, 2016 at 4:15 PM Hans Wennborg wrote:
You may need to install the Visual Studio SDK. Did you do that when you
initially installed VS 2015?
On Thu, Sep 15, 2016 at 4:15 PM Hans Wennborg wrote:
> Well, on my machine $(SDKToolsDir) doesn't work :-( I suspect the file
> will need manual tweaking by whoever is trying to build the plugin
Well, on my machine $(SDKToolsDir) doesn't work :-( I suspect the file
will need manual tweaking by whoever is trying to build the plugin.
Anyway, I've updated the solution to build with VS2015 in r281648 and
confirmed that it can still be used with older VS versions too.
Cheers,
Hans
On Thu, Au
erik.pilkington added a comment.
Ping, sorry for the delay.
https://reviews.llvm.org/D22053
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erik.pilkington created this revision.
erik.pilkington added reviewers: faisalv, rsmith.
erik.pilkington added a subscriber: cfe-commits.
Previously, clang emitted no diagnostic for the following:
```
auto f() {
int loc;
return [&] { return loc; };
}
```
The problem being that this returns a d
dcoughlin added a comment.
Thanks for adding the macros. I've provided some feedback inline.
I think a good rule of thumb for readability is: suppose you are a maintainer
and need to add a summary for a new function. Can you copy the the summary for
an existing function and figure out what each
Author: ericwf
Date: Thu Sep 15 17:27:07 2016
New Revision: 281673
URL: http://llvm.org/viewvc/llvm-project?rev=281673&view=rev
Log:
[libc++] Fix and document visibility attributes for Clang, GCC and Windows.
Summary:
This patch fixes a number of problems with the visibility macros across GCC (on
EricWF updated this revision to Diff 71570.
EricWF added a comment.
I'm going to go ahead and commit this w/o review because it's blocking more
important changes. Post-commit comments on the documentation are appreciated.
https://reviews.llvm.org/D24602
Files:
CMakeLists.txt
docs/DesignDoc
EricWF abandoned this revision.
EricWF added a comment.
Abandoning. All issues have been addressed by other commits.
Comment at: include/memory:5452-5458
@@ +5451,9 @@
+ {
+return static_cast<_To>(_FromPtrTraits::pointer_to(__e));
+ }
+
+ _LIBCPP_INLINE_VISIBILITY
+ stat
Author: ahatanak
Date: Thu Sep 15 17:19:25 2016
New Revision: 281669
URL: http://llvm.org/viewvc/llvm-project?rev=281669&view=rev
Log:
[Sema] Allow shifting a scalar operand by a vector operand.
r278501 inadvertently introduced a bug in which it disallowed shifting
scalar operands by vector opera
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281669: [Sema] Allow shifting a scalar operand by a vector
operand. (authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D24467?vs=71545&id=71569#toc
Repository:
rL LLVM
https:/
Author: dlj
Date: Thu Sep 15 17:12:26 2016
New Revision: 281666
URL: http://llvm.org/viewvc/llvm-project?rev=281666&view=rev
Log:
Simplify Clang's version number configuration in CMake.
Currently, the Clang version is computed as follows:
1. LLVM defines major, minor, and patch versions, all st
Author: kcc
Date: Thu Sep 15 17:11:08 2016
New Revision: 281665
URL: http://llvm.org/viewvc/llvm-project?rev=281665&view=rev
Log:
[sanitizer-coverage] make trace-pc-guard and indirect-call work together
Modified:
cfe/trunk/docs/SanitizerCoverage.rst
Modified: cfe/trunk/docs/SanitizerCoverage
EricWF resigned from this revision.
EricWF removed a reviewer: EricWF.
EricWF added a comment.
After talking with @rmaprath we have agreed to go in a different direction.
Resigning as reviewer to keep my queue clean.
https://reviews.llvm.org/D23926
___
rsmith added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:4227
@@ -4226,1 +4226,3 @@
continue;
+// Using(Shadow)Decl itself is not a constructor
+if (isa(ND) || isa(ND))
This isn't really right: a `UsingShadowDecl` whose underly
bkramer accepted this revision.
bkramer added a comment.
looks good from my side.
https://reviews.llvm.org/D18462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
twoh updated this revision to Diff 71560.
twoh added a comment.
Tests added
https://reviews.llvm.org/D23765
Files:
lib/Sema/SemaExprCXX.cpp
test/SemaCXX/crash-has-nothrow-constructor.cpp
test/SemaCXX/crash-has-nothrow-copy.cpp
Index: test/SemaCXX/crash-has-nothrow-copy.cpp
==
EricWF added a comment.
Thanks for working on this. That static initialization bug is ugly.
My only concern with this patch is that adding `constexpr` to unconstrained
constructors is going to result compile errors caused by Clang's eager
instantiation.
Also, unlike @mclow.lists, I think we sh
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:4967
@@ +4966,3 @@
+
+ D->addAttr(::new (S.Context)
+ AMDGPUFlatWorkGroupSizeAttr(Attr.getLoc(), S.Context, Min, Max,
Is it okay to supply `0, 0` as the min, max arguments?
==
blastrock added a comment.
Seems fine to me, but I think you forgot to update the tests :)
Repository:
rL LLVM
https://reviews.llvm.org/D24628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
aaron.ballman added a comment.
Thank you for working on this check! A few comments:
The patch is missing Sema tests for the attribute (that it only applies to
declarations you expect, accepts no args, etc).
Have you considered making this a type attribute on the return type of the
function rat
andriigrynenko created this revision.
andriigrynenko added reviewers: kcc, blastrock, dvyukov, filcab.
andriigrynenko added a subscriber: cfe-commits.
andriigrynenko set the repository for this revision to rL LLVM.
Herald added a subscriber: kubabrecka.
This patch extends __sanitizer_finish_switch
yaxunl created this revision.
yaxunl added reviewers: Anastasia, bader.
yaxunl added subscribers: cfe-commits, nhaustov, rampitec.
Herald added a subscriber: yaxunl.
https://reviews.llvm.org/D24626
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
test/SemaOpenCL/half.
- cfe-dev, + cfe-commits
Hi Tobias,
This is a great start. Thanks for the patch!
> Not sure I know how to use the analyzer config flags yet. My patch
> currently also still causes a segfault on Analysis/retain-release.m
The segfault is because the diagnostics machinery expects a declaration wit
vbyakovlcl updated this revision to Diff 71545.
https://reviews.llvm.org/D24467
Files:
llvm/tools/clang/lib/Sema/SemaExpr.cpp
llvm/tools/clang/test/CodeGen/vecshift.c
llvm/tools/clang/test/Sema/vecshift.c
Index: llvm/tools/clang/lib/Sema/SemaExpr.cpp
===
vbyakovlcl added inline comments.
Comment at: llvm/tools/clang/test/CodeGen/vecshift.c:43
@@ +42,3 @@
+ vi8 = 1 << vi8;
+// CHECK: [[t2:%.+]] = load <8 x i32>, <8 x i32>* @vi8, align 32
+// CHECK: shl <8 x i32> , [[t2]]
ahatanak wrote:
> This test fails on my mac
Author: hans
Date: Thu Sep 15 14:44:49 2016
New Revision: 281648
URL: http://llvm.org/viewvc/llvm-project?rev=281648&view=rev
Log:
clang-format VS plugin: upgrade the project files to VS2015
The plugin itself runs on previous VS versions, but this enables
it to be built with VS2015.
Modified:
ahatanak added a comment.
LGTM with a nit in test case.
Comment at: llvm/tools/clang/test/CodeGen/vecshift.c:43
@@ +42,3 @@
+ vi8 = 1 << vi8;
+// CHECK: [[t2:%.+]] = load <8 x i32>, <8 x i32>* @vi8, align 32
+// CHECK: shl <8 x i32> , [[t2]]
This test fails on
EricWF added a comment.
In https://reviews.llvm.org/D24599#543849, @mclow.lists wrote:
> Any reason we shouldn't just revert r280944, wait for the LLVM bug to be
> fixed, and then re-apply it?
I would like to put some time between fixing the Clang bug and re-introducing
the reproducer into li
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for the patch.
Comment at: src/cxa_thread_atexit.cpp:70
@@ +69,3 @@
+
+ void run_dtors(void*) {
+while (auto head = dtors) {
Na I thought I
hiraditya added a comment.
@EricWF, since inline is only a hint, the compiler would not inline in many
cases, it might give the inliner a little bit of push to inline. When we were
working on this patch, adding inline wasn't enough and hence we added the
_LIBCPP_INLINE_VISIBILITY flag. The comp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281641: [libc++] Avoid include in locale_win32.h
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D24374?vs=70899&id=71530#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
Author: smeenai
Date: Thu Sep 15 13:36:13 2016
New Revision: 281641
URL: http://llvm.org/viewvc/llvm-project?rev=281641&view=rev
Log:
[libc++] Avoid include in locale_win32.h
When `_LIBCPP_NO_EXCEPTIONS` is defined, we end up with compile errors
when targeting MSVCRT:
* Code includes ``
* `` in
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
LGTM as well, thank you!
https://reviews.llvm.org/D24289
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
rnk added a comment.
In https://reviews.llvm.org/D24289#543874, @thakis wrote:
> Works for me if rnk likes it :-)
Yep, looks good.
> (We could bikeshed on if this should be one of the -Wmicrosoft warnings, but
> the warning can't be both in -Wall and -Wmicrosoft, so let's don't).
I also don
loladiro updated this revision to Diff 71528.
loladiro added a comment.
Add private copy of forward (__forward) that is constexpr even in C++11 mode,
use test suggested by @rsmith
Repository:
rL LLVM
https://reviews.llvm.org/D24372
Files:
include/memory
test/std/utilities/memory/unique
thakis added a comment.
Works for me if rnk likes it :-)
(We could bikeshed on if this should be one of the -Wmicrosoft warnings, but
the warning can't be both in -Wall and -Wmicrosoft, so let's don't).
I do have a question about the test (the first commit below):
Comment at:
Author: aaronballman
Date: Thu Sep 15 13:07:51 2016
New Revision: 281632
URL: http://llvm.org/viewvc/llvm-project?rev=281632&view=rev
Log:
Reapply: Silence false positive diagnostics regarding passing an object of
enumeration type to va_start().
The underlying type for an enumeration in C is eit
davidsh created this revision.
davidsh added reviewers: carlo.bertolli, arpith-jacob, kkwli0, sfantao, ABataev.
davidsh added a subscriber: cfe-commits.
#pragma omp for
{
for(...)
}
This is technically not allowed by the standard, gcc doesnt allow such code.
https://reviews.llvm.org/D24615
Fi
mclow.lists added a comment.
Any reason we shouldn't just revert r280944, wait for the LLVM bug to be fixed,
and then re-apply it?
https://reviews.llvm.org/D24599
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281625: [analyzer] Fix HTMLRewriter style sheets to support
non-webkit browsers. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D23272?vs=67182&id=71517#toc
Repository:
rL
Author: dergachev
Date: Thu Sep 15 11:25:42 2016
New Revision: 281625
URL: http://llvm.org/viewvc/llvm-project?rev=281625&view=rev
Log:
[analyzer] Fix HTMLRewriter style sheets to support non-webkit browsers.
This fixes rounded corners and shadows of analyzer diagnostic pieces
in browsers such as
NoQ updated this revision to Diff 71510.
NoQ marked an inline comment as done.
NoQ added a comment.
Herald added subscribers: mgorny, beanz.
Added a huge amount of macros in order to improve readability of function specs.
Other inline comments should have been addressed before.
https://reviews.l
tavianator marked 5 inline comments as done.
Comment at: src/cxa_thread_atexit.cpp:70
@@ +69,3 @@
+while (auto head = dtors) {
+ dtors = head->next;
+ head->dtor(head->obj);
EricWF wrote:
> tavianator wrote:
> > EricWF wrote:
> > > tavianator wrote:
tavianator updated this revision to Diff 71508.
tavianator added a comment.
Herald added subscribers: mgorny, beanz.
Integrated @EricWF's expanded test case, and avoid an unneeded
pthread_setspecific() call if the last thread_local's destructor initializes a
new thread_local.
https://reviews.l
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:104
@@ +103,3 @@
+ std::reverse(Namespaces.begin(), Namespaces.end());
+ return Namespaces;
+}
Aha, I see. I misused the `findLocationAfterToken` previously.
Comment at: clang-m
hokein updated this revision to Diff 71506.
hokein marked 2 inline comments as done.
hokein added a comment.
Herald added a subscriber: mgorny.
Address review comments.
https://reviews.llvm.org/D24243
Files:
CMakeLists.txt
clang-move/CMakeLists.txt
clang-move/ClangMove.cpp
clang-move/Cl
Author: aaronballman
Date: Thu Sep 15 09:12:33 2016
New Revision: 281612
URL: http://llvm.org/viewvc/llvm-project?rev=281612&view=rev
Log:
Reverting r281609; it caused some build bots to break.
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/20061/steps/test/lo
sdardis closed this revision.
sdardis added a comment.
Committed as https://reviews.llvm.org/rL281610.
https://reviews.llvm.org/D22679
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sdardis
Date: Thu Sep 15 09:01:55 2016
New Revision: 281610
URL: http://llvm.org/viewvc/llvm-project?rev=281610&view=rev
Log:
[mips][ias] Enable IAS by default for N64 on Debian mips64el.
Unfortunately we can't enable it for all N64 because it is not yet possible to
distinguish N32 from N
hokein added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:200
@@ +199,3 @@
+ while (!NsSplitted.empty()) {
+// FIXME: consider code style for comments.
+Code = ("namespace " + NsSplitted.back() + " {\n" + Code +
Doesn't `formatAndAppl
aaron.ballman closed this revision.
aaron.ballman added a comment.
Commit in r281609
https://reviews.llvm.org/D23921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Thu Sep 15 09:01:10 2016
New Revision: 281609
URL: http://llvm.org/viewvc/llvm-project?rev=281609&view=rev
Log:
Silence false positive diagnostics regarding passing an object of enumeration
type to va_start(). The underlying type for an enumeration in C is either char,
vbyakovlcl updated this revision to Diff 71498.
https://reviews.llvm.org/D24467
Files:
llvm/tools/clang/lib/Sema/SemaExpr.cpp
llvm/tools/clang/test/CodeGen/vecshift.c
llvm/tools/clang/test/Sema/vecshift.c
Index: llvm/tools/clang/lib/Sema/SemaExpr.cpp
===
mstorsjo created this revision.
mstorsjo added a reviewer: compnerd.
mstorsjo added a subscriber: cfe-commits.
Herald added subscribers: samparker, rengolin, aemerson.
On ARM, there are multiple versions of each of the intrinsics, with
acquire/relaxed/release barrier semantics.
The 64 bit versio
ioeric added a comment.
PIng
https://reviews.llvm.org/D24183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
milianw accepted this revision.
milianw added a comment.
This revision is now accepted and ready to land.
agreed, lgtm but someone else must accept this upstream
https://reviews.llvm.org/D18462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hokein added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:206
@@ +205,3 @@
+StringRef Code = Buffer.get()->getBuffer();
+format::FormatStyle Style = format::getLLVMStyle();
+llvm::Expected CleanReplacements =
ioeric wrote:
> Add a
1 - 100 of 116 matches
Mail list logo
