[clang-tools-extra] r279803 - [clang-tidy] Added hh, hxx and hpp to header guard checks.

Author: madsravn Date: Fri Aug 26 00:59:53 2016 New Revision: 279803 URL: http://llvm.org/viewvc/llvm-project?rev=279803&view=rev Log: [clang-tidy] Added hh, hxx and hpp to header guard checks. Changed the extension check to include the option of ",h,hh,hpp,hxx" instead of just returning whether

Re: [PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

This revision was automatically updated to reflect the committed changes. Closed by commit rL279803: [clang-tidy] Added hh, hxx and hpp to header guard checks. (authored by madsravn). Changed prior to commit: https://reviews.llvm.org/D20512?vs=69250&id=69320#toc Repository: rL LLVM https://

[PATCH] D23907: Fix documentation of MemberExpr::getMemberDecl

sberg created this revision. sberg added reviewers: rsmith, doug.gregor. sberg added a subscriber: cfe-commits. https://reviews.llvm.org/D23907 Files: include/clang/AST/Expr.h Index: include/clang/AST/Expr.h === --- include/clang/

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

Microsoft used to call their IDL dialect 'MIDL' (which is kind of punny), don't know if it makes sense to stick with that over 'MSIDL'. - Kim Den 26 aug. 2016 4:09 fm skrev "Nico Weber via cfe-commits" < cfe-commits@lists.llvm.org>: > thakis updated this revision to Diff 69312. > thakis marked a

Re: [PATCH] D23905: [Modules] Add 'gnuinlineasm' to the 'requires-declaration' feature-list.

On 25 Aug 2016 7:37 p.m., "Bruno Cardoso Lopes" wrote: bruno created this revision. bruno added a reviewer: rsmith. bruno added subscribers: cfe-commits, eladcohen. This adds support for modules that require (no-)gnu-inline-asm environment, such as the compiler builtin cpuid submodule. This is

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. F2334952: pingpingpingping Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

Re: [PATCH] D22227: [ubsan] Disable bounds-check for flexible array ivars

vsk added a comment. Ping. https://reviews.llvm.org/D7 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23859: [Preprocessor] Add a macro for -fno-gnu-inline-asm

bruno abandoned this revision. bruno added a comment. Abandon in favor of https://reviews.llvm.org/D23905 https://reviews.llvm.org/D23859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D23905: [Modules] Add 'gnuinlineasm' to the 'requires-declaration' feature-list.

bruno created this revision. bruno added a reviewer: rsmith. bruno added subscribers: cfe-commits, eladcohen. This adds support for modules that require (no-)gnu-inline-asm environment, such as the compiler builtin cpuid submodule. This is the gnu-inline-asm variant of https://reviews.llvm.org/D2

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

thakis updated this revision to Diff 69312. thakis marked an inline comment as done. thakis added a comment. comments round 1 https://reviews.llvm.org/D23895 Files: include/clang/Basic/Attr.td include/clang/Basic/Attributes.h include/clang/Parse/Parser.h include/clang/Sema/AttributeList

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

thakis marked an inline comment as done. thakis added a comment. Thanks for the fast review and the good comments! I'll leave it to y'all to agree on some name if you don't like the one I picked. > Also, doesn't this introduce ambiguities into the grammar? Something like > this: > > void u

Re: [PATCH] D23902: Minor cleanup of PTHWriter

alexshap added a comment. F2334541: Screen Shot 2016-08-25 at 6.57.45 PM.png Repository: rL LLVM https://reviews.llvm.org/D23902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D23902: Minor cleanup of PTHWriter

alexshap created this revision. alexshap added reviewers: bogner, dblaikie, rnk. alexshap added a subscriber: cfe-commits. alexshap set the repository for this revision to rL LLVM. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". The

[PATCH] D23901: Minor cleanup of the class CallStackFrame

alexshap created this revision. alexshap added reviewers: rsmith, gbiv, bkramer. alexshap added a subscriber: cfe-commits. alexshap set the repository for this revision to rL LLVM. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". The

Re: [PATCH] D23901: Minor cleanup of the class CallStackFrame

alexshap added a comment. F2334496: Screen Shot 2016-08-25 at 6.20.05 PM.png Repository: rL LLVM https://reviews.llvm.org/D23901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

On Thu, Aug 25, 2016 at 9:16 PM, Richard Smith wrote: > On Thu, Aug 25, 2016 at 5:46 PM, Reid Kleckner wrote: >> >> rnk added a comment. >> >> I think these are known as "IDL attributes": >> https://msdn.microsoft.com/en-us/library/8tesw2eh.aspx >> >> Let's update the naming to use that terminolo

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

On Thu, Aug 25, 2016 at 5:46 PM, Reid Kleckner wrote: > rnk added a comment. > > I think these are known as "IDL attributes": > https://msdn.microsoft.com/en-us/library/8tesw2eh.aspx > > Let's update the naming to use that terminology, so AS_MS should be > AS_IDL, and MaybeParseMicrosoftAttribute

Re: r253647 - [Myriad]: handle Preprocess job action (-E)

On Thu, Nov 19, 2015 at 8:58 PM, Douglas Katzman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dougk > Date: Thu Nov 19 22:58:12 2015 > New Revision: 253647 > > URL: http://llvm.org/viewvc/llvm-project?rev=253647&view=rev > Log: > [Myriad]: handle Preprocess job action (-E) > > Mo

Re: [PATCH] D21959: [X86] Add xgetbv xsetbv intrinsics

rnk added a comment. Now might be the time to solve the larger problem of wider intrinsic availability. Like I mentioned, all these intrinsics really ought to be available all the time, regardless of CPU subtarget. Repository: rL LLVM https://reviews.llvm.org/D21959 _

r279799 - Sort list of driver-known file extensions. It was previously approximately

Author: rsmith Date: Thu Aug 25 19:41:59 2016 New Revision: 279799 URL: http://llvm.org/viewvc/llvm-project?rev=279799&view=rev Log: Sort list of driver-known file extensions. It was previously approximately ordered by length then alphabetically; apply that order consistently. Modified: cfe/t

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

rnk added a comment. I think these are known as "IDL attributes": https://msdn.microsoft.com/en-us/library/8tesw2eh.aspx Let's update the naming to use that terminology, so AS_MS should be AS_IDL, and MaybeParseMicrosoftAttributes should be MaybeParseMicrosoftIDLAttributes, etc. Also, doesn't t

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

rsmith added inline comments. Comment at: include/clang/Basic/Attr.td:201 @@ -200,2 +200,3 @@ class Declspec : Spelling; +class MS : Spelling; class CXX11 Is there some better description for this than MS? `__declspec` is also an MS attribute. Is it fair to cal

Re: [PATCH] D23898: Minor cleanup of MismatchingNewDeleteDetector

alexshap added a comment. F2334424: Screen Shot 2016-08-25 at 5.30.51 PM.png Repository: rL LLVM https://reviews.llvm.org/D23898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D23898: Minor cleanup of MismatchingNewDeleteDetector

alexshap created this revision. alexshap added reviewers: ismailp, rsmith, bkramer. alexshap added a subscriber: cfe-commits. alexshap set the repository for this revision to rL LLVM. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". T

Re: [PATCH] D23816: Add support for -fdiagnostics-abs-path: printing absolute paths in diagnostics

On Thu, Aug 25, 2016 at 5:22 PM, Hans Wennborg wrote: > hans added inline comments. > > > Comment at: lib/Frontend/TextDiagnostic.cpp:770-777 > @@ +769,10 @@ > + if (DiagOpts->AbsolutePath) { > +const DirectoryEntry *Dir = SM.getFileManager().getDirectory( > +llvm::s

Re: [PATCH] D23816: Add support for -fdiagnostics-abs-path: printing absolute paths in diagnostics

hans added inline comments. Comment at: lib/Frontend/TextDiagnostic.cpp:770-777 @@ +769,10 @@ + if (DiagOpts->AbsolutePath) { +const DirectoryEntry *Dir = SM.getFileManager().getDirectory( +llvm::sys::path::parent_path(Filename)); +if (Dir) { + StringRef DirN

r279794 - C++ Modules TS: add frontend support for building pcm files from module

Author: rsmith Date: Thu Aug 25 19:14:38 2016 New Revision: 279794 URL: http://llvm.org/viewvc/llvm-project?rev=279794&view=rev Log: C++ Modules TS: add frontend support for building pcm files from module interface files. At the moment, all declarations (and no macros) are exported, and 'export' d

Re: [PATCH] D23816: Add support for -fdiagnostics-abs-path: printing absolute paths in diagnostics

rsmith accepted this revision. Comment at: lib/Frontend/TextDiagnostic.cpp:770-777 @@ +769,10 @@ + if (DiagOpts->AbsolutePath) { +const DirectoryEntry *Dir = SM.getFileManager().getDirectory( +llvm::sys::path::parent_path(Filename)); +if (Dir) { + StringRef D

Re: [PATCH] D23816: Add support for -fdiagnostics-abs-path: printing absolute paths in diagnostics

hans marked an inline comment as done. Comment at: include/clang/Driver/Options.td:994 @@ -993,1 +993,3 @@ Flags<[CC1Option]>, HelpText<"Do not include source location information with diagnostics">; +def fdiagnostics_abs_path : Flag<["-"], "fdiagnostics-abs-path">, Group, +

Re: [PATCH] D23816: Add support for -fdiagnostics-abs-path: printing absolute paths in diagnostics

hans updated this revision to Diff 69304. hans added a comment. Addressing Richard's comments. https://reviews.llvm.org/D23816 Files: include/clang/Basic/DiagnosticOptions.def include/clang/Driver/CLCompatOptions.td include/clang/Driver/Options.td include/clang/Frontend/TextDiagnostic.h

Re: [PATCH] D22794: [Sema] Propagate nullability when deducing type of auto

ahatanak abandoned this revision. ahatanak added a comment. Abandoning this revision. It looks like we cannot correctly implement this warning without introducing a lot of complexity to clang. Users can use the static analyzer instead as it already warns about this case. https://reviews.llvm.

[PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

thakis created this revision. thakis added a reviewer: rnk. thakis added a subscriber: cfe-commits. Some Windows SDK classes, for example Windows::Storage::Streams::IBufferByteAccess, use the ATL way of spelling attributes: [uuid("")] class IBufferByteAccess {}; To be able to use __uuido

Re: [PATCH] D23858: Don't diagnose non-modular includes when we are not compiling a module

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. OK, if this unblocks you and you're working towards properly handling umbrella headers in the VFS, I'm happy to go ahead with this. Please either rename the variable or move that part of the c

Re: [PATCH] D23816: Add support for -fdiagnostics-abs-path: printing absolute paths in diagnostics

rsmith added inline comments. Comment at: include/clang/Driver/Options.td:994 @@ -993,1 +993,3 @@ Flags<[CC1Option]>, HelpText<"Do not include source location information with diagnostics">; +def fdiagnostics_abs_path : Flag<["-"], "fdiagnostics-abs-path">, Group, + Flags<[C

[PATCH] D23894: [Clang-tidy] Fix some checks documentation style

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: alexfh. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Herald added a subscriber: nemanjai. Repository: rL LLVM https://reviews.llvm.org/D23894 Files: docs/

Re: [PATCH] D23816: Add support for -fdiagnostics-abs-path: printing absolute paths in diagnostics

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. I like this approach. https://reviews.llvm.org/D23816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

Re: [PATCH] D23816: Add support for -fdiagnostics-abs-path: printing absolute paths in diagnostics

hans retitled this revision from "clang-cl: Add support for /FC: absolute paths in diagnostics and __FILE__" to "Add support for -fdiagnostics-abs-path: printing absolute paths in diagnostics". hans updated the summary for this revision. hans updated this revision to Diff 69300. hans added a comm

r279786 - Widen type of __offset_flags in RTTI on Mingw64

Author: rnk Date: Thu Aug 25 17:16:30 2016 New Revision: 279786 URL: http://llvm.org/viewvc/llvm-project?rev=279786&view=rev Log: Widen type of __offset_flags in RTTI on Mingw64 Otherwise we can't handle secondary base classes at offsets greater than 2**24. This agrees with libstdc++abi. We coul

Re: [PATCH] D23858: Don't diagnose non-modular includes when we are not compiling a module

manmanren added a comment. In https://reviews.llvm.org/D23858#525647, @rsmith wrote: > It seems to me like this is papering over an issue rather than fixing it. I guess that is why we introduced fmodule-implementation-of, to work around issues like "relative includes to a VFS-mapped module". B

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

amccarth added inline comments. Comment at: clang-tidy-vs/ClangTidy/CheckTree.cs:68 @@ +67,3 @@ +return Name_; +return ParentPath + "-" + Name_; +} OK, cool. I assumed that the root had a name. Thus a node with no

Re: [PATCH] D23871: [Modules] Add 'freestanding' to the 'requires-declaration' feature-list.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Makes sense to me. I imagine this would also be useful for libc++. Comment at: lib/Headers/module.modulemap:66 @@ -65,2 +65,3 @@ explicit module mm_malloc { + requir

Re: [PATCH] D23858: Don't diagnose non-modular includes when we are not compiling a module

rsmith added a comment. It seems to me like this is papering over an issue rather than fixing it. `diagnoseHeaderInclusion` calls `isHeaderInUmbrellaDirs` here, which is presumably failing to determine that `Nonmodular/A.h` is in the umbrella directory for the `Nonmodular` module. My first gues

r279774 - [MS] Win64 va_arg should expect large arguments to be passed indirectly

Author: rnk Date: Thu Aug 25 15:42:26 2016 New Revision: 279774 URL: http://llvm.org/viewvc/llvm-project?rev=279774&view=rev Log: [MS] Win64 va_arg should expect large arguments to be passed indirectly Fixes PR20569 Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp cfe/trunk/test/CodeGen/ms

Re: r279632 - clang-offload-bundler - offload files bundling/unbundling tool

This test failed on Windows because clang is called "clang.exe" not "clang". Fixed in r279772. On Wed, Aug 24, 2016 at 8:21 AM, Samuel Antao via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: sfantao > Date: Wed Aug 24 10:21:05 2016 > New Revision: 279632 > > URL: http://llvm.org/view

r279772 - Fix clang-offload-bundler.c test on Windows

Author: rnk Date: Thu Aug 25 15:40:23 2016 New Revision: 279772 URL: http://llvm.org/viewvc/llvm-project?rev=279772&view=rev Log: Fix clang-offload-bundler.c test on Windows Modified: cfe/trunk/test/Driver/clang-offload-bundler.c Modified: cfe/trunk/test/Driver/clang-offload-bundler.c URL:

Re: [PATCH] D23816: clang-cl: Add support for /FC: absolute paths in diagnostics and __FILE__

thakis added inline comments. Comment at: include/clang/Driver/CLCompatOptions.td:68 @@ +67,3 @@ +def _SLASH_FC : CLFlag<"FC">, + HelpText<"Use absolute paths in diagnostics and __FILE__">, + Alias; hans wrote: > thakis wrote: > > hans wrote: > > > thakis wrote:

Re: [PATCH] D23816: clang-cl: Add support for /FC: absolute paths in diagnostics and __FILE__

hans added inline comments. Comment at: include/clang/Driver/CLCompatOptions.td:68 @@ +67,3 @@ +def _SLASH_FC : CLFlag<"FC">, + HelpText<"Use absolute paths in diagnostics and __FILE__">, + Alias; thakis wrote: > hans wrote: > > thakis wrote: > > > Hm, I'm not s

Re: [PATCH] D23816: clang-cl: Add support for /FC: absolute paths in diagnostics and __FILE__

thakis added inline comments. Comment at: include/clang/Driver/CLCompatOptions.td:68 @@ +67,3 @@ +def _SLASH_FC : CLFlag<"FC">, + HelpText<"Use absolute paths in diagnostics and __FILE__">, + Alias; hans wrote: > thakis wrote: > > Hm, I'm not sure this should af

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

zturner added inline comments. Comment at: clang-tidy-vs/ClangTidy/CheckTree.cs:67 @@ +66,3 @@ +if (ParentPath == null) +return Name_; +return ParentPath + "-" + Name_; amccarth wrote: > This seems overly complic

Re: [PATCH] D23816: clang-cl: Add support for /FC: absolute paths in diagnostics and __FILE__

hans added inline comments. Comment at: include/clang/Driver/CLCompatOptions.td:68 @@ +67,3 @@ +def _SLASH_FC : CLFlag<"FC">, + HelpText<"Use absolute paths in diagnostics and __FILE__">, + Alias; thakis wrote: > Hm, I'm not sure this should affect __FILE__. It

Re: [PATCH] D23816: clang-cl: Add support for /FC: absolute paths in diagnostics and __FILE__

thakis added inline comments. Comment at: include/clang/Driver/CLCompatOptions.td:68 @@ +67,3 @@ +def _SLASH_FC : CLFlag<"FC">, + HelpText<"Use absolute paths in diagnostics and __FILE__">, + Alias; Hm, I'm not sure this should affect __FILE__. It sounds people

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

zturner added a comment. In https://reviews.llvm.org/D23848#525485, @Eugene.Zelenko wrote: > I think will be good idea to mention this plugin in docs/ReleaseNotes.rst. I was planning to wait until it's "finished". This patch will give you a user interface for editing .clang-tidy files, but i

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

Eugene.Zelenko added a comment. I think will be good idea to mention this plugin in docs/ReleaseNotes.rst. https://reviews.llvm.org/D23848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

r279766 - Refactor to remove the assumption that we know the name of the module we're emitting at the point when we create a PCHGenerator (with the C++ modules TS, we find that out part way through pa

Author: rsmith Date: Thu Aug 25 13:26:30 2016 New Revision: 279766 URL: http://llvm.org/viewvc/llvm-project?rev=279766&view=rev Log: Refactor to remove the assumption that we know the name of the module we're emitting at the point when we create a PCHGenerator (with the C++ modules TS, we find t

Re: [PATCH] D23878: [libc++abi] Fix test under ASAN and MSAN

smeenai updated this revision to Diff 69275. smeenai added a comment. Using attributes instead of compile flags, per compnerd's suggestion https://reviews.llvm.org/D23878 Files: test/backtrace_test.pass.cpp Index: test/backtrace_test.pass.cpp =

Re: [PATCH] D23720: Omit column info for CodeView by default

This revision was automatically updated to reflect the committed changes. Closed by commit rL279765: Omit column info for CodeView by default (authored by amccarth). Changed prior to commit: https://reviews.llvm.org/D23720?vs=68713&id=69274#toc Repository: rL LLVM https://reviews.llvm.org/D

r279765 - Omit column info for CodeView by default

Author: amccarth Date: Thu Aug 25 13:24:35 2016 New Revision: 279765 URL: http://llvm.org/viewvc/llvm-project?rev=279765&view=rev Log: Omit column info for CodeView by default Clang tracks only start columns, not start-end ranges. CodeView allows for that, but the VS debugger doesn't handle anyt

r279764 - [MS] Pass non-trivially-copyable objects indirectly on Windows ARM

Author: rnk Date: Thu Aug 25 13:23:28 2016 New Revision: 279764 URL: http://llvm.org/viewvc/llvm-project?rev=279764&view=rev Log: [MS] Pass non-trivially-copyable objects indirectly on Windows ARM This isn't exactly what MSVC does, unfortunately. MSVC does not pass objects with destructors but no

[libcxx] r279763 - Followon to r279744. Find the other exception types and make __throw_XXX routines (and call them). Remove the generic __libcpp_throw routine, since no one uses it anymore.

Author: marshall Date: Thu Aug 25 12:47:09 2016 New Revision: 279763 URL: http://llvm.org/viewvc/llvm-project?rev=279763&view=rev Log: Followon to r279744. Find the other exception types and make __throw_XXX routines (and call them). Remove the generic __libcpp_throw routine, since no one uses

Re: [PATCH] D23878: [libc++abi] Fix test under ASAN and MSAN

compnerd added a comment. I think it would be better to use `assert(true)` to avoid the TCO from kicking in. https://reviews.llvm.org/D23878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

vmiklos added a comment. > If I understood correctly, you and Alex are talking about different things. Yes, sorry, the context of my above comment was the cl::opt instances in the tool itself, not the various parameters to the different actions called from the tool. https://reviews.llvm.org/

Re: [PATCH] D23720: Omit column info for CodeView by default

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D23720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23860: [Sema][Comments] Add support for TypeAliasTemplate

bruno closed this revision. bruno added a comment. Applied your suggestions and committed r279754. Thanks! https://reviews.llvm.org/D23860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

r279754 - [Sema][Comments] Add support for TypeAliasTemplate

Author: bruno Date: Thu Aug 25 12:09:33 2016 New Revision: 279754 URL: http://llvm.org/viewvc/llvm-project?rev=279754&view=rev Log: [Sema][Comments] Add support for TypeAliasTemplate Emit proper diagnostics when -Wdocumentation is used with constructs such as: template using fn = int(T aaa,

Re: r267338 - Improve diagnostic checking for va_start to also warn on other instances of undefined behavior, such as a parameter declared with the register keyword in C, or a parameter of a type that

> On Aug 25, 2016, at 8:17 AM, Aaron Ballman wrote: > > On Thu, Aug 25, 2016 at 11:04 AM, Frédéric Riss wrote: >> >>> On Aug 25, 2016, at 7:44 AM, Aaron Ballman wrote: >>> >>> On Tue, Aug 23, 2016 at 9:32 PM, Frédéric Riss wrote: Hey Aaron, This commit triggers warnings when

Re: [PATCH] D23852: [SemaObjC] Fix crash while parsing type arguments and protocols

doug.gregor added a comment. This will work, but it's *really* unfortunate to put tentative parsing into this code path because tentative parsing is far from free, and specialized Objective-C types are getting pretty common in Objective-C headers. Why can't the callers be taught to handle EOF a

[libcxx] r279746 - Remove duplicate inline

Author: marshall Date: Thu Aug 25 10:56:55 2016 New Revision: 279746 URL: http://llvm.org/viewvc/llvm-project?rev=279746&view=rev Log: Remove duplicate inline Modified: libcxx/trunk/include/experimental/any Modified: libcxx/trunk/include/experimental/any URL: http://llvm.org/viewvc/llvm-pro

Re: [PATCH] D22871: Fix incorrect -Wtautological-constant-out-of-range warnings with enums

ibadawi abandoned this revision. ibadawi added a comment. Abandoning for now -- might submit another patch later according to new discussion on https://llvm.org/bugs/show_bug.cgi?id=16154 https://reviews.llvm.org/D22871 ___ cfe-commits mailing list

Re: [PATCH] D23858: Don't diagnose non-modular includes when we are not compiling a module

benlangmuir added a comment. LGTM, but @rsmith should glance at this too. https://reviews.llvm.org/D23858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23878: [libc++abi] Fix test under ASAN and MSAN

smeenai created this revision. smeenai added reviewers: compnerd, EricWF, rsmith. smeenai added a subscriber: cfe-commits. When we're running tests under ASAN or MSAN, they're compiled with -O1, which enables tail call elimination. This causes backtrace_test to fail: the compiler performs tail cal

Re: [PATCH] D23855: Make exception-throwing from a noexcept build `abort()`.

rmaprath added a subscriber: rmaprath. rmaprath added a comment. I don't know how I missed this. Thanks for the patch!!! https://reviews.llvm.org/D23855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [PATCH] D23855: Make exception-throwing from a noexcept build `abort()`.

mclow.lists closed this revision. mclow.lists added a comment. Committed as revision 279744 https://reviews.llvm.org/D23855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r267338 - Improve diagnostic checking for va_start to also warn on other instances of undefined behavior, such as a parameter declared with the register keyword in C, or a parameter of a type that

On Thu, Aug 25, 2016 at 11:04 AM, Frédéric Riss wrote: > >> On Aug 25, 2016, at 7:44 AM, Aaron Ballman wrote: >> >> On Tue, Aug 23, 2016 at 9:32 PM, Frédéric Riss wrote: >>> Hey Aaron, >>> >>> This commit triggers warnings when the argument to va_start is an enum >>> type. The standard says: >>

[libcxx] r279744 - Add an _LIBCPP_NORETURN inline function named __throw_XXX for each exception type we define. They either construct and throw the exception, or abort() (if exceptions are disabled).

Author: marshall Date: Thu Aug 25 10:09:01 2016 New Revision: 279744 URL: http://llvm.org/viewvc/llvm-project?rev=279744&view=rev Log: Add an _LIBCPP_NORETURN inline function named __throw_XXX for each exception type we define. They either construct and throw the exception, or abort() (if except

Re: [PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

madsravn updated this revision to Diff 69250. madsravn added a comment. Last change - documentation should be fine now. https://reviews.llvm.org/D20512 Files: clang-tidy/llvm/HeaderGuardCheck.cpp clang-tidy/llvm/HeaderGuardCheck.h clang-tidy/utils/HeaderFileExtensionsUtils.cpp clang-tid

Re: r267338 - Improve diagnostic checking for va_start to also warn on other instances of undefined behavior, such as a parameter declared with the register keyword in C, or a parameter of a type that

> On Aug 25, 2016, at 7:44 AM, Aaron Ballman wrote: > > On Tue, Aug 23, 2016 at 9:32 PM, Frédéric Riss wrote: >> Hey Aaron, >> >> This commit triggers warnings when the argument to va_start is an enum type. >> The standard says: >> >> 7.16.1.4 The va_start macro >> >>• 4 The parame

Re: r279653 - Fix offload bundler tests so that diagnostic can start with caps.

Thanks for letting me know, should be fixed in r279741. Samuel   - Original message -From: Vitaly Buka To: Samuel F Antao/Watson/IBM@IBMUS, cfe-commits@lists.llvm.orgCc:Subject: Re: r279653 - Fix offload bundler tests so that diagnostic can start with caps.Date: Thu, Aug 25, 2016 4:04 AM  I

Re: r267338 - Improve diagnostic checking for va_start to also warn on other instances of undefined behavior, such as a parameter declared with the register keyword in C, or a parameter of a type that

On Tue, Aug 23, 2016 at 9:32 PM, Frédéric Riss wrote: > Hey Aaron, > > This commit triggers warnings when the argument to va_start is an enum type. > The standard says: > > 7.16.1.4 The va_start macro > > • 4 The parameter parmN is the identifier of the rightmost parameter > in the vari

r279741 - Fix offload bundler test to support Windows new lines.

Author: sfantao Date: Thu Aug 25 09:35:20 2016 New Revision: 279741 URL: http://llvm.org/viewvc/llvm-project?rev=279741&view=rev Log: Fix offload bundler test to support Windows new lines. Modified: cfe/trunk/test/Driver/clang-offload-bundler.c Modified: cfe/trunk/test/Driver/clang-offload-b

[PATCH] D23871: [Modules] Add 'freestanding' to the 'requires-declaration' feature-list.

eladcohen created this revision. eladcohen added reviewers: rsmith, andreybokhanko. eladcohen added a subscriber: cfe-commits. This adds support for modules that require (non-)freestanding environment such as the compiler builtin mm_malloc submodule. https://reviews.llvm.org/D23871 Files: doc

Re: [PATCH] D23837: Fix colored diagnostics from tools

ogoffart updated this revision to Diff 69225. ogoffart added a comment. This new patch make sure the test run fine as part of the testsuite, where the output is not a terminal and the color are disabled by default https://reviews.llvm.org/D23837 Files: lib/Tooling/Tooling.cpp unittests/Too

[libcxx] r279731 - Remove trailing WS [NFC]

Author: hiraditya Date: Thu Aug 25 06:52:38 2016 New Revision: 279731 URL: http://llvm.org/viewvc/llvm-project?rev=279731&view=rev Log: Remove trailing WS [NFC] Modified: libcxx/trunk/include/algorithm Modified: libcxx/trunk/include/algorithm URL: http://llvm.org/viewvc/llvm-project/libcxx/

Re: [PATCH] D23855: Make exception-throwing from a noexcept build `abort()`.

sebpop accepted this revision. sebpop added a comment. This revision is now accepted and ready to land. Very nice cleanup. Maybe you can move some more #ifdefs into __throw_* functions, although as is LGTM. Thanks! https://reviews.llvm.org/D23855 _

Re: [PATCH] D21502: Fix heuristics skipping invalid ctor-initializers with C++11

ogoffart added a comment. Regarding this: struct Foo { Foo() : some_long_x(0), some_| {} int some_long_x, some_long_y; }; That should work fine because the token before the { is the code completion token, not an identifier. This is basicaly tested by the test with CHECK-CC2. Howev

Re: [PATCH] D21502: Fix heuristics skipping invalid ctor-initializers with C++11

ogoffart updated this revision to Diff 69223. ogoffart added a comment. Made the requested changes https://reviews.llvm.org/D21502 Files: lib/Parse/ParseCXXInlineMethods.cpp test/CodeCompletion/ctor-initializer.cpp Index: test/CodeCompletion/ctor-initializer.cpp ===

Re: [PATCH] D23837: Fix colored diagnostics from tools

ogoffart updated this revision to Diff 69221. ogoffart added a comment. Added a test. https://reviews.llvm.org/D23837 Files: lib/Tooling/Tooling.cpp unittests/Tooling/ToolingTest.cpp Index: unittests/Tooling/ToolingTest.cpp ==

Re: [PATCH] D22431: clang-format: [JS] nested and tagged template strings.

This revision was automatically updated to reflect the committed changes. Closed by commit rL279727: clang-format: [JS] nested and tagged template strings. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D22431?vs=68853&id=69219#toc Repository: rL LLVM https://revie

r279727 - clang-format: [JS] nested and tagged template strings.

Author: mprobst Date: Thu Aug 25 05:13:21 2016 New Revision: 279727 URL: http://llvm.org/viewvc/llvm-project?rev=279727&view=rev Log: clang-format: [JS] nested and tagged template strings. JavaScript template strings can be nested arbitrarily: foo = `text ${es.map(e => { return `<${e}>`; })}

Re: [PATCH] D23860: [Sema][Comments] Add support for TypeAliasTemplate

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. LGTM with two more tests. Comment at: test/Sema/warn-documentation.cpp:433 @@ +432,3 @@ +template +using test_function_like_usingA = foo::function_wrapper; + ---

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

omtcyfz added a comment. Actually, it might make sense to merge `rename-at` and `rename-all` after all. Passing a list of `old-name`/`offset` -> `new-name` is just easier. But that's for another patch. https://reviews.llvm.org/D23651 ___ cfe-commi

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

omtcyfz updated this revision to Diff 69214. omtcyfz marked 2 inline comments as done. omtcyfz added a comment. Address couple of comments. https://reviews.llvm.org/D23651 Files: clang-rename/USRFindingAction.cpp clang-rename/USRFindingAction.h clang-rename/tool/ClangRename.cpp Index: cl

Re: [PATCH] D23842: [CFG] Add iterator_ranges to CFG and CFGBlock.

mboehme marked an inline comment as done. Comment at: include/clang/Analysis/CFG.h:526 @@ -524,1 +525,3 @@ typedef AdjacentBlocks::const_reverse_iterator const_pred_reverse_iterator; + typedef llvm::iterator_range pred_range; + typedef llvm::iterator_ran

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

mboehme marked 9 inline comments as done. mboehme added a comment. > > > 2. Also it would be good to make link in cppcoreguidelines. > > > > > > > > > How exactly would I create such a "link"? Are you just thinking of a link > > in the documentation, or is there a way to have one clang

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

Abpostelnicu marked 4 inline comments as done. Abpostelnicu added a comment. I've added also support for pure in case CXXOperatorCallExprClass::isAssignmentOperator is true. https://reviews.llvm.org/D22910 ___ cfe-commits mailing list cfe-commits@l

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

Abpostelnicu updated this revision to Diff 69205. https://reviews.llvm.org/D22910 Files: include/clang/AST/ExprCXX.h lib/AST/Expr.cpp Index: lib/AST/Expr.cpp === --- lib/AST/Expr.cpp +++ lib/AST/Expr.cpp @@ -2861,8 +2861,19 @@

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

mboehme updated this revision to Diff 69206. mboehme added a comment. Responses to reviewer comments. https://reviews.llvm.org/D23353 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/UseAfterMoveCheck.cpp clang-tidy/misc/UseAfterMoveCheck.h docs

Re: [PATCH] D22431: clang-format: [JS] nested and tagged template strings.

mprobst added a comment. No worries, thanks for the review. https://reviews.llvm.org/D22431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r279653 - Fix offload bundler tests so that diagnostic can start with caps.

It still fails on Windows on another line, \0A vs \0D\0A C:\buildbot\slave-config\clang-x86-win2008-selfhost\llvm\tools\clang\test\Driver\clang-offload-bundler.c:233:16: error: expected string not found in input // CK-OBJ-CMD: private constant [25 x i8] c"Content of device file 1\0A", section "__

[libclc] r279723 - amdgcn: Fix return type of get_num_groups

Author: arsenm Date: Thu Aug 25 02:31:40 2016 New Revision: 279723 URL: http://llvm.org/viewvc/llvm-project?rev=279723&view=rev Log: amdgcn: Fix return type of get_num_groups Added: libclc/trunk/amdgcn/lib/workitem/get_num_groups.ll libclc/trunk/r600/lib/workitem/get_num_groups.ll -

r279722 - Fix memory leaks in clang-offload-bundler

Author: vitalybuka Date: Thu Aug 25 02:21:34 2016 New Revision: 279722 URL: http://llvm.org/viewvc/llvm-project?rev=279722&view=rev Log: Fix memory leaks in clang-offload-bundler Summary: 1. Pair removed from StringMap was not destroyed 2. ObjectFile had no owner Reviewers: sfantao Subscribers:

  1   2   >