hans added inline comments. ================ Comment at: include/clang/Driver/CLCompatOptions.td:68 @@ +67,3 @@ +def _SLASH_FC : CLFlag<"FC">, + HelpText<"Use absolute paths in diagnostics and __FILE__">, + Alias<fabsolute_paths>; ---------------- thakis wrote: > Hm, I'm not sure this should affect __FILE__. It sounds people want this for > diagnostics, but making it affect __FILE__ makes reproducible builds harder. > (There's -ffile-macro-prefix-to-remove from http://reviews.llvm.org/D17741 > for that too, but that's not in.) The MSVC docs say it applies to __FILE__ though https://msdn.microsoft.com/en-us/library/027c4t2s.aspx and I worry that implementing only half of it might surprise users.
Chromium currently builds with MSVC and /FC, so we should already have full paths in __FILE__ there. https://reviews.llvm.org/D23816 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
