jojo closed this revision.
jojo added a comment.
Committed r278890.
https://reviews.llvm.org/D23293
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mehdi_amini
Date: Wed Aug 17 01:23:08 2016
New Revision: 278906
URL: http://llvm.org/viewvc/llvm-project?rev=278906&view=rev
Log:
[ThinLTO] Adapt backend invocation to llvm API changes.
Reviewers: tejohnson
Subscribers: mehdi_amini, llvm-commits
Differential Revision: https://reviews.ll
Ah, I missed Doug's follow-up commit r266797, which moved the code again. I
noticed that the RenderDebugEnablingArgs() call was missing in the spot
indicated below, but it was only moved.
-Dimitry
> On 17 Aug 2016, at 01:17, Hans Wennborg wrote:
>
> Looks like it was committed back in April,
Author: marshall
Date: Wed Aug 17 00:58:40 2016
New Revision: 278904
URL: http://llvm.org/viewvc/llvm-project?rev=278904&view=rev
Log:
Support allocators with explicit conversion constructors. Fixes bug #29000
Modified:
libcxx/trunk/include/map
libcxx/trunk/include/unordered_map
libcx
compnerd added inline comments.
Comment at: include/clang/Basic/IdentifierTable.h:34
@@ -26,2 +33,3 @@
namespace llvm {
+
template struct DenseMapInfo;
Not sure the whitespace adds any benefit here.
Comment at: include/clang/Basic/Identifier
Prazek added inline comments.
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:35
@@ +34,3 @@
+ auto CanCallCtor = unless(has(ignoringImpCasts(cxxConstructExpr(
+ hasDeclaration(decl(anyOf(isPrivate(), isProtected(;
+
aaron.ballman wrote:
> Pra
Author: dexonsmith
Date: Tue Aug 16 22:15:29 2016
New Revision: 278898
URL: http://llvm.org/viewvc/llvm-project?rev=278898&view=rev
Log:
CodeGen: Avoid dereferencing end() in
ScalarExprEmitter::EmitOverflowCheckedBinOp
Use BB.getNextNode(), which returns nullptr on end(), instead of
&*BB.getIter
Author: chandlerc
Date: Tue Aug 16 22:09:11 2016
New Revision: 278897
URL: http://llvm.org/viewvc/llvm-project?rev=278897&view=rev
Log:
[PM] Update Clang for LLVM's r278896 which re-organized a header.
(sorry this didn't get landed closer in time...)
Modified:
cfe/trunk/lib/CodeGen/BackendUt
rtrieu updated this revision to Diff 68278.
rtrieu added a comment.
Add function void ODRHash(llvm::FoldingSetNodeID &ID) to several classes for
computing the hash. Decl, Stmt, TemplateArgument, Type and QualType now have
this function, and can call among each others' functions.
https://revie
manmanren added a comment.
Richard,
Are you okay with the patch now?
Thanks,
Manman
https://reviews.llvm.org/D23125
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Tue Aug 16 21:22:39 2016
New Revision: 278891
URL: http://llvm.org/viewvc/llvm-project?rev=278891&view=rev
Log:
Add missing close brace to fix Windows bots. Oops :(
Modified:
cfe/trunk/tools/driver/cc1_main.cpp
Modified: cfe/trunk/tools/driver/cc1_main.cpp
URL:
http://l
Author: zijiaoma
Date: Tue Aug 16 21:13:33 2016
New Revision: 278890
URL: http://llvm.org/viewvc/llvm-project?rev=278890&view=rev
Log:
Some missing usage of TargetParser. NFC.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Basic/Targets.c
Looks fine to me. (At one point we were deliberately not following GCC in
making -fwrapv affect left shift, because it's a bit operation rather than
an arithmetic one, but this is ultimately supposed to be a GCC-compatible
flag so behaving as they do seems reasonable.)
On Tue, Aug 16, 2016 at 9:38
dcoughlin added a comment.
Thanks for patch! Some comments inline.
You don't have to do it in this patch, but I think it would be good to get this
working with AddImplicitDtors. I think it would also be good to (eventually)
add CFGElements marking when the storage duration for underlying storag
Author: rsmith
Date: Tue Aug 16 20:05:07 2016
New Revision: 278882
URL: http://llvm.org/viewvc/llvm-project?rev=278882&view=rev
Log:
If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work
around a Linux kernel bug where the actual amount of available stack may be a
*lot* lower
Eugene.Zelenko created this revision.
Eugene.Zelenko added a reviewer: alexfh.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Checks are described at beginning and directory names follow name prefixes, so
another list is redundant.
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: compnerd, mehdi_amini.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I checked this patch on my own build on RHEL 6. Regressions were OK.
Repository:
rL LLVM
On Fri, Aug 5, 2016 at 12:03 PM, David Blaikie via cfe-commits
wrote:
> Author: dblaikie
> Date: Fri Aug 5 14:03:01 2016
> New Revision: 277852
>
> URL: http://llvm.org/viewvc/llvm-project?rev=277852&view=rev
> Log:
> PR26423: Assert on valid use of using declaration of a function with an
> unde
thegameg marked an inline comment as done.
thegameg added a comment.
https://reviews.llvm.org/D23585
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thegameg updated this revision to Diff 68288.
thegameg added a comment.
Mention UniqueExternalLinkage type, add a test according to it.
`EXPECT_FALSE(matches(` -> `EXPECT_TRUE(notMatches(`
https://reviews.llvm.org/D23585
Files:
include/clang/ASTMatchers/ASTMatchers.h
unittests/ASTMatchers/A
thegameg updated this revision to Diff 68290.
thegameg added a comment.
Sorry, sent the wrong patch.
https://reviews.llvm.org/D23585
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTMatchersNar
thegameg marked an inline comment as done.
thegameg added a comment.
https://reviews.llvm.org/D23585
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
manmanren accepted this revision.
manmanren added a reviewer: manmanren.
manmanren added a comment.
This revision is now accepted and ready to land.
LGTM.
Manman
https://reviews.llvm.org/D22929
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
Looks like it was committed back in April, so unless I'm missing
something it should already be in the branch (which was cut mid-July).
Thanks,
Hans
On Tue, Aug 16, 2016 at 2:16 PM, Dimitry Andric wrote:
> Hi Hans,
>
> Can we please merge this one to release_39 too? I forgot all about it, sorry
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
A few minor nits, but thank you for the patch!
Comment at: include/clang/ASTMatchers/ASTMatchers.h:5481
@@ +5480,3 @@
+///
+/// Example matches only z (
thegameg created this revision.
thegameg added reviewers: bkramer, alexfh, hokein.
thegameg added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Matches NamedDecl nodes whose linkage is external.
https://reviews.llvm.org/D23585
Files:
docs/LibASTMatchersReference.html
include/
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:35
@@ +34,3 @@
+ auto CanCallCtor = unless(has(ignoringImpCasts(cxxConstructExpr(
+ hasDeclaration(decl(anyOf(isPrivate(), isProtected(;
+
Prazek wrote:
> aar
Prazek added inline comments.
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:35
@@ +34,3 @@
+ auto CanCallCtor = unless(has(ignoringImpCasts(cxxConstructExpr(
+ hasDeclaration(decl(anyOf(isPrivate(), isProtected(;
+
aaron.ballman wrote:
> Per
amccarth closed this revision.
amccarth added a comment.
Closed by r278861
https://reviews.llvm.org/D23462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: cbieneman
Date: Tue Aug 16 17:16:29 2016
New Revision: 278862
URL: http://llvm.org/viewvc/llvm-project?rev=278862&view=rev
Log:
[CMake] Workflow improvements to PGO generation
This patch adds a few new convenience options used by the PGO CMake cache to
setup options on bootstrap stages.
Author: amccarth
Date: Tue Aug 16 17:11:18 2016
New Revision: 278861
URL: http://llvm.org/viewvc/llvm-project?rev=278861&view=rev
Log:
Emit debug info for dynamic classes if they are imported from a DLL.
With -debug-info-kind=limited, we omit debug info for dynamic classes that live
in other TUs
rjmccall added inline comments.
Comment at: lib/CodeGen/CGStmt.cpp:525
@@ +524,3 @@
+void CodeGenFunction::LexicalNoAliasInfo::addNoAliasMD() {
+ if (MemoryInsts.empty() || NoAliasScopes.empty())
+return;
It's much more likely that NoAliasScopes will be empty
ahatanak added inline comments.
Comment at: test/CodeGenObjCXX/encode.mm:231
@@ +230,3 @@
+struct S {
+ typedef T Ty;
+ Ty *t;
manmanren wrote:
> I wonder if we can further reduce the testing case. Is this necessary to
> cause the infinite recursion?
Yes. If I
hfinkel added inline comments.
Comment at: lib/CodeGen/CGStmt.cpp:537
@@ +536,3 @@
+ llvm::LLVMContext::MD_noalias),
+ NewScopeList));
+
rjmccall wrote:
> This is a very strange representati
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D23462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
timshen created this revision.
timshen added a reviewer: dblaikie.
timshen added a subscriber: cfe-commits.
Corresponding LLVM patch: D23580
https://reviews.llvm.org/D23581
Files:
lib/Serialization/ModuleManager.cpp
Index: lib/Serialization/ModuleManager.cpp
==
Hi Hans,
Can we please merge this one to release_39 too? I forgot all about it, sorry.
Doug, can you please approve?
-Dimitry
> On 19 Apr 2016, at 19:43, Douglas Katzman via cfe-commits
> wrote:
>
> Author: dougk
> Date: Tue Apr 19 12:43:54 2016
> New Revision: 266775
>
> URL: http://llvm.
Author: cbieneman
Date: Tue Aug 16 15:44:58 2016
New Revision: 278849
URL: http://llvm.org/viewvc/llvm-project?rev=278849&view=rev
Log:
[CMake] [Apple Cache] Set CLANG_VENDOR_UTI for Apple builds
This is just a minor update to the Apple packaging configuration.
Modified:
cfe/trunk/cmake/cach
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278851: [OpenCL] AMDGPU: Add extensions cl_amd_media_ops and
cl_amd_media_ops2 (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D23322?vs=67358&id=68250#toc
Repository:
rL LLVM
Author: yaxunl
Date: Tue Aug 16 15:49:49 2016
New Revision: 278851
URL: http://llvm.org/viewvc/llvm-project?rev=278851&view=rev
Log:
[OpenCL] AMDGPU: Add extensions cl_amd_media_ops and cl_amd_media_ops2
Differential Revision: https://reviews.llvm.org/D23322
Modified:
cfe/trunk/include/clang
Author: cbieneman
Date: Tue Aug 16 15:49:49 2016
New Revision: 278850
URL: http://llvm.org/viewvc/llvm-project?rev=278850&view=rev
Log:
[CMake] Fixing typo in Info.plist generation
This is causing an error in the generation of the clang info plist.
Modified:
cfe/trunk/tools/driver/Info.plist
arsenm added inline comments.
Comment at: lib/CodeGen/CodeGenModule.h:664
@@ +663,3 @@
+ /// Get integer type of the same size as a pointer type.
+ llvm::IntegerType *getIntPtrTy(llvm::PointerType *PT);
+
This has the same purpose as DataLayout::getIntPtrType, s
arsenm closed this revision.
arsenm added a comment.
r278844
https://reviews.llvm.org/D23536
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rnk
Date: Tue Aug 16 15:20:56 2016
New Revision: 278842
URL: http://llvm.org/viewvc/llvm-project?rev=278842&view=rev
Log:
Try to work around an MSVC 2013 bug around defaulted default ctors
An UnresolvedSetIterator() is supposed to be zeroed out, but MSVC 2013
does not do that.
Modified:
ahatanak added a comment.
I didn't think of this case, but no, it isn't a good idea. We shouldn't issue a
warning unless we know the returned pointer is nullable.
Comment at: lib/Sema/SemaDecl.cpp:9739
@@ +9738,3 @@
+ DeducedType = DeducedType.setNullability(
+ In
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Better update the title to be `[OpenCL] AMDGPU: add support of
cl_khr_subgroups` since cl_khr_subgroups is already in clang.
Repository:
rL LLVM
https://reviews.llvm.org/D23
yaxunl updated this revision to Diff 68241.
yaxunl added a comment.
Remove language dependency. Choose proper integer types for pointer arithmetic.
https://reviews.llvm.org/D23361
Files:
include/clang/Basic/TargetInfo.h
lib/Basic/TargetInfo.cpp
lib/Basic/Targets.cpp
lib/CodeGen/CGExprSc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278838: Remove excessive padding from LineNoCacheTy
(authored by d0k).
Changed prior to commit:
https://reviews.llvm.org/D23546?vs=68153&id=68240#toc
Repository:
rL LLVM
https://reviews.llvm.org/D23
NoQ added inline comments.
Comment at: lib/Analysis/CloneDetection.cpp:154
@@ -153,2 +153,3 @@
// Function pointers don't have a callee and we just skip hashing it.
-if (S->getDirectCallee())
+if (S->getDirectCallee()) {
+ // If the function is a template instant
yaxunl added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:101
@@ -100,3 +100,3 @@
DoubleTy = llvm::Type::getDoubleTy(LLVMContext);
PointerWidthInBits = C.getTargetInfo().getPointerWidth(0);
PointerAlignInBytes =
joey wrote:
> What if you cre
alexshap added a comment.
Thanks, no, i don't. I will be grateful to you if you land this patch.
https://reviews.llvm.org/D23546
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
looks good, thanks. Do you have commit access?
https://reviews.llvm.org/D23546
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
dcoughlin added a comment.
I would recommend putting the tests in existing test files next to tests that
for similar diagnostics for other allocation/free schemes. So the test for
printExpectedAllocName() should go in test/Analysis/free.c and the test for
printExpectedDeallocName() should proba
Today, the code includes the eprintf archive on all linker invocations for i386
that include the OS X archive.
Removing the eprintf library from the command and including eprintf only for
i386 in the OS X archive should be equivalent to what we have today.
-Chris
> On Aug 16, 2016, at 8:27 AM,
ashi1 created this revision.
ashi1 added reviewers: yaxunl, Anastasia.
ashi1 added a subscriber: cfe-commits.
ashi1 set the repository for this revision to rL LLVM.
Adding extension cl_khr_subgroups to clang's OpenCL Extensions and initiated
inside AMDGPU Target. Similar to https://reviews.llvm.o
amccarth added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:1688-1689
@@ -1687,3 +1687,4 @@
- if (CXXDecl->hasDefinition() && CXXDecl->isDynamicClass())
+ if (CXXDecl->hasDefinition() && CXXDecl->isDynamicClass() &&
+ !CXXDecl->hasAttr())
return true;
---
amccarth updated this revision to Diff 68225.
amccarth added a comment.
Add comment as requested.
https://reviews.llvm.org/D23462
Files:
lib/CodeGen/CGDebugInfo.cpp
test/CodeGenCXX/debug-info-dllimport-base-class.cpp
Index: test/CodeGenCXX/debug-info-dllimport-base-class.cpp
==
klimek added a reviewer: diltsman.
klimek added a comment.
+Daniel dilts who wrote the arguments support
One problem is that getting into the game of parsing arbitrary shell modes is
rather ugly.
https://reviews.llvm.org/D23455
___
cfe-commits mai
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278826: [ObjC] Warn on unguarded use of partial declaration
(authored by epilk).
Changed prior to commit:
https://reviews.llvm.org/D23003?vs=67713&id=68218#toc
Repository:
rL LLVM
https://reviews.ll
Author: epilk
Date: Tue Aug 16 12:44:11 2016
New Revision: 278826
URL: http://llvm.org/viewvc/llvm-project?rev=278826&view=rev
Log:
[ObjC] Warn on unguarded use of partial declaration
This commit adds a traversal of the AST after Sema of a function that diagnoses
unguarded references to declarati
Anastasia added a comment.
In https://reviews.llvm.org/D23086#516741, @yaxunl wrote:
> In https://reviews.llvm.org/D23086#516365, @Anastasia wrote:
>
> > Why not to just identify the type by the name? It seems much easier and
> > also gives flexibility to implement the type in different ways if
I'm not Richard, but I agree with merging it into 3.9 nonetheless. :-)
~Aaron
On Tue, Aug 16, 2016 at 12:30 PM, Hans Wennborg via cfe-commits
wrote:
> Seems reasonable to me if Richard agrees.
>
> On Tue, Aug 16, 2016 at 3:01 AM, James Molloy wrote:
>> Hi Hans,
>>
>> [cc. Richard as code owner]
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/readability/MisplacedArrayIndexCheck.cpp:56
@@ +55,3 @@
+ if (hasMacroID(ArraySubscriptE) ||
+
!Result.SourceManager->isWrittenInSameFile(ArraySubscriptE->getLoc
zturner added a comment.
In https://reviews.llvm.org/D23455#516753, @alexfh wrote:
> In https://reviews.llvm.org/D23455#515527, @rnk wrote:
>
> > In https://reviews.llvm.org/D23455#515486, @brad.king wrote:
> >
> > > > the feasibility of emitting 'arguments' instead of 'command' into the
> > > >
Seems reasonable to me if Richard agrees.
On Tue, Aug 16, 2016 at 3:01 AM, James Molloy wrote:
> Hi Hans,
>
> [cc. Richard as code owner]
>
> I'd like to nominate this commit for 3.9. The actual code churn is tiny, and
> this fixes a problem noticed by and causing pain to the qemu project.
>
> Ch
Adding Guy, the author of this commit.
From: Reid Kleckner [mailto:r...@google.com]
Sent: Tuesday, August 16, 2016 19:14
To: Yatsina, Marina
Cc: cfe-commits
Subject: Re: r278783 - [X86] Add xgetbv/x[X86] Add xgetbv xsetbv intrinsics to
non-windows platforms
Reverted in r278814, it appears to b
r278817. Many thanks.
On Mon, Aug 15, 2016 at 5:36 PM, Richard Smith wrote:
> Hi Hans, Eric Fiselier requested that we fix this bug for 3.9 (it affects
> libc++'s std::optional implementation), so this would be a good candidate
> for the branch.
>
> On Mon, Aug 15, 2016 at 5:13 PM, Richard Smith
alexfh added a comment.
Adding Aaron, since he seems to have interest in Windows support for clang-tidy.
https://reviews.llvm.org/D23455
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
alexfh added a comment.
In https://reviews.llvm.org/D23455#515527, @rnk wrote:
> In https://reviews.llvm.org/D23455#515486, @brad.king wrote:
>
> > > the feasibility of emitting 'arguments' instead of 'command' into the
> > > JSON compilation database.
> >
> >
> > CMake constructs the command li
rnk added a subscriber: rnk.
rnk added a comment.
Reverted in r278814, it appears to break usage of _xgetbv on Windows:
https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin%28dll%29/builds/5846/steps/compile/logs/stdio
../../base/cpu.cc(194,10): error: use of undeclared identifier '_xge
Author: rnk
Date: Tue Aug 16 11:07:46 2016
New Revision: 278815
URL: http://llvm.org/viewvc/llvm-project?rev=278815&view=rev
Log:
Remove most instances of REQUIRES: shell from the tools/extra tests
None of these tests actually require bash, they just have quoting bugs
when paths contain backslash
Reverted in r278814, it appears to break usage of _xgetbv on Windows:
https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin%28dll%29/builds/5846/steps/compile/logs/stdio
../../base/cpu.cc(194,10): error: use of undeclared identifier '_xgetbv'
(_xgetbv(0) & 6) == 6 /* XSAVE enabled
Author: rnk
Date: Tue Aug 16 11:04:14 2016
New Revision: 278814
URL: http://llvm.org/viewvc/llvm-project?rev=278814&view=rev
Log:
Revert "[X86] Add xgetbv/x[X86] Add xgetbv xsetbv intrinsics to non-windows
platforms"
This reverts commit r278783. It breaks usage of _xgetbv on Windows.
Modified:
lattner resigned from this revision.
lattner removed a reviewer: lattner.
lattner added a comment.
Seems obvious to me, but it would be best to find another reviewer, I haven't
worked on this code for some time.
https://reviews.llvm.org/D23546
___
yaxunl added a comment.
In https://reviews.llvm.org/D23086#516365, @Anastasia wrote:
> Why not to just identify the type by the name? It seems much easier and also
> gives flexibility to implement the type in different ways if needed.
> Considering that similar approach is already used for some
The original motivation for organizing things this way was to try and
always be in the situation where, when linking against the latest
deployment target, we should never need the extra library (because the
content will be present in libSystem). This is useful in helping to ensure
we don't unnecess
rnk added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:1688-1689
@@ -1687,3 +1687,4 @@
- if (CXXDecl->hasDefinition() && CXXDecl->isDynamicClass())
+ if (CXXDecl->hasDefinition() && CXXDecl->isDynamicClass() &&
+ !CXXDecl->hasAttr())
return true;
v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
LGTM.
https://reviews.llvm.org/D22515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/readability/NonConstParameterCheck.cpp:95-98
@@ +94,6 @@
+const QualType T = VD->getType();
+if (T->isPointerType() && !T->getPointeeType().isConstQualified())
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman closed this revision.
aaron.ballman added a comment.
Thank you! I've commit in r278812.
https://reviews.llvm.org/D23329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
Author: aaronballman
Date: Tue Aug 16 09:48:39 2016
New Revision: 278812
URL: http://llvm.org/viewvc/llvm-project?rev=278812&view=rev
Log:
Reduce the number of allocations required for AST attributes. In test cases,
the max resident memory changed from 65760k to 64476k which is 1.9%
improvement.
Author: sfantao
Date: Tue Aug 16 09:38:39 2016
New Revision: 278811
URL: http://llvm.org/viewvc/llvm-project?rev=278811&view=rev
Log:
Reorder stderr redirection in test command.
Modified:
cfe/trunk/test/Driver/cuda-detect.cu
Modified: cfe/trunk/test/Driver/cuda-detect.cu
URL:
http://llvm.or
Author: sfantao
Date: Tue Aug 16 09:31:39 2016
New Revision: 278806
URL: http://llvm.org/viewvc/llvm-project?rev=278806&view=rev
Log:
Add empty --gcc-toolchain empty to cuda-detect test.
Unless we overload the default gcc toolchain with an empty string
the system root used in the tests will be i
teemperor planned changes to this revision.
teemperor added a comment.
- As the hash_stream patch will take a while to land upstream, we will change
this to use FoldingSetNodeID and change it to hash_stream once that landed.
https://reviews.llvm.org/D22515
___
alexfh added inline comments.
Comment at: test/clang-tidy/clang-tidy-run-with-database.cpp:11
@@ -10,3 @@
-// RUN: echo '#include "header.h"' > %T/compilation-database-test/b/d.cpp
-// RUN: sed 's|test_dir|%T/compilation-database-test|g'
%S/Inputs/compilation-database/template.js
teemperor created this revision.
teemperor added reviewers: v.g.vassilev, NoQ.
teemperor added a subscriber: cfe-commits.
The CloneDetector currently ignores template arguments in function calls which
leads to false-positive clones such as `isa(S)` and `isa(S)`.
This patch adds functionality to
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with one minor nit (you can fix it during the commit).
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:35
@@ +34,3 @@
+ auto CanCallCtor = unless(ha
Dear Clang developers,
please find attached a tiny patch which fixes a indentation warning from
GCC 6 within ArrayBoundCheckerV2.cpp
Proposed commit message:
> StaticAnalyzer: Fix GCC 6 indention warning in ArrayBoundCheckerV2.cpp
>
> Patch by Christoph Grüninger
Bye
Christoph
Index: lib/StaticAn
aaron.ballman added a comment.
Thank you for working on this check!
We already have a frontend diagnostic for comparisons between string literals
and pointers, so I'm not certain of the utility of adding a clang-tidy check
for that case (see -Wstring-compare, aka,
http://coliru.stacked-crooked
teemperor marked 2 inline comments as done.
teemperor added a comment.
https://reviews.llvm.org/D22515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:46-56
@@ +45,13 @@
+// std::move(). This will hopefully prevent erroneous replacements if the
+// code does unusual things (e.g. create an alias for std::move() in
+// ano
teemperor updated this revision to Diff 68170.
teemperor added a comment.
- Renamed FoldingSetWrapper to FoldingSetNodeIDWrapper
- Added missing // end anonymous namespace
https://reviews.llvm.org/D22515
Files:
include/clang/Analysis/CloneDetection.h
lib/Analysis/CloneDetection.cpp
lib/St
xazax.hun created this revision.
xazax.hun added reviewers: zaks.anna, dcoughlin, NoQ.
xazax.hun added a subscriber: cfe-commits.
Small cleanup to utilize PathDiagnosticLocation::getStmt where appropriate.
https://reviews.llvm.org/D23550
Files:
lib/StaticAnalyzer/Checkers/DynamicTypeChecker.cp
ABataev requested changes to this revision.
ABataev added a comment.
This revision now requires changes to proceed.
No tests for serialization/deserialization/AST printing
https://reviews.llvm.org/D23528
___
cfe-commits mailing list
cfe-commits@list
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
This LGTM, but you should wait for confirmation on the behavior of the R_Group
behavior from @dnovillo or @rsmith before committing.
https://reviews.llvm.org/D23284
_
Author: hokein
Date: Tue Aug 16 06:15:05 2016
New Revision: 278791
URL: http://llvm.org/viewvc/llvm-project?rev=278791&view=rev
Log:
[clang-tidy] readability-implicit-bool-cast forgets to store its options.
Reviewers: alexfh
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.o
xazax.hun updated this revision to Diff 68157.
xazax.hun marked 5 inline comments as done.
xazax.hun added a comment.
- Improvements according to review comments.
https://reviews.llvm.org/D15227
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278791: [clang-tidy] readability-implicit-bool-cast forgets
to store its options. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D23544?vs=68154&id=68158#toc
Repository:
rL L
hokein updated this revision to Diff 68154.
hokein added a comment.
Move ctor body to .cpp file.
https://reviews.llvm.org/D23544
Files:
clang-tidy/readability/ImplicitBoolCastCheck.cpp
clang-tidy/readability/ImplicitBoolCastCheck.h
Index: clang-tidy/readability/ImplicitBoolCastCheck.h
Anastasia added a comment.
In https://reviews.llvm.org/D23086#515590, @yaxunl wrote:
> In https://reviews.llvm.org/D23086#515506, @Anastasia wrote:
>
> >
>
>
>
>
> > Surely vendors can re-implement all OpenCL types with an implicit typedef.
> > For example this would just work:
>
> >
>
> > ty
1 - 100 of 119 matches
Mail list logo
