compnerd added inline comments.
================
Comment at: include/clang/Basic/IdentifierTable.h:34
@@ -26,2 +33,3 @@
namespace llvm {
+
template <typename T> struct DenseMapInfo;
----------------
Not sure the whitespace adds any benefit here.
================
Comment at: include/clang/Basic/IdentifierTable.h:103
@@ -95,1 +102,3 @@
+ return getLength() == StrLen-1 &&
+ memcmp(getNameStart(), Str, StrLen-1) == 0;
}
----------------
Isn't the LLVM style to prefer the negation? Why did the infix operators not
get space around them?
================
Comment at: include/clang/Frontend/ASTUnit.h:52
@@ -39,2 +51,3 @@
namespace llvm {
+
class MemoryBuffer;
----------------
Not sure the whitespace is beneficial here.
================
Comment at: include/clang/Frontend/ASTUnit.h:928
@@ -913,3 +927,3 @@
bool lookupMissingImports(StringRef Name, SourceLocation TriggerLoc) override
- { return 0; }
+ { return false; }
};
----------------
This is weirdly formatted. I think its fine to clang-format this line.
================
Comment at: include/clang/Lex/PreprocessorOptions.h:22
@@ -23,2 +21,3 @@
namespace llvm {
+
class MemoryBuffer;
----------------
Don't think that the whitespace is beneficial here.
Repository:
rL LLVM
https://reviews.llvm.org/D23595
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
