Author: ctopper
Date: Fri Jul 8 00:11:47 2016
New Revision: 274825
URL: http://llvm.org/viewvc/llvm-project?rev=274825&view=rev
Log:
[X86] Remove dead builtins that don't exist in the backend intrinsic file and
don't have custom handling in CGBuiltins.cpp either.
Modified:
cfe/trunk/include
> On Jul 7, 2016, at 8:36 PM, Gerolf Hoflehner wrote:
>
> Ahmed pointed out the clang commit causing the issue is r244207 - Mark calls
> in thunk functions as tail-call optimization candidates
>
> The purpose of the fix was to prevent thunks from showing up on the call
> stack.
>
> It seems
dberris added a comment.
Thanks -- I don't have commit powers yet, do either of you mind landing this
for me?
Cheers
http://reviews.llvm.org/D20352
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: ctopper
Date: Thu Jul 7 21:17:35 2016
New Revision: 274823
URL: http://llvm.org/viewvc/llvm-project?rev=274823&view=rev
Log:
[CodeGen] Use llvm::Type::getVectorNumElements instead of casting to
llvm::VectorType and calling getNumElements. This is equivalent and shorter.
Modified:
cf
Author: ctopper
Date: Thu Jul 7 20:57:24 2016
New Revision: 274821
URL: http://llvm.org/viewvc/llvm-project?rev=274821&view=rev
Log:
[X86] Reuse existing lambda and remove unnecessary argument from vector cmp
builtin handling. NFC
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
Modified: cfe
Author: ctopper
Date: Thu Jul 7 20:48:44 2016
New Revision: 274820
URL: http://llvm.org/viewvc/llvm-project?rev=274820&view=rev
Log:
[X86] Remove a couple calls to create V2F64 and V4F32 types for builtin
handling. Just get the type from the operand of the builtin instead. NFC
Modified:
cfe
mehdi_amini accepted this revision.
mehdi_amini added a reviewer: mehdi_amini.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D11360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274816: [analyzer] Add rudimentary handling of AtomicExpr.
(authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D21667?vs=63096&id=63172#toc
Repository:
rL LLVM
http://reviews.l
Author: dcoughlin
Date: Thu Jul 7 19:53:18 2016
New Revision: 274816
URL: http://llvm.org/viewvc/llvm-project?rev=274816&view=rev
Log:
[analyzer] Add rudimentary handling of AtomicExpr.
This proposed patch adds crude handling of atomics to the static analyzer.
Rather than ignore AtomicExprs, as
compnerd added inline comments.
Comment at: src/Registers.hpp:1497
@@ -1479,3 +1496,3 @@
_LIBUNWIND_ABORT("unsupported arm register");
}
rmaprath wrote:
> compnerd wrote:
> > Early returns would be nicer imo.
> Not sure if I follow, did you mean to check t
Author: compnerd
Date: Thu Jul 7 19:37:31 2016
New Revision: 274814
URL: http://llvm.org/viewvc/llvm-project?rev=274814&view=rev
Log:
Revert "Driver: Stop linking to C++ when using sanitizers on Darwin"
This reverts SVN r274797. It broke the Green Dragon bot. Revert it until the
failure can be
dcoughlin added a comment.
Anna and Jordan said I should just go ahead and commit this.
http://reviews.llvm.org/D21667
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
teemperor updated this revision to Diff 63161.
teemperor marked 5 inline comments as done.
teemperor added a comment.
- Fixed type of StmtSequence::iterator.
http://reviews.llvm.org/D20795
Files:
include/clang/AST/CloneDetection.h
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/AST/
sfantao added a comment.
In http://reviews.llvm.org/D21857#476527, @Hahnfeld wrote:
> Hi Samuel,
>
> this looks pretty good overall!
>
> I've only encountered one issue which I don't really know is caused by which
> patch: I can't use the (exact) same triple for offloading and the host when
> c
sfantao added a comment.
Hi Jonas,
Thanks for trying that out!
Comment at: tools/clang-offload-bundler/ClangOffloadBundler.cpp:477-490
@@ +476,16 @@
+
+// Do the incremental linking. We write to the output file directly. So, we
+// close it and use the name to pass down
teemperor updated this revision to Diff 63159.
teemperor added a comment.
- Fixed the problems pointed out by Vassil (Thanks!)
- Comments now have less line breaks.
- Added more documentation to HashValue, it's hash function and the used prime
numbers.
- Added a typedef for StmtSequence::iterator
Author: mkuper
Date: Thu Jul 7 18:22:39 2016
New Revision: 274805
URL: http://llvm.org/viewvc/llvm-project?rev=274805&view=rev
Log:
[CUDA] Pass correct option in test.
Modified:
cfe/trunk/test/Driver/cuda-version-check.cu
Modified: cfe/trunk/test/Driver/cuda-version-check.cu
URL:
http://ll
This patch was reverted because it breaks a test on the buildbots (that
I've been unable to reproduce locally), so that's why you didn't seen
anything. I'll try again to land the patch once I can fix and verify that
test.
This patch is one part of the change. The other part is
http://reviews.llv
On Thu, Jul 7, 2016 at 3:45 PM, David Blaikie wrote:
> Yeah - is this necessary for CodeView? (does something break, or do you
> just get simple names where you'd prefer full mangled or qualified names)
>
> It was chosen pretty deliberately to do it this way (use unqualified
> names) for gmlt to
On Wed, Jul 6, 2016 at 2:07 PM, David Majnemer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: majnemer
> Date: Wed Jul 6 16:07:53 2016
> New Revision: 274677
>
> URL: http://llvm.org/viewvc/llvm-project?rev=274677&view=rev
> Log:
> [CodeGen, DebugInfo] Use hasLocalLinkage instead
Ah, I see why I might not've seen the result - it was reverted & I didn't
spot the revert in a quick search for r274628 (because it was quoted as
rL because Phab is weird and likes to put an "L" in there).
On Thu, Jul 7, 2016 at 4:03 PM, David Blaikie wrote:
> This may cause problems for DWA
This may cause problems for DWARF type unit consistency...
Under what conditions do nested types appear in the member list? (my simple
test case on a fresh clang didn't seem to produce anything about the nested
type: struct outer { struct inner { int i; }; int j; }; outer o; )
On Wed, Jul 6, 2016
Author: vedantk
Date: Thu Jul 7 17:38:29 2016
New Revision: 274800
URL: http://llvm.org/viewvc/llvm-project?rev=274800&view=rev
Log:
[Lex] Speed up updateConsecutiveMacroArgTokens (NFC)
SM.isWrittenInSameFile() calls getFileID(), which can be expensive.
Move this check behind some cheaper filter
Yeah - is this necessary for CodeView? (does something break, or do you
just get simple names where you'd prefer full mangled or qualified names)
It was chosen pretty deliberately to do it this way (use unqualified names)
for gmlt to keep size down. Have you got numbers for the size delta for
Code
Author: rksimon
Date: Thu Jul 7 17:32:26 2016
New Revision: 274799
URL: http://llvm.org/viewvc/llvm-project?rev=274799&view=rev
Log:
Update switch statement to match coding standards.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
URL:
http://llvm.org/v
omtcyf0 added a comment.
Manuel,
> I think it's important to note that Miklos is probably a user, otherwise I'd
> guess he wouldn't add those features.
Sure. But there are different kinds of users :) IIRC there's a discussion in
cfe-def called "Clang should natively support Fortran" or someth
ashi1 marked an inline comment as done.
Comment at: cfe/trunk/include/clang/Driver/Options.td:381
@@ +380,3 @@
+def cl_unsafe_math_optimizations : Flag<["-"],
"cl-unsafe-math-optimizations">, Group, Flags<[CC1Option]>,
+ HelpText<"OpenCL only. Allow unsafe floating-point optimiz
Author: compnerd
Date: Thu Jul 7 16:42:29 2016
New Revision: 274797
URL: http://llvm.org/viewvc/llvm-project?rev=274797&view=rev
Log:
Driver: Stop linking to C++ when using sanitizers on Darwin
Sanitizers on Darwin are built as dynamic libraries, not static libraries.
Sanitizers will have their
Alexander_Droste updated this revision to Diff 63142.
Alexander_Droste added a comment.
- fix typo
http://reviews.llvm.org/D21962
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/MpiTypeMismatchCheck.cpp
clang-tidy/misc/MpiTypeMismatchCheck.h
do
ashi1 added a reviewer: yaxunl.
ashi1 removed rL LLVM as the repository for this revision.
ashi1 updated this revision to Diff 63143.
ashi1 added a comment.
Revised base on Sam's comments.
Added no-signed-zeros as an attribute no-signed-zeros-fp-math.
Added a test for no-signed-zeros-fp-math.
probinson created this revision.
probinson added a reviewer: rsmith.
probinson added a subscriber: cfe-commits.
We have a C test that now gets a warning about a C++1z extension, which seems
inappropriate.
http://reviews.llvm.org/D22113
Files:
lib/Sema/SemaDecl.cpp
test/Sema/inline.c
Index
Alexander_Droste marked 4 inline comments as done.
Alexander_Droste added a comment.
http://reviews.llvm.org/D21962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added a comment.
Kirill, I think it's important to note that Miklos is probably a user,
otherwise I'd guess he wouldn't add those features.
Generally, we also internally have a (large scale) simplified rename tool that
allows renaming multiple things in a code base at once; it is definite
omtcyf0 added a comment.
Miklos, thanks for the feedback!
Hm, I'm not sure about a) and b) camps here. I think we can have both. It may
be that I haven't looked too much into the code or I am missing something, but
so far both integration and cross-TU analysis seem OK together in one tool as
f
vmiklos added a comment.
Kirill: OK, so you're in the camp marked as b) by Manuel. Sure, the vim
integration is nice (I'm also a vim user), now that you mentioned it, I need to
go and try it myself. ;-) Given the above patch, probably it's obvious that I'm
more in camp a). I don't insist on hav
Author: mcrosier
Date: Thu Jul 7 15:02:25 2016
New Revision: 274791
URL: http://llvm.org/viewvc/llvm-project?rev=274791&view=rev
Log:
[AArch64] Change the preferred alignment for char and short.
This reinstates commits r273280 and r273289.
Original Review: http://reviews.llvm.org/D21414.
Modif
Btw we do have some advice for these situations in the programmer's manual:
http://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations
-- Sean Silva
On Thu, Jul 7, 2016 at 4:24 AM, Simon Pilgrim via cfe-commits <
cfe-commits@lists.llvm.org> wrot
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
In http://reviews.llvm.org/D20352#477203, @rnk wrote:
> In http://reviews.llvm.org/D20352#477084, @aaron.ballman wrote:
>
> > No, I'm not. I am worried about how this conflicts wi
echristo added a comment.
In http://reviews.llvm.org/D20352#477203, @rnk wrote:
> In http://reviews.llvm.org/D20352#477084, @aaron.ballman wrote:
>
> > No, I'm not. I am worried about how this conflicts with another in-flight
> > patch for supporting MS hotpatchable functions since it seems thes
rnk added a comment.
In http://reviews.llvm.org/D20352#477084, @aaron.ballman wrote:
> No, I'm not. I am worried about how this conflicts with another in-flight
> patch for supporting MS hotpatchable functions since it seems these two
> attributes do roughly the same thing. I'd like to understa
RKSimon created this revision.
RKSimon added reviewers: eli.friedman, mkuper, craig.topper, spatel, andreadb.
RKSimon added a subscriber: cfe-commits.
RKSimon set the repository for this revision to rL LLVM.
D20859 and D20860 attempted to replace the SSE (V)CVTTPS2DQ and VCVTTPD2DQ
truncating con
omtcyf0 created this revision.
omtcyf0 added reviewers: alexfh, klimek, bkramer, ioeric.
omtcyf0 added a subscriber: cfe-commits.
This patch introduces few additional tests including one case the tool does not
handle yet, which should be fixed in the future.
http://reviews.llvm.org/D22102
Files
aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.
In http://reviews.llvm.org/D20352#477038, @rnk wrote:
> Looks good from a driver perspective. Aaron, you're happy with the attribute
> spelling stuff, right?
No, I'm
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Looks good from a driver perspective. Aaron, you're happy with the attribute
spelling stuff, right?
It looks like you can actually land this before landing the two dependent
changes you mention and
Author: jlebar
Date: Thu Jul 7 13:24:28 2016
New Revision: 274782
URL: http://llvm.org/viewvc/llvm-project?rev=274782&view=rev
Log:
[CUDA] s/OPT_nocuda_version_chec/OPT_no_cuda_version_check/.
Fix build breakage.
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
cfe/trunk/lib/Driver/Tools.c
omtcyf0 created this revision.
omtcyf0 added reviewers: kimgr, alexfh, bkramer, hokein, ioeric.
omtcyf0 added a subscriber: cfe-commits.
http://reviews.llvm.org/D22100
Files:
clang-rename/tool/clang-rename.py
Index: clang-rename/tool/clang-rename.py
omtcyf0 added a comment.
@kimgr oops, sorry.
I'll send a cleanup patch.
Thanks for noticing.
Repository:
rL LLVM
http://reviews.llvm.org/D22087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
bittnerbarni updated this revision to Diff 63098.
bittnerbarni added a comment.
Thank you, for your valuable comments Alexander!
http://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringConcatenationCheck.cpp
clang-tidy/performanc
jlebar added a comment.
Friendly ping
http://reviews.llvm.org/D21912
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274781: [CUDA] Check that our CUDA install supports the
requested architectures. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D21869?vs=63094&id=63100#toc
Repository:
rL LLV
Author: jlebar
Date: Thu Jul 7 13:17:52 2016
New Revision: 274781
URL: http://llvm.org/viewvc/llvm-project?rev=274781&view=rev
Log:
[CUDA] Check that our CUDA install supports the requested architectures.
Summary:
Raise an error if you're using a CUDA installation that's too old for
the requeste
Author: jlebar
Date: Thu Jul 7 13:15:03 2016
New Revision: 274780
URL: http://llvm.org/viewvc/llvm-project?rev=274780&view=rev
Log:
[CUDA] Rename the __nvvm_bar0 builtin back to __syncthreads.
The builtin was renamed in r274770. But __syncthreads is part of our
user-facing API, so we need to ke
omtcyf0 added a subscriber: omtcyf0.
omtcyf0 added a comment.
Hi @vmiklos!
Thank you very much for contributing to clang-rename.
The patch looks nice, but it conflicts with my understanding of the view on
what the tool should do.
Generally, I do not support the idea of adding an option to perf
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: lib/Driver/ToolChains.cpp:1798
@@ +1797,3 @@
+FS.getBufferForFile(InstallPath + "/version.txt");
+if (!VersionFile) {
+ // CUDA 7.0 doesn't have a
dcoughlin marked an inline comment as done.
dcoughlin added a comment.
Ping.
Richard: Would you be willing to take a quick look at the change to the AST?
http://reviews.llvm.org/D21667
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
dcoughlin marked an inline comment as done.
Comment at: test/Analysis/atomics.c:5
@@ +4,3 @@
+// because we don't fully model the atomics and instead imprecisely
+// treat their arguments as escaping.
+
Thanks! Fixed.
http://reviews.llvm.org/D21667
__
dcoughlin updated this revision to Diff 63096.
dcoughlin added a comment.
Fix typo and bad indentation.
http://reviews.llvm.org/D21667
Files:
include/clang/AST/Expr.h
include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h
lib/StaticAnalyzer/Core/ExprEngine.cpp
test/Analysis/atomic
jlebar added inline comments.
Comment at: include/clang/Driver/Options.td:1722-1724
@@ -1721,2 +1721,5 @@
def nocudalib : Flag<["-"], "nocudalib">;
+def nocuda_version_check : Flag<["-"], "nocuda-version-check">,
+ HelpText<"Don't error out if the detected version of the CUDA in
jlebar updated this revision to Diff 63094.
jlebar marked 3 inline comments as done.
jlebar added a comment.
Address review comments.
http://reviews.llvm.org/D21869
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Options.td
lib/Driver/ToolChains.cpp
lib/Driver/T
omtcyf0 added inline comments.
Comment at: clang-rename/USRLocFinder.h:38
@@ -37,2 +37,2 @@
-#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_RENAME_USR_LOC_FINDER_H
+#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_RENAME_USR_LOC_FINDER_H
bkramer wrote:
> In LLVM we usually have
omtcyf0 updated this revision to Diff 63093.
omtcyf0 marked an inline comment as done.
http://reviews.llvm.org/D22091
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRLocFinder.cpp
clang-rename/USRLocFinder.h
clang-rename/tool/ClangRename.cpp
Index: clang-rename/tool/ClangRename.cp
Alexander_Droste marked 22 inline comments as done.
Comment at: clang-tidy/misc/MpiTypeMismatchCheck.cpp:153
@@ +152,3 @@
+ {BuiltinType::LongDouble, "MPI_C_LONG_DOUBLE_COMPLEX"}};
+
+ const auto *Builtin =
Sure, I can do that. I marked all addressed comment
+ Brian
Hi Anastasia,
The advantage for translating sampler variable to a global variable with
__sampler_initializer type is that it is consistent with OpenCL C++ and SPIRV,
so it is easier to translate the IR to SPIRV.
About the type name of sampler_t in LLVM, using a name without `.` allows
Alexander_Droste updated this revision to Diff 63091.
Alexander_Droste added a comment.
- make static functions free functions
- make static containers local to their corresponding functions
- only assign the buffer type name in case of an error
- fix capitalization and punctuation in error diagno
dcoughlin closed this revision.
dcoughlin added a comment.
This was committed in r274691. I forgot to add the Differential Revision line
so phabricator didn't pick it up.
http://reviews.llvm.org/D22048
___
cfe-commits mailing list
cfe-commits@lists
davidsh updated this revision to Diff 63090.
davidsh added a comment.
Address comments
http://reviews.llvm.org/D22075
Files:
lib/Sema/SemaOpenMP.cpp
test/OpenMP/target_map_messages.cpp
Index: test/OpenMP/target_map_messages.cpp
==
sfantao added a comment.
Thanks. You have to wait for Alexey to take a look at the patch too.
Thanks again,
Samuel
http://reviews.llvm.org/D22075
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
zaks.anna accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:2075
@@ +2074,3 @@
+void ExprEngine::VisitAtomicExpr(const AtomicExpr *AE, ExplodedNode *Pred,
+ ExplodedNodeSet &Dst) {
+ Exp
tra added inline comments.
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:32
@@ -29,1 +31,3 @@
+ "Use --cuda-path to specify a different CUDA install, or pass "
+ "--nocuda-version-check.">;
def err_drv_invalid_thread_model_for_target : Error<
Is it s
Author: mcrosier
Date: Thu Jul 7 11:37:21 2016
New Revision: 274767
URL: http://llvm.org/viewvc/llvm-project?rev=274767&view=rev
Log:
Revert "[aarch64] Update datalayout for aarch64 tests"
This reverts commit r273289, which was a follow to r273280, which was
reverted because the change was not p
Author: bogner
Date: Thu Jul 7 11:41:08 2016
New Revision: 274770
URL: http://llvm.org/viewvc/llvm-project?rev=274770&view=rev
Log:
NVPTX: Use the nvvm builtins to read SRegs rather than the legacy ptx ones
The ptx spellings were removed from LLVM in r274769.
Modified:
cfe/trunk/include/cla
Author: mcrosier
Date: Thu Jul 7 11:37:19 2016
New Revision: 274766
URL: http://llvm.org/viewvc/llvm-project?rev=274766&view=rev
Log:
Revert "[AArch64] Change the preferred alignment for char and short to word
alignment"
This reverts commit r273280 as the change was not properly approved.
Modi
Anastasia added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2509
@@ -2508,3 +2508,3 @@
"functions, methods, and parameters|classes|enums|variables|methods|"
- "fields and global variables|structs|variables and typedefs|thread-local
variables|"
- "
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Could you please address these last minor comments though before
committing.
Thanks!
Comment at: test/SemaOpenCL/access-qualifier.cl:10
@@ +9,3 @@
+#if __OPENCL_
bkramer added inline comments.
Comment at: clang-rename/USRLocFinder.h:38
@@ -37,2 +37,2 @@
-#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_RENAME_USR_LOC_FINDER_H
+#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_RENAME_USR_LOC_FINDER_H
In LLVM we usually have only one space be
Anastasia added inline comments.
Comment at: include/clang/AST/BuiltinTypes.def:164
@@ +163,3 @@
+// Internal OpenCL sampler initializer type.
+BUILTIN_TYPE(OCLSamplerInit, OCLSamplerInitTy)
+
> However, we want it to be translated to __sampler_initializer* type.
kimgr added a subscriber: kimgr.
kimgr added a comment.
I only caught this typo after it was committed.
Comment at: clang-tools-extra/trunk/clang-rename/tool/clang-rename.py:17-18
@@ +16,4 @@
+All you have to do now is to place a cursor on a variable/function/class which
+you wo
vmiklos added a subscriber: vmiklos.
vmiklos added a comment.
Can you please postpone the cleanup till http://reviews.llvm.org/D21814 is
reviewed? The two patches conflict with each other, I fear. Thanks. :-)
http://reviews.llvm.org/D22091
___
cfe-
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in r274751.
http://reviews.llvm.org/D22046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
asavonic marked 4 inline comments as done.
asavonic added a comment.
http://reviews.llvm.org/D20948
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
asavonic updated this revision to Diff 63073.
asavonic added a comment.
Merged invalid-access-qualifier.cl and images-typedef.cl tests, fixed
code style issues.
http://reviews.llvm.org/D20948
Files:
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274759: [clang-rename] add basic vim integration (authored
by d0k).
Changed prior to commit:
http://reviews.llvm.org/D22087?vs=63058&id=63072#toc
Repository:
rL LLVM
http://reviews.llvm.org/D22087
Author: d0k
Date: Thu Jul 7 09:35:32 2016
New Revision: 274759
URL: http://llvm.org/viewvc/llvm-project?rev=274759&view=rev
Log:
[clang-rename] add basic vim integration
This patch introduces basic Vim integration for clang-rename tool.
For setup reference see clang-rename/tool/clang-rename.py
omtcyf0 added a comment.
@bkramer can you please land the patch?
http://reviews.llvm.org/D22087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyf0 created this revision.
omtcyf0 added reviewers: alexfh, klimek, bkramer, ioeric.
omtcyf0 added a subscriber: cfe-commits.
This patch does the following:
* enforces proper formatting for few files (i.e. deals with 80 linewidth
violations and few other things)
* ensures '\n' chars are pass
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Sorry for the delay. Feel free to ping me earlier.
Comment at: clang-tidy/modernize/ExplicitOperatorBoolCheck.cpp:38
@@ +37,3 @@
+ Finder->addMatcher(
+ cxxCon
thakis added a comment.
r274751, thanks!
http://reviews.llvm.org/D22046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Thu Jul 7 08:19:45 2016
New Revision: 274751
URL: http://llvm.org/viewvc/llvm-project?rev=274751&view=rev
Log:
[clang-tidy] Add dependency on clang-headers
Currently, to be able to process a source file including e.g. stddef.h with
clang-tidy, one has to build both clang-tidy
alexfh added a comment.
Sorry for the delay. Your patch was lost in my inbox. Feel free to ping me
earlier.
Comment at: docs/clang-tidy/checks/bugprone-bool-to-integer-conversion.rst:37
@@ +36,3 @@
+
+It turns out that the common bug is to have function returning only bools but
a.sidorin created this revision.
a.sidorin added reviewers: zaks.anna, dcoughlin.
a.sidorin added a subscriber: cfe-commits.
Some FileIDs that may be used by PlistDiagnostics are not added while building
a list of pieces. This leads to assertion violation in `GetFID()` function.
This patch tries
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/misc/MpiTypeMismatchCheck.cpp:147
@@ +146,3 @@
+const Type *MpiTypeMismatchCheck::argumentType(const CallExpr *const CE,
+
klimek added a comment.
In http://reviews.llvm.org/D21814#476572, @bkramer wrote:
> In http://reviews.llvm.org/D21814#475322, @klimek wrote:
>
> > I think we really want 2 tools:
> > a) one that is optimized for oldname->newname renames, and supports the
> > multi-TU case really well
> > b) on
omtcyf0 updated this revision to Diff 63058.
http://reviews.llvm.org/D22087
Files:
clang-rename/tool/clang-rename.py
Index: clang-rename/tool/clang-rename.py
===
--- /dev/null
+++ clang-rename/tool/clang-rename.py
@@ -0,0 +1,61 @@
omtcyf0 updated this revision to Diff 63057.
omtcyf0 marked 2 inline comments as done.
http://reviews.llvm.org/D22087
Files:
clang-rename/tool/clang-rename.py
Index: clang-rename/tool/clang-rename.py
===
--- /dev/null
+++ clang-re
omtcyf0 marked an inline comment as done.
Comment at: clang-rename/tool/clang-rename.py:13
@@ +12,3 @@
+map ,cr :pyf /clang-rename.py
+
+IMPORTANT NOTE: Before running the tool, make sure you saved the file.
Aw, sure; sorry for that. That's an artifact from fi
omtcyf0 marked an inline comment as done.
omtcyf0 added a comment.
http://reviews.llvm.org/D22087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
Thanks for the new awesome check!
Please run the check on LLVM and include your analysis of the results in the
patch description. Another couple of comments below.
Comment at: clang-tidy/cppcoreguidelines/SlicingCheck.cpp:93
@@ +92,3 @@
+ continue;
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:525
@@ +524,3 @@
+ DeclarationType = DeclarationType.getNonReferenceType();
+if (Descriptor.ElemType.isNull() || DeclarationType
alexfh added inline comments.
Comment at: clang-rename/tool/clang-rename.py:17
@@ +16,3 @@
+All you have to do now is to place a cursor on a variable/function/class which
+you would like to rename and press ',cf'. You will be promted a new name if the
+cursor points to a valid sym
alexfh accepted this revision.
alexfh added a comment.
LG
http://reviews.llvm.org/D22087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 133 matches
Mail list logo
