tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

LGTM.


================
Comment at: lib/Driver/ToolChains.cpp:1798
@@ +1797,3 @@
+        FS.getBufferForFile(InstallPath + "/version.txt");
+    if (!VersionFile) {
+      // CUDA 7.0 doesn't have a version.txt, so guess that's our version if
----------------
Good point. It may be worth a separate patch. Falling back to 7.0 on any error 
is OK for now.

================
Comment at: lib/Driver/ToolChains.cpp:4727
@@ +4726,3 @@
+  // Check our CUDA version if we're going to include the CUDA headers.
+  if (!DriverArgs.hasArg(options::OPT_nocudainc) &&
+      !DriverArgs.hasArg(options::OPT_nocuda_version_check)) {
----------------
OK.


http://reviews.llvm.org/D21869



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to