Re: [llvm-dev] [RFC] Embedded bitcode and related upstream (Part II)

Hi Steven, Great to see the commentary and updates here. I've got a few questions about some of this work. It might be nice to see some separate RFCs for a couple of things, but we'll figure that out after you send out patches probably :) What needs to be improved: > 1. Whitelist for command line

Re: [PATCH] D21270: clang-rename: implement handling of remaining named casts

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG, although I believe the recent history of changes indicates that the approach is suboptimal, and we should address this on a higher level. But for now fixing the bugs seems like the right s

[PATCH] D21275: clang-format: [JS] Indent namespaces in JavaScript/TS by default.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added subscribers: cfe-commits, alexeagle. Herald added a subscriber: klimek. There's no convention of avoiding the nested indentation. http://reviews.llvm.org/D21275 Files: lib/Format/Format.cpp unittests/Format/Forma

r272534 - MPIBugReporter.h: Fix a warning. [-Wdocumentation]

Author: chapuni Date: Mon Jun 13 00:46:35 2016 New Revision: 272534 URL: http://llvm.org/viewvc/llvm-project?rev=272534&view=rev Log: MPIBugReporter.h: Fix a warning. [-Wdocumentation] Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/MPI-Checker/MPIBugReporter.h Modified: cfe/trunk/lib/Static

r272532 - [AVX512] Masked pcmpeqd, pcmpeqq, pcmpgtd, and pcmpgtq don't require avx512bw, just avx512vl.

Author: ctopper Date: Sun Jun 12 23:15:11 2016 New Revision: 272532 URL: http://llvm.org/viewvc/llvm-project?rev=272532&view=rev Log: [AVX512] Masked pcmpeqd, pcmpeqq, pcmpgtd, and pcmpgtq don't require avx512bw, just avx512vl. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def cfe/

r272531 - Improved Visual Studio visualization of OpaquePtr

Author: mps Date: Sun Jun 12 23:02:35 2016 New Revision: 272531 URL: http://llvm.org/viewvc/llvm-project?rev=272531&view=rev Log: Improved Visual Studio visualization of OpaquePtr Create a special visualizer for OpaquePtr because the standard visualizer doesn't work with OpaquePtr due to QualTyp

r272530 - [analyzer] Remove some list initialization from MPI Checker to make MSVC bots happy.

Author: dcoughlin Date: Sun Jun 12 22:58:58 2016 New Revision: 272530 URL: http://llvm.org/viewvc/llvm-project?rev=272530&view=rev Log: [analyzer] Remove some list initialization from MPI Checker to make MSVC bots happy. This is a speculative attempt to fix the compiler error: "list initializati

Re: [PATCH] D21081: MPI-Checker patch for Clang Static Analyzer

This revision was automatically updated to reflect the committed changes. Closed by commit rL272529: [analyzer] Add checker to verify the correct usage of the MPI API (authored by dcoughlin). Changed prior to commit: http://reviews.llvm.org/D21081?vs=60472&id=60486#toc Repository: rL LLVM h

r272529 - [analyzer] Add checker to verify the correct usage of the MPI API

Author: dcoughlin Date: Sun Jun 12 22:22:41 2016 New Revision: 272529 URL: http://llvm.org/viewvc/llvm-project?rev=272529&view=rev Log: [analyzer] Add checker to verify the correct usage of the MPI API This commit adds a static analysis checker to verify the correct usage of the MPI API in C and

Re: [PATCH] D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl

mspertus closed this revision. mspertus added a comment. revision 272525 http://reviews.llvm.org/D21256 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21273: clang-format: [JS] Introduce WrapJavaScriptImports option.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. When turned on, clang-format wraps JavaScript imports (and importing exports), instead of forcing the entire import statement onto one line. http://reviews

Re: [PATCH] D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl

mspertus accepted this revision. mspertus added a reviewer: mspertus. mspertus added a comment. This revision is now accepted and ready to land. No adverse (or otherwise) comments received, so committing as revision 272525 http://reviews.llvm.org/D21256 ___

Re: [PATCH] D21204: clang-format: [JS] post-fix non-null assertion operator.

This revision was automatically updated to reflect the committed changes. Closed by commit rL272524: clang-format: [JS] post-fix non-null assertion operator. (authored by mprobst). Changed prior to commit: http://reviews.llvm.org/D21204?vs=60311&id=60482#toc Repository: rL LLVM http://revie

r272524 - clang-format: [JS] post-fix non-null assertion operator.

Author: mprobst Date: Sun Jun 12 19:49:54 2016 New Revision: 272524 URL: http://llvm.org/viewvc/llvm-project?rev=272524&view=rev Log: clang-format: [JS] post-fix non-null assertion operator. Summary: Do not insert whitespace preceding the "!" postfix operator. This is an incomplete fix, but shoul

Re: [PATCH] D21145: [Sema] Fix crash on valid where instantiation of lambda cannot access type of 'this'

faisalv added a comment. Hmm - after having given this some more thought - I'm not as confident about the best approach. Should we leverage the CXXThisTypeOverride mechanism (as you had done in your initial patch) - and remove the computation entirely from getCurrentThisType - or just remove C

Re: [PATCH] D21241: Add an ASTMatcher for ignoring ExprWithCleanups.

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. Also, please add documentation to the matcher definition and regenerate the documentation. http://reviews.llvm.org/D21241 ___

r272522 - Visual Studio Visualizer for PackExpansionType

Author: mps Date: Sun Jun 12 17:54:46 2016 New Revision: 272522 URL: http://llvm.org/viewvc/llvm-project?rev=272522&view=rev Log: Visual Studio Visualizer for PackExpansionType Modified: cfe/trunk/utils/ClangVisualizers/clang.natvis Modified: cfe/trunk/utils/ClangVisualizers/clang.natvis URL

r272521 - Visual Studio native visualizer for ParsedTemplateArgument

Author: mps Date: Sun Jun 12 17:21:56 2016 New Revision: 272521 URL: http://llvm.org/viewvc/llvm-project?rev=272521&view=rev Log: Visual Studio native visualizer for ParsedTemplateArgument Does a good job with type and non-type template arguments and lays the groundwork for template template argu

Re: [PATCH] D20358: [Clang][AVX512][Intrinsics]Convert AVX non-temporal store builtins to LLVM-native IR.

RKSimon added a comment. In http://reviews.llvm.org/D20358#446241, @RKSimon wrote: > In http://reviews.llvm.org/D20358#446220, @ab wrote: > > > In http://reviews.llvm.org/D20358#446218, @ab wrote: > > > > > In http://reviews.llvm.org/D20358#446210, @RKSimon wrote: > > > > > > > Is there any reaso

[PATCH] D21272: [Clang][X86] Convert non-temporal store builtins to generic __builtin_nontemporal_store in headers

RKSimon created this revision. RKSimon added reviewers: craig.topper, ab, spatel, andreadb. RKSimon added a subscriber: cfe-commits. RKSimon set the repository for this revision to rL LLVM. As discussed on D20358, we can now use __builtin_nontemporal_store instead of target specific builtins for

Re: [PATCH] D21081: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste added a comment. Hi Devin, this is much cleaner. Looks good for me! http://reviews.llvm.org/D21081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21270: clang-rename: implement handling of remaining named casts

vmiklos created this revision. vmiklos added a reviewer: klimek. vmiklos added a subscriber: cfe-commits. const_cast<> and reinterpret_cast<>. http://reviews.llvm.org/D21270 Files: clang-rename/USRLocFinder.cpp test/clang-rename/ConstCastExpr.cpp test/clang-rename/ReinterpretCastExpr.cpp

r272520 - Add some std::move where the value is only read otherwise.

Author: d0k Date: Sun Jun 12 15:05:23 2016 New Revision: 272520 URL: http://llvm.org/viewvc/llvm-project?rev=272520&view=rev Log: Add some std::move where the value is only read otherwise. This mostly affects smart pointers. No functionality change intended. Modified: cfe/trunk/include/clang

Re: [PATCH] D21268: [x86] translate SSE packed FP comparison builtins to IR

RKSimon added a comment. Eeep that's certainly a lot more work than just adding a few extra cases! Please add a TODO explaining what we need to do? If there is a problem with the header documentation please can you raise a bugzilla and CC Katya Romanova. http://reviews.llvm.org/D21268

Re: [PATCH] D21241: Add an ASTMatcher for ignoring ExprWithCleanups.

klimek added a comment. Please add a test. http://reviews.llvm.org/D21241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21145: [Sema] Fix crash on valid where instantiation of lambda cannot access type of 'this'

erik.pilkington updated this revision to Diff 60477. erik.pilkington added a comment. This new patch changes `Sema::getCurrentThisType` to recover the `this` type when a lambda initializer is being transformed. This is done with the same code as when instantiating a generic lambda initializer. I

Re: [PATCH] D21268: [x86] translate SSE packed FP comparison builtins to IR

spatel added a comment. In http://reviews.llvm.org/D21268#455668, @RKSimon wrote: > Is there any reason that we shouldn't include the avxintrin.h > __builtin_ia32_cmppd/__builtin_ia32_cmpps/__builtin_ia32_cmppd256/__builtin_ia32_cmpps256 > packed intrinsics in this CGBuiltin.cpp patch? Since we

Re: [PATCH] D21113: Add support for case-insensitive header lookup

On Fri, Jun 10, 2016 at 10:35:26AM -0700, Hans Wennborg wrote: > On Thu, Jun 9, 2016 at 5:31 PM, Joerg Sonnenberger via cfe-commits > wrote: > > On Wed, Jun 08, 2016 at 01:12:31AM +, Hans Wennborg via cfe-commits > > wrote: > >> There has been a patch for this before (http://reviews.llvm.org/

Re: [PATCH] D21268: [x86] translate SSE packed FP comparison builtins to IR

RKSimon added a comment. Is there any reason that we shouldn't include the avxintrin.h __builtin_ia32_cmppd/__builtin_ia32_cmpps/__builtin_ia32_cmppd256/__builtin_ia32_cmpps256 packed intrinsics in this CGBuiltin.cpp patch? Since we're heading towards nixing them anyhow. http://reviews.llvm.o

Re: Add support for musl-libc on Linux

On Sun, Jun 12, 2016 at 10:51:11AM +0800, Lei Zhang via llvm-commits wrote: > Hi, > > I'm replying to this thread; sorry I wasn't subscribed to the list, > thus cannot reply to it directly. > > http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160606/161733.html > > Joerg, thanks for you

r272518 - Rudimentary support for Visual Studio Stmt visualizer

Author: mps Date: Sun Jun 12 13:42:04 2016 New Revision: 272518 URL: http://llvm.org/viewvc/llvm-project?rev=272518&view=rev Log: Rudimentary support for Visual Studio Stmt visualizer Better than nothing... Modified: cfe/trunk/utils/ClangVisualizers/clang.natvis Modified: cfe/trunk/utils/Cl

Re: [PATCH] D21081: MPI-Checker patch for Clang Static Analyzer

dcoughlin updated this revision to Diff 60472. dcoughlin added a comment. Alexander, a drawback with using keeping a vector of MPIBugReporters in the checker is that this will essentially "leak" all the created bug reporters. How about this instead: - Remove MPIBugReporter's MPIFunctionClassifi

[PATCH] D21268: [x86] translate SSE packed FP comparison builtins to IR

spatel created this revision. spatel added reviewers: craig.topper, RKSimon, ab. spatel added a subscriber: cfe-commits. Herald added a subscriber: mcrosier. As noted in the code comment, a potential follow-on would be to remove the builtins themselves. Other than ord/unord, this already works as

Re: [PATCH] D3243: Fix PR19195

karthikthecool abandoned this revision. karthikthecool added a comment. Abandon old review as im no longer working on the same. Thanks http://reviews.llvm.org/D3243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

Re: [PATCH] D21081: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste added a comment. F2057622: MPI-Checker.diff Hi, I now solved this, by using a `small_vector` of `MPIBugReporter`s (MPIChecker.h line: 101). So each time a report is generated, a new `MPIBugReporter` is added to that vector, in order to refer

Re: [PATCH] D19260: [analyzer][scan-build-py] subprocess output handling reviewed in clang module

rizsotto.mailinglist added a comment. hey Devin, thanks for looking to it. Comment at: tools/scan-build-py/libscanbuild/clang.py:90 @@ -89,2 +89,3 @@ -{: (, )} """ +predicate.patterns = [re.compile(r'^' + a + r'(\.|$)') for a in checkers] +return predicate