Re: [PATCH] D21204: clang-format: [JS] post-fix non-null assertion operator.

mprobst added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:2128 @@ +2127,3 @@ +if (Right.is(tok::exclaim) && (Left.isOneOf(tok::identifier, tok::r_paren, +tok::r_square, tok::r_brace) || +

Re: [PATCH] D21204: clang-format: [JS] post-fix non-null assertion operator.

mprobst updated this revision to Diff 60311. mprobst added a comment. - more tests http://reviews.llvm.org/D21204 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Format/FormatTestJS.cpp

Re: [PATCH] D21204: clang-format: [JS] post-fix non-null assertion operator.

djasper accepted this revision. This revision is now accepted and ready to land. Comment at: lib/Format/TokenAnnotator.cpp:2128 @@ +2127,3 @@ +if (Right.is(tok::exclaim) && +(Left.isOneOf(tok::identifier, tok::r_paren, tok::r_square) || + Left.Tok.isLiteral()))

Re: [PATCH] D21204: clang-format: [JS] post-fix non-null assertion operator.

mprobst updated this revision to Diff 60308. mprobst marked an inline comment as done. mprobst added a comment. - invert check to whitelist known tokens that can precede a non-null assertion. http://reviews.llvm.org/D21204 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestJS.c

Re: [PATCH] D21204: clang-format: [JS] post-fix non-null assertion operator.

mprobst added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:2127 @@ +2126,3 @@ +// Postfix non-null assertion operator, as in `foo!.bar()`. +if (Right.is(tok::exclaim) && Right.Next && +Right.Next->isNot(tok::identifier) && !Right.Next->Tok.isLiteral()

r272368 - Check for null pointers before calling the Stmt Profiler

Author: rtrieu Date: Thu Jun 9 23:52:09 2016 New Revision: 272368 URL: http://llvm.org/viewvc/llvm-project?rev=272368&view=rev Log: Check for null pointers before calling the Stmt Profiler Some calls from OMPClauseProfiler were calling the Stmt Profiler with null pointers, but the profiler can o

Re: [PATCH] D21204: clang-format: [JS] post-fix non-null assertion operator.

djasper added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:2127 @@ +2126,3 @@ +// Postfix non-null assertion operator, as in `foo!.bar()`. +if (Right.is(tok::exclaim) && Right.Next && +Right.Next->isNot(tok::identifier) && !Right.Next->Tok.isLiteral()

r272366 - Fix recognition of shadowed template parameter

Author: sepavloff Date: Thu Jun 9 23:39:07 2016 New Revision: 272366 URL: http://llvm.org/viewvc/llvm-project?rev=272366&view=rev Log: Fix recognition of shadowed template parameter Crash reported in PR28023 is caused by the fact that non-type template parameters are found by tag name lookup. I

Re: [PATCH] D21163: Strip Android version when looking up toolchain paths.

t.p.northover accepted this revision. t.p.northover added a reviewer: t.p.northover. t.p.northover added a comment. This revision is now accepted and ready to land. I think that looks good. Thanks for adding the test! Tim. http://reviews.llvm.org/D21163 __

r272361 - Reduce sizeof(CXXConstructorDecl) by 4-8 bytes.

Author: rsmith Date: Thu Jun 9 21:01:28 2016 New Revision: 272361 URL: http://llvm.org/viewvc/llvm-project?rev=272361&view=rev Log: Reduce sizeof(CXXConstructorDecl) by 4-8 bytes. Modified: cfe/trunk/include/clang/AST/DeclCXX.h Modified: cfe/trunk/include/clang/AST/DeclCXX.h URL: http://ll

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

vsk added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:41 @@ +40,3 @@ + // (and destructed) as in push_back case. + auto isCtorOfSmartPtr = hasDeclaration(cxxConstructorDecl( + ofClass(hasAnyName("std::shared_ptr", "std::unique_ptr", "std::auto_ptr"

Re: [PATCH] D21163: Strip Android version when looking up toolchain paths.

jmgao updated this revision to Diff 60294. jmgao added a comment. Add test. http://reviews.llvm.org/D21163 Files: lib/Driver/Driver.cpp test/Driver/Inputs/android_triple_version/bin/arm-linux-androideabi-ld test/Driver/Inputs/android_triple_version/bin/arm-linux-androideabi-ld.exe test/

Re: [PATCH] D19260: [analyzer][scan-build-py] subprocess output handling reviewed in clang module

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. This looks good to me. I've run this on a suite of open source projects and it reported no changes in the reference results. Thanks for simplifying and adding the extra tests!

r272357 - Remove CXXConstructExpr::getFoundDecl(); it turned out to not be useful.

Author: rsmith Date: Thu Jun 9 19:58:19 2016 New Revision: 272357 URL: http://llvm.org/viewvc/llvm-project?rev=272357&view=rev Log: Remove CXXConstructExpr::getFoundDecl(); it turned out to not be useful. Modified: cfe/trunk/include/clang/AST/ExprCXX.h cfe/trunk/include/clang/Sema/Sema.h

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

rsmith added a comment. Thanks for the updates, LGTM (@bruno, did you get the performance numbers you wanted?) http://reviews.llvm.org/D19843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

Re: [PATCH] D21113: Add support for case-insensitive header lookup

On Wed, Jun 08, 2016 at 01:12:31AM +, Hans Wennborg via cfe-commits wrote: > There has been a patch for this before (http://reviews.llvm.org/D2972), > but this one is more general, as it works on the virtual filesystem > layer, and also supports case-insensitive lookups of parent directories >

r272350 - Add doxygen comments to mmintrin.h's intrinsics.

Author: kromanova Date: Thu Jun 9 19:10:40 2016 New Revision: 272350 URL: http://llvm.org/viewvc/llvm-project?rev=272350&view=rev Log: Add doxygen comments to mmintrin.h's intrinsics. The doxygen comments are automatically generated based on Sony's intrinsics docu ment. I got an OK from Eric Ch

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

eric_niebler updated this revision to Diff 60281. eric_niebler added a comment. Replace `StringSet` with `StringSwitch`, ASCII range ends at 0x7f not 0xff, miscellaneous formatting tweaks. http://reviews.llvm.org/D19843 Files: include/clang/Basic/DiagnosticLexKinds.td include/clang/Basic/F

Re: [PATCH] D21198: RenderScript support in the Frontend

pirama added a comment. Thanks for the review. Docs update is in http://reviews.llvm.org/D21212 Repository: rL LLVM http://reviews.llvm.org/D21198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D21212: Add documentation for RenderScript changes

pirama created this revision. pirama added a reviewer: rsmith. pirama added subscribers: srhines, cfe-commits. Herald added subscribers: danalbert, tberghammer. - Document the new 'kernel' attribute - Mention RenderScript support in the Release Notes. http://reviews.llvm.org/D21212 Files: docs

Re: [PATCH] D21198: RenderScript support in the Frontend

This revision was automatically updated to reflect the committed changes. Closed by commit rL272342: RenderScript support in the Frontend (authored by pirama). Changed prior to commit: http://reviews.llvm.org/D21198?vs=60277&id=60279#toc Repository: rL LLVM http://reviews.llvm.org/D21198 F

r272342 - RenderScript support in the Frontend

Author: pirama Date: Thu Jun 9 18:34:20 2016 New Revision: 272342 URL: http://llvm.org/viewvc/llvm-project?rev=272342&view=rev Log: RenderScript support in the Frontend Summary: Create a new Frontend LangOpt to specify the renderscript language. It is enabled by the "-x renderscript" option fro

Re: [PATCH] D21198: RenderScript support in the Frontend

pirama updated this revision to Diff 60277. pirama added a comment. Reorder IK_RenderScript before IK_AST like Richard had requested. http://reviews.llvm.org/D21198 Files: include/clang/Basic/Attr.td include/clang/Basic/LangOptions.def include/clang/Frontend/FrontendOptions.h lib/Fronte

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

eric_niebler added inline comments. Comment at: lib/Lex/PPDirectives.cpp:33 @@ -28,2 +32,2 @@ #include "llvm/Support/Path.h" #include "llvm/Support/SaveAndRestore.h" rsmith wrote: > eric_niebler wrote: > > You mean, instead of the `StringSet` below? Looks like `

Re: [PATCH] D21206: clang-format: [JS] recognized named functions in AnnotatingParser.

This revision was automatically updated to reflect the committed changes. Closed by commit rL272330: clang-format: [JS] recognized named functions in AnnotatingParser. (authored by mprobst). Changed prior to commit: http://reviews.llvm.org/D21206?vs=60254&id=60268#toc Repository: rL LLVM ht

r272330 - clang-format: [JS] recognized named functions in AnnotatingParser.

Author: mprobst Date: Thu Jun 9 17:49:04 2016 New Revision: 272330 URL: http://llvm.org/viewvc/llvm-project?rev=272330&view=rev Log: clang-format: [JS] recognized named functions in AnnotatingParser. Summary: This also fixes union type formatting in function parameter types. Before: function x(

r272325 - Redirect unused output in test to /dev/null

Author: rtrieu Date: Thu Jun 9 17:39:20 2016 New Revision: 272325 URL: http://llvm.org/viewvc/llvm-project?rev=272325&view=rev Log: Redirect unused output in test to /dev/null Discard unused output so when the test fails, it only prints information that is helpful about the failure. No function

r272323 - [CMake] Version is aways greater than 3

Author: cbieneman Date: Thu Jun 9 17:38:40 2016 New Revision: 272323 URL: http://llvm.org/viewvc/llvm-project?rev=272323&view=rev Log: [CMake] Version is aways greater than 3 We don't need any checks for this code anymore. Since CMake version is always greater than 3 we can always generate the

Re: [PATCH] D21206: clang-format: [JS] recognized named functions in AnnotatingParser.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. The change looks good, but can you add a before/after example to change description? http://reviews.llvm.org/D21206 ___ cfe-commits mailing li

r272324 - [CMake] Cleaning up CMake version checks in ExternalProject calls

Author: cbieneman Date: Thu Jun 9 17:38:42 2016 New Revision: 272324 URL: http://llvm.org/viewvc/llvm-project?rev=272324&view=rev Log: [CMake] Cleaning up CMake version checks in ExternalProject calls Now that we're on CMake 3.4.3 all the ExternalProject features we use are supported everywhere

Re: [PATCH] D20388: AMDGPU: Fix supported CL features

jvesely marked an inline comment as done. jvesely added a comment. Repository: rL LLVM http://reviews.llvm.org/D20388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20388: AMDGPU: Fix supported CL features

jvesely updated this revision to Diff 60259. jvesely added a comment. tests all extensions against expected outcome (add negative tests) enable cl_khr_icd (works ok with mesa) Repository: rL LLVM http://reviews.llvm.org/D20388 Files: lib/Basic/Targets.cpp test/Misc/amdgcn.languageOptsOpe

Re: [PATCH] D20389: NVPTX: Add supported CL features

jvesely updated this revision to Diff 60257. jvesely added a comment. add back require registered target Repository: rL LLVM http://reviews.llvm.org/D20389 Files: lib/Basic/Targets.cpp test/Misc/nvptx.languageOptsOpenCL.cl Index: test/Misc/nvptx.languageOptsOpenCL.cl ===

[PATCH] D21206: clang-format: [JS] recognized named functions in AnnotatingParser.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. This also fixes union type formatting in function parameter types. http://reviews.llvm.org/D21206 Files: lib/Format/TokenAnnotator.cpp unittests/Forma

r272318 - Fix a crash in the AST dumper.

Author: rtrieu Date: Thu Jun 9 17:03:04 2016 New Revision: 272318 URL: http://llvm.org/viewvc/llvm-project?rev=272318&view=rev Log: Fix a crash in the AST dumper. Boxed expressions in a template context may have a null method decl. If so, don't try to access the selector. Modified: cfe/tru

Re: [PATCH] D21198: RenderScript support in the Frontend

pirama updated this revision to Diff 60252. pirama added a comment. Cleanup bad merge http://reviews.llvm.org/D21198 Files: include/clang/Basic/Attr.td include/clang/Basic/LangOptions.def include/clang/Frontend/FrontendOptions.h lib/Frontend/CompilerInvocation.cpp lib/Frontend/Fronten

Re: [PATCH] D20338: [PCH] Fixed overridden files always invalidating preamble even when unchanged

cameron314 updated this revision to Diff 60250. cameron314 added a comment. Here's the final fix (it's the line in FileManager.cpp, plus a test). http://reviews.llvm.org/D20338 Files: include/clang/Frontend/ASTUnit.h lib/Basic/FileManager.cpp lib/Frontend/ASTUnit.cpp unittests/Frontend/

Re: [PATCH] D21198: RenderScript support in the Frontend

pirama added a comment. Oops, this update merged changes from http://reviews.llvm.org/D21199 as well. Let me clean up and upload a new patch. http://reviews.llvm.org/D21198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

r272317 - Add a RenderScript language type

Author: pirama Date: Thu Jun 9 16:57:40 2016 New Revision: 272317 URL: http://llvm.org/viewvc/llvm-project?rev=272317&view=rev Log: Add a RenderScript language type Summary: Add RenderScript language type and associate it with ".rs" extensions. Test that the driver passes "-x renderscript" to th

Re: [PATCH] D21199: Add a RenderScript language type

This revision was automatically updated to reflect the committed changes. Closed by commit rL272317: Add a RenderScript language type (authored by pirama). Changed prior to commit: http://reviews.llvm.org/D21199?vs=60238&id=60249#toc Repository: rL LLVM http://reviews.llvm.org/D21199 Files

Re: [PATCH] D21198: RenderScript support in the Frontend

pirama updated this revision to Diff 60247. pirama updated the summary for this revision. pirama added a comment. Re-ordered enum http://reviews.llvm.org/D21198 Files: include/clang/Basic/Attr.td include/clang/Basic/LangOptions.def include/clang/Driver/Types.def include/clang/Frontend/F

Re: Does anyone need these zorg modules?

Hello, Last call for the next builder modules: ChrootSetup.py DragonEggBuilder.py KLEEBuilder.py ScriptedBuilder.py gccSuiteBuilder.py I am going to remove them. If anyone have plans for any of them please speak up! Thanks Galina ___ cfe-commits mail

Re: [PATCH] D20338: [PCH] Fixed overridden files always invalidating preamble even when unchanged

cameron314 added inline comments. Comment at: lib/Basic/FileManager.cpp:389 @@ -383,2 +388,3 @@ UFE->File.reset(); + UFE->IsVirtual = true; return UFE; rsmith wrote: > Yes. The `IsValid` flag is just supposed to mean that this file has actually > been adde

Re: [PATCH] D21198: RenderScript support in the Frontend

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Please make sure that any relevant parts of our documentation are also updated. Given how small and self-contained this is, that we have a reasonable expectation of good support and maintainer

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21204: clang-format: [JS] post-fix non-null assertion operator.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. Do not insert whitespace preceding the "!" postfix operator. This is an incomplete fix, but should cover common usage. http://reviews.llvm.org/D21204 File

r272312 - [CMake] Cleaning up CMake feature gating on 2.8.12

Author: cbieneman Date: Thu Jun 9 16:29:55 2016 New Revision: 272312 URL: http://llvm.org/viewvc/llvm-project?rev=272312&view=rev Log: [CMake] Cleaning up CMake feature gating on 2.8.12 CMake 2.8.12 introduced interface libraries and some related policies. This removes the conditional block bec

Re: [PATCH] D20933: Preallocate ExplodedNode hash table

zaks.anna added a comment. Ah, right, please, add a comment explaining what we are doing and why. http://reviews.llvm.org/D20933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20933: Preallocate ExplodedNode hash table

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. LGTM. Thanks! http://reviews.llvm.org/D20933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D21199: Add a RenderScript language type

pirama created this revision. pirama added a reviewer: rsmith. pirama added subscribers: srhines, cfe-commits. Add RenderScript language type and associate it with ".rs" extensions. Test that the driver passes "-x renderscript" to the frontend for ".rs" files. (Also add '.rs' to the list of suffi

[PATCH] D21198: Add a RenderScript language type

pirama created this revision. pirama added a reviewer: rsmith. pirama added subscribers: srhines, cfe-commits. Add RenderScript language type and associate it with ".rs" extensions. Test that the driver passes "-x renderscript" to the frontend for ".rs" files. (Also add '.rs' to the list of suffi

r272310 - Revert "[Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr."

Author: timshen Date: Thu Jun 9 16:13:39 2016 New Revision: 272310 URL: http://llvm.org/viewvc/llvm-project?rev=272310&view=rev Log: Revert "[Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr." This reverts r272296, since there are clang-tidy failures that appear to be ca

Re: [PATCH] D21054: CodeGen: Update Clang to use the new type metadata.

eugenis accepted this revision. eugenis added a reviewer: eugenis. eugenis added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D21054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

Re: [PATCH] D20338: [PCH] Fixed overridden files always invalidating preamble even when unchanged

rsmith added inline comments. Comment at: lib/Basic/FileManager.cpp:389 @@ -383,2 +388,3 @@ UFE->File.reset(); + UFE->IsVirtual = true; return UFE; Yes. The `IsValid` flag is just supposed to mean that this file has actually been added to the `UniqueRealFi

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

eric_niebler added a comment. > Before this goes in again, I want to double check that this doesn't affect > compile time on darwin + frameworks. @bruno, you're not likely to find a difference for darwin + frameworks since the frameworks headers like `Cocoa/Cocoa.h` don't exist on-disk with th

Re: [PATCH] D20821: Fix a few issues while skipping function bodies

rsmith added a comment. Please call `Parser::ConsumeAndStoreFunctionPrologue` rather than trying to reinvent it. You're still getting a number of cases wrong that it handles properly. You also need to handle the case where the code completion token appears within the constructor *mem-initializ

Re: [PATCH] D21187: Allow use of lambda expressions in array bounds

rsmith added a subscriber: rsmith. Comment at: lib/Sema/SemaExpr.cpp:12825 @@ -12824,1 +12824,3 @@ + // BlockContext. + } else if (!Rec.IsArrayBound) { // C++1y [expr.const]p2: This isn't correct; you still need to produce the diagnostic even if

Re: [PATCH] D20490: [Parser] Fix a crash on invalid where a delayed TypoExpr was corrected twice

rsmith added inline comments. Comment at: lib/Parse/ParseExpr.cpp:450-452 @@ -449,1 +449,5 @@ + +// In this case, ActOnBinOp performed the CorrectDelayedTyposInExpr check. +if (!getLangOpts().CPlusPlus) + continue; } else { The inc

Re: [PATCH] D20933: Preallocate ExplodedNode hash table

bcraig added a comment. I got better valgrind numbers (symbols are important). Before: 106,131,538 After: 106,657,666 Diff: 526,128 larger. Note that this is sampled peaks for heap usage. They may not be accurate. Regardless, the peak usage increased by less than .5%. http://reviews.llvm.org

Re: [PATCH] D20933: Preallocate ExplodedNode hash table

bcraig updated this revision to Diff 60177. bcraig added a comment. Capping the pre-reserve space http://reviews.llvm.org/D20933 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h lib/StaticAnalyzer/Core/CoreEngine.cpp Index: lib/StaticAnalyzer/Core/CoreEngine.cpp =

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

vsk added a subscriber: vsk. vsk added a comment. @Eugene.Zelenko thanks for pointing this out, I had totally missed this patch! Once we get this reviewed I'm willing to abandon my version. Some comments inline -- Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:26 @@ +25,

Re: [PATCH] D21162: [CUDA] Implement __shfl* intrinsics in clang headers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL272299: [CUDA] Implement __shfl* intrinsics in clang headers. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D21162?vs=60223&id=60230#toc Repository: rL LLVM http://reviews.l

r272299 - [CUDA] Implement __shfl* intrinsics in clang headers.

Author: jlebar Date: Thu Jun 9 15:04:57 2016 New Revision: 272299 URL: http://llvm.org/viewvc/llvm-project?rev=272299&view=rev Log: [CUDA] Implement __shfl* intrinsics in clang headers. Summary: Clang changes to make use of the LLVM intrinsics added in D21160. Reviewers: tra Subscribers: jhole

Re: [PATCH] D20389: NVPTX: Add supported CL features

jvesely marked 2 inline comments as done. jvesely added a comment. Repository: rL LLVM http://reviews.llvm.org/D20389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20389: NVPTX: Add supported CL features

jvesely updated this revision to Diff 60226. jvesely added a comment. Test all known extensions against expected nvptx outcome (add negative tests) Repository: rL LLVM http://reviews.llvm.org/D20389 Files: lib/Basic/Targets.cpp test/Misc/nvptx.languageOptsOpenCL.cl Index: test/Misc/nvpt

Re: [PATCH] D20498: [Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL272296: [Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr. (authored by timshen). Changed prior to commit: http://reviews.llvm.org/D20498?vs=58694&id=60227#toc Repository: rL

r272296 - [Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr.

Author: timshen Date: Thu Jun 9 14:54:46 2016 New Revision: 272296 URL: http://llvm.org/viewvc/llvm-project?rev=272296&view=rev Log: [Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr. These ExprWithCleanups are added for holding a RunCleanupsScope not for destructor calls

Re: [PATCH] D20490: [Parser] Fix a crash on invalid where a delayed TypoExpr was corrected twice

erik.pilkington added a comment. Pong!! http://reviews.llvm.org/D20490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20498: [Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D20498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D21162: [CUDA] Implement __shfl* intrinsics in clang headers.

jlebar added inline comments. Comment at: lib/Headers/__clang_cuda_intrinsics.h:77-80 @@ +76,6 @@ +_Static_assert(sizeof(__tmp) == sizeof(__in)); \ +memcpy(&__tmp, &__in, sizeof(__in)); \ +__tmp = ::__

Re: [PATCH] D21162: [CUDA] Implement __shfl* intrinsics in clang headers.

jlebar updated this revision to Diff 60223. jlebar marked 2 inline comments as done. jlebar added a comment. Update after tra's review. http://reviews.llvm.org/D21162 Files: include/clang/Basic/BuiltinsNVPTX.def lib/Headers/__clang_cuda_intrinsics.h lib/Headers/__clang_cuda_runtime_wrappe

Re: [PATCH] D20933: Preallocate ExplodedNode hash table

zaks.anna added a comment. > If the underlying allocator that does a poor job at reusing freed memory, > then trivial > functions will use about 1 MB more than before, then free the memory > immediately. You could probably flag some of those functions, especially the ones that do not conta

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Eugene.Zelenko added a comment. There are alternative implementation in http://reviews.llvm.org/D21185. Will be good idea to how one which take the best from both :-) http://reviews.llvm.org/D20964 ___ cfe-commits mailing list cfe-commits@lists.llv

Re: [PATCH] D21185: [clang-tidy] Add performance-emplace-into-containers

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. See also http://reviews.llvm.org/D20964. I think modernize is better place for such check. http://reviews.llvm.org/D21185 ___ cfe-commits mailing list cfe-commits@li

Re: [PATCH] D19854: Define Contiki OS toolchain

eugenis added a comment. This needs a driver test. http://reviews.llvm.org/D19854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20347: Add support to clang-cl driver for /GS switch

thakis added a comment. probably at least the "the XOR with RSP/EBP/ESP" bit still (and maybe EH function upgrades instead of bailing) Comment at: lib/Driver/Tools.cpp:9990 @@ +9989,3 @@ + /*default=*/false)) +CmdArgs.push_back("/GS-"); +

Fwd: Java Interface for clang

Hello everybody, I want to use clang and its facilities to parse c and c++ . but I need to use it in java. In my searches , saw jClang or Clang bindings for java, checking the date of pages returned to me was before 2015. so I know what is the status of jclang or is there any solution to use clang

Re: [PATCH] D21113: Add support for case-insensitive header lookup

hans updated this revision to Diff 60220. hans added a comment. Adding the version that caches directory contents. This has the problem the it doesn't play with modules, the rewriter, and possibly others, because they write to the file system without any way for the vfs to find out. I've tried

RE: [PATCH] D21173: [X86] _MM_ALIGN16 attribute support for non-windows targets

Thanks the suggestion, David. I did not realize __attribute__ is supported by Windows targets. Zvi From: David Majnemer [mailto:david.majne...@gmail.com] Sent: Thursday, June 09, 2016 17:48 To: reviews+d21173+public+9a6e31402e430...@reviews.llvm.org; Rackover, Zvi Cc: Aboud, Amjad ; mku...@goo

Re: [PATCH] D21173: [X86] _MM_ALIGN16 attribute support for non-windows targets

zvi updated this revision to Diff 60217. zvi added a comment. Following David Majnemer's suggestion on cfe-commits: I would just use the __attribute__ spelling, no need for two definitions Repository: rL LLVM http://reviews.llvm.org/D21173 Files: lib/Headers/xmmintrin.h test/Headers/xmm

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

rmaprath added a comment. @mclow.lists, @EricWF: Gentle (and shameless) ping! http://reviews.llvm.org/D20328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20338: [PCH] Fixed overridden files always invalidating preamble even when unchanged

cameron314 added a comment. This is a fairly important bug for anyone hosting clang as a library (e.g. IDEs). Can someone have a look at this patch when they have a free moment? http://reviews.llvm.org/D20338 ___ cfe-commits mailing list cfe-commit

Re: [PATCH] D20132: [libclang] Add clang_getAllSkippedRanges function

cameron314 added a comment. Can someone have a look at this now that there's a test? http://reviews.llvm.org/D20132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r272288 - Make the comparison objects that we pass in for various tests look more like actual comparison objects. No functional change.

Author: marshall Date: Thu Jun 9 13:34:38 2016 New Revision: 272288 URL: http://llvm.org/viewvc/llvm-project?rev=272288&view=rev Log: Make the comparison objects that we pass in for various tests look more like actual comparison objects. No functional change. Modified: libcxx/trunk/test/st

Re: [PATCH] D20347: Add support to clang-cl driver for /GS switch

hans added a comment. Is this waiting for anything more now that http://reviews.llvm.org/D20346 has landed? http://reviews.llvm.org/D20347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D20979: [OpenCL] Use function attribute/metadata to represent kernel attributes

Anastasia added a comment. In http://reviews.llvm.org/D20979#452616, @yaxunl wrote: > In http://reviews.llvm.org/D20979#452463, @Anastasia wrote: > > > Looking good generally, I am just not sure about mixing two different > > representations. > > > If we choose only one form of representation, w

Re: [PATCH] D20444: [OpenCL] Include opencl-c.h by default as a clang module

Anastasia added inline comments. Comment at: test/Headers/opencl-c-header.cl:70 @@ +69,3 @@ +// RUN: %clang_cc1 -triple spir-unknown-unknown -emit-llvm -o - -finclude-default-header -fmodules -fimplicit-module-maps -fmodules-cache-path=%t %s | FileCheck %s +// RUN: %clang_cc1 -t

Re: [PATCH] D21185: [clang-tidy] Add performance-emplace-into-containers

vsk updated this revision to Diff 60206. vsk added a comment. - Fix the diagnostic message. Suggested by Erik Pilkington. http://reviews.llvm.org/D21185 Files: clang-tidy/performance/CMakeLists.txt clang-tidy/performance/EmplaceCheck.cpp clang-tidy/performance/EmplaceCheck.h clang-tidy/

Re: [PATCH] D21162: [CUDA] Implement __shfl* intrinsics in clang headers.

tra added inline comments. Comment at: lib/Headers/__clang_cuda_intrinsics.h:77-80 @@ +76,6 @@ +_Static_assert(sizeof(__tmp) == sizeof(__in)); \ +memcpy(&__tmp, &__in, sizeof(__in)); \ +__tmp = ::__FnN

Java Interface for clang

Hello everybody, I want to use clang and its facilities to parse c and c++ . but I need to use it in java. In my searches , saw jClang or Clang bindings for java, checking the date of pages returned to me was before 2015. so I know what is the status of jclang or is there any solution to use clang

r272280 - Revert "[CMake] Fix an issue building out-of-tree introduced in r272200"

Author: cbieneman Date: Thu Jun 9 12:24:16 2016 New Revision: 272280 URL: http://llvm.org/viewvc/llvm-project?rev=272280&view=rev Log: Revert "[CMake] Fix an issue building out-of-tree introduced in r272200" This reverts r272275. This actually wasn't the right way to fix the problem. The correc

Re: [PATCH] D21185: [clang-tidy] Add performance-emplace-into-containers

vsk added a reviewer: flx. vsk updated this revision to Diff 60194. vsk added a comment. - Fix handling of push_back(X(/* comment */)). - Don't try to emit a warning when the callee comes from a macro expansion. - Get rid of a weird/wrong comment about checking for "default constructors". As a si

Re: [clang-tools-extra] r272188 - clang-rename: implement renaming of classes inside dynamic_cast

Hi Galina, On Thu, Jun 09, 2016 at 10:15:27AM -0700, Galina Kistanova wrote: > This revision broke tests on one of builders: > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/14332 Please accept if it's the correct fix. It fix

[PATCH] D21187: Allow use of lambda expressions in array bounds

ahatanak created this revision. ahatanak added a subscriber: cfe-commits. clang currently errors out when a lambda expression is used to compute the size of an array even though clang supports variable-length arrays as a C99 extension. For example, $ cat vla1.cpp ``` int foo3(); struct S1 {

Re: [PATCH] D21162: [CUDA] Implement __shfl* intrinsics in clang headers.

jlebar added a comment. Thank you for the reviews, Justin! http://reviews.llvm.org/D21162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang-tools-extra] r272188 - clang-rename: implement renaming of classes inside dynamic_cast

Hi Miklos, This revision broke tests on one of builders: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/14332 Please have a look at this? Thanks Galina On Wed, Jun 8, 2016 at 11:38 AM, Miklos Vajna via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Au

Re: [PATCH] D21162: [CUDA] Implement __shfl* intrinsics in clang headers.

jlebar added a comment. (Art, I would appreciate a second set of eyes on this one, as the last time I did this -- with ldg -- I messed up pretty badly.) http://reviews.llvm.org/D21162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

Re: [PATCH] D20498: [Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr

timshen marked an inline comment as done. timshen added a comment. Ping? :) http://reviews.llvm.org/D20498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21163: Strip Android version when looking up toolchain paths.

t.p.northover added a subscriber: t.p.northover. t.p.northover added a comment. This could do with a test in test/Driver. http://reviews.llvm.org/D21163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

r272275 - [CMake] Fix an issue building out-of-tree introduced in r272200

Author: cbieneman Date: Thu Jun 9 11:21:10 2016 New Revision: 272275 URL: http://llvm.org/viewvc/llvm-project?rev=272275&view=rev Log: [CMake] Fix an issue building out-of-tree introduced in r272200 The out-of-tree build needs to read LLVM_TOOLS_INSTALL_DIR out of TOOLS_BINARY_DIR because LLVM_

  1   2   >