twoh added a comment.
@faisalv, thank you for the update. I wonder if getCurrentThisType() is the
best place to call adjustCVQualifiersForCXXThisWithinLambda(). It seems that
getCurrentThisType() does more than its name suggests. Is there any other place
that the adjustment function can be call
Author: djasper
Date: Fri May 20 01:16:01 2016
New Revision: 270188
URL: http://llvm.org/viewvc/llvm-project?rev=270188&view=rev
Log:
clang-format: [JS] Treat "for" as a reserved word after a ".".
Otherwise, clang-format can get confused with statements like:
x.for = 1;
Modified:
cfe/trun
DmitryPolukhin added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:13111
@@ -13090,3 +13110,3 @@
llvm_unreachable("Invalid special member.");
}
} else {
rnk wrote:
> Can we add `if (InClassDef) ActOnFinishInlineFunctionDef(MD);` here instead
DmitryPolukhin updated this revision to Diff 57896.
DmitryPolukhin marked 2 inline comments as done.
DmitryPolukhin added a comment.
Comments resolved, PTAL.
http://reviews.llvm.org/D20422
Files:
lib/Sema/SemaDeclCXX.cpp
test/CodeGenCXX/dllexport-members.cpp
test/CodeGenCXX/dllexport.cpp
bittnerbarni updated this revision to Diff 57894.
http://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringAdditionCheck.cpp
clang-tidy/performance/InefficientStringAdditionCheck.h
clang-tidy/performance/PerformanceTidyModule.cpp
pxli168 accepted this revision.
pxli168 added a comment.
Sorry about late reply.
LGTM!
http://reviews.llvm.org/D17578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pxli168 accepted this revision.
pxli168 added a comment.
LGTM!
I think we may add optimization on this base later.
http://reviews.llvm.org/D18369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
On Thu, May 19, 2016 at 12:13 PM, Serge Pavlov wrote:
> In this case moving implementation of `Singleton::getInstance()` into a
> .cpp file would prevent compiler from instantiation of the method body when
> it sees `Singleton::getInstance()`. In this case
> `Singleton::getInstance()` must be ins
Author: compnerd
Date: Thu May 19 22:58:12 2016
New Revision: 270180
URL: http://llvm.org/viewvc/llvm-project?rev=270180&view=rev
Log:
CodeGen: address -Wcast-qual warning
Add a const_cast rather than the C-style cast. NFC.
Modified:
cfe/trunk/lib/CodeGen/BackendUtil.cpp
Modified: cfe/trun
On Thu, May 19, 2016 at 11:15 AM, David Majnemer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: majnemer
> Date: Thu May 19 13:15:53 2016
> New Revision: 270089
>
> URL: http://llvm.org/viewvc/llvm-project?rev=270089&view=rev
> Log:
> [MS ABI] Ignore transparent contexts when deter
ahatanak added a comment.
In http://reviews.llvm.org/D20407#433915, @rjmccall wrote:
> _Atomic is functionally a type qualifier and should be removed in Sema when
> computing the result type of the getter and the parameter type of the setter.
> That is, if the user declares a property of type
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Sorry for the delay, this all LGTM. Do you need someone to commit it for you?
Comment at: lib/Sema/SemaTemplate.cpp:2082-2085
@@ +2081,6 @@
+// If the Index is out of boun
On Thu, May 19, 2016 at 6:11 PM, Justin Lebar via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> jlebar created this revision.
> jlebar added a reviewer: rsmith.
> jlebar added a subscriber: cfe-commits.
>
> http://reviews.llvm.org/D20457
>
> Files:
> include/clang/Basic/LangOptions.def
>
Author: rsmith
Date: Thu May 19 20:06:47 2016
New Revision: 270169
URL: http://llvm.org/viewvc/llvm-project?rev=270169&view=rev
Log:
Revert incorrect module map changes in r269907 and replace them with the
appropriate changes.
Modified:
cfe/trunk/lib/Headers/module.modulemap
Modified: cfe/tr
Author: rsmith
Date: Thu May 19 20:07:10 2016
New Revision: 270170
URL: http://llvm.org/viewvc/llvm-project?rev=270170&view=rev
Log:
Re-alphabetize this file list.
Modified:
cfe/trunk/lib/Headers/CMakeLists.txt
Modified: cfe/trunk/lib/Headers/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-
Fixed in r270169.
On Thu, May 19, 2016 at 2:13 PM, Richard Smith
wrote:
> The modules buildbot has been broken since this commit landed:
>
>
> http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules/builds/15761/steps/compile.llvm.stage2/logs/stdio
>
> Please fix or revert.
>
> On
jlebar created this revision.
jlebar added a reviewer: rsmith.
jlebar added a subscriber: cfe-commits.
http://reviews.llvm.org/D20457
Files:
include/clang/Basic/LangOptions.def
include/clang/Driver/Options.td
Index: include/clang/Driver/Options.td
Author: rnk
Date: Thu May 19 19:38:25 2016
New Revision: 270164
URL: http://llvm.org/viewvc/llvm-project?rev=270164&view=rev
Log:
Avoid depending on test inputes that aren't in Inputs
Some people have weird CI systems that run each test subdirectory
independently without access to other parallel
rsmith added a subscriber: rsmith.
rsmith added a comment.
Thanks for this! Sorry for the delay on the review side. Generally, the
approach here looks fine, and I don't have any high-level concerns beyond a
performance concern over whatever dark magic you're doing on the LLVM side to
get this f
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a couple of nits.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:22
@@ +21,3 @@
+// A function that helps to tell whether a TargetDecl will be checked.
+// We o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270160: [Lexer] Don't merge macro args from different macro
files (authored by vedantk).
Changed prior to commit:
http://reviews.llvm.org/D20401?vs=57810&id=57880#toc
Repository:
rL LLVM
http://revi
Author: vedantk
Date: Thu May 19 18:44:02 2016
New Revision: 270160
URL: http://llvm.org/viewvc/llvm-project?rev=270160&view=rev
Log:
[Lexer] Don't merge macro args from different macro files
The lexer sets the end location of macro arguments incorrectly *if*,
while merging consecutive args to fi
Author: ayartsev
Date: Thu May 19 18:03:49 2016
New Revision: 270154
URL: http://llvm.org/viewvc/llvm-project?rev=270154&view=rev
Log:
[analyzer] Fix for PR23790 : constrain return value of strcmp() rather than
returning a concrete value.
The function strcmp() can return any value, not just {-1,
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
amccarth created this revision.
amccarth added a reviewer: majnemer.
amccarth added a subscriber: cfe-commits.
This fixes the problem where the driver will look for cl.exe.exe while walking
the PATH.
I looked into changing the Windows implementation of
llvm::sys::fs::can_execute(), but there wa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270150: [CUDA] Implement __ldg using intrinsics. (authored
by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D19990?vs=56603&id=57873#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1999
Author: jlebar
Date: Thu May 19 17:49:13 2016
New Revision: 270150
URL: http://llvm.org/viewvc/llvm-project?rev=270150&view=rev
Log:
[CUDA] Implement __ldg using intrinsics.
Summary:
Previously it was implemented as inline asm in the CUDA headers.
This change allows us to use the [addr+imm] addr
bruno created this revision.
bruno added reviewers: doug.gregor, rsmith.
bruno added a subscriber: cfe-commits.
If a closing ')' isn't found for a macro instantiation inside a '[',
the next token is EOF, this leads to crashes if we try to look ahead of
that. This could be triggered whenever trying
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
After offline discussion: we don't know for sure whether we're going to hit the
combinatorial explosion in future or not. Let's go ahead with this as-is for
now, then, with the explicit acknow
Yes, here are the results from the unpatched compiler:
Avg. wall time (s): 0.73241
Std. deviation: 0.05850
And here are the results from the patched compiler:
Avg. wall time (s): 0.75554
Std. deviation: 0.07492
The testing methodology was the same (100 trials), except I used `clang -x
objectiv
r270144 should fix that failure.
On Thu, May 19, 2016 at 10:17 PM, Evgenii Stepanov
wrote:
> Looks like this commit broke the bot:
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-
> bootstrap/builds/11738/steps/check-clang%20ubsan/logs/stdio
>
> On Thu, May 19, 2016 at 3:52 AM, Benjami
Author: d0k
Date: Thu May 19 16:53:33 2016
New Revision: 270144
URL: http://llvm.org/viewvc/llvm-project?rev=270144&view=rev
Log:
[Sema] Fix use after move. Found by ubsan.
Modified:
cfe/trunk/include/clang/Sema/SemaInternal.h
cfe/trunk/lib/Sema/SemaLookup.cpp
Modified: cfe/trunk/include
Could you also check performance of creating a PCH file out of Cocoa.h ?
> On May 19, 2016, at 1:47 PM, Vedant Kumar wrote:
>
> vsk added a comment.
>
> I discussed this bug with Argyrios off-list, who lgtm'd on the condition that
> it doesn't introduce a performance regression. He suggested p
The modules buildbot has been broken since this commit landed:
http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules/builds/15761/steps/compile.llvm.stage2/logs/stdio
Please fix or revert.
On Wed, May 18, 2016 at 4:56 AM, Ashutosh Nema via cfe-commits <
cfe-commits@lists.llvm.org
cdavis5x created this revision.
cdavis5x added a reviewer: rsmith.
cdavis5x added a subscriber: cfe-commits.
This is a very strange target. Sema thinks it's targeting a Darwin-esque
system, while IRGen thinks it's targeting a Windows'ish system. The result
is that Clang can no longer compile `__bu
vsk added a comment.
I discussed this bug with Argyrios off-list, who lgtm'd on the condition that
it doesn't introduce a performance regression. He suggested preprocessing
Cocoa.h to stress the patch. After running a stabilization script, I used this
command to stress RelNoAsserts builds of cl
cdavis5x updated this revision to Diff 57853.
cdavis5x marked an inline comment as done.
cdavis5x added a comment.
- Add Sema tests for the `ms_hook_prologue` attribute.
- Disallow `ms_hook_prologue` on architectures that Windows doesn't support.
- Disallow `ms_hook_prologue` with the `naked` and
cdavis5x added a comment.
For now, I've disallowed it with `naked` and `always_inline`/`__forceinline`
attributes. Do any other attributes affect prologue generation in a way that
might interfere with `ms_hook_prologue`? AFAICT, GCC only disallows
`ms_hook_prologue` on a) nested functions and b
Hi Michael
This commit seems break darwin LTO bootstrap bot.
http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_check/7916/
Also breaks the Asan Ubsan bot:
http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/1742/
Can you talk a look? I don't why the failure doesn't sho
Looks like this commit broke the bot:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-
bootstrap/builds/11738/steps/check-clang%20ubsan/logs/stdio
On Thu, May 19, 2016 at 3:52 AM, Benjamin Kramer via cfe-commits
wrote:
> Author: d0k
> Date: Thu May 19 05:46:10 2016
> New Revision: 270039
Author: tra
Date: Thu May 19 15:13:53 2016
New Revision: 270108
URL: http://llvm.org/viewvc/llvm-project?rev=270108&view=rev
Log:
[CUDA] Do not allow non-empty destructors for global device-side variables.
According to Cuda Programming guide (v7.5, E2.3.1):
> __device__, __constant__ and __shared
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270107: [CUDA] Split device-var-init.cu tests into separate
Sema and CodeGen parts. (authored by tra).
Changed prior to commit:
http://reviews.llvm.org/D20139?vs=56824&id=57848#toc
Repository:
rL LLV
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270108: [CUDA] Do not allow non-empty destructors for global
device-side variables. (authored by tra).
Changed prior to commit:
http://reviews.llvm.org/D20140?vs=56829&id=57849#toc
Repository:
rL LLV
Author: tra
Date: Thu May 19 15:13:39 2016
New Revision: 270107
URL: http://llvm.org/viewvc/llvm-project?rev=270107&view=rev
Log:
[CUDA] Split device-var-init.cu tests into separate Sema and CodeGen parts.
Codegen tests for device-side variable initialization are subset of test
cases used to veri
vmiklos created this revision.
vmiklos added reviewers: cfe-commits, klimek.
The second check failed, FOO(C.X) wasn't renamed to FOO(C.Y).
http://reviews.llvm.org/D20446
Files:
clang-rename/USRLocFinder.cpp
test/clang-rename/MemberExprMacro.cpp
Index: test/clang-rename/MemberExprMacro.cpp
=
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D20392
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl created this revision.
yaxunl added reviewers: Anastasia, pxli168, bader, rsmith.
yaxunl added a subscriber: cfe-commits.
Include opencl-c.h by default as a module to utilize the automatic AST caching
mechanism of module.
Add an option -fno-default-header to disable default header for Ope
In this case moving implementation of `Singleton::getInstance()` into a
.cpp file would prevent compiler from instantiation of the method body when
it sees `Singleton::getInstance()`. In this case
`Singleton::getInstance()` must be instantiated in some source file
either explicitly or implicitly. I
rnk added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:4814
@@ -4813,3 +4813,3 @@
// we have a definition.
auto *CXXC = dyn_cast(MD);
if ((MD->isMoveAssignmentOperator() ||
nit, can you rename this Ctor? I definitely know that t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270094: [CUDA] Enable fusing FP ops (-ffp-contract=fast) for
CUDA by default. (authored by tra).
Changed prior to commit:
http://reviews.llvm.org/D20341?vs=57541&id=57833#toc
Repository:
rL LLVM
htt
Author: tra
Date: Thu May 19 13:44:45 2016
New Revision: 270094
URL: http://llvm.org/viewvc/llvm-project?rev=270094&view=rev
Log:
[CUDA] Enable fusing FP ops (-ffp-contract=fast) for CUDA by default.
This matches default nvcc behavior and gives substantial
performance boost on GPU where fmad is m
tra added a subscriber: chandlerc.
tra added a comment.
Short version of offline discussion with @chandlerc : Default of
-ffp-contract=fast for CUDA is fine.
http://reviews.llvm.org/D20341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
Well, if the CUDA documentation says so...let's do it. :) Thanks for your
patience, everyone.
http://reviews.llvm.org/D20341
___
cfe-commits m
On Thu, May 19, 2016 at 4:45 PM, Hans Wennborg wrote:
> +Tom who manages 3.8.1
> +Alex who's owner of clang-tidy: is this ok for 3.8.1?
>
Yes, would be nice to have this in 3.8.1. This fixes a rather annoying
problem.
>
> On Thu, May 19, 2016 at 1:56 AM, Edoardo P. via cfe-commits
> wrote:
>
Author: majnemer
Date: Thu May 19 13:15:53 2016
New Revision: 270089
URL: http://llvm.org/viewvc/llvm-project?rev=270089&view=rev
Log:
[MS ABI] Ignore transparent contexts when determining the effective context
We didn't skip over extern "C++" contexts, causing us to mangle things
which don't nee
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270086: Check for nullptr argument. (authored by tra).
Changed prior to commit:
http://reviews.llvm.org/D20141?vs=56832&id=57825#toc
Repository:
rL LLVM
http://reviews.llvm.org/D20141
Files:
cfe/t
Author: tra
Date: Thu May 19 13:00:18 2016
New Revision: 270086
URL: http://llvm.org/viewvc/llvm-project?rev=270086&view=rev
Log:
Check for nullptr argument.
Addresses static analysis report in PR15492.
Differential Revision: http://reviews.llvm.org/D20141
Modified:
cfe/trunk/lib/CodeGen/Co
Author: d0k
Date: Thu May 19 12:57:35 2016
New Revision: 270085
URL: http://llvm.org/viewvc/llvm-project?rev=270085&view=rev
Log:
Don't rely on value numbers in test, those are fragile and change in Release
(no asserts) builds.
Modified:
cfe/trunk/test/CodeGen/avx512f-builtins.c
Modified: c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270084: [CUDA] Allow sm_50,52,53 GPUs (authored by tra).
Changed prior to commit:
http://reviews.llvm.org/D20405?vs=57715&id=57822#toc
Repository:
rL LLVM
http://reviews.llvm.org/D20405
Files:
cfe
Author: tra
Date: Thu May 19 12:47:47 2016
New Revision: 270084
URL: http://llvm.org/viewvc/llvm-project?rev=270084&view=rev
Log:
[CUDA] Allow sm_50,52,53 GPUs
LLVM accepts them since r233575.
Differential Revision: http://reviews.llvm.org/D20405
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Hey,
For some reason clang does not emit ObjC method and block annotations to
IR. Here is a fix for that.
--
Max Bazaliy
objc_blocks_emit_ir.patch
Description: Binary data
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
hintonda added a comment.
Sure that sounds good to me. However, I would like to learn how to write
better ASTMatchers.
In any case, this has been a great learning experience.
http://reviews.llvm.org/D20428
___
cfe-commits mailing list
cfe-commits
aaron.ballman added a comment.
In http://reviews.llvm.org/D20428#434420, @hintonda wrote:
> I can already catch all of these cases, but I can't catch this one, will this
> catch it too?
>
> void g(void (*fp)(void) throw()) throw();
> ^^^
>
>
> Actually, I can catc
aaron.ballman updated this revision to Diff 57816.
aaron.ballman added a comment.
Added test cases for parameter types that have exception specifications.
http://reviews.llvm.org/D20428
Files:
include/clang/AST/Decl.h
include/clang/AST/TypeLoc.h
lib/AST/Decl.cpp
lib/Parse/ParseDeclCXX.c
Author: rksimon
Date: Thu May 19 12:11:31 2016
New Revision: 270083
URL: http://llvm.org/viewvc/llvm-project?rev=270083&view=rev
Log:
[X86][SSE] Sync with llvm/test/CodeGen/X86/sse-intrinsics-fast-isel.ll
sse-builtins.c now just covers SSE1 intrinsics
Modified:
cfe/trunk/test/CodeGen/sse-bui
manmanren added a comment.
Thanks Bruno
Comment at: lib/Serialization/ASTWriter.cpp:2191
@@ -2191,1 +2190,3 @@
+// We write out exported module macros for PCH as well.
+if (true) {
auto Leafs = PP.getLeafModuleMacros(Name);
bruno wrote:
> Is this
Author: d0k
Date: Thu May 19 11:57:57 2016
New Revision: 270082
URL: http://llvm.org/viewvc/llvm-project?rev=270082&view=rev
Log:
[include-fixer] Fix unused variable warning in Release builds.
Modified:
clang-tools-extra/trunk/include-fixer/IncludeFixer.cpp
Modified: clang-tools-extra/trunk/
Author: rksimon
Date: Thu May 19 11:48:59 2016
New Revision: 270079
URL: http://llvm.org/viewvc/llvm-project?rev=270079&view=rev
Log:
[X86][SSE2] Fixed shuffle of results in _mm_cmpnge_sd/_mm_cmpngt_sd tests
Modified:
cfe/trunk/test/CodeGen/sse2-builtins.c
Modified: cfe/trunk/test/CodeGen/ss
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
In the future I'd prefer to do renaming changes
(ResultReporter->SymbolReporter) in a separate change, but this is fine now.
Comment at: include-fixer/find-all-symbols/Symb
hintonda added a comment.
Btw, this version can successfully check libcxx.
http://reviews.llvm.org/D18575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda updated this revision to Diff 57811.
hintonda added a comment.
Adjust matcher, add better error checking, and additional test cases.
We can now parse all dynamic exception specifications, but haven't
been able to develop a matcher that will find the following function
declaration without
vsk updated this revision to Diff 57810.
vsk added a comment.
- Fix explanation of the test case in test/CoverageMapping.
http://reviews.llvm.org/D20401
Files:
lib/Lex/TokenLexer.cpp
test/CoverageMapping/Inputs/macros.h
test/CoverageMapping/include-macros.c
unittests/Lex/LexerTest.cpp
pcc updated this revision to Diff 57809.
pcc added a comment.
- Add a test for DW_OP_stack_value
http://reviews.llvm.org/D20415
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.cpp
lib/CodeGen/CodeGenFunction.h
test/Code
majnemer added inline comments.
Comment at: include/clang/Sema/DeclSpec.h:1152-1169
@@ -1153,19 +1151,20 @@
struct ArrayTypeInfo : TypeInfoCommon {
-/// The type qualifiers for the array: const/volatile/restrict/_Atomic.
-unsigned TypeQuals : 4;
+/// The type qual
hintonda added a comment.
I can already catch all of these cases, but I can't catch this one, will this
catch it too?
void g(void (*fp)(void) throw()) throw();
^^^
http://reviews.llvm.org/D20428
___
cfe-commits mail
David,
All these cases are handled properly now.
Could you, please, review?
http://reviews.llvm.org/D20437
Yours,
Andrey
On Sat, May 14, 2016 at 6:11 AM, David Majnemer
wrote:
> FYI, the following is a little shorter:
> using Ty = int () __unaligned;
>
> Also, this case (in C mode) is inter
andreybokhanko created this revision.
andreybokhanko added reviewers: rnk, majnemer.
andreybokhanko added a subscriber: cfe-commits.
This adds support of MS-specific "__unaligned" qualifier for function types and
fixes errors described by David Majnemer in this thread:
http://lists.llvm.org/pipe
mprobst marked 2 inline comments as done.
mprobst added a comment.
Thanks for the review, appreciated!
Comment at: lib/Format/SortJavaScriptImports.cpp:160
@@ +159,3 @@
+ if (i + 1 < e) {
+// Insert breaks between imports.
+ReferencesText += "\n";
--
aaron.ballman added a comment.
In http://reviews.llvm.org/D20428#434270, @alexfh wrote:
> In http://reviews.llvm.org/D20428#434242, @aaron.ballman wrote:
>
> > In http://reviews.llvm.org/D20428#434238, @alexfh wrote:
> >
> > > Full context diff, please.
> >
> >
> > Pardon my complete ignorance, b
Author: atanasyan
Date: Thu May 19 10:05:22 2016
New Revision: 270067
URL: http://llvm.org/viewvc/llvm-project?rev=270067&view=rev
Log:
[driver][mips] Hardcode triple name in case of CodeSourcery toolchain. NFC
CodeSourcery toolchain is a standalone toolchain which always uses
the same triple nam
aaron.ballman updated this revision to Diff 57798.
aaron.ballman added a comment.
For noexcept specifications without an expression, now tracking the full source
range. Also, added tests.
http://reviews.llvm.org/D20428
Files:
include/clang/AST/Decl.h
include/clang/AST/TypeLoc.h
lib/AST/D
klimek added inline comments.
Comment at: lib/Format/SortJavaScriptImports.cpp:160
@@ +159,3 @@
+ if (i + 1 < e) {
+// Insert breaks between imports.
+ReferencesText += "\n";
Between categories of imports and imports and exports, right?
=
a.sidorin updated this revision to Diff 57796.
a.sidorin marked an inline comment as done.
a.sidorin added a comment.
Add some basic tests for ExpressionTraitExpr and ArrayTypeTraitExpr.
http://reviews.llvm.org/D14326
Files:
include/clang/AST/ASTImporter.h
include/clang/AST/DeclFriend.h
l
Author: atanasyan
Date: Thu May 19 10:07:00 2016
New Revision: 270068
URL: http://llvm.org/viewvc/llvm-project?rev=270068&view=rev
Log:
[driver] Do not pass target triple to the MultilibSet include dirs callback
No one callback uses target triple so we can escape passing the unused
argument.
Mod
Author: atanasyan
Date: Thu May 19 10:07:21 2016
New Revision: 270069
URL: http://llvm.org/viewvc/llvm-project?rev=270069&view=rev
Log:
[driver] Do not pass install dir to the MultilibSet include dirs callback
All additional include directories are relative to the toolchain install
folder. So let
mprobst updated this revision to Diff 57795.
mprobst added a comment.
- ranges
http://reviews.llvm.org/D20198
Files:
include/clang/Format/Format.h
lib/Format/CMakeLists.txt
lib/Format/Format.cpp
lib/Format/FormatToken.h
lib/Format/FormatTokenLexer.cpp
lib/Format/FormatTokenLexer.h
mprobst updated this revision to Diff 57794.
mprobst added a comment.
- correctly insert breaks after import block
http://reviews.llvm.org/D20198
Files:
include/clang/Format/Format.h
lib/Format/CMakeLists.txt
lib/Format/Format.cpp
lib/Format/FormatToken.h
lib/Format/FormatTokenLexer.c
+Tom who manages 3.8.1
+Alex who's owner of clang-tidy: is this ok for 3.8.1?
On Thu, May 19, 2016 at 1:56 AM, Edoardo P. via cfe-commits
wrote:
> Is it possible to port this commit to 3.8.1?
>
> Cheers,
> Edward-san
>
> 2016-02-26 10:19 GMT+01:00 Haojian Wu via cfe-commits
> :
>> Author: hokein
hokein marked an inline comment as done.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:22
@@ +21,3 @@
+namespace {
+bool IsValidDecl(const Decl *TargetDecl) {
+ // Ignores using-declarations defined in macros.
alexfh wrote:
> This method assumes a rather
hokein updated this revision to Diff 57790.
hokein added a comment.
Forgot a comments.
http://reviews.llvm.org/D20429
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
clang-tidy/misc/UnusedUsingDeclsCheck.h
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-unused-us
hokein updated this revision to Diff 57785.
hokein marked 4 inline comments as done.
hokein added a comment.
Address comments.
http://reviews.llvm.org/D20429
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
clang-tidy/misc/UnusedUsingDeclsCheck.h
test/clang-tidy/misc-unused-using-decls.cp
alexfh added a comment.
In http://reviews.llvm.org/D20428#434242, @aaron.ballman wrote:
> In http://reviews.llvm.org/D20428#434238, @alexfh wrote:
>
> > Full context diff, please.
>
>
> Pardon my complete ignorance, but how? I generated the diff from svn the
> usual way, so I assume I've missed
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:22
@@ +21,3 @@
+namespace {
+bool IsValidDecl(const Decl *TargetDecl) {
+ // Ignores using-declarations defined in macros.
-
aaron.ballman added a comment.
In http://reviews.llvm.org/D20428#434238, @alexfh wrote:
> Full context diff, please.
Pardon my complete ignorance, but how? I generated the diff from svn the usual
way, so I assume I've missed some step.
> > I'm not certain of the best way to test this function
Author: hokein
Date: Thu May 19 08:23:27 2016
New Revision: 270059
URL: http://llvm.org/viewvc/llvm-project?rev=270059&view=rev
Log:
[include-fixer] Remove an unused local variable ExistingHeaders.
Modified:
clang-tools-extra/trunk/include-fixer/IncludeFixer.cpp
Modified: clang-tools-extra/t
alexfh added a comment.
Full context diff, please.
> I'm not certain of the best way to test this functionality in isolation;
Same way other locations/ranges are tested in
unittests/AST/SourceLocationTest.cpp?
http://reviews.llvm.org/D20428
___
hokein created this revision.
hokein added a reviewer: alexfh.
hokein added subscribers: djasper, cfe-commits.
http://reviews.llvm.org/D20429
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
clang-tidy/misc/UnusedUsingDeclsCheck.h
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/cla
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270058: [ARM] Fix cdp intrinsic (authored by rsingh).
Changed prior to commit:
http://reviews.llvm.org/D20394?vs=57698&id=5#toc
Repository:
rL LLVM
http://reviews.llvm.org/D20394
Files:
cfe/tr
Author: rsingh
Date: Thu May 19 08:04:34 2016
New Revision: 270058
URL: http://llvm.org/viewvc/llvm-project?rev=270058&view=rev
Log:
[ARM] Fix cdp intrinsic
- Fixed cdp intrinsic to only accept compile time
constant values previously you could pass in a
variable to the builtin which would res
aaron.ballman created this revision.
aaron.ballman added a reviewer: rsmith.
aaron.ballman added subscribers: cfe-commits, hintonda, alexfh.
We do not currently track the source locations for exception specifications
such that their source range can be queried through the AST. This leads to
tryi
1 - 100 of 136 matches
Mail list logo
