r269554 - Update identifiers as needed when loading macros from serialized ASTs.

Author: spyffe Date: Sat May 14 01:24:14 2016 New Revision: 269554 URL: http://llvm.org/viewvc/llvm-project?rev=269554&view=rev Log: Update identifiers as needed when loading macros from serialized ASTs. This is essential for iterating across macros properly, which LLDB does when loading macros f

r269553 - Fixed a bug where the ASTImporter didn't propagate builtin IDs at all.

Author: spyffe Date: Sat May 14 01:11:19 2016 New Revision: 269553 URL: http://llvm.org/viewvc/llvm-project?rev=269553&view=rev Log: Fixed a bug where the ASTImporter didn't propagate builtin IDs at all. IdentifierInfos are assigned builtin IDs during parsing, but Idents.get() does not do that w

r269552 - [X86] Change most 'void' pointers in builtin type lists to more correct types. Fix some unaligned load/store intrinsics to use a less aligned type in their pointer casts.

Author: ctopper Date: Sat May 14 01:03:13 2016 New Revision: 269552 URL: http://llvm.org/viewvc/llvm-project?rev=269552&view=rev Log: [X86] Change most 'void' pointers in builtin type lists to more correct types. Fix some unaligned load/store intrinsics to use a less aligned type in their pointe

r269551 - Handle injected class names in the ASTImporter.

Author: spyffe Date: Sat May 14 00:43:57 2016 New Revision: 269551 URL: http://llvm.org/viewvc/llvm-project?rev=269551&view=rev Log: Handle injected class names in the ASTImporter. Every class as parsed by Clang has a forward declaration of itself as a member: class A { class A; ... } but w

Re: [PATCH] D20261: [compiler-rt] Fix multi-configuration output paths

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Great! Lgtm http://reviews.llvm.org/D20261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

r269549 - Revert "Reapply "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC""

Author: chandlerc Date: Sat May 14 00:39:45 2016 New Revision: 269549 URL: http://llvm.org/viewvc/llvm-project?rev=269549&view=rev Log: Revert "Reapply "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC"" This reverts commit r269492 as the corresponding LLVM commit was reverted due

r269546 - Added support to the ASTImporter for C++ constructor initializers.

Author: spyffe Date: Sat May 14 00:20:31 2016 New Revision: 269546 URL: http://llvm.org/viewvc/llvm-project?rev=269546&view=rev Log: Added support to the ASTImporter for C++ constructor initializers. Thanks to Aleksei Sidorin for review and advice. Added: cfe/trunk/test/ASTMerge/Inputs/init-

Re: [PATCH] D20261: [compiler-rt] Fix multi-configuration output paths

etienneb added a comment. In http://reviews.llvm.org/D20261#430151, @rnk wrote: > Will this put the libraries in build/Release/bin/../lib/. aka > build/Release/lib, or will they collide between build types? If I get your question correctly, they won't collide since the first folder below

Re: r269220 - [MSVC] Implementation of __unaligned as a proper type qualifier

FYI, the following is a little shorter: using Ty = int () __unaligned; Also, this case (in C mode) is interesting: void f(int x[__unaligned 4]); DeclaratorChunk::getArray will truncate the TypeQuals because ArrayTypeInfo's TypeQuals doesn't have enough bits. similar issues arise with: struct A;

r269530 - When typo-correcting a using-declaration, actually correct the name of the

Author: rsmith Date: Fri May 13 20:58:49 2016 New Revision: 269530 URL: http://llvm.org/viewvc/llvm-project?rev=269530&view=rev Log: When typo-correcting a using-declaration, actually correct the name of the UsingDecl (so that redeclaration lookup can find it). Modified: cfe/trunk/lib/Sema/Se

Re: [PATCH] D19851: Warn on binding reference to null in copy initialization

rsmith accepted this revision. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5369 @@ -5368,1 +5368,3 @@ +def warn_binding_null_to_reference : Warning< + "binding null pointer to reference has undefined behavior">, InGroup; def note_indirection_through_null : Note<

r269528 - Fix some typos.

Author: rsmith Date: Fri May 13 20:21:40 2016 New Revision: 269528 URL: http://llvm.org/viewvc/llvm-project?rev=269528&view=rev Log: Fix some typos. Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/tru

[PATCH] D20266: [Modules] Use vfs for (recursive) directory iteration

bruno created this revision. bruno added a reviewer: benlangmuir. bruno added a subscriber: cfe-commits. Clang performs directory walk while searching headers inside modules by using the ::sys::fs instead of ::vfs. This prevents any code that uses the VFS (e.g, reproducer scripts) to actually find

r269527 - [AVX512] Update pshufd type strings to match the backend. Also mark the immediate as an ICE instead of marking the previous vector as const.

Author: ctopper Date: Fri May 13 19:49:36 2016 New Revision: 269527 URL: http://llvm.org/viewvc/llvm-project?rev=269527&view=rev Log: [AVX512] Update pshufd type strings to match the backend. Also mark the immediate as an ICE instead of marking the previous vector as const. Modified: cfe/tru

Re: [PATCH] D20170: [clang-tidy] TypeTraits - Type is not expensive to copy when it has a deleted copy constructor.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good after addressing Etienne's comment. Thanks! http://reviews.llvm.org/D20170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

Re: [PATCH] D20171: Support for MSVS default calling convention options (/Gd, /Gz, /Gv, /Gr)

rnk added inline comments. Comment at: include/clang/Driver/CC1Options.td:615 @@ +614,3 @@ + HelpText<"Set default MS calling convention">; +def mrtd : Flag<["-"], "mrtd">, Group, + Alias, AliasArgs<["stdcall"]>, Doesn't this have to live in Options.td if you wa

r269520 - [VFS] Add level() method to vfs::recursive_directory_iterator

Author: bruno Date: Fri May 13 19:00:18 2016 New Revision: 269520 URL: http://llvm.org/viewvc/llvm-project?rev=269520&view=rev Log: [VFS] Add level() method to vfs::recursive_directory_iterator Unlike sys::fs::recursive_directory_iterator, vfs::recursive_directory_iterator does not implement the

Re: [patch] Don't use appending linkage for embeded bitcode

> On May 13, 2016, at 3:56 PM, Duncan P. N. Exon Smith > wrote: > > Is this something that you need the linker to treat as "used", or just > something you don't want the compiler to drop? If the latter, > @llvm.compiler.used seems more appropriate. Bitcode is actually not really used by the

Re: [PATCH] D19667: [ubsan] Minimize size of data for type_mismatch

rsmith added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:579 @@ -578,1 +578,3 @@ +// Make sure we're not losing information. Alignment needs to be a power of 2 +assert(!AlignVal || (uint64_t)1 << llvm::Log2_64(AlignVal) == AlignVal); llvm::Constant *StaticDat

[clang-tools-extra] r269517 - [Release notes] Mention Clang-tidy modernize-avoid-bind check.

Author: eugenezelenko Date: Fri May 13 18:35:56 2016 New Revision: 269517 URL: http://llvm.org/viewvc/llvm-project?rev=269517&view=rev Log: [Release notes] Mention Clang-tidy modernize-avoid-bind check. Fix some problems in its documentation. Modified: clang-tools-extra/trunk/docs/ReleaseNot

Re: [PATCH] D20137: [PCH] Fixed bugs with preamble invalidation when files change (on Windows)

rsmith added inline comments. Comment at: lib/Frontend/ASTUnit.cpp:1402-1406 @@ +1401,7 @@ + +vfs::Status Status; +if (FileMgr->getNoncachedStatValue(RB.first, Status)) { + AnyFileChanged = true; + break; +} + Suppose file

r269515 - Get default -fms-compatibility-version from cl.exe's version

Author: amccarth Date: Fri May 13 18:20:11 2016 New Revision: 269515 URL: http://llvm.org/viewvc/llvm-project?rev=269515&view=rev Log: Get default -fms-compatibility-version from cl.exe's version -fms-compatibility-version was defaulting to 18 (VS 2013), which is a pain if your environment is po

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

This revision was automatically updated to reflect the committed changes. amccarth marked an inline comment as done. Closed by commit rL269515: Get default -fms-compatibility-version from cl.exe's version (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D20136?vs=57196&i

Re: r269398 - Add support for derived class special members hiding functions brought in from

Update: Vassil and I have dug into this a bit offline. It looks like the root cause is a likely-pre-existing bug where we somehow import a default constructor for a class from a module but don't set the "has a default constructor" flag on the class definition. On Fri, May 13, 2016 at 2:54 AM, Vass

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. LG, sounds like people are happy with this http://reviews.llvm.org/D20136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

Re: r269220 - [MSVC] Implementation of __unaligned as a proper type qualifier

Hi David, Thanks for letting me know -- will investigate after the weekend. Yours, Andrey Отправлено с iPad > 13 мая 2016 г., в 20:33, David Majnemer написал(а): > > This seems to crash clang: > struct S { > void f() __unaligned; > }; > void S::f() __unaligned { > } > > clang/lib/Sema/Decl

Re: [PATCH] D18953: [ms][dll] #26935 Defining a dllimport function should cause it to be exported

rnk added inline comments. Comment at: test/SemaCXX/dllimport.cpp:179 @@ -140,1 +178,3 @@ +template +int ExternVarTmplDeclInit = 1; avt77 wrote: > majnemer wrote: > > avt77 wrote: > > > rnk wrote: > > > > Can you check with MSVC 2015 update 2 actually does with

Re: [patch] Don't use appending linkage for embeded bitcode

Is this something that you need the linker to treat as "used", or just something you don't want the compiler to drop? If the latter, @llvm.compiler.used seems more appropriate. > On 2016-May-13, at 14:01, Steven Wu wrote: > > Attach a patch using private linkage type and adding to llvm.used.

Re: [PATCH] D20261: [compiler-rt] Fix multi-configuration output paths

rnk added a comment. Will this put the libraries in build/Release/bin/../lib/. aka build/Release/lib, or will they collide between build types? http://reviews.llvm.org/D20261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

Re: [PATCH] D20194: [ModuleMap][CrashReproducer] Collect headers from inner frameworks

bruno closed this revision. bruno added a comment. Thanks Ben! Committed r269502 http://reviews.llvm.org/D20194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r269502 - [ModuleMap][CrashReproducer] Collect headers from inner frameworks

Author: bruno Date: Fri May 13 17:21:51 2016 New Revision: 269502 URL: http://llvm.org/viewvc/llvm-project?rev=269502&view=rev Log: [ModuleMap][CrashReproducer] Collect headers from inner frameworks (1) Collect headers under inner frameworks (frameworks inside other other frameworks). (2) Make su

Re: [PATCH] D20194: [ModuleMap][CrashReproducer] Collect headers from inner frameworks

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D20194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D20194: [ModuleMap][CrashReproducer] Collect headers from inner frameworks

bruno updated this revision to Diff 57263. bruno added a comment. Updated after Ben's suggestions! http://reviews.llvm.org/D20194 Files: include/clang/Lex/ModuleMap.h lib/Frontend/ModuleDependencyCollector.cpp lib/Lex/ModuleMap.cpp test/Modules/Inputs/crash-recovery/Frameworks/A.framewo

[PATCH] D20261: [compiler-rt] Fix multi-configuration output paths

etienneb created this revision. etienneb added a reviewer: rnk. etienneb added a subscriber: cfe-commits. When using a multi-configuration build (i.e. MSVC) the output path where libraries are dropped is incorrect. Example: ``` C:\src\llvm\examples>d:\src\llvm\build\Release\bin\clang-cl.exe -fsa

Re: [PATCH] D19902: [ProfileData] (clang) Use Error in InstrProf and Coverage

This revision was automatically updated to reflect the committed changes. Closed by commit rL269492: Reapply "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC" (authored by vedantk). Changed prior to commit: http://reviews.llvm.org/D19902?vs=56346&id=57259#toc Repository: rL LL

r269492 - Reapply "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC"

Author: vedantk Date: Fri May 13 16:51:02 2016 New Revision: 269492 URL: http://llvm.org/viewvc/llvm-project?rev=269492&view=rev Log: Reapply "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC" Sync up with "(llvm) Use Error in InstrProf and Coverage". Differential Revision: http://

r269487 - ARM-MachO: stop claiming to be EABI

Author: tnorthover Date: Fri May 13 16:26:45 2016 New Revision: 269487 URL: http://llvm.org/viewvc/llvm-project?rev=269487&view=rev Log: ARM-MachO: stop claiming to be EABI Embedded ARM MachO targets are AAPCS but not full EABI (we don't use __aeabi_whatever and the functions are allowed to be ha

Re: [patch] Don't use appending linkage for embeded bitcode

You can probably use collectUsedGlobalVariables. You can probably also delete the FIXME about llvm.used and appending linkage. I think the way to fix this is to make "can be dropped" an independent property from the linkage and then we don't need llvm.used at all. Cheers, Rafael On 13 May 2016

Re: [PATCH] D20137: [PCH] Fixed bugs with preamble invalidation when files change (on Windows)

cameron314 updated this revision to Diff 57253. cameron314 added a comment. Removed workaround for case that can no longer happen. http://reviews.llvm.org/D20137 Files: include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp Index: lib/Frontend/ASTUnit.cpp ===

Re: [PATCH] D20137: [PCH] Fixed bugs with preamble invalidation when files change (on Windows)

cameron314 added inline comments. Comment at: lib/Basic/FileManager.cpp:304-307 @@ -303,1 +303,6 @@ + if (UFE.isVirtual()) { +UFE.Name = InterndFileName; +return &UFE; + } + rsmith wrote: > It looks like this is unreachable: `IsVirtual` is only ever `t

Re: [PATCH] D20118: Add support for injected class names and constructor initializers in C++

spyffe added a comment. I’m just going to use clang-format to resolve trailing whitespace/etc issues. It changes around some indentation in the class declaration for ASTImporter but that probably needs to be taken care of anyway… Sean Repository: rL LLVM http://reviews.llvm.org/D20118

Re: [PATCH] D20118: Add support for injected class names and constructor initializers in C++

I’m just going to use clang-format to resolve trailing whitespace/etc issues. It changes around some indentation in the class declaration for ASTImporter but that probably needs to be taken care of anyway… Sean > On May 13, 2016, at 1:40 PM, Sean Callanan wrote: > > spyffe added a subscriber

Re: [patch] Don't use appending linkage for embeded bitcode

Attach a patch using private linkage type and adding to llvm.used. I have to recreate llvm.used when embedding bitcode. I don't really like it but I don't have better solutions. Few other options: 1. Not allowing re-embedded bitcode will simplify the code a bit but not a lot. 2. Create a new "llv

Re: [PATCH] D20254: [Clang] Fix some Clang-tidy modernize-use-bool-literals warnings; other minor fixes.

Eugene.Zelenko updated this revision to Diff 57250. Eugene.Zelenko added a comment. Include mode context. Repository: rL LLVM http://reviews.llvm.org/D20254 Files: include/clang/AST/RecursiveASTVisitor.h include/clang/Basic/IdentifierTable.h lib/Basic/FileManager.cpp Index: lib/Basic/

Re: [PATCH] D20254: [Clang] Fix some Clang-tidy modernize-use-bool-literals warnings; other minor fixes.

Prazek added a subscriber: Prazek. Prazek added a comment. Can you post this review with more context? (diff -U9) Repository: rL LLVM http://reviews.llvm.org/D20254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

Re: [PATCH] D20118: Add support for injected class names and constructor initializers in C++

spyffe added a subscriber: spyffe. spyffe added a comment. Thank you for your comments, I’m working on them now. Sean Repository: rL LLVM http://reviews.llvm.org/D20118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

Re: [PATCH] D20118: Add support for injected class names and constructor initializers in C++

Thank you for your comments, I’m working on them now. Sean > On May 11, 2016, at 4:39 AM, Aleksei Sidorin wrote: > > a.sidorin added a comment. > > I' d like to have some tests for this. CXXCtorInitializers can be tested with > D14224 -like stuff or with ASTMat

[PATCH] D20254: [Clang] Fix some Clang-tidy modernize-use-bool-literals warnings; other minor fixes.

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Fix some Include What You Use warnings. I checked this patch on my own build on RHEL 6. Regres

r269468 - Revert "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC"

Author: vedantk Date: Fri May 13 15:10:22 2016 New Revision: 269468 URL: http://llvm.org/viewvc/llvm-project?rev=269468&view=rev Log: Revert "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC" This reverts commit r269463. It fails two llvm-profdata tests. Modified: cfe/trunk/lib

r269465 - [MS ABI] Delegating constructors should not assume they are most derived

Author: majnemer Date: Fri May 13 15:05:09 2016 New Revision: 269465 URL: http://llvm.org/viewvc/llvm-project?rev=269465&view=rev Log: [MS ABI] Delegating constructors should not assume they are most derived A constructor needs to know whether or not it is most derived in order to determine if it

r269463 - [ProfileData] (clang) Use Error in InstrProf and Coverage, NFC

Author: vedantk Date: Fri May 13 15:01:34 2016 New Revision: 269463 URL: http://llvm.org/viewvc/llvm-project?rev=269463&view=rev Log: [ProfileData] (clang) Use Error in InstrProf and Coverage, NFC Sync up with "(llvm) Use Error in InstrProf and Coverage". Modified: cfe/trunk/lib/CodeGen/Code

r269460 - Add an AST matcher for CastExpr kind

Author: etienneb Date: Fri May 13 14:36:55 2016 New Revision: 269460 URL: http://llvm.org/viewvc/llvm-project?rev=269460&view=rev Log: Add an AST matcher for CastExpr kind Summary: This AST matcher will match a given CastExpr kind. It's an narrowing matcher on CastExpr. Reviewers: klimek, alexfh

Re: [PATCH] D20240: [clang-rename] Fix broken dependency on shared build.

etienneb added a comment. In http://reviews.llvm.org/D20240#429910, @vmiklos wrote: > Thanks for fixing the problem I introduced. :-) No worries, I did the same twice this week. http://reviews.llvm.org/D20240 ___ cfe-commits mailing list cfe-comm

Re: [PATCH] D20240: [clang-rename] Fix broken dependency on shared build.

vmiklos added a subscriber: vmiklos. vmiklos added a comment. Thanks for fixing the problem I introduced. :-) http://reviews.llvm.org/D20240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D20253: clang-rename: fix missing clangLex dependency

vmiklos abandoned this revision. vmiklos added a comment. Ah, already fixed by http://reviews.llvm.org/D20240, sorry for the noise. :-) http://reviews.llvm.org/D20253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D20253: clang-rename: fix missing clangLex dependency

vmiklos created this revision. vmiklos added reviewers: cfe-commits, klimek. Blind fix for . http://reviews.llvm.org/D20253 Files: clang-rename/CMakeLists.txt Index: clang-rename/CMakeLists.txt

r269457 - Use marginally more appropriate functions to detect if we should declare an

Author: rsmith Date: Fri May 13 13:48:05 2016 New Revision: 269457 URL: http://llvm.org/viewvc/llvm-project?rev=269457&view=rev Log: Use marginally more appropriate functions to detect if we should declare an implicit copy constructor/assignment, and other minor cleanups. No functionality change i

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth marked an inline comment as done. Comment at: lib/Driver/MSVCToolChain.cpp:481 @@ +480,3 @@ + + std::vector VersionBlock(VersionSize); + if (!::GetFileVersionInfoW(ClExeWide.c_str(), 0, VersionSize, majnemer wrote: > amccarth wrote: > > majnemer wrote:

Re: [PATCH] D20137: [PCH] Fixed bugs with preamble invalidation when files change (on Windows)

rsmith added inline comments. Comment at: lib/Basic/FileManager.cpp:304-307 @@ -303,1 +303,6 @@ + if (UFE.isVirtual()) { +UFE.Name = InterndFileName; +return &UFE; + } + It looks like this is unreachable: `IsVirtual` is only ever `true` when `IsValid`

Re: r269431 - [OpenCL] Add supported OpenCL extensions to target info.

It is part of -Wall group and it should be on by default when you building clang. That warning is added into clang some time in 2014. Make sure you are not using a compiler that is too old. Steven > On May 13, 2016, at 10:58 AM, Liu, Yaxun (Sam) wrote: > > BTW is there a way to turn on this w

Re: [PATCH] D20137: [PCH] Fixed bugs with preamble invalidation when files change (on Windows)

cameron314 updated this revision to Diff 57222. cameron314 added a comment. Updated patch to include later fixes I had made after the initial change. http://reviews.llvm.org/D20137 Files: include/clang/Basic/FileManager.h include/clang/Frontend/ASTUnit.h lib/Basic/FileManager.cpp lib/Fr

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

Anastasia added inline comments. Comment at: lib/Headers/opencl-c.h:14057 @@ +14056,3 @@ +event_t __attribute__((overloadable)) async_work_group_copy(__local float2 *dst, const __global float2 *src, size_t num_elements, event_t event); +event_t __attribute__((overloadable)) async

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

Anastasia added inline comments. Comment at: lib/Headers/opencl-c.h:7452 @@ +7451,3 @@ + +// OpenCL v1.2 s6.12.2, v2.0 s6.13.2 - Math functions + Could you put OpenCL v1.1 section too? Comment at: lib/Headers/opencl-c.h:7767 @@ +7766,3 @@ +/** +

RE: r269431 - [OpenCL] Add supported OpenCL extensions to target info.

BTW is there a way to turn on this warning with CMake? I could not see this warning in my own build. Thanks. Sam -Original Message- From: Liu, Yaxun (Sam) Sent: Friday, May 13, 2016 1:33 PM To: 'steve...@apple.com' Cc: cfe-commits@lists.llvm.org Subject: RE: r269431 - [OpenCL] Add sup

Re: [PATCH] D20243: [PCH] Disable inclusion of timestamps when generating pch files on windows.

probinson added a subscriber: probinson. probinson added a comment. Please make sure the test files have newlines at the end. "touch-pragma-once.cpp" should probably be named something like "pragma-once-timestamp.cpp". http://reviews.llvm.org/D20243 __

Re: [PATCH] D20249: [OpenCL] Hierarchical/dynamic parallelism - enqueue kernel in OpenCL 2.0

Anastasia added inline comments. Comment at: include/clang/Basic/Builtins.h:39 @@ -38,3 +38,3 @@ MS_LANG = 0x10, // builtin requires MS mode. - OCLC_LANG = 0x20, // builtin for OpenCL C only. + OCLC20_LANG = 0x20, // builtin for OpenCL C only. ALL_LANGUAGES = C_LANG

[PATCH] D20249: [OpenCL] Hierarchical/dynamic parallelism - enqueue kernel in OpenCL 2.0

Anastasia created this revision. Anastasia added reviewers: bader, yaxunl. Anastasia added subscribers: pekka.jaaskelainen, pxli168, cfe-commits. An implementation of device side enqueue (DSE) - enqueue_kernel and related BIFs from OpenCL v2.0 s6.13.17. This change includes: 1. adding enqueue_k

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

majnemer added inline comments. Comment at: lib/Driver/MSVCToolChain.cpp:481 @@ +480,3 @@ + + std::vector VersionBlock(VersionSize); + if (!::GetFileVersionInfoW(ClExeWide.c_str(), 0, VersionSize, amccarth wrote: > majnemer wrote: > > It might be nicer to use a

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth added inline comments. Comment at: lib/Driver/MSVCToolChain.cpp:481 @@ +480,3 @@ + + std::vector VersionBlock(VersionSize); + if (!::GetFileVersionInfoW(ClExeWide.c_str(), 0, VersionSize, majnemer wrote: > It might be nicer to use a `SmallVector`, > or

Re: [PATCH] D20245: [include-fixer] Fix broken dependency shared build

This revision was automatically updated to reflect the committed changes. Closed by commit rL269441: [include-fixer] Fix broken dependency shared build (authored by etienneb). Changed prior to commit: http://reviews.llvm.org/D20245?vs=57208&id=57221#toc Repository: rL LLVM http://reviews.ll

[clang-tools-extra] r269441 - [include-fixer] Fix broken dependency shared build

Author: etienneb Date: Fri May 13 12:38:22 2016 New Revision: 269441 URL: http://llvm.org/viewvc/llvm-project?rev=269441&view=rev Log: [include-fixer] Fix broken dependency shared build Summary: The shared build is broken (again). To repro: [Release + Shared] ``` -DCMAKE_BUILD_TYPE=Release -DBUI

Re: [PATCH] D19322: Concepts: Create space for requires-clause in TemplateParameterList; NFC

hubert.reinterpretcast updated this revision to Diff 57216. hubert.reinterpretcast added a comment. Set requires-clause when creating TemplateParameterLists; NFC Removes the default argument for the requires-clause constraint expression in TemplateParameterList::Create. An appropriate argument

r269440 - Fix module map typo in r269347.

Author: rsmith Date: Fri May 13 12:28:51 2016 New Revision: 269440 URL: http://llvm.org/viewvc/llvm-project?rev=269440&view=rev Log: Fix module map typo in r269347. Modified: cfe/trunk/include/clang/module.modulemap Modified: cfe/trunk/include/clang/module.modulemap URL: http://llvm.org/vie

Re: r269220 - [MSVC] Implementation of __unaligned as a proper type qualifier

This seems to crash clang: struct S { void f() __unaligned; }; void S::f() __unaligned { } clang/lib/Sema/DeclSpec.cpp:214: static clang::DeclaratorChunk clang::DeclaratorChunk::getFunction(bool, bool, clang::SourceLocation, clang::DeclaratorChunk::ParamInfo *, unsigned int, clang::SourceLocatio

RE: r269431 - [OpenCL] Add supported OpenCL extensions to target info.

Thanks Steven. I have reverted my change. I will apply your patch and re-commit. Sam -Original Message- From: steve...@apple.com [mailto:steve...@apple.com] Sent: Friday, May 13, 2016 1:27 PM To: Liu, Yaxun (Sam) Cc: cfe-commits@lists.llvm.org Subject: Re: r269431 - [OpenCL] Add suppor

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

majnemer added inline comments. Comment at: lib/Driver/MSVCToolChain.cpp:481 @@ +480,3 @@ + + std::vector VersionBlock(VersionSize); + if (!::GetFileVersionInfoW(ClExeWide.c_str(), 0, VersionSize, It might be nicer to use a `SmallVector`, or whatever `VersionSi

Re: r269431 - [OpenCL] Add supported OpenCL extensions to target info.

Hi Yaxun You seems missing some override keyword that triggers -Winconsistent-missing-override. See: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_build/24442/warnings8Result/new/ Here is a patch to fix them: diff --git a/lib/Basic/Targets.cpp b/lib/Basic/Targets.cpp inde

RE: [PATCH] D19484: [OpenCL] Add supported OpenCL extensions to target info.

Done. Thanks for letting me know. Sam -Original Message- From: Jun Bum Lim [mailto:junb...@codeaurora.org] Sent: Friday, May 13, 2016 1:10 PM To: Liu, Yaxun (Sam) ; anastasia.stul...@arm.com; aleksey.ba...@mail.ru Cc: junb...@codeaurora.org; Stellard, Thomas ; xiuli...@outlook.com; cfe

r269435 - Revert "[OpenCL] Add supported OpenCL extensions to target info."

Author: yaxunl Date: Fri May 13 12:16:26 2016 New Revision: 269435 URL: http://llvm.org/viewvc/llvm-project?rev=269435&view=rev Log: Revert "[OpenCL] Add supported OpenCL extensions to target info." Revert r269431 due to build failure caused by warning msg: llvm/tools/clang/lib/Basic/Targets.c

Re: [patch] Don't use appending linkage for embeded bitcode

On 13 May 2016 at 13:02, Steven Wu wrote: > Hi Rafael > > Thanks for notice this! That would definitely cause duplicated symbol error > and I should definitely change that. > Here is some background: > ld64 in Xcode 7+ knows how to handle the embedded bitcode correctly but not > the ones in earl

Re: [PATCH] D19484: [OpenCL] Add supported OpenCL extensions to target info.

junbuml added a subscriber: junbuml. junbuml added a comment. In current trunk, I got build error : llvm/tools/clang/lib/Basic/Targets.cpp:2090:9: error: 'setSupportedOpenCLOpts' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] void setSupp

[PATCH] D20245: [include-fixer] Fix broken dependency shared build

etienneb created this revision. etienneb added reviewers: bkramer, hokein. etienneb added a subscriber: cfe-commits. The shared build is broken (again). To repro: [Release + Shared] ``` -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON ``` Errors: ``` tools/clang/tools/extra/include-fixer/tool/C

Re: [patch] Don't use appending linkage for embeded bitcode

Hi Rafael Thanks for notice this! That would definitely cause duplicated symbol error and I should definitely change that. Here is some background: ld64 in Xcode 7+ knows how to handle the embedded bitcode correctly but not the ones in earlier Xcode. The old ld64 will simply concatenate the bit

[patch] Don't use appending linkage for embeded bitcode

Hi Steven, I think there was a mistake when picking this linkage. The appending linkage is really just for things that llvm itself special cases. By an historical artifact it was codegened just like external. The attached patch changes it to external linkage. I tested that the produced .o file is

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: r269411 - [mips] Consult triple's vendor field before using musl's interpreter.

Hi, This change makes sense but it needs a test case. > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of Vasileios Kalintiris via cfe-commits > Sent: 13 May 2016 13:13 > To: cfe-commits@lists.llvm.org > Subject: r269411 - [mips] Consult tri

[PATCH] D20243: [PCH] Disable inclusion of timestamps when generating pch files on windows.

pgousseau created this revision. pgousseau added a reviewer: rsmith. pgousseau added a subscriber: cfe-commits. On Linux, if a header file included in the pch is modified then a fatal error is emitted, which is reasonable. On Windows the check is ifdefed out, allowing the compilation to continue

Re: [PATCH] D20194: [ModuleMap][CrashReproducer] Collect headers from inner frameworks

benlangmuir added a comment. Let's move the code looks up the alternate name out of the ModuleMap parser, and into the dependency collector callbacks. This feels like an implementation detail of the dependency collector. We could add a new callback specifically for umbrella headers and handle

Re: [PATCH] D20157: Add test for D20156

rovka abandoned this revision. rovka added a comment. With the new diagnostic handler in r269428, we no longer need this test (it will be covered by the existing tests such as CodeGen/AArch64/arm64-inline-asm-error-N.ll, by removing the -exit-on-error flag). http://reviews.llvm.org/D20157

Re: [PATCH] D19484: [OpenCL] Add supported OpenCL extensions to target info.

This revision was automatically updated to reflect the committed changes. Closed by commit rL269431: [OpenCL] Add supported OpenCL extensions to target info. (authored by yaxunl). Changed prior to commit: http://reviews.llvm.org/D19484?vs=57177&id=57201#toc Repository: rL LLVM http://review

r269431 - [OpenCL] Add supported OpenCL extensions to target info.

Author: yaxunl Date: Fri May 13 10:44:37 2016 New Revision: 269431 URL: http://llvm.org/viewvc/llvm-project?rev=269431&view=rev Log: [OpenCL] Add supported OpenCL extensions to target info. Add supported OpenCL extensions to target info. It serves as default values to save the users of the burde

Re: [PATCH] D20205: [include-fixer] Use scope contexts information to improve query.

This revision was automatically updated to reflect the committed changes. Closed by commit rL269430: [include-fixer] Use scope contexts information to improve query. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20205?vs=57197&id=57200#toc Repository: rL LLVM http:

[clang-tools-extra] r269430 - [include-fixer] Use scope contexts information to improve query.

Author: hokein Date: Fri May 13 10:44:16 2016 New Revision: 269430 URL: http://llvm.org/viewvc/llvm-project?rev=269430&view=rev Log: [include-fixer] Use scope contexts information to improve query. Reviewers: bkramer Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D20205

[clang-tools-extra] r269429 - [clang-rename] Fix broken dependency on shared build.

Author: etienneb Date: Fri May 13 10:38:54 2016 New Revision: 269429 URL: http://llvm.org/viewvc/llvm-project?rev=269429&view=rev Log: [clang-rename] Fix broken dependency on shared build. Summary: The build is broken due to a missing dependency. To repro: [Release + Shared] ``` -DCMAKE_BUILD_TY

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth updated this revision to Diff 57196. amccarth marked an inline comment as done. amccarth added a comment. Addressed additional comments. http://reviews.llvm.org/D20136 Files: include/clang/Driver/ToolChain.h lib/Driver/MSVCToolChain.cpp lib/Driver/ToolChains.h lib/Driver/Tools.

Re: [PATCH] D20205: [include-fixer] Use scope contexts information to improve query.

hokein updated this revision to Diff 57197. hokein added a comment. Rebase. http://reviews.llvm.org/D20205 Files: include-fixer/IncludeFixer.cpp include-fixer/SymbolIndexManager.cpp unittests/include-fixer/IncludeFixerTest.cpp Index: unittests/include-fixer/IncludeFixerTest.cpp =

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth marked 2 inline comments as done. Comment at: lib/Driver/MSVCToolChain.cpp:42 @@ -40,1 +41,3 @@ + + #pragma comment(lib, "version.lib") #endif aaron.ballman wrote: > Eh, I am lightening up on this sort of thing, so this is fine by me. I was following th

Re: [PATCH] D20240: [clang-rename] Fix broken dependency on shared build.

etienneb added a comment. thanks, landing as soon as my other checkouts complete their tests (few minutes). http://reviews.llvm.org/D20240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

r269419 - [CodeGen] Clang does not choose aapcs-vfp calling convention for ARM bare metal target with hard float (EABIHF)

Author: oleg Date: Fri May 13 09:45:57 2016 New Revision: 269419 URL: http://llvm.org/viewvc/llvm-project?rev=269419&view=rev Log: [CodeGen] Clang does not choose aapcs-vfp calling convention for ARM bare metal target with hard float (EABIHF) Summary: Clang does not detect `aapcs-vfp` for the EA

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

bittnerbarni updated this revision to Diff 57181. http://reviews.llvm.org/D20196 Files: docs/clang-tidy/checks/performance-inefficient-string-addition.rst Index: docs/clang-tidy/checks/performance-inefficient-string-addition.rst =

  1   2   >